)]}'
{"rally/common/objects/task.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8edfbb38cf0954da2d36a66d552f6a88cd375c1a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"triggered_at\": {"},{"line_number":107,"context_line":"            \"type\": \"object\","},{"line_number":108,"context_line":"            \"properties\": {"},{"line_number":109,"context_line":"                \"iteration\": {\"type\": \"integer\"},"},{"line_number":110,"context_line":"                \"time\": {\"type\": \"integer\"},"},{"line_number":111,"context_line":"            },"},{"line_number":112,"context_line":"            \"additionalProperties\": False,"},{"line_number":113,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_05ba4823","line":110,"range":{"start_line":109,"start_character":16,"end_line":110,"end_character":44},"updated":"2016-09-12 12:18:01.000000000","message":"as far as I understand we cannot have both properties at the same time.","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"}],"rally/consts.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8edfbb38cf0954da2d36a66d552f6a88cd375c1a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class _HookStatus(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":185,"context_line":"    \"\"\"Hook result statuses.\"\"\""},{"line_number":186,"context_line":"    UNKNOWN \u003d \"unknown\""},{"line_number":187,"context_line":"    SUCCESS \u003d \"success\""},{"line_number":188,"context_line":"    FAILED \u003d \"failed\""},{"line_number":189,"context_line":"    WRONG_FORMAT \u003d \"wrong format\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_6585d457","line":186,"range":{"start_line":186,"start_character":4,"end_line":186,"end_character":23},"updated":"2016-09-12 12:18:01.000000000","message":"unified status: \"n/a\"","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8edfbb38cf0954da2d36a66d552f6a88cd375c1a","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    UNKNOWN \u003d \"unknown\""},{"line_number":187,"context_line":"    SUCCESS \u003d \"success\""},{"line_number":188,"context_line":"    FAILED \u003d \"failed\""},{"line_number":189,"context_line":"    WRONG_FORMAT \u003d \"wrong format\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"TaskStatus \u003d _TaskStatus()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_45829053","line":189,"range":{"start_line":189,"start_character":4,"end_line":189,"end_character":33},"updated":"2016-09-12 12:18:01.000000000","message":"based on new task statuses (https://review.openstack.org/#/c/309883/4/rally/consts.py). It would be nice to name this like `validation_failed`","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"}],"rally/task/hook.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8edfbb38cf0954da2d36a66d552f6a88cd375c1a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self._finished_at \u003d 0.0"},{"line_number":127,"context_line":"        self._result \u003d self._format_result(status\u003dconsts.HookStatus.UNKNOWN)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _format_result(self, status, action\u003d\"unknown\", error\u003dNone):"},{"line_number":130,"context_line":"        \"\"\"Returns hook result dict.\"\"\""},{"line_number":131,"context_line":"        result \u003d {"},{"line_number":132,"context_line":"            \"hook\": self.get_name(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_e5680424","line":129,"range":{"start_line":129,"start_character":37,"end_line":129,"end_character":53},"updated":"2016-09-12 12:18:01.000000000","message":"please put None or \"n/a\"","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7882a939ddb9fb91909f6046109559cc58877bda","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            result[\"error\"] \u003d error"},{"line_number":141,"context_line":"        return result"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def set_triggered_at(self, triggered_at):"},{"line_number":144,"context_line":"        self._result[\"triggered_at\"] \u003d self._triggered_at \u003d triggered_at"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def set_result_error(self, exception_name, description, details):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_da903351","line":143,"range":{"start_line":143,"start_character":8,"end_line":143,"end_character":24},"updated":"2016-09-12 12:26:29.000000000","message":"Maybe set_triggered_by?","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8edfbb38cf0954da2d36a66d552f6a88cd375c1a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            result[\"error\"] \u003d error"},{"line_number":141,"context_line":"        return result"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def set_triggered_at(self, triggered_at):"},{"line_number":144,"context_line":"        self._result[\"triggered_at\"] \u003d self._triggered_at \u003d triggered_at"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def set_result_error(self, exception_name, description, details):"},{"line_number":147,"context_line":"        \"\"\"Set error related information to result."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param exception_name: name of exception as string"},{"line_number":150,"context_line":"        :param description: short description as string"},{"line_number":151,"context_line":"        :param details: any details as string"},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        self._result[\"error\"] \u003d [exception_name, description, details]"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def set_result_action(self, action):"},{"line_number":156,"context_line":"        \"\"\"Set description of an action performed by hook.\"\"\""},{"line_number":157,"context_line":"        self._result[\"action\"] \u003d action"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def set_result_status(self, status):"},{"line_number":160,"context_line":"        \"\"\"Set status to result.\"\"\""},{"line_number":161,"context_line":"        self._result[\"status\"] \u003d status"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def set_result_output(self, output):"},{"line_number":164,"context_line":"        \"\"\"Set output to result."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        :param output: Diagram data in task.OUTPUT_SCHEMA format"},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        self._result[\"output\"] \u003d output"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _thread_method(self):"},{"line_number":171,"context_line":"        # Run hook synchronously"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_4560d035","line":168,"range":{"start_line":143,"start_character":1,"end_line":168,"end_character":39},"updated":"2016-09-12 12:18:01.000000000","message":"I dislike naming... let\u0027s remove at least word \"results\"","commit_id":"2ca4f9ee54d90692fa1ca1ff86f55231c0eefd90"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ec12de4a116a3f5b1258b65dd0923d22ca044c0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class HookExecutor(object):"},{"line_number":40,"context_line":"    \"\"\"Runs hooks and collects results from them.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, config):"},{"line_number":43,"context_line":"        self.config \u003d config"},{"line_number":44,"context_line":"        self._timer_thread \u003d threading.Thread(target\u003dself._timer_method)"},{"line_number":45,"context_line":"        self._timer_stop_event \u003d threading.Event()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_e496474b","line":42,"range":{"start_line":42,"start_character":17,"end_line":42,"end_character":29},"updated":"2016-09-15 10:09:55.000000000","message":"we should accept here task object to be able to do some logging.","commit_id":"7cbc88031ac9f67fdd06d3e621e41e75bb987c79"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"693bb488946cfb5a54a34608fdcfe5dd1527dfb4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class HookExecutor(object):"},{"line_number":40,"context_line":"    \"\"\"Runs hooks and collects results from them.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, config):"},{"line_number":43,"context_line":"        self.config \u003d config"},{"line_number":44,"context_line":"        self._timer_thread \u003d threading.Thread(target\u003dself._timer_method)"},{"line_number":45,"context_line":"        self._timer_stop_event \u003d threading.Event()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_72a55945","line":42,"range":{"start_line":42,"start_character":17,"end_line":42,"end_character":29},"in_reply_to":"7a8ec9b2_e496474b","updated":"2016-09-16 11:16:51.000000000","message":"Done","commit_id":"7cbc88031ac9f67fdd06d3e621e41e75bb987c79"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ec12de4a116a3f5b1258b65dd0923d22ca044c0","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        trigger.Trigger.validate(config[\"trigger\"])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def __init__(self, config):"},{"line_number":122,"context_line":"        self.config \u003d config"},{"line_number":123,"context_line":"        self._thread \u003d threading.Thread(target\u003dself._thread_method)"},{"line_number":124,"context_line":"        self._description \u003d \"n/a\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_c4b4ebd2","line":121,"range":{"start_line":121,"start_character":17,"end_line":121,"end_character":30},"updated":"2016-09-15 10:09:55.000000000","message":"It should accept task object too.","commit_id":"7cbc88031ac9f67fdd06d3e621e41e75bb987c79"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ec12de4a116a3f5b1258b65dd0923d22ca044c0","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def run_async(self):"},{"line_number":191,"context_line":"        \"\"\"Run hook asynchronously.\"\"\""},{"line_number":192,"context_line":"        self._thread.start()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def run_sync(self):"},{"line_number":195,"context_line":"        \"\"\"Run hook synchronously.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_24790ff7","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":28},"updated":"2016-09-15 10:09:55.000000000","message":"We need to add logging message here to inform about started async call of Hook N for Task M","commit_id":"7cbc88031ac9f67fdd06d3e621e41e75bb987c79"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ec12de4a116a3f5b1258b65dd0923d22ca044c0","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        \"\"\"Run hook asynchronously.\"\"\""},{"line_number":192,"context_line":"        self._thread.start()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def run_sync(self):"},{"line_number":195,"context_line":"        \"\"\"Run hook synchronously.\"\"\""},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            with rutils.Timer() as timer:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_c4394b43","line":194,"range":{"start_line":194,"start_character":0,"end_line":194,"end_character":23},"updated":"2016-09-15 10:09:55.000000000","message":"We need to wrapp this method with new logging wrapper(similar to https://github.com/openstack/rally/blob/master/rally/common/logging.py#L173-L216 . they use self.task object) with infromation about task uuid and hook","commit_id":"7cbc88031ac9f67fdd06d3e621e41e75bb987c79"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"66aed15c556ac9bcbb7146912e862aaaa7437874","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        Hook plugin shoud call following methods to set result:"},{"line_number":214,"context_line":"            set_result_status - to set success/failed status"},{"line_number":215,"context_line":"        Optionally the following methods should be colled:"},{"line_number":216,"context_line":"            set_result_error - to indicate that there was an error"},{"line_number":217,"context_line":"            set_result_output - to provide diarmam data"},{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_e0e0ac98","line":216,"range":{"start_line":216,"start_character":12,"end_line":216,"end_character":28},"updated":"2016-09-16 12:48:33.000000000","message":"It looks like it should be \u0027set_error\u0027. But let\u0027s fix it in the next patches.","commit_id":"6273674aa2701865305ff55fe6d019087101890e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"66aed15c556ac9bcbb7146912e862aaaa7437874","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            set_result_status - to set success/failed status"},{"line_number":215,"context_line":"        Optionally the following methods should be colled:"},{"line_number":216,"context_line":"            set_result_error - to indicate that there was an error"},{"line_number":217,"context_line":"            set_result_output - to provide diarmam data"},{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def result(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_40b40081","line":217,"range":{"start_line":217,"start_character":43,"end_line":217,"end_character":50},"updated":"2016-09-16 12:48:33.000000000","message":"diagram?","commit_id":"6273674aa2701865305ff55fe6d019087101890e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"66aed15c556ac9bcbb7146912e862aaaa7437874","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            set_result_status - to set success/failed status"},{"line_number":215,"context_line":"        Optionally the following methods should be colled:"},{"line_number":216,"context_line":"            set_result_error - to indicate that there was an error"},{"line_number":217,"context_line":"            set_result_output - to provide diarmam data"},{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def result(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_a08864c6","line":217,"range":{"start_line":217,"start_character":16,"end_line":217,"end_character":22},"updated":"2016-09-16 12:48:33.000000000","message":"ditto.","commit_id":"6273674aa2701865305ff55fe6d019087101890e"}]}
