)]}'
{"rally/api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"36054744745272ac354403baed16e70896093cd8","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        return backup_obj"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    @staticmethod"},{"line_number":454,"context_line":"    @contextlib.contextmanager"},{"line_number":455,"context_line":"    def _rollback_on_failure(backup):"},{"line_number":456,"context_line":"        try:"},{"line_number":457,"context_line":"            yield"},{"line_number":458,"context_line":"        except Exception:"},{"line_number":459,"context_line":"            backup.rollback()"},{"line_number":460,"context_line":"            raise"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @classmethod"},{"line_number":463,"context_line":"    def update_verifier(cls, name_or_uuid, system_wide\u003dNone, version\u003dNone,"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_19d6ccf0","line":460,"range":{"start_line":453,"start_character":4,"end_line":460,"end_character":17},"updated":"2016-11-11 12:59:00.000000000","message":"you do not need it. you can use backup as context manager itself, but __exit__ method should be modified to check \"exc_type\" argument before calling rollout","commit_id":"f8c32c9cdd041045362c174099c81f94a98a0b4b"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"388aa30a81aecd0917e131ba33cfd5e165cca399","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # TODO(akscram): Check that the deployment have got a status that"},{"line_number":83,"context_line":"        #                is equal to \"*-\u003efinished\" or \"deploy-\u003einconsistent\"."},{"line_number":84,"context_line":"        deployment \u003d objects.Deployment.get(deployment)"},{"line_number":85,"context_line":"        # FIXME: list all verifiers and unisntall all related data."},{"line_number":86,"context_line":"        pass"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a74a57a_77f16395","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":67},"updated":"2016-11-29 19:26:16.000000000","message":"Maybe we should combine the verifications table\u0027s status to delete verifiers.","commit_id":"870c03e59b1f70869cace07b15960ce4f89c35df"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            raise"},{"line_number":438,"context_line":"        verifier.update_status(consts.VerifierStatus.INSTALLED)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        LOG.info(\"Verifier \u0027%s\u0027 (UUID\u003d%s) has been successfully created!\","},{"line_number":441,"context_line":"                 verifier.name, verifier.uuid)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        return verifier.uuid"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_18c9c126","line":440,"range":{"start_line":440,"start_character":27,"end_line":440,"end_character":41},"updated":"2016-12-15 00:07:23.000000000","message":"this string is repeated multiple times. Based on L40-41 (https://review.openstack.org/#/c/372334/59/rally/common/objects/verifier.py), we can replace `\"bla bla bla \u0027%s\u0027 (UUID\u003d%s)\" % (verifier.name, verifier.uuid)` just by `\"bla bla bla %s\" % verifier`","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            raise"},{"line_number":438,"context_line":"        verifier.update_status(consts.VerifierStatus.INSTALLED)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        LOG.info(\"Verifier \u0027%s\u0027 (UUID\u003d%s) has been successfully created!\","},{"line_number":441,"context_line":"                 verifier.name, verifier.uuid)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        return verifier.uuid"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_72be3f66","line":440,"range":{"start_line":440,"start_character":27,"end_line":440,"end_character":41},"in_reply_to":"1a6eadb0_18c9c126","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    def list(status\u003dNone):"},{"line_number":455,"context_line":"        \"\"\"List all verifiers."},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        :param status: Status to sort verifiers by"},{"line_number":458,"context_line":"        \"\"\""},{"line_number":459,"context_line":"        vs \u003d objects.Verifier.list()"},{"line_number":460,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_2c14829e","line":457,"range":{"start_line":457,"start_character":33,"end_line":457,"end_character":37},"updated":"2016-12-15 00:07:23.000000000","message":"s/sort/filter/d","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    def list(status\u003dNone):"},{"line_number":455,"context_line":"        \"\"\"List all verifiers."},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        :param status: Status to sort verifiers by"},{"line_number":458,"context_line":"        \"\"\""},{"line_number":459,"context_line":"        vs \u003d objects.Verifier.list()"},{"line_number":460,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_b29d370c","line":457,"range":{"start_line":457,"start_character":33,"end_line":457,"end_character":37},"in_reply_to":"1a6eadb0_2c14829e","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        :param status: Status to sort verifiers by"},{"line_number":458,"context_line":"        \"\"\""},{"line_number":459,"context_line":"        vs \u003d objects.Verifier.list()"},{"line_number":460,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_46cfe428","line":459,"updated":"2016-12-15 00:07:23.000000000","message":"let\u0027s transmit status to db layer (it is better in terms of performance to filter verifiers there).","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        :param status: Status to sort verifiers by"},{"line_number":458,"context_line":"        \"\"\""},{"line_number":459,"context_line":"        vs \u003d objects.Verifier.list()"},{"line_number":460,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4dae01e7","line":459,"in_reply_to":"1a6eadb0_46cfe428","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                    Verification.delete(verification.uuid)"},{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                raise exceptions.RallyException("},{"line_number":486,"context_line":"                    \"Failed to delete verifier \u0027{0}\u0027 (UUID\u003d{1}) because there \""},{"line_number":487,"context_line":"                    \"are stored verifier verifications{2}! Please, make sure \""},{"line_number":488,"context_line":"                    \"that they are not important to you. Set \u0027force\u003dTrue\u0027 if \""},{"line_number":489,"context_line":"                    \"you would like to delete verifications{2} as well.\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_98ddd1e2","line":486,"range":{"start_line":486,"start_character":47,"end_line":486,"end_character":63},"updated":"2016-12-15 00:07:23.000000000","message":"just \"{0}\".format(verifier)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                    Verification.delete(verification.uuid)"},{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                raise exceptions.RallyException("},{"line_number":486,"context_line":"                    \"Failed to delete verifier \u0027{0}\u0027 (UUID\u003d{1}) because there \""},{"line_number":487,"context_line":"                    \"are stored verifier verifications{2}! Please, make sure \""},{"line_number":488,"context_line":"                    \"that they are not important to you. Set \u0027force\u003dTrue\u0027 if \""},{"line_number":489,"context_line":"                    \"you would like to delete verifications{2} as well.\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_52f86349","line":486,"range":{"start_line":486,"start_character":47,"end_line":486,"end_character":63},"in_reply_to":"1a6eadb0_98ddd1e2","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                raise exceptions.RallyException("},{"line_number":486,"context_line":"                    \"Failed to delete verifier \u0027{0}\u0027 (UUID\u003d{1}) because there \""},{"line_number":487,"context_line":"                    \"are stored verifier verifications{2}! Please, make sure \""},{"line_number":488,"context_line":"                    \"that they are not important to you. Set \u0027force\u003dTrue\u0027 if \""},{"line_number":489,"context_line":"                    \"you would like to delete verifications{2} as well.\""},{"line_number":490,"context_line":"                    .format(verifier.name, verifier.uuid, d_msg))"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_78ae3599","line":487,"range":{"start_line":487,"start_character":32,"end_line":487,"end_character":41},"updated":"2016-12-15 00:07:23.000000000","message":"redundant word","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":484,"context_line":"            else:"},{"line_number":485,"context_line":"                raise exceptions.RallyException("},{"line_number":486,"context_line":"                    \"Failed to delete verifier \u0027{0}\u0027 (UUID\u003d{1}) because there \""},{"line_number":487,"context_line":"                    \"are stored verifier verifications{2}! Please, make sure \""},{"line_number":488,"context_line":"                    \"that they are not important to you. Set \u0027force\u003dTrue\u0027 if \""},{"line_number":489,"context_line":"                    \"you would like to delete verifications{2} as well.\""},{"line_number":490,"context_line":"                    .format(verifier.name, verifier.uuid, d_msg))"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_32fbe748","line":487,"range":{"start_line":487,"start_character":32,"end_line":487,"end_character":41},"in_reply_to":"1a6eadb0_78ae3599","updated":"2016-12-15 14:47:20.000000000","message":"not sure...","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                    .format(verifier.name, verifier.uuid, d_msg))"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if deployment_id:"},{"line_number":493,"context_line":"            LOG.info(\"Deleting deployment-specific data for verifier \u0027%s\u0027 \""},{"line_number":494,"context_line":"                     \"(UUID\u003d%s).\", verifier.name, verifier.uuid)"},{"line_number":495,"context_line":"            verifier.set_deployment(deployment_id)"},{"line_number":496,"context_line":"            verifier.manager.uninstall()"},{"line_number":497,"context_line":"            LOG.info(\"Deployment-specific data has been successfully deleted!\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_18f0e166","line":494,"range":{"start_line":493,"start_character":68,"end_line":494,"end_character":31},"updated":"2016-12-15 00:07:23.000000000","message":"same here","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                    .format(verifier.name, verifier.uuid, d_msg))"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        if deployment_id:"},{"line_number":493,"context_line":"            LOG.info(\"Deleting deployment-specific data for verifier \u0027%s\u0027 \""},{"line_number":494,"context_line":"                     \"(UUID\u003d%s).\", verifier.name, verifier.uuid)"},{"line_number":495,"context_line":"            verifier.set_deployment(deployment_id)"},{"line_number":496,"context_line":"            verifier.manager.uninstall()"},{"line_number":497,"context_line":"            LOG.info(\"Deployment-specific data has been successfully deleted!\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_32e4c7aa","line":494,"range":{"start_line":493,"start_character":68,"end_line":494,"end_character":31},"in_reply_to":"1a6eadb0_18f0e166","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            verifier.manager.uninstall()"},{"line_number":497,"context_line":"            LOG.info(\"Deployment-specific data has been successfully deleted!\")"},{"line_number":498,"context_line":"        else:"},{"line_number":499,"context_line":"            LOG.info(\"Deleting verifier \u0027%s\u0027 (UUID\u003d%s).\", verifier.name,"},{"line_number":500,"context_line":"                     verifier.uuid)"},{"line_number":501,"context_line":"            verifier.manager.uninstall(full\u003dTrue)"},{"line_number":502,"context_line":"            objects.Verifier.delete(verifier_id)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_78eb9578","line":499,"range":{"start_line":499,"start_character":40,"end_line":499,"end_character":54},"updated":"2016-12-15 00:07:23.000000000","message":"and here:)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            verifier.manager.uninstall()"},{"line_number":497,"context_line":"            LOG.info(\"Deployment-specific data has been successfully deleted!\")"},{"line_number":498,"context_line":"        else:"},{"line_number":499,"context_line":"            LOG.info(\"Deleting verifier \u0027%s\u0027 (UUID\u003d%s).\", verifier.name,"},{"line_number":500,"context_line":"                     verifier.uuid)"},{"line_number":501,"context_line":"            verifier.manager.uninstall(full\u003dTrue)"},{"line_number":502,"context_line":"            objects.Verifier.delete(verifier_id)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_12db4bed","line":499,"range":{"start_line":499,"start_character":40,"end_line":499,"end_character":54},"in_reply_to":"1a6eadb0_78eb9578","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        :param update_venv: Update the virtual environment for verifier"},{"line_number":514,"context_line":"        \"\"\""},{"line_number":515,"context_line":"        if system_wide is None and version is None and not update_venv:"},{"line_number":516,"context_line":"            # noting to update"},{"line_number":517,"context_line":"            raise exceptions.RallyException("},{"line_number":518,"context_line":"                \"At least one of the following parameters should be \""},{"line_number":519,"context_line":"                \"specified: \u0027update-venv\u0027, \u0027version\u0027, \u0027system-wide\u0027, \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_789c755d","line":516,"range":{"start_line":516,"start_character":14,"end_line":516,"end_character":20},"updated":"2016-12-15 00:07:23.000000000","message":"s/noting/nothing","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        :param update_venv: Update the virtual environment for verifier"},{"line_number":514,"context_line":"        \"\"\""},{"line_number":515,"context_line":"        if system_wide is None and version is None and not update_venv:"},{"line_number":516,"context_line":"            # noting to update"},{"line_number":517,"context_line":"            raise exceptions.RallyException("},{"line_number":518,"context_line":"                \"At least one of the following parameters should be \""},{"line_number":519,"context_line":"                \"specified: \u0027update-venv\u0027, \u0027version\u0027, \u0027system-wide\u0027, \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_d2d473be","line":516,"range":{"start_line":516,"start_character":14,"end_line":516,"end_character":20},"in_reply_to":"1a6eadb0_789c755d","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        if verifier.status not in (consts.VerifierStatus.INSTALLED,"},{"line_number":527,"context_line":"                                   consts.VerifierStatus.CONFIGURED):"},{"line_number":528,"context_line":"            raise exceptions.RallyException("},{"line_number":529,"context_line":"                \"Failed to update verifier \u0027%s\u0027 (UUID\u003d%s) because \""},{"line_number":530,"context_line":"                \"verifier is in \u0027%s\u0027 status.\" % (verifier.name, verifier.uuid,"},{"line_number":531,"context_line":"                                                 verifier.status))"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_b8760dd5","line":529,"range":{"start_line":529,"start_character":43,"end_line":529,"end_character":57},"updated":"2016-12-15 00:07:23.000000000","message":"you know what I want to write)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        if verifier.status not in (consts.VerifierStatus.INSTALLED,"},{"line_number":527,"context_line":"                                   consts.VerifierStatus.CONFIGURED):"},{"line_number":528,"context_line":"            raise exceptions.RallyException("},{"line_number":529,"context_line":"                \"Failed to update verifier \u0027%s\u0027 (UUID\u003d%s) because \""},{"line_number":530,"context_line":"                \"verifier is in \u0027%s\u0027 status.\" % (verifier.name, verifier.uuid,"},{"line_number":531,"context_line":"                                                 verifier.status))"},{"line_number":532,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_b2cff727","line":529,"range":{"start_line":529,"start_character":43,"end_line":529,"end_character":57},"in_reply_to":"1a6eadb0_b8760dd5","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        if update_venv and system_wide_in_use:"},{"line_number":536,"context_line":"            raise exceptions.RallyException("},{"line_number":537,"context_line":"                \"It is impossible to update the virtual environment for \""},{"line_number":538,"context_line":"                \"verifier \u0027%s\u0027 (UUID\u003d%s) when verifier is switched to using \""},{"line_number":539,"context_line":"                \"the system-wide environment.\" % (verifier.name, verifier.uuid)"},{"line_number":540,"context_line":"            )"},{"line_number":541,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_2c280286","line":538,"range":{"start_line":538,"start_character":40,"end_line":538,"end_character":76},"updated":"2016-12-15 00:07:23.000000000","message":"when it uses","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        if update_venv and system_wide_in_use:"},{"line_number":536,"context_line":"            raise exceptions.RallyException("},{"line_number":537,"context_line":"                \"It is impossible to update the virtual environment for \""},{"line_number":538,"context_line":"                \"verifier \u0027%s\u0027 (UUID\u003d%s) when verifier is switched to using \""},{"line_number":539,"context_line":"                \"the system-wide environment.\" % (verifier.name, verifier.uuid)"},{"line_number":540,"context_line":"            )"},{"line_number":541,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_72c9df25","line":538,"range":{"start_line":538,"start_character":40,"end_line":538,"end_character":76},"in_reply_to":"1a6eadb0_2c280286","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        if vm.is_configured():"},{"line_number":624,"context_line":"            LOG.info(\"Verifier is already configured!\")"},{"line_number":625,"context_line":"            if not recreate:"},{"line_number":626,"context_line":"                if extra_options:"},{"line_number":627,"context_line":"                    # Just add extra options to the config file."},{"line_number":628,"context_line":"                    verifier.update_status(consts.VerifierStatus.CONFIGURING)"},{"line_number":629,"context_line":"                    conf \u003d configparser.ConfigParser()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_6c803af8","line":626,"updated":"2016-12-15 00:07:23.000000000","message":"It would be nice to log here, that config will be updated with extra options.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        if vm.is_configured():"},{"line_number":624,"context_line":"            LOG.info(\"Verifier is already configured!\")"},{"line_number":625,"context_line":"            if not recreate:"},{"line_number":626,"context_line":"                if extra_options:"},{"line_number":627,"context_line":"                    # Just add extra options to the config file."},{"line_number":628,"context_line":"                    verifier.update_status(consts.VerifierStatus.CONFIGURING)"},{"line_number":629,"context_line":"                    conf \u003d configparser.ConfigParser()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_524a23ad","line":626,"in_reply_to":"1a6eadb0_6c803af8","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    verifier.update_status(consts.VerifierStatus.CONFIGURED)"},{"line_number":634,"context_line":"                    LOG.info(msg)"},{"line_number":635,"context_line":"                return verify_utils.read_configfile(vm.configfile)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"            LOG.info(\"Reconfiguring verifier.\")"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        verifier.update_status(consts.VerifierStatus.CONFIGURING)"},{"line_number":640,"context_line":"        raw_configfile \u003d vm.create_configfile(extra_options\u003dextra_options)"},{"line_number":641,"context_line":"        verifier.update_status(consts.VerifierStatus.CONFIGURED)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        LOG.info(msg)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        return raw_configfile"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_8c9cb65e","line":643,"range":{"start_line":636,"start_character":0,"end_line":643,"end_character":21},"updated":"2016-12-15 00:07:23.000000000","message":"we should not reconfigure verifier if recreate\u003d\u003dFalse . recreate argument is used only at L625","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    verifier.update_status(consts.VerifierStatus.CONFIGURED)"},{"line_number":634,"context_line":"                    LOG.info(msg)"},{"line_number":635,"context_line":"                return verify_utils.read_configfile(vm.configfile)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"            LOG.info(\"Reconfiguring verifier.\")"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        verifier.update_status(consts.VerifierStatus.CONFIGURING)"},{"line_number":640,"context_line":"        raw_configfile \u003d vm.create_configfile(extra_options\u003dextra_options)"},{"line_number":641,"context_line":"        verifier.update_status(consts.VerifierStatus.CONFIGURED)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        LOG.info(msg)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        return raw_configfile"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_92a83b8f","line":643,"range":{"start_line":636,"start_character":0,"end_line":643,"end_character":21},"in_reply_to":"1a6eadb0_8c9cb65e","updated":"2016-12-15 14:47:20.000000000","message":"The code does the same what you said :)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        return raw_configfile"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    @classmethod"},{"line_number":648,"context_line":"    def rewrite_configfile(cls, verifier_id, deployment_id, new_content):"},{"line_number":649,"context_line":"        \"\"\"Rewrite a verifier config file."},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        :param verifier_id: Verifier name or UUID"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4cbd3eb6","line":648,"range":{"start_line":648,"start_character":8,"end_line":648,"end_character":26},"updated":"2016-12-15 00:07:23.000000000","message":"\"override\" is a better word","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        return raw_configfile"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    @classmethod"},{"line_number":648,"context_line":"    def rewrite_configfile(cls, verifier_id, deployment_id, new_content):"},{"line_number":649,"context_line":"        \"\"\"Rewrite a verifier config file."},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        :param verifier_id: Verifier name or UUID"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_12542b51","line":648,"range":{"start_line":648,"start_character":8,"end_line":648,"end_character":26},"in_reply_to":"1a6eadb0_4cbd3eb6","updated":"2016-12-15 14:47:20.000000000","message":"not sure...","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":748,"context_line":"            Verifier.configure(verifier_id, deployment_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        verifier.manager.validate_args(run_args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        verification \u003d objects.Verification.create(verifier_id,"},{"line_number":753,"context_line":"                                                   deployment_id, run_args)"},{"line_number":754,"context_line":"        LOG.info(\"Starting verification (UUID\u003d%s) for deployment \u0027%s\u0027 \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_a0a893dc","line":751,"updated":"2016-12-15 00:07:23.000000000","message":"please leave here todo for extending skip_list to allow to skip whole test case or specify just test name without id","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3550f241a56f51e4ab10e1dd12a1e9b6f507650d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"            Verifier.configure(verifier_id, deployment_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        verifier.manager.validate_args(run_args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        verification \u003d objects.Verification.create(verifier_id,"},{"line_number":753,"context_line":"                                                   deployment_id, run_args)"},{"line_number":754,"context_line":"        LOG.info(\"Starting verification (UUID\u003d%s) for deployment \u0027%s\u0027 \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_1a4402b5","line":751,"in_reply_to":"1a6eadb0_a0a893dc","updated":"2016-12-16 12:25:45.000000000","message":"Are you sure that we need a \u0027todo\u0027 in the \u0027start\u0027 method? :)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        :param verifier_id: Verifier name or UUID"},{"line_number":786,"context_line":"        :param deployment_id: Deployment name or UUID"},{"line_number":787,"context_line":"        :param status: Status to sort verifications by"},{"line_number":788,"context_line":"        \"\"\""},{"line_number":789,"context_line":"        vs \u003d objects.Verification.list(verifier_id, deployment_id)"},{"line_number":790,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_ec47eab9","line":787,"range":{"start_line":787,"start_character":33,"end_line":787,"end_character":37},"updated":"2016-12-15 00:07:23.000000000","message":"s/sort/filter/d","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        :param verifier_id: Verifier name or UUID"},{"line_number":786,"context_line":"        :param deployment_id: Deployment name or UUID"},{"line_number":787,"context_line":"        :param status: Status to sort verifications by"},{"line_number":788,"context_line":"        \"\"\""},{"line_number":789,"context_line":"        vs \u003d objects.Verification.list(verifier_id, deployment_id)"},{"line_number":790,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_6dd2e25d","line":787,"range":{"start_line":787,"start_character":33,"end_line":787,"end_character":37},"in_reply_to":"1a6eadb0_ec47eab9","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        :param deployment_id: Deployment name or UUID"},{"line_number":787,"context_line":"        :param status: Status to sort verifications by"},{"line_number":788,"context_line":"        \"\"\""},{"line_number":789,"context_line":"        vs \u003d objects.Verification.list(verifier_id, deployment_id)"},{"line_number":790,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    @classmethod"},{"line_number":793,"context_line":"    def delete(cls, verification_uuid):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_ac4172ab","line":790,"range":{"start_line":789,"start_character":8,"end_line":790,"end_character":70},"updated":"2016-12-15 00:07:23.000000000","message":"let\u0027s use filtering at db layer","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        :param deployment_id: Deployment name or UUID"},{"line_number":787,"context_line":"        :param status: Status to sort verifications by"},{"line_number":788,"context_line":"        \"\"\""},{"line_number":789,"context_line":"        vs \u003d objects.Verification.list(verifier_id, deployment_id)"},{"line_number":790,"context_line":"        return [v for v in vs if v.status \u003d\u003d status] if status else vs"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    @classmethod"},{"line_number":793,"context_line":"    def delete(cls, verification_uuid):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_aaa21bac","line":790,"range":{"start_line":789,"start_character":8,"end_line":790,"end_character":70},"in_reply_to":"1a6eadb0_ac4172ab","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        :param uuids: List of verifications UUIDs"},{"line_number":808,"context_line":"        :param html: Whether or not to create the report in HTML format"},{"line_number":809,"context_line":"        \"\"\""},{"line_number":810,"context_line":"        results \u003d {}"},{"line_number":811,"context_line":"        for uuid in uuids:"},{"line_number":812,"context_line":"            v \u003d cls.get(uuid)"},{"line_number":813,"context_line":"            results[uuid] \u003d {"},{"line_number":814,"context_line":"                \"started_at\": v.created_at.strftime(\"%Y-%m-%d %H:%M:%S\"),"},{"line_number":815,"context_line":"                \"finished_at\": v.updated_at.strftime(\"%Y-%m-%d %H:%M:%S\"),"},{"line_number":816,"context_line":"                \"status\": v.status,"},{"line_number":817,"context_line":"                \"run_args\": v.run_args,"},{"line_number":818,"context_line":"                \"tests_duration\": v.tests_duration,"},{"line_number":819,"context_line":"                \"tests_count\": v.tests_count,"},{"line_number":820,"context_line":"                \"skipped\": v.skipped,"},{"line_number":821,"context_line":"                \"success\": v.success,"},{"line_number":822,"context_line":"                \"expected_failures\": v.expected_failures,"},{"line_number":823,"context_line":"                \"unexpected_success\": v.unexpected_success,"},{"line_number":824,"context_line":"                \"failures\": v.failures,"},{"line_number":825,"context_line":"                \"tests\": v.tests"},{"line_number":826,"context_line":"            }"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        if html:"},{"line_number":829,"context_line":"            return report.VerificationReport(results).to_html()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_2cf00267","line":826,"range":{"start_line":810,"start_character":8,"end_line":826,"end_character":13},"updated":"2016-12-15 00:07:23.000000000","message":"1) it is better to use collections.OrderedDict at L810 to display results in order that user specified.\n\n2) not sure why we need to create this dict here, let\u0027s move it to VerificationReport class.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        :param uuids: List of verifications UUIDs"},{"line_number":808,"context_line":"        :param html: Whether or not to create the report in HTML format"},{"line_number":809,"context_line":"        \"\"\""},{"line_number":810,"context_line":"        results \u003d {}"},{"line_number":811,"context_line":"        for uuid in uuids:"},{"line_number":812,"context_line":"            v \u003d cls.get(uuid)"},{"line_number":813,"context_line":"            results[uuid] \u003d {"},{"line_number":814,"context_line":"                \"started_at\": v.created_at.strftime(\"%Y-%m-%d %H:%M:%S\"),"},{"line_number":815,"context_line":"                \"finished_at\": v.updated_at.strftime(\"%Y-%m-%d %H:%M:%S\"),"},{"line_number":816,"context_line":"                \"status\": v.status,"},{"line_number":817,"context_line":"                \"run_args\": v.run_args,"},{"line_number":818,"context_line":"                \"tests_duration\": v.tests_duration,"},{"line_number":819,"context_line":"                \"tests_count\": v.tests_count,"},{"line_number":820,"context_line":"                \"skipped\": v.skipped,"},{"line_number":821,"context_line":"                \"success\": v.success,"},{"line_number":822,"context_line":"                \"expected_failures\": v.expected_failures,"},{"line_number":823,"context_line":"                \"unexpected_success\": v.unexpected_success,"},{"line_number":824,"context_line":"                \"failures\": v.failures,"},{"line_number":825,"context_line":"                \"tests\": v.tests"},{"line_number":826,"context_line":"            }"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        if html:"},{"line_number":829,"context_line":"            return report.VerificationReport(results).to_html()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_a87a2875","line":826,"range":{"start_line":810,"start_character":8,"end_line":826,"end_character":13},"in_reply_to":"1a6eadb0_2cf00267","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        vm \u003d verifier.manager"},{"line_number":613,"context_line":"        if vm.is_configured():"},{"line_number":614,"context_line":"            LOG.info(\"Verifier is already configured!\")"},{"line_number":615,"context_line":"            if not recreate:"},{"line_number":616,"context_line":"                if extra_options:"},{"line_number":617,"context_line":"                    # Just add extra options to the config file."},{"line_number":618,"context_line":"                    if logging.is_debug():"},{"line_number":619,"context_line":"                        LOG.debug(\"Adding the following extra options: %s \""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_1aee7dec","line":616,"range":{"start_line":615,"start_character":12,"end_line":616,"end_character":33},"updated":"2016-12-19 12:28:53.000000000","message":"if not recreate:\n    if not extra_options:\n        # log that nothing will be changed(info level)\n    else:\n        # put L618-630","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        vm \u003d verifier.manager"},{"line_number":613,"context_line":"        if vm.is_configured():"},{"line_number":614,"context_line":"            LOG.info(\"Verifier is already configured!\")"},{"line_number":615,"context_line":"            if not recreate:"},{"line_number":616,"context_line":"                if extra_options:"},{"line_number":617,"context_line":"                    # Just add extra options to the config file."},{"line_number":618,"context_line":"                    if logging.is_debug():"},{"line_number":619,"context_line":"                        LOG.debug(\"Adding the following extra options: %s \""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_2cd8631d","line":616,"range":{"start_line":615,"start_character":12,"end_line":616,"end_character":33},"in_reply_to":"1a6eadb0_1aee7dec","updated":"2016-12-19 14:44:30.000000000","message":"I think log message will be redundant. I will return verify_utils.read_configfile(vm.configfile) instead.\n\n\nif not extra_options:\n    return verify_utils.read_configfile(vm.configfile)\nelse:\n    # put L618-630\n\n\nIs it ok?","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            Verifier.configure(verifier_id, deployment_id)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        verifier.manager.validate_args(run_args)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        verification \u003d objects.Verification.create(verifier_id,"},{"line_number":744,"context_line":"                                                   deployment_id, run_args)"},{"line_number":745,"context_line":"        LOG.info(\"Starting verification (UUID\u003d%s) for deployment \u0027%s\u0027 \""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_da916554","line":742,"updated":"2016-12-19 12:28:53.000000000","message":"From patch-set #59:\n\n\u003e me: please leave here todo for extending skip_list to allow \n\u003e        to skip whole test case or specify just test name without id\n\u003e you: Are you sure that we need a \u0027todo\u0027 in the \u0027start\u0027 method? :)\n\nit should be placed to \"visible place\", so I\u0027ll see it when I have enough time and fix it.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":739,"context_line":"            Verifier.configure(verifier_id, deployment_id)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        verifier.manager.validate_args(run_args)"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        verification \u003d objects.Verification.create(verifier_id,"},{"line_number":744,"context_line":"                                                   deployment_id, run_args)"},{"line_number":745,"context_line":"        LOG.info(\"Starting verification (UUID\u003d%s) for deployment \u0027%s\u0027 \""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_83806548","line":742,"in_reply_to":"1a6eadb0_da916554","updated":"2016-12-19 14:44:30.000000000","message":"Done","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        try:"},{"line_number":752,"context_line":"            results \u003d verifier.manager.run(verification, **run_args)"},{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            verification.set_failed(e)"},{"line_number":755,"context_line":"            raise"},{"line_number":756,"context_line":"        verification.finish(results.totals, results.tests)"},{"line_number":757,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_177e58ae","line":754,"updated":"2016-12-19 12:28:53.000000000","message":"let\u0027s add here check that verification object exist(obtain it again from db). it can help in case if user launched `rally verify remove-verifier` in paraller:)","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        try:"},{"line_number":752,"context_line":"            results \u003d verifier.manager.run(verification, **run_args)"},{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            verification.set_failed(e)"},{"line_number":755,"context_line":"            raise"},{"line_number":756,"context_line":"        verification.finish(results.totals, results.tests)"},{"line_number":757,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_a3948144","line":754,"in_reply_to":"1a6eadb0_177e58ae","updated":"2016-12-19 14:44:30.000000000","message":"Can we do it in other patches? I will add a \u0027todo\u0027.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            verification.set_failed(e)"},{"line_number":755,"context_line":"            raise"},{"line_number":756,"context_line":"        verification.finish(results.totals, results.tests)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        LOG.info(\"Verification (UUID\u003d%s) has been successfully finished for \""},{"line_number":759,"context_line":"                 \"deployment \u0027%s\u0027 (UUID\u003d%s)!\", verification.uuid,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_9748a889","line":756,"updated":"2016-12-19 12:28:53.000000000","message":"same here + dump json to tmp dir if verification is not exist in db","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        except Exception as e:"},{"line_number":754,"context_line":"            verification.set_failed(e)"},{"line_number":755,"context_line":"            raise"},{"line_number":756,"context_line":"        verification.finish(results.totals, results.tests)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        LOG.info(\"Verification (UUID\u003d%s) has been successfully finished for \""},{"line_number":759,"context_line":"                 \"deployment \u0027%s\u0027 (UUID\u003d%s)!\", verification.uuid,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_e3f039cc","line":756,"in_reply_to":"1a6eadb0_9748a889","updated":"2016-12-19 14:44:30.000000000","message":"Why do we need dump JSON to temp file? It looks like it is useless for us.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        :param deployment_id: Deployment name or UUID"},{"line_number":778,"context_line":"        :param status: Status to filter verifications by"},{"line_number":779,"context_line":"        \"\"\""},{"line_number":780,"context_line":"        return objects.Verification.list(verifier_id, deployment_id, status)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    @classmethod"},{"line_number":783,"context_line":"    def delete(cls, verification_uuid):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_da78852e","line":780,"range":{"start_line":780,"start_character":41,"end_line":780,"end_character":76},"updated":"2016-12-19 12:28:53.000000000","message":"nit: use keyword argument.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                     % deployment[\"uuid\"])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for verifier in _Verifier.list():"},{"line_number":100,"context_line":"            _Verifier.delete(verifier.uuid, deployment[\"name\"], force\u003dTrue)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        deployment.delete()"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_5c0d3c36","line":100,"range":{"start_line":100,"start_character":38,"end_line":100,"end_character":42},"updated":"2016-12-23 12:01:24.000000000","message":"Nit: I know it doesn\u0027t matter, but let\u0027s use \u0027name\u0027 here as well.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"class _Verifier(object):"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    FINAL_STATES \u003d (consts.VerifierStatus.INSTALLED,"},{"line_number":393,"context_line":"                    consts.VerifierStatus.CONFIGURED)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_5c80dc46","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":16},"updated":"2016-12-23 12:01:24.000000000","message":"In earlier patch sets you named it \u0027allowed_statuses\u0027. Let\u0027s rename it to ALLOWED_STATUSES.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a43e975a2e055afc3f51064c47ce6be0d385373b","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"class _Verifier(object):"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    FINAL_STATES \u003d (consts.VerifierStatus.INSTALLED,"},{"line_number":393,"context_line":"                    consts.VerifierStatus.CONFIGURED)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_3427a313","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":16},"in_reply_to":"da4df55a_4b4acbc6","updated":"2016-12-23 15:59:02.000000000","message":"IMHO, FINAL_STATES is not clear as well :) Maybe STATUSES_TO_PROCEED or something like that?","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c5c1dc17cbd427475686d6a2670a0fa11cde7b5e","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"class _Verifier(object):"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    FINAL_STATES \u003d (consts.VerifierStatus.INSTALLED,"},{"line_number":393,"context_line":"                    consts.VerifierStatus.CONFIGURED)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_4b4acbc6","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":16},"in_reply_to":"da4df55a_5c80dc46","updated":"2016-12-23 12:53:11.000000000","message":"it was wrong name. allowed_statuses is too unclear name. Allowed for what? :)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    @classmethod"},{"line_number":408,"context_line":"    def create(cls, name, vtype, namespace\u003dNone, source\u003dNone, version\u003dNone,"},{"line_number":409,"context_line":"               system_wide\u003dFalse, extra\u003dNone):"},{"line_number":410,"context_line":"        \"\"\"Create a verifier."},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        :param name: Verifier name"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_dcba0c0a","line":409,"range":{"start_line":409,"start_character":34,"end_line":409,"end_character":39},"updated":"2016-12-23 12:01:24.000000000","message":"extra_settings","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        :param name: Verifier name"},{"line_number":413,"context_line":"        :param vtype: Verifier plugin name"},{"line_number":414,"context_line":"        :param namespace: Verifier type namespace. Should be specified when"},{"line_number":415,"context_line":"                          there are two verifier plugins with equal names but"},{"line_number":416,"context_line":"                          in different namespaces"},{"line_number":417,"context_line":"        :param source: Path or URL to the repo to clone verifier from"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_5cf7fcf4","line":414,"range":{"start_line":414,"start_character":35,"end_line":414,"end_character":39},"updated":"2016-12-23 12:01:24.000000000","message":"plugin","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                        verifier installation"},{"line_number":420,"context_line":"        :param system_wide: Whether or not to use the system-wide environment"},{"line_number":421,"context_line":"                            for verifier instead of a virtual environment"},{"line_number":422,"context_line":"        :param extra: Verifier-specific installation options"},{"line_number":423,"context_line":"        \"\"\""},{"line_number":424,"context_line":"        # check that the specified verifier type exists"},{"line_number":425,"context_line":"        vmanager.VerifierManager.get(vtype, namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_77193a79","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":60},"updated":"2016-12-23 12:01:24.000000000","message":"Extra installation settings for verifier","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        :param deployment_id: Deployment name or UUID. If specified,"},{"line_number":474,"context_line":"                              only deployment-specific data will be deleted"},{"line_number":475,"context_line":"                              for verifier"},{"line_number":476,"context_line":"        :param force: Delete all stored verifier verifications."},{"line_number":477,"context_line":"                      If deployment_id specified, only deployment-specific"},{"line_number":478,"context_line":"                      verifications will be deleted"},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":481,"context_line":"        verifications \u003d _Verification.list(verifier_id, deployment_id)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_1cd73424","line":478,"range":{"start_line":476,"start_character":22,"end_line":478,"end_character":51},"updated":"2016-12-23 12:01:24.000000000","message":"Delete all stored verifications of the specified verifier. If deployment specified, only verifications of this deployment will be deleted\n\n\nI fixed your comment in CLI. Let\u0027s fix it here as well.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":521,"context_line":"            # nothing to update"},{"line_number":522,"context_line":"            raise exceptions.RallyException("},{"line_number":523,"context_line":"                \"At least one of the following parameters should be \""},{"line_number":524,"context_line":"                \"specified: \u0027update-venv\u0027, \u0027version\u0027, \u0027system-wide\u0027, \""},{"line_number":525,"context_line":"                \"\u0027no-system-wide\u0027.\")"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":528,"context_line":"        LOG.info(\"Updating verifier %s.\", verifier)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_5c10dca8","line":525,"range":{"start_line":524,"start_character":28,"end_line":525,"end_character":33},"updated":"2016-12-23 12:01:24.000000000","message":"\u0027system_wide\u0027, \u0027version\u0027, \u0027update_venv\u0027","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        return raw_config"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    @classmethod"},{"line_number":656,"context_line":"    def override_config(cls, verifier_id, deployment_id, new_content):"},{"line_number":657,"context_line":"        \"\"\"Override a verifier configuration(for example rewrite config file)."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param verifier_id: Verifier name or UUID"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_777dbb1b","line":656,"range":{"start_line":656,"start_character":17,"end_line":656,"end_character":23},"updated":"2016-12-23 12:01:24.000000000","message":"Maybe configuration?","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    @classmethod"},{"line_number":656,"context_line":"    def override_config(cls, verifier_id, deployment_id, new_content):"},{"line_number":657,"context_line":"        \"\"\"Override a verifier configuration(for example rewrite config file)."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param verifier_id: Verifier name or UUID"},{"line_number":660,"context_line":"        :param deployment_id: Deployment name or UUID"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_1730ef9d","line":657,"range":{"start_line":657,"start_character":11,"end_line":657,"end_character":78},"updated":"2016-12-23 12:01:24.000000000","message":"Override a verifier configuration (e.g., rewrite the config file).","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":664,"context_line":"        if verifier.status not in cls.FINAL_STATES:"},{"line_number":665,"context_line":"            raise exceptions.RallyException("},{"line_number":666,"context_line":"                \"Failed to override verifier %s configuration for deployment \""},{"line_number":667,"context_line":"                \"\u0027%s\u0027 (UUID\u003d%s) because verifier is in \u0027%s\u0027 status.\""},{"line_number":668,"context_line":"                % (verifier, verifier.deployment[\"name\"],"},{"line_number":669,"context_line":"                   verifier.deployment[\"uuid\"], verifier.status))"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_77a4dba5","line":666,"range":{"start_line":666,"start_character":45,"end_line":666,"end_character":47},"updated":"2016-12-23 12:01:24.000000000","message":"Let\u0027s delete it.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        if verifier.status not in cls.FINAL_STATES:"},{"line_number":665,"context_line":"            raise exceptions.RallyException("},{"line_number":666,"context_line":"                \"Failed to override verifier %s configuration for deployment \""},{"line_number":667,"context_line":"                \"\u0027%s\u0027 (UUID\u003d%s) because verifier is in \u0027%s\u0027 status.\""},{"line_number":668,"context_line":"                % (verifier, verifier.deployment[\"name\"],"},{"line_number":669,"context_line":"                   verifier.deployment[\"uuid\"], verifier.status))"},{"line_number":670,"context_line":"        verifier.set_deployment(deployment_id)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_97c69f47","line":667,"range":{"start_line":667,"start_character":40,"end_line":667,"end_character":49},"updated":"2016-12-23 12:01:24.000000000","message":"verifier %s","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":683,"context_line":"        if verifier.status not in cls.FINAL_STATES:"},{"line_number":684,"context_line":"            raise exceptions.RallyException("},{"line_number":685,"context_line":"                \"Failed to list tests for verifier %s because verifier is not \""},{"line_number":686,"context_line":"                \"installed yet.\" % verifier)"},{"line_number":687,"context_line":"        return verifier.manager.list_tests(pattern)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_375b3389","line":686,"range":{"start_line":685,"start_character":1,"end_line":686,"end_character":44},"updated":"2016-12-23 12:01:24.000000000","message":"Let\u0027s use the following message:\n\n\n\"Failed to list verifier tests because verifier %s is in \u0027%s\u0027 status.\" % (verifier, verifier.status)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        return verifier.manager.list_tests(pattern)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    @classmethod"},{"line_number":690,"context_line":"    def add_extension(cls, verifier_id, source, version\u003dNone, extra\u003dNone):"},{"line_number":691,"context_line":"        \"\"\"Add a verifier extension."},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        :param verifier_id: Verifier name or UUID"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_3745f36f","line":690,"range":{"start_line":690,"start_character":62,"end_line":690,"end_character":67},"updated":"2016-12-23 12:01:24.000000000","message":"extra_settings","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        \"\"\"Add a verifier extension."},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        :param verifier_id: Verifier name or UUID"},{"line_number":694,"context_line":"        :param source: Path or URL to the repo to clone verifier from"},{"line_number":695,"context_line":"        :param version: Branch, tag or commit ID to checkout before"},{"line_number":696,"context_line":"                        installation of the verifier extension"},{"line_number":697,"context_line":"        :param extra: Verifier-specific installation options"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d7e1079c","line":694,"range":{"start_line":694,"start_character":56,"end_line":694,"end_character":64},"updated":"2016-12-23 12:01:24.000000000","message":"extension","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        :param source: Path or URL to the repo to clone verifier from"},{"line_number":695,"context_line":"        :param version: Branch, tag or commit ID to checkout before"},{"line_number":696,"context_line":"                        installation of the verifier extension"},{"line_number":697,"context_line":"        :param extra: Verifier-specific installation options"},{"line_number":698,"context_line":"        \"\"\""},{"line_number":699,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":700,"context_line":"        if verifier.status not in cls.FINAL_STATES:"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d77d87b2","line":697,"range":{"start_line":697,"start_character":22,"end_line":697,"end_character":60},"updated":"2016-12-23 12:01:24.000000000","message":"Extra installation settings for verifier extension","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":726,"context_line":"        if verifier.status not in cls.FINAL_STATES:"},{"line_number":727,"context_line":"            raise exceptions.RallyException("},{"line_number":728,"context_line":"                \"Failed to list extensions of verifier %s because verifier \""},{"line_number":729,"context_line":"                \"is not installed yet.\" % verifier)"},{"line_number":730,"context_line":"        return verifier.manager.list_extensions()"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_f771aaa9","line":729,"range":{"start_line":728,"start_character":0,"end_line":729,"end_character":51},"updated":"2016-12-23 12:01:24.000000000","message":"\"Failed to list verifier extensions because verifier %s is in \u0027%s\u0027 status.\" % (verifier, verifier.status)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":739,"context_line":"        verifier \u003d cls.get(verifier_id)"},{"line_number":740,"context_line":"        if verifier.status not in cls.FINAL_STATES:"},{"line_number":741,"context_line":"            raise exceptions.RallyException("},{"line_number":742,"context_line":"                \"Failed to delete extension of verifier %s because verifier \""},{"line_number":743,"context_line":"                \"even is not installed yet.\" % verifier)"},{"line_number":744,"context_line":"        LOG.info(\"Deleting extension for verifier %s.\", verifier)"},{"line_number":745,"context_line":"        verifier.manager.uninstall_extension(name)"},{"line_number":746,"context_line":"        LOG.info(\"Extension for verifier %s has been successfully deleted!\","}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_37ab32d8","line":743,"range":{"start_line":742,"start_character":0,"end_line":743,"end_character":56},"updated":"2016-12-23 12:01:24.000000000","message":"\"Failed to delete verifier extension \u0027%s\u0027 because verifier %s is in \u0027%s\u0027 status.\" % (name, verifier, verifier.status)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                 \"(UUID\u003d%s) by verifier %s.\", verification.uuid,"},{"line_number":782,"context_line":"                 verifier.deployment[\"name\"], verifier.deployment[\"uuid\"],"},{"line_number":783,"context_line":"                 verifier)"},{"line_number":784,"context_line":"        verification.update_status(consts.TaskStatus.RUNNING)"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            results \u003d verifier.manager.run(verification, **run_args)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_37c0927c","line":784,"range":{"start_line":784,"start_character":42,"end_line":784,"end_character":52},"updated":"2016-12-23 12:01:24.000000000","message":"VerificationStatus","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        try:"},{"line_number":787,"context_line":"            results \u003d verifier.manager.run(verification, **run_args)"},{"line_number":788,"context_line":"        except Exception as e:"},{"line_number":789,"context_line":"            verification.set_failed(e)"},{"line_number":790,"context_line":"            raise"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # TODO(ylobankov): Check that verification exists in the database"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d741060d","line":789,"range":{"start_line":789,"start_character":29,"end_line":789,"end_character":35},"updated":"2016-12-23 12:01:24.000000000","message":"error","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    @classmethod"},{"line_number":849,"context_line":"    def import_results(cls, verifier_id, deployment_id, data, **run_args):"},{"line_number":850,"context_line":"        \"\"\"Import results of a test run into Rally database.."},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"        :param verifier_id: Verifier name or UUID"},{"line_number":853,"context_line":"        :param deployment_id: Deployment name or UUID"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d7dd8643","line":850,"range":{"start_line":850,"start_character":60,"end_line":850,"end_character":61},"updated":"2016-12-23 12:01:24.000000000","message":"Please, remove it.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":897,"context_line":""},{"line_number":898,"context_line":"Deployment \u003d _DeprecatedAPIClass(_Deployment)"},{"line_number":899,"context_line":"Task \u003d _DeprecatedAPIClass(_Task)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"class API(object):"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_f7852a07","line":900,"updated":"2016-12-23 12:01:24.000000000","message":"Should we add Verification here?","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c5c1dc17cbd427475686d6a2670a0fa11cde7b5e","unresolved":false,"context_lines":[{"line_number":897,"context_line":""},{"line_number":898,"context_line":"Deployment \u003d _DeprecatedAPIClass(_Deployment)"},{"line_number":899,"context_line":"Task \u003d _DeprecatedAPIClass(_Task)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"class API(object):"},{"line_number":903,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_cb5a3b83","line":900,"in_reply_to":"da4df55a_f7852a07","updated":"2016-12-23 12:53:11.000000000","message":"it will have separate class, which will work in not same way as _DeprecatedAPIClass. _DeprecatedAPIClass was introduced to support backward compatibility Verification api class is totally redesign and is not backward compatible at all","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"}],"rally/cli/cliutils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    completion \u003d []"},{"line_number":686,"context_line":"    for category, cmds in main.categories.items():"},{"line_number":687,"context_line":"        for name, command in _methods_of(cmds):"},{"line_number":688,"context_line":"            if name is None:"},{"line_number":689,"context_line":"                continue"},{"line_number":690,"context_line":"            command_name \u003d getattr(command, \"alias\", name.replace(\"_\", \"-\"))"},{"line_number":691,"context_line":"            args_list \u003d []"},{"line_number":692,"context_line":"            for arg in getattr(command, \"args\", []):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_3f93cc50","line":689,"range":{"start_line":688,"start_character":12,"end_line":689,"end_character":24},"updated":"2016-12-15 00:07:23.000000000","message":"Not sure why we need this","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    completion \u003d []"},{"line_number":686,"context_line":"    for category, cmds in main.categories.items():"},{"line_number":687,"context_line":"        for name, command in _methods_of(cmds):"},{"line_number":688,"context_line":"            if name is None:"},{"line_number":689,"context_line":"                continue"},{"line_number":690,"context_line":"            command_name \u003d getattr(command, \"alias\", name.replace(\"_\", \"-\"))"},{"line_number":691,"context_line":"            args_list \u003d []"},{"line_number":692,"context_line":"            for arg in getattr(command, \"args\", []):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_10717ea8","line":689,"range":{"start_line":688,"start_character":12,"end_line":689,"end_character":24},"in_reply_to":"1a6eadb0_3f93cc50","updated":"2016-12-15 14:47:20.000000000","message":"Without it one unit test fails.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"}],"rally/cli/commands/verify.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @cliutils.args(\"--type\", dest\u003d\"vtype\", type\u003dstr, required\u003dTrue,"},{"line_number":72,"context_line":"                   help\u003d\"Verifier plugin name. HINT: You can list all \""},{"line_number":73,"context_line":"                        \"verifier plugins by executing command `rally verify \""},{"line_number":74,"context_line":"                        \"list-verifier-plugins`.\")"},{"line_number":75,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr, metavar\u003d\"\u003cname\u003e\","},{"line_number":76,"context_line":"                   required\u003dFalse,"},{"line_number":77,"context_line":"                   help\u003d\"Verifier plugin namespace. Should be specified when \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cc76aed6","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":46},"updated":"2016-12-15 00:07:23.000000000","message":"it looks like it is wrong command. list-plugins is the right one.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @cliutils.args(\"--type\", dest\u003d\"vtype\", type\u003dstr, required\u003dTrue,"},{"line_number":72,"context_line":"                   help\u003d\"Verifier plugin name. HINT: You can list all \""},{"line_number":73,"context_line":"                        \"verifier plugins by executing command `rally verify \""},{"line_number":74,"context_line":"                        \"list-verifier-plugins`.\")"},{"line_number":75,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr, metavar\u003d\"\u003cname\u003e\","},{"line_number":76,"context_line":"                   required\u003dFalse,"},{"line_number":77,"context_line":"                   help\u003d\"Verifier plugin namespace. Should be specified when \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_5094d641","line":74,"range":{"start_line":74,"start_character":25,"end_line":74,"end_character":46},"in_reply_to":"1a6eadb0_cc76aed6","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            cv \u003d envutils.get_global(envutils.ENV_VERIFIER)"},{"line_number":132,"context_line":"            formatters \u003d {"},{"line_number":133,"context_line":"                \"Created at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":134,"context_line":"                \"System-wide\": lambda v: True if v.system_wide else False,"},{"line_number":135,"context_line":"                \"Active\": lambda v: u\"\\u2714\" if v.uuid \u003d\u003d cv else \"\","},{"line_number":136,"context_line":"                \"Location\": lambda v: v.manager.repo_dir"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cf3940d9","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":74},"updated":"2016-12-15 00:07:23.000000000","message":"v.system_wide should be already boolean. This line looks redundant.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            cv \u003d envutils.get_global(envutils.ENV_VERIFIER)"},{"line_number":132,"context_line":"            formatters \u003d {"},{"line_number":133,"context_line":"                \"Created at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":134,"context_line":"                \"System-wide\": lambda v: True if v.system_wide else False,"},{"line_number":135,"context_line":"                \"Active\": lambda v: u\"\\u2714\" if v.uuid \u003d\u003d cv else \"\","},{"line_number":136,"context_line":"                \"Location\": lambda v: v.manager.repo_dir"},{"line_number":137,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_10297e37","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":74},"in_reply_to":"1a6eadb0_cf3940d9","updated":"2016-12-15 14:47:20.000000000","message":"No, it is needed. It is just for writing System-wide instead of System_wide.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            cliutils.print_list(verifiers, fields, formatters\u003dformatters,"},{"line_number":139,"context_line":"                                normalize_field_names\u003dTrue, sortby_index\u003d4)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            print(_(\"No verifier was created yet. You can create verifier \""},{"line_number":142,"context_line":"                    \"by executing command `rally verify create-verifier`.\"))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @cliutils.help_group(\"verifier\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_efe51c38","line":141,"range":{"start_line":141,"start_character":21,"end_line":141,"end_character":48},"updated":"2016-12-15 00:07:23.000000000","message":"There are no verifiers.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            cliutils.print_list(verifiers, fields, formatters\u003dformatters,"},{"line_number":139,"context_line":"                                normalize_field_names\u003dTrue, sortby_index\u003d4)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            print(_(\"No verifier was created yet. You can create verifier \""},{"line_number":142,"context_line":"                    \"by executing command `rally verify create-verifier`.\"))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @cliutils.help_group(\"verifier\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_10aede97","line":141,"range":{"start_line":141,"start_character":21,"end_line":141,"end_character":48},"in_reply_to":"1a6eadb0_efe51c38","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                normalize_field_names\u003dTrue, sortby_index\u003d4)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            print(_(\"No verifier was created yet. You can create verifier \""},{"line_number":142,"context_line":"                    \"by executing command `rally verify create-verifier`.\"))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @cliutils.help_group(\"verifier\")"},{"line_number":145,"context_line":"    @cliutils.args(\"--verifier-id\", dest\u003d\"verifier_id\", type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cfaea0e5","line":142,"range":{"start_line":142,"start_character":24,"end_line":142,"end_character":33},"updated":"2016-12-15 00:07:23.000000000","message":"s/executing/using\n\nExecuting is not right word here, since `rally verify create-verifier` requires additional arguments.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                normalize_field_names\u003dTrue, sortby_index\u003d4)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            print(_(\"No verifier was created yet. You can create verifier \""},{"line_number":142,"context_line":"                    \"by executing command `rally verify create-verifier`.\"))"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @cliutils.help_group(\"verifier\")"},{"line_number":145,"context_line":"    @cliutils.args(\"--verifier-id\", dest\u003d\"verifier_id\", type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_30975a49","line":142,"range":{"start_line":142,"start_character":24,"end_line":142,"end_character":33},"in_reply_to":"1a6eadb0_cfaea0e5","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                        \"executing command `rally deployment list`.\")"},{"line_number":156,"context_line":"    @cliutils.args(\"--force\", dest\u003d\"force\", action\u003d\"store_true\","},{"line_number":157,"context_line":"                   required\u003dFalse,"},{"line_number":158,"context_line":"                   help\u003d\"Delete all stored verifier verifications. If \""},{"line_number":159,"context_line":"                        \"deployment ID specified, only deployment-specific \""},{"line_number":160,"context_line":"                        \"verifications will be deleted. Use this argument \""},{"line_number":161,"context_line":"                        \"carefully! You can delete verifications that may be \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cfc30088","line":158,"range":{"start_line":158,"start_character":43,"end_line":158,"end_character":65},"updated":"2016-12-15 00:07:23.000000000","message":"verifications of specified verifier","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                        \"executing command `rally deployment list`.\")"},{"line_number":156,"context_line":"    @cliutils.args(\"--force\", dest\u003d\"force\", action\u003d\"store_true\","},{"line_number":157,"context_line":"                   required\u003dFalse,"},{"line_number":158,"context_line":"                   help\u003d\"Delete all stored verifier verifications. If \""},{"line_number":159,"context_line":"                        \"deployment ID specified, only deployment-specific \""},{"line_number":160,"context_line":"                        \"verifications will be deleted. Use this argument \""},{"line_number":161,"context_line":"                        \"carefully! You can delete verifications that may be \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_3b157b3f","line":158,"range":{"start_line":158,"start_character":43,"end_line":158,"end_character":65},"in_reply_to":"1a6eadb0_cfc30088","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    @cliutils.args(\"--force\", dest\u003d\"force\", action\u003d\"store_true\","},{"line_number":157,"context_line":"                   required\u003dFalse,"},{"line_number":158,"context_line":"                   help\u003d\"Delete all stored verifier verifications. If \""},{"line_number":159,"context_line":"                        \"deployment ID specified, only deployment-specific \""},{"line_number":160,"context_line":"                        \"verifications will be deleted. Use this argument \""},{"line_number":161,"context_line":"                        \"carefully! You can delete verifications that may be \""},{"line_number":162,"context_line":"                        \"important to you.\")"},{"line_number":163,"context_line":"    @envutils.with_default_verifier_id(cli_arg_name\u003d\"verifier-id\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cf4a2026","line":160,"range":{"start_line":159,"start_character":55,"end_line":160,"end_character":38},"updated":"2016-12-15 00:07:23.000000000","message":"all verifications are deployment-specific, so it is better to write \"verifications of specific deployment\"","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    @cliutils.args(\"--force\", dest\u003d\"force\", action\u003d\"store_true\","},{"line_number":157,"context_line":"                   required\u003dFalse,"},{"line_number":158,"context_line":"                   help\u003d\"Delete all stored verifier verifications. If \""},{"line_number":159,"context_line":"                        \"deployment ID specified, only deployment-specific \""},{"line_number":160,"context_line":"                        \"verifications will be deleted. Use this argument \""},{"line_number":161,"context_line":"                        \"carefully! You can delete verifications that may be \""},{"line_number":162,"context_line":"                        \"important to you.\")"},{"line_number":163,"context_line":"    @envutils.with_default_verifier_id(cli_arg_name\u003d\"verifier-id\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_1c443519","line":160,"range":{"start_line":159,"start_character":55,"end_line":160,"end_character":38},"in_reply_to":"1a6eadb0_cf4a2026","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":165,"context_line":"    def delete_verifier(self, verifier_id\u003dNone, deployment\u003dNone, force\u003dFalse):"},{"line_number":166,"context_line":"        \"\"\"Delete a verifier.\"\"\""},{"line_number":167,"context_line":"        verifications \u003d api.Verification.list(verifier_id, deployment)"},{"line_number":168,"context_line":"        if verifications and not force:"},{"line_number":169,"context_line":"            d_msg \u003d (\" for deployment \u0027%s\u0027\" % deployment) if deployment else \"\""},{"line_number":170,"context_line":"            print(_(\"Verifier \u0027{0}\u0027 cannot be deleted because there are stored\""},{"line_number":171,"context_line":"                    \" verifier verifications{1}! Please, make sure that they \""},{"line_number":172,"context_line":"                    \"are not important to you. Use \u0027--force\u0027 argument if you \""},{"line_number":173,"context_line":"                    \"would like to delete verifications{1} as well.\")"},{"line_number":174,"context_line":"                  .format(verifier_id, d_msg))"},{"line_number":175,"context_line":"            return 1"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        api.Verifier.delete(verifier_id, deployment, force)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_ef18bc20","line":175,"range":{"start_line":167,"start_character":8,"end_line":175,"end_character":20},"updated":"2016-12-15 00:07:23.000000000","message":"I think we already have the same check at api layer.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":165,"context_line":"    def delete_verifier(self, verifier_id\u003dNone, deployment\u003dNone, force\u003dFalse):"},{"line_number":166,"context_line":"        \"\"\"Delete a verifier.\"\"\""},{"line_number":167,"context_line":"        verifications \u003d api.Verification.list(verifier_id, deployment)"},{"line_number":168,"context_line":"        if verifications and not force:"},{"line_number":169,"context_line":"            d_msg \u003d (\" for deployment \u0027%s\u0027\" % deployment) if deployment else \"\""},{"line_number":170,"context_line":"            print(_(\"Verifier \u0027{0}\u0027 cannot be deleted because there are stored\""},{"line_number":171,"context_line":"                    \" verifier verifications{1}! Please, make sure that they \""},{"line_number":172,"context_line":"                    \"are not important to you. Use \u0027--force\u0027 argument if you \""},{"line_number":173,"context_line":"                    \"would like to delete verifications{1} as well.\")"},{"line_number":174,"context_line":"                  .format(verifier_id, d_msg))"},{"line_number":175,"context_line":"            return 1"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        api.Verifier.delete(verifier_id, deployment, force)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_db056711","line":175,"range":{"start_line":167,"start_character":8,"end_line":175,"end_character":20},"in_reply_to":"1a6eadb0_ef18bc20","updated":"2016-12-15 14:47:20.000000000","message":"You think it is redundant?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                        \"the same version to pull the latest repo code.\")"},{"line_number":190,"context_line":"    @cliutils.args(\"--system-wide\", dest\u003d\"system_wide\", action\u003d\"store_true\","},{"line_number":191,"context_line":"                   required\u003dFalse,"},{"line_number":192,"context_line":"                   help\u003d\"Switch to using the system-wide environment.\")"},{"line_number":193,"context_line":"    @cliutils.args(\"--no-system-wide\", dest\u003d\"no_system_wide\","},{"line_number":194,"context_line":"                   action\u003d\"store_true\", required\u003dFalse,"},{"line_number":195,"context_line":"                   help\u003d\"Switch to using the virtual environment. \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4fa8d08d","line":192,"range":{"start_line":192,"start_character":35,"end_line":192,"end_character":40},"updated":"2016-12-15 00:07:23.000000000","message":"s/using/use","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                        \"the same version to pull the latest repo code.\")"},{"line_number":190,"context_line":"    @cliutils.args(\"--system-wide\", dest\u003d\"system_wide\", action\u003d\"store_true\","},{"line_number":191,"context_line":"                   required\u003dFalse,"},{"line_number":192,"context_line":"                   help\u003d\"Switch to using the system-wide environment.\")"},{"line_number":193,"context_line":"    @cliutils.args(\"--no-system-wide\", dest\u003d\"no_system_wide\","},{"line_number":194,"context_line":"                   action\u003d\"store_true\", required\u003dFalse,"},{"line_number":195,"context_line":"                   help\u003d\"Switch to using the virtual environment. \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_1b235fa8","line":192,"range":{"start_line":192,"start_character":35,"end_line":192,"end_character":40},"in_reply_to":"1a6eadb0_4fa8d08d","updated":"2016-12-15 14:47:20.000000000","message":"It looks like everything is correct here.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                   help\u003d\"Switch to using the system-wide environment.\")"},{"line_number":193,"context_line":"    @cliutils.args(\"--no-system-wide\", dest\u003d\"no_system_wide\","},{"line_number":194,"context_line":"                   action\u003d\"store_true\", required\u003dFalse,"},{"line_number":195,"context_line":"                   help\u003d\"Switch to using the virtual environment. \""},{"line_number":196,"context_line":"                        \"If the virtual environment doesn\u0027t exist, \""},{"line_number":197,"context_line":"                        \"it will be created.\")"},{"line_number":198,"context_line":"    @envutils.with_default_verifier_id()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4fc1b053","line":195,"range":{"start_line":195,"start_character":35,"end_line":195,"end_character":40},"updated":"2016-12-15 00:07:23.000000000","message":"s/using/use","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                   help\u003d\"Switch to using the system-wide environment.\")"},{"line_number":193,"context_line":"    @cliutils.args(\"--no-system-wide\", dest\u003d\"no_system_wide\","},{"line_number":194,"context_line":"                   action\u003d\"store_true\", required\u003dFalse,"},{"line_number":195,"context_line":"                   help\u003d\"Switch to using the virtual environment. \""},{"line_number":196,"context_line":"                        \"If the virtual environment doesn\u0027t exist, \""},{"line_number":197,"context_line":"                        \"it will be created.\")"},{"line_number":198,"context_line":"    @envutils.with_default_verifier_id()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_5b3957d6","line":195,"range":{"start_line":195,"start_character":35,"end_line":195,"end_character":40},"in_reply_to":"1a6eadb0_4fc1b053","updated":"2016-12-15 14:47:20.000000000","message":"It looks like everything is correct here.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def update_verifier(self, verifier_id\u003dNone, version\u003dNone, system_wide\u003dNone,"},{"line_number":201,"context_line":"                        no_system_wide\u003dNone, update_venv\u003dNone):"},{"line_number":202,"context_line":"        \"\"\"Update a verifier.\"\"\""},{"line_number":203,"context_line":"        if not (version or system_wide or no_system_wide or update_venv):"},{"line_number":204,"context_line":"            print(_(\"At least one of the following arguments should be \""},{"line_number":205,"context_line":"                    \"provided: \u0027--update-venv\u0027, \u0027--version\u0027, \u0027--system-wide\u0027, \""},{"line_number":206,"context_line":"                    \"\u0027--no-system-wide\u0027.\"))"},{"line_number":207,"context_line":"            return 1"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        msg \u003d _(\"Arguments \u0027--%s\u0027 and \u0027--%s\u0027 cannot be used simultaneously. \""},{"line_number":210,"context_line":"                \"You can use only one of the mentioned arguments.\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_2f8ab41b","line":207,"range":{"start_line":203,"start_character":8,"end_line":207,"end_character":20},"updated":"2016-12-15 00:07:23.000000000","message":"we have the same check at api layer.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def update_verifier(self, verifier_id\u003dNone, version\u003dNone, system_wide\u003dNone,"},{"line_number":201,"context_line":"                        no_system_wide\u003dNone, update_venv\u003dNone):"},{"line_number":202,"context_line":"        \"\"\"Update a verifier.\"\"\""},{"line_number":203,"context_line":"        if not (version or system_wide or no_system_wide or update_venv):"},{"line_number":204,"context_line":"            print(_(\"At least one of the following arguments should be \""},{"line_number":205,"context_line":"                    \"provided: \u0027--update-venv\u0027, \u0027--version\u0027, \u0027--system-wide\u0027, \""},{"line_number":206,"context_line":"                    \"\u0027--no-system-wide\u0027.\"))"},{"line_number":207,"context_line":"            return 1"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        msg \u003d _(\"Arguments \u0027--%s\u0027 and \u0027--%s\u0027 cannot be used simultaneously. \""},{"line_number":210,"context_line":"                \"You can use only one of the mentioned arguments.\")"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_e17fd6dd","line":207,"range":{"start_line":203,"start_character":8,"end_line":207,"end_character":20},"in_reply_to":"1a6eadb0_2f8ab41b","updated":"2016-12-15 14:47:20.000000000","message":"Args are different in API. For example, there is no \u0027no-system-wide\u0027 at API layer.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                   metavar\u003d\"\u003cpath/json/yaml\u003e\", required\u003dFalse,"},{"line_number":241,"context_line":"                   help\u003d\"Add options to the verifier config file. If options \""},{"line_number":242,"context_line":"                        \"are already present in the verifier config file, the \""},{"line_number":243,"context_line":"                        \"given ones will override them. Can be a path to a \""},{"line_number":244,"context_line":"                        \"regular config file or just a json/yaml.\")"},{"line_number":245,"context_line":"    @cliutils.args(\"--replace-by\", dest\u003d\"replace\", type\u003dstr, metavar\u003d\"\u003cpath\u003e\","},{"line_number":246,"context_line":"                   required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4fbd30b6","line":243,"range":{"start_line":243,"start_character":41,"end_line":243,"end_character":54},"updated":"2016-12-15 00:07:23.000000000","message":"will be used.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                   metavar\u003d\"\u003cpath/json/yaml\u003e\", required\u003dFalse,"},{"line_number":241,"context_line":"                   help\u003d\"Add options to the verifier config file. If options \""},{"line_number":242,"context_line":"                        \"are already present in the verifier config file, the \""},{"line_number":243,"context_line":"                        \"given ones will override them. Can be a path to a \""},{"line_number":244,"context_line":"                        \"regular config file or just a json/yaml.\")"},{"line_number":245,"context_line":"    @cliutils.args(\"--replace-by\", dest\u003d\"replace\", type\u003dstr, metavar\u003d\"\u003cpath\u003e\","},{"line_number":246,"context_line":"                   required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_3bc65b9a","line":243,"range":{"start_line":243,"start_character":41,"end_line":243,"end_character":54},"in_reply_to":"1a6eadb0_4fbd30b6","updated":"2016-12-15 14:47:20.000000000","message":"not sure that we should change something here.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            api.Verifier.rewrite_configfile(verifier_id, deployment, config)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            if extra_options:"},{"line_number":273,"context_line":"                if os.path.isfile(extra_options):"},{"line_number":274,"context_line":"                    conf \u003d configparser.ConfigParser()"},{"line_number":275,"context_line":"                    conf.read(extra_options)"},{"line_number":276,"context_line":"                    extra_options \u003d dict(conf._sections)"},{"line_number":277,"context_line":"                    for s in extra_options:"},{"line_number":278,"context_line":"                        extra_options[s] \u003d dict(extra_options[s])"},{"line_number":279,"context_line":"                        extra_options[s].pop(\"__name__\", None)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                    defaults \u003d dict(conf.defaults())"},{"line_number":282,"context_line":"                    if defaults:"},{"line_number":283,"context_line":"                        extra_options[\"DEFAULT\"] \u003d dict(conf.defaults())"},{"line_number":284,"context_line":"                else:"},{"line_number":285,"context_line":"                    extra_options \u003d yaml.safe_load(extra_options)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            config \u003d api.Verifier.configure(verifier_id, deployment,"},{"line_number":288,"context_line":"                                            extra_options\u003dextra_options,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_4fce102f","line":285,"range":{"start_line":273,"start_character":16,"end_line":285,"end_character":65},"updated":"2016-12-15 00:07:23.000000000","message":"1) `conf \u003d configparser.ConfigParser(); conf.read(extra_options)` can raise an exception, we should handle it.\n\n2) let\u0027s allow specifying json/yaml in file too. To do it, just try to load path with yaml.safe_load, if it tries an error, try to load with ConfigParser.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            api.Verifier.rewrite_configfile(verifier_id, deployment, config)"},{"line_number":271,"context_line":"        else:"},{"line_number":272,"context_line":"            if extra_options:"},{"line_number":273,"context_line":"                if os.path.isfile(extra_options):"},{"line_number":274,"context_line":"                    conf \u003d configparser.ConfigParser()"},{"line_number":275,"context_line":"                    conf.read(extra_options)"},{"line_number":276,"context_line":"                    extra_options \u003d dict(conf._sections)"},{"line_number":277,"context_line":"                    for s in extra_options:"},{"line_number":278,"context_line":"                        extra_options[s] \u003d dict(extra_options[s])"},{"line_number":279,"context_line":"                        extra_options[s].pop(\"__name__\", None)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                    defaults \u003d dict(conf.defaults())"},{"line_number":282,"context_line":"                    if defaults:"},{"line_number":283,"context_line":"                        extra_options[\"DEFAULT\"] \u003d dict(conf.defaults())"},{"line_number":284,"context_line":"                else:"},{"line_number":285,"context_line":"                    extra_options \u003d yaml.safe_load(extra_options)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            config \u003d api.Verifier.configure(verifier_id, deployment,"},{"line_number":288,"context_line":"                                            extra_options\u003dextra_options,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_9c712547","line":285,"range":{"start_line":273,"start_character":16,"end_line":285,"end_character":65},"in_reply_to":"1a6eadb0_4fce102f","updated":"2016-12-15 14:47:20.000000000","message":"1) I think we shouldn\u0027t hide original exceptions.\n2) I think it is really redundant. We have a possibility to load a regular config file.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                   help\u003d\"Pattern which will be used for matching. Can be a \""},{"line_number":301,"context_line":"                        \"regexp or a verifier-specific entity (for example, \""},{"line_number":302,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":303,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":304,"context_line":"    @envutils.with_default_verifier_id()"},{"line_number":305,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":306,"context_line":"    def list_verifier_tests(self, verifier_id\u003dNone, pattern\u003d\"\"):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_8f3e68d8","line":303,"range":{"start_line":303,"start_character":25,"end_line":303,"end_character":57},"updated":"2016-12-15 00:07:23.000000000","message":"should we use regex as behavior by default?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                   help\u003d\"Pattern which will be used for matching. Can be a \""},{"line_number":301,"context_line":"                        \"regexp or a verifier-specific entity (for example, \""},{"line_number":302,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":303,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":304,"context_line":"    @envutils.with_default_verifier_id()"},{"line_number":305,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":306,"context_line":"    def list_verifier_tests(self, verifier_id\u003dNone, pattern\u003d\"\"):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_fb0ce3ed","line":303,"range":{"start_line":303,"start_character":25,"end_line":303,"end_character":57},"in_reply_to":"1a6eadb0_8f3e68d8","updated":"2016-12-15 14:47:20.000000000","message":"didn\u0027t understand the question.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                   help\u003d\"Pattern which will be used for running tests. Can be \""},{"line_number":384,"context_line":"                        \"a regexp or a verifier-specific entity (for example, \""},{"line_number":385,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":386,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":387,"context_line":"    @cliutils.args(\"--concurrency\", dest\u003d\"concur\", type\u003dint, metavar\u003d\"\u003cN\u003e\","},{"line_number":388,"context_line":"                   required\u003dFalse,"},{"line_number":389,"context_line":"                   help\u003d\"How many processes to use to run verifier tests. \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_cf24e0c6","line":386,"range":{"start_line":386,"start_character":24,"end_line":386,"end_character":58},"updated":"2016-12-15 00:07:23.000000000","message":"same question here.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                   help\u003d\"Pattern which will be used for running tests. Can be \""},{"line_number":384,"context_line":"                        \"a regexp or a verifier-specific entity (for example, \""},{"line_number":385,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":386,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":387,"context_line":"    @cliutils.args(\"--concurrency\", dest\u003d\"concur\", type\u003dint, metavar\u003d\"\u003cN\u003e\","},{"line_number":388,"context_line":"                   required\u003dFalse,"},{"line_number":389,"context_line":"                   help\u003d\"How many processes to use to run verifier tests. \""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_1b299f37","line":386,"range":{"start_line":386,"start_character":24,"end_line":386,"end_character":58},"in_reply_to":"1a6eadb0_cf24e0c6","updated":"2016-12-15 14:47:20.000000000","message":"ditto.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if do_use:"},{"line_number":463,"context_line":"            self.use(verification.uuid)"},{"line_number":464,"context_line":"        else:"},{"line_number":465,"context_line":"            print(_(\"Verification UUID: %s.\") % verification.uuid)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @cliutils.help_group(\"verification\")"},{"line_number":468,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"verification_uuid\", type\u003dstr, required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_82239fa6","line":465,"range":{"start_line":464,"start_character":8,"end_line":465,"end_character":66},"updated":"2016-12-15 00:07:23.000000000","message":"print this line everytime","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if do_use:"},{"line_number":463,"context_line":"            self.use(verification.uuid)"},{"line_number":464,"context_line":"        else:"},{"line_number":465,"context_line":"            print(_(\"Verification UUID: %s.\") % verification.uuid)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @cliutils.help_group(\"verification\")"},{"line_number":468,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"verification_uuid\", type\u003dstr, required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_db7f27de","line":465,"range":{"start_line":464,"start_character":8,"end_line":465,"end_character":66},"in_reply_to":"1a6eadb0_82239fa6","updated":"2016-12-15 14:47:20.000000000","message":"Why?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                lambda v: api.Deployment.get(v.deployment_uuid)[\"name\"]),"},{"line_number":503,"context_line":"            \"Started at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":504,"context_line":"            \"Finished at\": lambda v: v.updated_at.replace(microsecond\u003d0),"},{"line_number":505,"context_line":"            \"Duration\": lambda v: (v.updated_at.replace(microsecond\u003d0) -"},{"line_number":506,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":507,"context_line":"        }"},{"line_number":508,"context_line":"        print(_(\"Verification:\"))"},{"line_number":509,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_82ae3f96","line":506,"range":{"start_line":505,"start_character":12,"end_line":506,"end_character":71},"updated":"2016-12-15 00:07:23.000000000","message":"we need to show 2 durations: full duration(includes duration of tests execution + configuration) and just duration of tests execution","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                lambda v: api.Deployment.get(v.deployment_uuid)[\"name\"]),"},{"line_number":503,"context_line":"            \"Started at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":504,"context_line":"            \"Finished at\": lambda v: v.updated_at.replace(microsecond\u003d0),"},{"line_number":505,"context_line":"            \"Duration\": lambda v: (v.updated_at.replace(microsecond\u003d0) -"},{"line_number":506,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":507,"context_line":"        }"},{"line_number":508,"context_line":"        print(_(\"Verification:\"))"},{"line_number":509,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_e16436ba","line":506,"range":{"start_line":505,"start_character":12,"end_line":506,"end_character":71},"in_reply_to":"1a6eadb0_82ae3f96","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    def show(self, verification_uuid\u003dNone, sort_by\u003d\"name\", detailed\u003dFalse):"},{"line_number":494,"context_line":"        \"\"\"Show a verification.\"\"\""},{"line_number":495,"context_line":"        verification \u003d api.Verification.get(verification_uuid)"},{"line_number":496,"context_line":"        fields \u003d [\"UUID\", \"Verifier name\", \"Deployment name\", \"Started at\","},{"line_number":497,"context_line":"                  \"Finished at\", \"Duration\", \"Status\"]"},{"line_number":498,"context_line":"        formatters \u003d {"},{"line_number":499,"context_line":"            \"Verifier name\": ("},{"line_number":500,"context_line":"                lambda v: api.Verifier.get(v.verifier_uuid).name),"},{"line_number":501,"context_line":"            \"Deployment name\": ("},{"line_number":502,"context_line":"                lambda v: api.Deployment.get(v.deployment_uuid)[\"name\"]),"},{"line_number":503,"context_line":"            \"Started at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":504,"context_line":"            \"Finished at\": lambda v: v.updated_at.replace(microsecond\u003d0),"},{"line_number":505,"context_line":"            \"Duration\": lambda v: (v.updated_at.replace(microsecond\u003d0) -"},{"line_number":506,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":507,"context_line":"        }"},{"line_number":508,"context_line":"        print(_(\"Verification:\"))"},{"line_number":509,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"},{"line_number":510,"context_line":"                            normalize_field_names\u003dTrue)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        if detailed:"},{"line_number":513,"context_line":"            print(_(\"\\nRun arguments:\"))"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_e2eff3e6","line":510,"range":{"start_line":496,"start_character":8,"end_line":510,"end_character":55},"updated":"2016-12-15 00:07:23.000000000","message":"we need to copy print_dict method[*] and use vertical table instead of horizontal(it will reduce the width of output and allow to show more data)\n\n\n[*] - https://github.com/openstack/python-novaclient/blob/master/novaclient/utils.py#L243-L273","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    def show(self, verification_uuid\u003dNone, sort_by\u003d\"name\", detailed\u003dFalse):"},{"line_number":494,"context_line":"        \"\"\"Show a verification.\"\"\""},{"line_number":495,"context_line":"        verification \u003d api.Verification.get(verification_uuid)"},{"line_number":496,"context_line":"        fields \u003d [\"UUID\", \"Verifier name\", \"Deployment name\", \"Started at\","},{"line_number":497,"context_line":"                  \"Finished at\", \"Duration\", \"Status\"]"},{"line_number":498,"context_line":"        formatters \u003d {"},{"line_number":499,"context_line":"            \"Verifier name\": ("},{"line_number":500,"context_line":"                lambda v: api.Verifier.get(v.verifier_uuid).name),"},{"line_number":501,"context_line":"            \"Deployment name\": ("},{"line_number":502,"context_line":"                lambda v: api.Deployment.get(v.deployment_uuid)[\"name\"]),"},{"line_number":503,"context_line":"            \"Started at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":504,"context_line":"            \"Finished at\": lambda v: v.updated_at.replace(microsecond\u003d0),"},{"line_number":505,"context_line":"            \"Duration\": lambda v: (v.updated_at.replace(microsecond\u003d0) -"},{"line_number":506,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":507,"context_line":"        }"},{"line_number":508,"context_line":"        print(_(\"Verification:\"))"},{"line_number":509,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"},{"line_number":510,"context_line":"                            normalize_field_names\u003dTrue)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        if detailed:"},{"line_number":513,"context_line":"            print(_(\"\\nRun arguments:\"))"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_21854e06","line":510,"range":{"start_line":496,"start_character":8,"end_line":510,"end_character":55},"in_reply_to":"1a6eadb0_e2eff3e6","updated":"2016-12-15 14:47:20.000000000","message":"I think we don\u0027t need it because we have \u0027report\u0027 method and user can find all information from the report.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        print(_(\"\\nTests:\"))"},{"line_number":517,"context_line":"        tests \u003d verification.tests"},{"line_number":518,"context_line":"        values \u003d [utils.Struct(**tests[test_id]) for test_id in tests]"},{"line_number":519,"context_line":"        fields \u003d [\"Name\", \"Duration, sec\", \"Status\"]"},{"line_number":520,"context_line":"        formatters \u003d {\"Duration, sec\": lambda v: v.duration}"},{"line_number":521,"context_line":"        index \u003d (\"name\", \"duration\", \"status\").index(sort_by)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_a2989bc1","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":70},"updated":"2016-12-15 00:07:23.000000000","message":"print_list accepts dict, so there is no need to transform results to Struct.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        print(_(\"\\nTests:\"))"},{"line_number":517,"context_line":"        tests \u003d verification.tests"},{"line_number":518,"context_line":"        values \u003d [utils.Struct(**tests[test_id]) for test_id in tests]"},{"line_number":519,"context_line":"        fields \u003d [\"Name\", \"Duration, sec\", \"Status\"]"},{"line_number":520,"context_line":"        formatters \u003d {\"Duration, sec\": lambda v: v.duration}"},{"line_number":521,"context_line":"        index \u003d (\"name\", \"duration\", \"status\").index(sort_by)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_16e096f9","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":70},"in_reply_to":"1a6eadb0_a2989bc1","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            cv \u003d envutils.get_global(envutils.ENV_VERIFIER)"},{"line_number":131,"context_line":"            formatters \u003d {"},{"line_number":132,"context_line":"                \"Created at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":133,"context_line":"                \"System-wide\": lambda v: True if v.system_wide else False,"},{"line_number":134,"context_line":"                \"Active\": lambda v: u\"\\u2714\" if v.uuid \u003d\u003d cv else \"\","},{"line_number":135,"context_line":"                \"Location\": lambda v: v.manager.repo_dir"},{"line_number":136,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_baa2e998","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":74},"updated":"2016-12-19 12:28:53.000000000","message":"From patch-set #59:\n\n\u003e me: v.system_wide should be already boolean. This line looks redundant.\n\u003e you: No, it is needed. It is just for writing System-wide instead of System_wide.\n\nomg. Sorry. print_list is less smart as I expected. \nLet\u0027s prevent such formatters in future and modify \nhttps://github.com/openstack/rally/blob/0.7.0/rally/cli/cliutils.py#L145-L149 (extend with additional replace \"-\" to \"_\")","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            cv \u003d envutils.get_global(envutils.ENV_VERIFIER)"},{"line_number":131,"context_line":"            formatters \u003d {"},{"line_number":132,"context_line":"                \"Created at\": lambda v: v.created_at.replace(microsecond\u003d0),"},{"line_number":133,"context_line":"                \"System-wide\": lambda v: True if v.system_wide else False,"},{"line_number":134,"context_line":"                \"Active\": lambda v: u\"\\u2714\" if v.uuid \u003d\u003d cv else \"\","},{"line_number":135,"context_line":"                \"Location\": lambda v: v.manager.repo_dir"},{"line_number":136,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_0681c88f","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":74},"in_reply_to":"1a6eadb0_baa2e998","updated":"2016-12-19 14:44:30.000000000","message":"Done","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            api.Verifier.rewrite_configfile(verifier_id, deployment, config)"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            if extra_options:"},{"line_number":272,"context_line":"                if os.path.isfile(extra_options):"},{"line_number":273,"context_line":"                    conf \u003d configparser.ConfigParser()"},{"line_number":274,"context_line":"                    conf.read(extra_options)"},{"line_number":275,"context_line":"                    extra_options \u003d dict(conf._sections)"},{"line_number":276,"context_line":"                    for s in extra_options:"},{"line_number":277,"context_line":"                        extra_options[s] \u003d dict(extra_options[s])"},{"line_number":278,"context_line":"                        extra_options[s].pop(\"__name__\", None)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                    defaults \u003d dict(conf.defaults())"},{"line_number":281,"context_line":"                    if defaults:"},{"line_number":282,"context_line":"                        extra_options[\"DEFAULT\"] \u003d dict(conf.defaults())"},{"line_number":283,"context_line":"                else:"},{"line_number":284,"context_line":"                    extra_options \u003d yaml.safe_load(extra_options)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            config \u003d api.Verifier.configure(verifier_id, deployment,"},{"line_number":287,"context_line":"                                            extra_options\u003dextra_options,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_9aba8d6d","line":284,"range":{"start_line":272,"start_character":15,"end_line":284,"end_character":65},"updated":"2016-12-19 12:28:53.000000000","message":"from patch-set #59:\n\n\u003e me: 1) `conf \u003d configparser.ConfigParser(); \n\u003e              conf.read(extra_options)` can raise an exception, we should handle it.\n\u003e        2) let\u0027s allow specifying json/yaml in file too. To do it, just try to load path with\n\u003e            yaml.safe_load, if it tries an error, try to load with ConfigParser.\n\u003e you: 1) I think we shouldn\u0027t hide original exceptions. \n\u003e          2) I think it is really redundant. We have a possibility to load a regular config file.\n\n1) original trace can be not user-friendly. for example http://xsnippet.org/362175/ . It would be better to print at least message that \"rally fails to read \u0027ini-format\u0027(https://en.wikipedia.org/wiki/INI_file) from file\" and then original trace can be shown or printed in debug...\n\n2) This redesign bases at idea that we will have different verifiers. some of them can have config files in json/yaml.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"014b60e8d89b3324d72ee7c78093e261f3c3bd05","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            api.Verifier.rewrite_configfile(verifier_id, deployment, config)"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            if extra_options:"},{"line_number":272,"context_line":"                if os.path.isfile(extra_options):"},{"line_number":273,"context_line":"                    conf \u003d configparser.ConfigParser()"},{"line_number":274,"context_line":"                    conf.read(extra_options)"},{"line_number":275,"context_line":"                    extra_options \u003d dict(conf._sections)"},{"line_number":276,"context_line":"                    for s in extra_options:"},{"line_number":277,"context_line":"                        extra_options[s] \u003d dict(extra_options[s])"},{"line_number":278,"context_line":"                        extra_options[s].pop(\"__name__\", None)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                    defaults \u003d dict(conf.defaults())"},{"line_number":281,"context_line":"                    if defaults:"},{"line_number":282,"context_line":"                        extra_options[\"DEFAULT\"] \u003d dict(conf.defaults())"},{"line_number":283,"context_line":"                else:"},{"line_number":284,"context_line":"                    extra_options \u003d yaml.safe_load(extra_options)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            config \u003d api.Verifier.configure(verifier_id, deployment,"},{"line_number":287,"context_line":"                                            extra_options\u003dextra_options,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_d4fe9137","line":284,"range":{"start_line":272,"start_character":15,"end_line":284,"end_character":65},"in_reply_to":"1a6eadb0_767225af","updated":"2016-12-19 15:38:01.000000000","message":"I will add a \u0027todo\u0027 :P","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"23204d0f2bbb0f5596dbaae802ecf2452d4e7a13","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            api.Verifier.rewrite_configfile(verifier_id, deployment, config)"},{"line_number":270,"context_line":"        else:"},{"line_number":271,"context_line":"            if extra_options:"},{"line_number":272,"context_line":"                if os.path.isfile(extra_options):"},{"line_number":273,"context_line":"                    conf \u003d configparser.ConfigParser()"},{"line_number":274,"context_line":"                    conf.read(extra_options)"},{"line_number":275,"context_line":"                    extra_options \u003d dict(conf._sections)"},{"line_number":276,"context_line":"                    for s in extra_options:"},{"line_number":277,"context_line":"                        extra_options[s] \u003d dict(extra_options[s])"},{"line_number":278,"context_line":"                        extra_options[s].pop(\"__name__\", None)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                    defaults \u003d dict(conf.defaults())"},{"line_number":281,"context_line":"                    if defaults:"},{"line_number":282,"context_line":"                        extra_options[\"DEFAULT\"] \u003d dict(conf.defaults())"},{"line_number":283,"context_line":"                else:"},{"line_number":284,"context_line":"                    extra_options \u003d yaml.safe_load(extra_options)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"            config \u003d api.Verifier.configure(verifier_id, deployment,"},{"line_number":287,"context_line":"                                            extra_options\u003dextra_options,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_767225af","line":284,"range":{"start_line":272,"start_character":15,"end_line":284,"end_character":65},"in_reply_to":"1a6eadb0_9aba8d6d","updated":"2016-12-19 14:46:02.000000000","message":"Sorry, forgot about this comment...","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                   help\u003d\"Pattern which will be used for matching. Can be a \""},{"line_number":300,"context_line":"                        \"regexp or a verifier-specific entity (for example, \""},{"line_number":301,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":302,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":303,"context_line":"    @envutils.with_default_verifier_id()"},{"line_number":304,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":305,"context_line":"    def list_verifier_tests(self, verifier_id\u003dNone, pattern\u003d\"\"):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_3d033378","line":302,"range":{"start_line":302,"start_character":26,"end_line":302,"end_character":55},"updated":"2016-12-19 12:28:53.000000000","message":"\u003eme: should we use regex as behavior by default?\n\u003eyou: didn\u0027t understand the question.\n\nWhat do you think about removing suffix \u0027regex\u003d\u0027 and use transmitted string as regexp if there is no suffix? (can be done separately)","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                   help\u003d\"Pattern which will be used for matching. Can be a \""},{"line_number":300,"context_line":"                        \"regexp or a verifier-specific entity (for example, \""},{"line_number":301,"context_line":"                        \"in case of Tempest you can specify \u0027set\u003dsmoke\u0027 or \""},{"line_number":302,"context_line":"                        \"\u0027regex\u003dtempest.api.identity.v3\u0027).\")"},{"line_number":303,"context_line":"    @envutils.with_default_verifier_id()"},{"line_number":304,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":305,"context_line":"    def list_verifier_tests(self, verifier_id\u003dNone, pattern\u003d\"\"):"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_ac80f347","line":302,"range":{"start_line":302,"start_character":26,"end_line":302,"end_character":55},"in_reply_to":"1a6eadb0_3d033378","updated":"2016-12-19 14:44:30.000000000","message":"Got it. Done","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        if do_use:"},{"line_number":462,"context_line":"            self.use(verification.uuid)"},{"line_number":463,"context_line":"        else:"},{"line_number":464,"context_line":"            print(_(\"Verification UUID: %s.\") % verification.uuid)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    @cliutils.help_group(\"verification\")"},{"line_number":467,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"verification_uuid\", type\u003dstr, required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_9d39a744","line":464,"range":{"start_line":463,"start_character":8,"end_line":464,"end_character":66},"updated":"2016-12-19 12:28:53.000000000","message":"\u003e me: print this line everytime\n\u003e you: Why?\n\nBecause I know a lot of guys who parses output for obtaining this uuid.","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        if do_use:"},{"line_number":462,"context_line":"            self.use(verification.uuid)"},{"line_number":463,"context_line":"        else:"},{"line_number":464,"context_line":"            print(_(\"Verification UUID: %s.\") % verification.uuid)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    @cliutils.help_group(\"verification\")"},{"line_number":467,"context_line":"    @cliutils.args(\"--uuid\", dest\u003d\"verification_uuid\", type\u003dstr, required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_cc71af79","line":464,"range":{"start_line":463,"start_character":8,"end_line":464,"end_character":66},"in_reply_to":"1a6eadb0_9d39a744","updated":"2016-12-19 14:44:30.000000000","message":"ok","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":506,"context_line":"        }"},{"line_number":507,"context_line":"        print(_(\"Verification:\"))"},{"line_number":508,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"},{"line_number":509,"context_line":"                            normalize_field_names\u003dTrue)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        if detailed:"},{"line_number":512,"context_line":"            print(_(\"\\nRun arguments:\"))"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_dd223f01","line":509,"range":{"start_line":508,"start_character":8,"end_line":509,"end_character":55},"updated":"2016-12-19 12:28:53.000000000","message":"returning to discussion about \"print_dict\" - let\u0027s talk about it in separate patch. we need to merge this one asap","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                   v.created_at.replace(microsecond\u003d0))"},{"line_number":506,"context_line":"        }"},{"line_number":507,"context_line":"        print(_(\"Verification:\"))"},{"line_number":508,"context_line":"        cliutils.print_list([verification], fields, formatters\u003dformatters,"},{"line_number":509,"context_line":"                            normalize_field_names\u003dTrue)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        if detailed:"},{"line_number":512,"context_line":"            print(_(\"\\nRun arguments:\"))"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_cb53596b","line":509,"range":{"start_line":508,"start_character":8,"end_line":509,"end_character":55},"in_reply_to":"1a6eadb0_dd223f01","updated":"2016-12-19 14:44:30.000000000","message":"ok","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"}],"rally/common/io/subunit_v2.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"36054744745272ac354403baed16e70896093cd8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                # wtf?! It is ok? What should we do in such cases??"},{"line_number":138,"context_line":"                pass"},{"line_number":139,"context_line":"            else:"},{"line_number":140,"context_line":"                self._tests[test] \u003d {"},{"line_number":141,"context_line":"                    \"status\": \"skip\","},{"line_number":142,"context_line":"                    \"name\": test(test_id.split(\"[\")[0]"},{"line_number":143,"context_line":"                                 if test_id.find(\"[\") \u003e -1 else test_id),"},{"line_number":144,"context_line":"                    \"time\": \"%.3f\" % 0}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        self._is_parsed \u003d True"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_999bbc65","line":144,"range":{"start_line":140,"start_character":15,"end_line":144,"end_character":39},"updated":"2016-11-11 12:59:00.000000000","message":"Yaroslav: please, do not forget to add reason here:)","commit_id":"f8c32c9cdd041045362c174099c81f94a98a0b4b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally.common import logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def total_seconds(td):"},{"line_number":24,"context_line":"    \"\"\"Convert the total duration into seconds."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    NOTE(andreykurilin): python 2.6 compatible method"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    if hasattr(td, \"total_seconds\"):"},{"line_number":29,"context_line":"        s \u003d td.total_seconds()"},{"line_number":30,"context_line":"    else:"},{"line_number":31,"context_line":"        # NOTE(andreykurilin): The following calculation is proposed"},{"line_number":32,"context_line":"        #                      in python docs:"},{"line_number":33,"context_line":"        # https://docs.python.org/2/library/datetime.html#datetime.timedelta.total_seconds"},{"line_number":34,"context_line":"        s \u003d (td.microseconds +"},{"line_number":35,"context_line":"             (td.seconds + td.days * 24 * 3600) * 10 ** 6) / 10.0 ** 6"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    return \"%.3f\" % s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def prepare_input_args(func):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_e2ab7373","line":37,"range":{"start_line":23,"start_character":0,"end_line":37,"end_character":21},"updated":"2016-12-15 00:07:23.000000000","message":"It is time to remove it. we do not support py26 any more. :)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally.common import logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def total_seconds(td):"},{"line_number":24,"context_line":"    \"\"\"Convert the total duration into seconds."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    NOTE(andreykurilin): python 2.6 compatible method"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    if hasattr(td, \"total_seconds\"):"},{"line_number":29,"context_line":"        s \u003d td.total_seconds()"},{"line_number":30,"context_line":"    else:"},{"line_number":31,"context_line":"        # NOTE(andreykurilin): The following calculation is proposed"},{"line_number":32,"context_line":"        #                      in python docs:"},{"line_number":33,"context_line":"        # https://docs.python.org/2/library/datetime.html#datetime.timedelta.total_seconds"},{"line_number":34,"context_line":"        s \u003d (td.microseconds +"},{"line_number":35,"context_line":"             (td.seconds + td.days * 24 * 3600) * 10 ** 6) / 10.0 ** 6"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    return \"%.3f\" % s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def prepare_input_args(func):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_138b43c4","line":37,"range":{"start_line":23,"start_character":0,"end_line":37,"end_character":21},"in_reply_to":"1a6eadb0_e2ab7373","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 logger_name\u003dNone):"},{"line_number":79,"context_line":"        self._tests \u003d {}"},{"line_number":80,"context_line":"        self._expected_failures \u003d expected_failures or {}"},{"line_number":81,"context_line":"        self._skipped_tests \u003d skipped_tests or {}"},{"line_number":82,"context_line":"        self.__skipped_tests \u003d self._skipped_tests.copy()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self._live \u003d live"},{"line_number":85,"context_line":"        self._logger \u003d logging.getLogger(logger_name or __name__)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_c2f75789","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":57},"updated":"2016-12-15 00:07:23.000000000","message":"why we need two variables here?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3550f241a56f51e4ab10e1dd12a1e9b6f507650d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 logger_name\u003dNone):"},{"line_number":79,"context_line":"        self._tests \u003d {}"},{"line_number":80,"context_line":"        self._expected_failures \u003d expected_failures or {}"},{"line_number":81,"context_line":"        self._skipped_tests \u003d skipped_tests or {}"},{"line_number":82,"context_line":"        self.__skipped_tests \u003d self._skipped_tests.copy()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self._live \u003d live"},{"line_number":85,"context_line":"        self._logger \u003d logging.getLogger(logger_name or __name__)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_3a8b7e20","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":57},"in_reply_to":"1a6eadb0_b369affb","updated":"2016-12-16 12:25:45.000000000","message":"I will delete self.__skipped_tests :)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                 logger_name\u003dNone):"},{"line_number":79,"context_line":"        self._tests \u003d {}"},{"line_number":80,"context_line":"        self._expected_failures \u003d expected_failures or {}"},{"line_number":81,"context_line":"        self._skipped_tests \u003d skipped_tests or {}"},{"line_number":82,"context_line":"        self.__skipped_tests \u003d self._skipped_tests.copy()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self._live \u003d live"},{"line_number":85,"context_line":"        self._logger \u003d logging.getLogger(logger_name or __name__)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_b369affb","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":57},"in_reply_to":"1a6eadb0_c2f75789","updated":"2016-12-15 14:47:20.000000000","message":"We need self._skipped_tests and its copy.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                self._tests[test_id][\"status\"] \u003d test_status"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"                # process expected failures"},{"line_number":175,"context_line":"                if test_id in self._expected_failures:"},{"line_number":176,"context_line":"                    if self._tests[test_id][\"status\"] \u003d\u003d \"fail\":"},{"line_number":177,"context_line":"                        self._tests[test_id][\"status\"] \u003d \"xfail\""},{"line_number":178,"context_line":"                        if self._expected_failures[test_id]:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_c201173a","line":175,"range":{"start_line":175,"start_character":15,"end_line":175,"end_character":53},"updated":"2016-12-15 00:07:23.000000000","message":"Let\u0027s use more complicated check for better user experience: `if test_id in self._expected_failures or self._tests[test_id][\"name\"] in self._expected_failures`","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                self._tests[test_id][\"status\"] \u003d test_status"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"                # process expected failures"},{"line_number":175,"context_line":"                if test_id in self._expected_failures:"},{"line_number":176,"context_line":"                    if self._tests[test_id][\"status\"] \u003d\u003d \"fail\":"},{"line_number":177,"context_line":"                        self._tests[test_id][\"status\"] \u003d \"xfail\""},{"line_number":178,"context_line":"                        if self._expected_failures[test_id]:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_695d6814","line":175,"range":{"start_line":175,"start_character":15,"end_line":175,"end_character":53},"in_reply_to":"1a6eadb0_c201173a","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    else:"},{"line_number":188,"context_line":"                        self._tests[test_id][file_name] +\u003d file_bytes"},{"line_number":189,"context_line":"        else:"},{"line_number":190,"context_line":"            self._unknown_tests.setdefault(test_id, {\"name\": test_id})"},{"line_number":191,"context_line":"            self._unknown_tests[test_id][\"status\"] \u003d test_status"},{"line_number":192,"context_line":"            if file_name in [\"traceback\", \"reason\"]:"},{"line_number":193,"context_line":"                if file_name not in self._unknown_tests[test_id]:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_42c347ed","line":190,"range":{"start_line":190,"start_character":17,"end_line":190,"end_character":31},"updated":"2016-12-15 00:07:23.000000000","message":"I prefer to use old name of variable, since it can contain not only tests, but test_cases too. Also, subunit allows to transmit more than just information about tests, but debug messages and etc.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                    else:"},{"line_number":188,"context_line":"                        self._tests[test_id][file_name] +\u003d file_bytes"},{"line_number":189,"context_line":"        else:"},{"line_number":190,"context_line":"            self._unknown_tests.setdefault(test_id, {\"name\": test_id})"},{"line_number":191,"context_line":"            self._unknown_tests[test_id][\"status\"] \u003d test_status"},{"line_number":192,"context_line":"            if file_name in [\"traceback\", \"reason\"]:"},{"line_number":193,"context_line":"                if file_name not in self._unknown_tests[test_id]:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_066a23b3","line":190,"range":{"start_line":190,"start_character":17,"end_line":190,"end_character":31},"in_reply_to":"1a6eadb0_42c347ed","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                else:"},{"line_number":196,"context_line":"                    self._unknown_tests[test_id][file_name] +\u003d file_bytes"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # process skipped tests"},{"line_number":199,"context_line":"        if self.__skipped_tests:"},{"line_number":200,"context_line":"            for t_id in self._skipped_tests:"},{"line_number":201,"context_line":"                if t_id not in self._tests:"},{"line_number":202,"context_line":"                    status \u003d \"skip\""},{"line_number":203,"context_line":"                    name \u003d self._get_test_name(t_id)"},{"line_number":204,"context_line":"                    self._tests[t_id] \u003d {\"status\": status,"},{"line_number":205,"context_line":"                                         \"name\": name,"},{"line_number":206,"context_line":"                                         \"duration\": \"%.3f\" % 0,"},{"line_number":207,"context_line":"                                         \"tags\": _parse_test_tags(t_id)}"},{"line_number":208,"context_line":"                    if self._skipped_tests[t_id]:"},{"line_number":209,"context_line":"                        self._tests[t_id][\"reason\"] \u003d self._skipped_tests[t_id]"},{"line_number":210,"context_line":"                        status +\u003d \": %s\" % self._tests[t_id][\"reason\"]"},{"line_number":211,"context_line":"                    if self._live:"},{"line_number":212,"context_line":"                        self._logger.info(\"%s ... %s\", name, status)"},{"line_number":213,"context_line":"                self.__skipped_tests.pop(t_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        if self._live and test_status not in (None, \"exists\", \"inprogress\"):"},{"line_number":216,"context_line":"            status \u003d test_status"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_c25d9748","line":213,"range":{"start_line":198,"start_character":8,"end_line":213,"end_character":46},"updated":"2016-12-15 00:07:23.000000000","message":"let\u0027s move it to separate method with good name(by first look, place for this code looks strange) - \"_print_info_about_skip\" or something like that.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                else:"},{"line_number":196,"context_line":"                    self._unknown_tests[test_id][file_name] +\u003d file_bytes"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        # process skipped tests"},{"line_number":199,"context_line":"        if self.__skipped_tests:"},{"line_number":200,"context_line":"            for t_id in self._skipped_tests:"},{"line_number":201,"context_line":"                if t_id not in self._tests:"},{"line_number":202,"context_line":"                    status \u003d \"skip\""},{"line_number":203,"context_line":"                    name \u003d self._get_test_name(t_id)"},{"line_number":204,"context_line":"                    self._tests[t_id] \u003d {\"status\": status,"},{"line_number":205,"context_line":"                                         \"name\": name,"},{"line_number":206,"context_line":"                                         \"duration\": \"%.3f\" % 0,"},{"line_number":207,"context_line":"                                         \"tags\": _parse_test_tags(t_id)}"},{"line_number":208,"context_line":"                    if self._skipped_tests[t_id]:"},{"line_number":209,"context_line":"                        self._tests[t_id][\"reason\"] \u003d self._skipped_tests[t_id]"},{"line_number":210,"context_line":"                        status +\u003d \": %s\" % self._tests[t_id][\"reason\"]"},{"line_number":211,"context_line":"                    if self._live:"},{"line_number":212,"context_line":"                        self._logger.info(\"%s ... %s\", name, status)"},{"line_number":213,"context_line":"                self.__skipped_tests.pop(t_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        if self._live and test_status not in (None, \"exists\", \"inprogress\"):"},{"line_number":216,"context_line":"            status \u003d test_status"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_899c84c1","line":213,"range":{"start_line":198,"start_character":8,"end_line":213,"end_character":46},"in_reply_to":"1a6eadb0_c25d9748","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            if test_id in self._tests and \"duration\" in self._tests[test_id]:"},{"line_number":219,"context_line":"                status +\u003d \"[%ss]\" % self._tests[test_id][\"duration\"]"},{"line_number":220,"context_line":"                if self._tests[test_id][\"status\"] in (\"xfail\", \"uxsuccess\"):"},{"line_number":221,"context_line":"                    s_map \u003d {\"fail\": \"xfail\", \"success\": \"uxsuccess\"}"},{"line_number":222,"context_line":"                    status \u003d status.replace(test_status, s_map[test_status])"},{"line_number":223,"context_line":"                    test_status \u003d self._tests[test_id][\"status\"]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            if test_status in (\"skip\", \"xfail\"):"},{"line_number":226,"context_line":"                if test_id in self._tests:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_a20edb38","line":223,"range":{"start_line":220,"start_character":16,"end_line":223,"end_character":64},"updated":"2016-12-15 00:07:23.000000000","message":"We already switched statuses at L175-182 . This code looks redundant","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"            if test_id in self._tests and \"duration\" in self._tests[test_id]:"},{"line_number":219,"context_line":"                status +\u003d \"[%ss]\" % self._tests[test_id][\"duration\"]"},{"line_number":220,"context_line":"                if self._tests[test_id][\"status\"] in (\"xfail\", \"uxsuccess\"):"},{"line_number":221,"context_line":"                    s_map \u003d {\"fail\": \"xfail\", \"success\": \"uxsuccess\"}"},{"line_number":222,"context_line":"                    status \u003d status.replace(test_status, s_map[test_status])"},{"line_number":223,"context_line":"                    test_status \u003d self._tests[test_id][\"status\"]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"            if test_status in (\"skip\", \"xfail\"):"},{"line_number":226,"context_line":"                if test_id in self._tests:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_09d31405","line":223,"range":{"start_line":220,"start_character":16,"end_line":223,"end_character":64},"in_reply_to":"1a6eadb0_a20edb38","updated":"2016-12-15 14:47:20.000000000","message":"In \u0027status\u0027 (L216) we stored the original test status. So we need to replace it by the proper status to print correct test info.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06286b80da4ffb4da2a947ffaeff12353afb98da","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            self._process_skipped_tests()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if self._live and test_status not in (None, \"exists\", \"inprogress\"):"},{"line_number":203,"context_line":"            status \u003d test_status"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            if test_id in self._tests and \"duration\" in self._tests[test_id]:"},{"line_number":206,"context_line":"                status +\u003d \"[%ss]\" % self._tests[test_id][\"duration\"]"},{"line_number":207,"context_line":"                if self._tests[test_id][\"status\"] in (\"xfail\", \"uxsuccess\"):"},{"line_number":208,"context_line":"                    s_map \u003d {\"fail\": \"xfail\", \"success\": \"uxsuccess\"}"},{"line_number":209,"context_line":"                    status \u003d status.replace(test_status, s_map[test_status])"},{"line_number":210,"context_line":"                    test_status \u003d self._tests[test_id][\"status\"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if test_status in (\"skip\", \"xfail\"):"},{"line_number":213,"context_line":"                if test_id in self._tests:"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_409ac8c6","line":210,"range":{"start_line":203,"start_character":12,"end_line":210,"end_character":64},"updated":"2016-12-19 12:28:53.000000000","message":"again, I do not understand why it cannot be simplified(removed magic about statuses):\n   \n   reason \u003d \"\"\n   duration \u003d \"\"\n   if test_id in self._tests:\n       status \u003d self._tests[test_id][\"status\"]\n       if \"duration\" in self._tests[test_id]:\n           duration \u003d \" [%ss]\" % self._tests[test_id][\"duration\"]\n   else:\n       status \u003d test_status\n\n   if status in (\"skp\"..)\n       if \"reason\"...\n         reason \u003d self._tests...\n\n   status +\u003d duration + reason","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dc04e714c75e135c48e77314f3ccc2d611ce8822","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            self._process_skipped_tests()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if self._live and test_status not in (None, \"exists\", \"inprogress\"):"},{"line_number":203,"context_line":"            status \u003d test_status"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            if test_id in self._tests and \"duration\" in self._tests[test_id]:"},{"line_number":206,"context_line":"                status +\u003d \"[%ss]\" % self._tests[test_id][\"duration\"]"},{"line_number":207,"context_line":"                if self._tests[test_id][\"status\"] in (\"xfail\", \"uxsuccess\"):"},{"line_number":208,"context_line":"                    s_map \u003d {\"fail\": \"xfail\", \"success\": \"uxsuccess\"}"},{"line_number":209,"context_line":"                    status \u003d status.replace(test_status, s_map[test_status])"},{"line_number":210,"context_line":"                    test_status \u003d self._tests[test_id][\"status\"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if test_status in (\"skip\", \"xfail\"):"},{"line_number":213,"context_line":"                if test_id in self._tests:"}],"source_content_type":"text/x-python","patch_set":63,"id":"1a6eadb0_ab245daf","line":210,"range":{"start_line":203,"start_character":12,"end_line":210,"end_character":64},"in_reply_to":"1a6eadb0_409ac8c6","updated":"2016-12-19 14:44:30.000000000","message":"Done","commit_id":"1b9ec4db5fc5004381c3f72f734e85d3cd89286e"}],"rally/common/objects/verifier.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self._deployment"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def manager(self):"},{"line_number":83,"context_line":"        # lazy load manager to be able to use non-plugin related stuff without"},{"line_number":84,"context_line":"        # loading plugins"},{"line_number":85,"context_line":"        if not self._manager:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_257655a4","line":82,"range":{"start_line":82,"start_character":3,"end_line":82,"end_character":22},"updated":"2016-12-15 00:07:23.000000000","message":"After removing \"launcher\" entity, \"manager\" sounds unclear.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self._deployment"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def manager(self):"},{"line_number":83,"context_line":"        # lazy load manager to be able to use non-plugin related stuff without"},{"line_number":84,"context_line":"        # loading plugins"},{"line_number":85,"context_line":"        if not self._manager:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_503211f3","line":82,"range":{"start_line":82,"start_character":3,"end_line":82,"end_character":22},"in_reply_to":"1a6eadb0_257655a4","updated":"2016-12-15 14:47:20.000000000","message":"Why?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"09956e663489e0c38d392c13fc3220812e7e1a10","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self._deployment"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def manager(self):"},{"line_number":83,"context_line":"        # lazy load manager to be able to use non-plugin related stuff without"},{"line_number":84,"context_line":"        # loading plugins"},{"line_number":85,"context_line":"        if not self._manager:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_82cd3187","line":82,"range":{"start_line":82,"start_character":3,"end_line":82,"end_character":22},"in_reply_to":"1a6eadb0_503211f3","updated":"2016-12-15 18:04:40.000000000","message":"as for me, management stuff is install/reinstall/uninstall and not launching tests. what about term \"driver\" ?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"fec7f89c5083b3ffc658b48c853e54f96a3671df","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self._deployment"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def manager(self):"},{"line_number":83,"context_line":"        # lazy load manager to be able to use non-plugin related stuff without"},{"line_number":84,"context_line":"        # loading plugins"},{"line_number":85,"context_line":"        if not self._manager:"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_636d60cb","line":82,"range":{"start_line":82,"start_character":3,"end_line":82,"end_character":22},"in_reply_to":"1a6eadb0_82cd3187","updated":"2016-12-16 08:52:43.000000000","message":"Driver is good to me, but I think this term is not suitable to us. Rally is based on plugins, not drivers, and I would like to keep concictensy with that. IMHO, manager is good, because manager manages everything (installation, configuration, launching, etc.).","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"}],"rally/consts.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":27,"context_line":"JSON_SCHEMA \u003d \"http://json-schema.org/draft-04/schema\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class _TempestApiTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":31,"context_line":"    BAREMETAL \u003d \"baremetal\""},{"line_number":32,"context_line":"    CLUSTERING \u003d \"clustering\""},{"line_number":33,"context_line":"    COMPUTE \u003d \"compute\""},{"line_number":34,"context_line":"    DATA_PROCESSING \u003d \"data_processing\""},{"line_number":35,"context_line":"    DATABASE \u003d \"database\""},{"line_number":36,"context_line":"    IDENTITY \u003d \"identity\""},{"line_number":37,"context_line":"    IMAGE \u003d \"image\""},{"line_number":38,"context_line":"    MESSAGING \u003d \"messaging\""},{"line_number":39,"context_line":"    NETWORK \u003d \"network\""},{"line_number":40,"context_line":"    OBJECT_STORAGE \u003d \"object_storage\""},{"line_number":41,"context_line":"    ORCHESTRATION \u003d \"orchestration\""},{"line_number":42,"context_line":"    TELEMETRY \u003d \"telemetry\""},{"line_number":43,"context_line":"    VOLUME \u003d \"volume\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class _TempestScenarioTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":47,"context_line":"    SCENARIO \u003d \"scenario\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class _TempestTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":51,"context_line":"    FULL \u003d \"full\""},{"line_number":52,"context_line":"    SMOKE \u003d \"smoke\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class _TaskStatus(utils.ImmutableMixin, utils.EnumMixin):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_e5b7fd37","line":52,"range":{"start_line":30,"start_character":0,"end_line":52,"end_character":19},"updated":"2016-12-15 00:07:23.000000000","message":"It is better to create rally.plugins.openstack.verification.const module and move these consts there.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"JSON_SCHEMA \u003d \"http://json-schema.org/draft-04/schema\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class _TempestApiTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":31,"context_line":"    BAREMETAL \u003d \"baremetal\""},{"line_number":32,"context_line":"    CLUSTERING \u003d \"clustering\""},{"line_number":33,"context_line":"    COMPUTE \u003d \"compute\""},{"line_number":34,"context_line":"    DATA_PROCESSING \u003d \"data_processing\""},{"line_number":35,"context_line":"    DATABASE \u003d \"database\""},{"line_number":36,"context_line":"    IDENTITY \u003d \"identity\""},{"line_number":37,"context_line":"    IMAGE \u003d \"image\""},{"line_number":38,"context_line":"    MESSAGING \u003d \"messaging\""},{"line_number":39,"context_line":"    NETWORK \u003d \"network\""},{"line_number":40,"context_line":"    OBJECT_STORAGE \u003d \"object_storage\""},{"line_number":41,"context_line":"    ORCHESTRATION \u003d \"orchestration\""},{"line_number":42,"context_line":"    TELEMETRY \u003d \"telemetry\""},{"line_number":43,"context_line":"    VOLUME \u003d \"volume\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class _TempestScenarioTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":47,"context_line":"    SCENARIO \u003d \"scenario\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class _TempestTestSets(utils.ImmutableMixin, utils.EnumMixin):"},{"line_number":51,"context_line":"    FULL \u003d \"full\""},{"line_number":52,"context_line":"    SMOKE \u003d \"smoke\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class _TaskStatus(utils.ImmutableMixin, utils.EnumMixin):"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_70a54d45","line":52,"range":{"start_line":30,"start_character":0,"end_line":52,"end_character":19},"in_reply_to":"1a6eadb0_e5b7fd37","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"}],"rally/plugins/openstack/verification/tempest/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        env[\"TEMPEST_CONFIG_DIR\"] \u003d os.path.dirname(self.configfile)"},{"line_number":50,"context_line":"        env[\"TEMPEST_CONFIG\"] \u003d os.path.basename(self.configfile)"},{"line_number":51,"context_line":"        env[\"OS_TEST_PATH\"] \u003d os.path.join("},{"line_number":52,"context_line":"            self.verifier.manager.repo_dir, \"tempest\", \"test_discover\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        return env"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_058cf97d","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":42},"updated":"2016-12-15 00:07:23.000000000","message":"just self.repo_dir","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        env[\"TEMPEST_CONFIG_DIR\"] \u003d os.path.dirname(self.configfile)"},{"line_number":50,"context_line":"        env[\"TEMPEST_CONFIG\"] \u003d os.path.basename(self.configfile)"},{"line_number":51,"context_line":"        env[\"OS_TEST_PATH\"] \u003d os.path.join("},{"line_number":52,"context_line":"            self.verifier.manager.repo_dir, \"tempest\", \"test_discover\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        return env"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_93b753d7","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":42},"in_reply_to":"1a6eadb0_058cf97d","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":111,"context_line":"               \"     \u0027entry_point\u0027: p.entry_point_target, \""},{"line_number":112,"context_line":"               \"     \u0027location\u0027: plugins_map[p.name][1]} \""},{"line_number":113,"context_line":"               \"    for p in plugins_manager.ext_plugins.extensions]; \""},{"line_number":114,"context_line":"               \"print(plugins_list)\")"},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            return yaml.load("},{"line_number":117,"context_line":"                utils.check_output([\"python\", \"-c\", cmd], cwd\u003dself.base_dir,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_8544891b","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":35},"updated":"2016-12-15 00:07:23.000000000","message":"more pythonic way: \n\n   import json; json.dumps(plugins_list)","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"09956e663489e0c38d392c13fc3220812e7e1a10","unresolved":false,"context_lines":[{"line_number":111,"context_line":"               \"     \u0027entry_point\u0027: p.entry_point_target, \""},{"line_number":112,"context_line":"               \"     \u0027location\u0027: plugins_map[p.name][1]} \""},{"line_number":113,"context_line":"               \"    for p in plugins_manager.ext_plugins.extensions]; \""},{"line_number":114,"context_line":"               \"print(plugins_list)\")"},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            return yaml.load("},{"line_number":117,"context_line":"                utils.check_output([\"python\", \"-c\", cmd], cwd\u003dself.base_dir,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_42aeb998","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":35},"in_reply_to":"1a6eadb0_1315033f","updated":"2016-12-15 18:04:40.000000000","message":"can you share log?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"f147af30114cba66144cc7fc023a9faf89a1d039","unresolved":false,"context_lines":[{"line_number":111,"context_line":"               \"     \u0027entry_point\u0027: p.entry_point_target, \""},{"line_number":112,"context_line":"               \"     \u0027location\u0027: plugins_map[p.name][1]} \""},{"line_number":113,"context_line":"               \"    for p in plugins_manager.ext_plugins.extensions]; \""},{"line_number":114,"context_line":"               \"print(plugins_list)\")"},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            return yaml.load("},{"line_number":117,"context_line":"                utils.check_output([\"python\", \"-c\", cmd], cwd\u003dself.base_dir,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_8c16294a","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":35},"in_reply_to":"1a6eadb0_42aeb998","updated":"2016-12-16 09:54:05.000000000","message":"There is no log. \n\nutils.check_output([\"python\", \"-c\", cmd], cwd\u003dself.base_dir,\n                   env\u003dself.environ).strip())\n\nreturns None and that\u0027s all.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"               \"     \u0027entry_point\u0027: p.entry_point_target, \""},{"line_number":112,"context_line":"               \"     \u0027location\u0027: plugins_map[p.name][1]} \""},{"line_number":113,"context_line":"               \"    for p in plugins_manager.ext_plugins.extensions]; \""},{"line_number":114,"context_line":"               \"print(plugins_list)\")"},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            return yaml.load("},{"line_number":117,"context_line":"                utils.check_output([\"python\", \"-c\", cmd], cwd\u003dself.base_dir,"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_1315033f","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":35},"in_reply_to":"1a6eadb0_8544891b","updated":"2016-12-15 14:47:20.000000000","message":"doesn\u0027t work :(","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                \"There is no Tempest plugin with name \u0027%s\u0027. \""},{"line_number":133,"context_line":"                \"Are you sure that it was installed?\" % name)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def list_tests(self, pattern\u003d\"\"):"},{"line_number":136,"context_line":"        \"\"\"List all Tempest tests.\"\"\""},{"line_number":137,"context_line":"        if pattern:"},{"line_number":138,"context_line":"            pattern \u003d self._transform_pattern(pattern)"},{"line_number":139,"context_line":"        output \u003d utils.check_output([\"testr\", \"list-tests\", pattern],"},{"line_number":140,"context_line":"                                    cwd\u003dself.repo_dir, env\u003dself.environ,"},{"line_number":141,"context_line":"                                    debug\u003dFalse)"},{"line_number":142,"context_line":"        return [l for l in output.split(\"\\n\") if TEST_NAME_REGEX.match(l)]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def parse_results(self, stream):"},{"line_number":145,"context_line":"        \"\"\"Parse subunit test streaming results of a Tempest test run.\"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_8512c907","line":142,"range":{"start_line":135,"start_character":4,"end_line":142,"end_character":74},"updated":"2016-12-15 00:07:23.000000000","message":"Let\u0027s return TestrLauncher separate class and move all testr related stuff there. It can be reused by other verifiers.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"09956e663489e0c38d392c13fc3220812e7e1a10","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                \"There is no Tempest plugin with name \u0027%s\u0027. \""},{"line_number":133,"context_line":"                \"Are you sure that it was installed?\" % name)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def list_tests(self, pattern\u003d\"\"):"},{"line_number":136,"context_line":"        \"\"\"List all Tempest tests.\"\"\""},{"line_number":137,"context_line":"        if pattern:"},{"line_number":138,"context_line":"            pattern \u003d self._transform_pattern(pattern)"},{"line_number":139,"context_line":"        output \u003d utils.check_output([\"testr\", \"list-tests\", pattern],"},{"line_number":140,"context_line":"                                    cwd\u003dself.repo_dir, env\u003dself.environ,"},{"line_number":141,"context_line":"                                    debug\u003dFalse)"},{"line_number":142,"context_line":"        return [l for l in output.split(\"\\n\") if TEST_NAME_REGEX.match(l)]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def parse_results(self, stream):"},{"line_number":145,"context_line":"        \"\"\"Parse subunit test streaming results of a Tempest test run.\"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_2280ddf6","line":142,"range":{"start_line":135,"start_character":4,"end_line":142,"end_character":74},"in_reply_to":"1a6eadb0_5374db34","updated":"2016-12-15 18:04:40.000000000","message":"before we find more proper place, let\u0027s put it to rally.verification.testr","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                \"There is no Tempest plugin with name \u0027%s\u0027. \""},{"line_number":133,"context_line":"                \"Are you sure that it was installed?\" % name)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def list_tests(self, pattern\u003d\"\"):"},{"line_number":136,"context_line":"        \"\"\"List all Tempest tests.\"\"\""},{"line_number":137,"context_line":"        if pattern:"},{"line_number":138,"context_line":"            pattern \u003d self._transform_pattern(pattern)"},{"line_number":139,"context_line":"        output \u003d utils.check_output([\"testr\", \"list-tests\", pattern],"},{"line_number":140,"context_line":"                                    cwd\u003dself.repo_dir, env\u003dself.environ,"},{"line_number":141,"context_line":"                                    debug\u003dFalse)"},{"line_number":142,"context_line":"        return [l for l in output.split(\"\\n\") if TEST_NAME_REGEX.match(l)]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def parse_results(self, stream):"},{"line_number":145,"context_line":"        \"\"\"Parse subunit test streaming results of a Tempest test run.\"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_5374db34","line":142,"range":{"start_line":135,"start_character":4,"end_line":142,"end_character":74},"in_reply_to":"1a6eadb0_8512c907","updated":"2016-12-15 14:47:20.000000000","message":"Where we should put this class?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    \"\u0027pattern\u0027 argument should be a regexp or set name \""},{"line_number":168,"context_line":"                    \"(format: \u0027regex\u003dtempest.api.identity.v3\u0027, \u0027set\u003dsmoke\u0027).\")"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def run(self, verification, **run_args):"},{"line_number":171,"context_line":"        \"\"\"Run Tempest tests.\"\"\""},{"line_number":172,"context_line":"        if run_args.get(\"pattern\"):"},{"line_number":173,"context_line":"            pattern \u003d self._transform_pattern(run_args[\"pattern\"])"},{"line_number":174,"context_line":"            run_args.update({\"pattern\": pattern})"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        with context.TestrContext(self.verifier, **run_args) as cmd:"},{"line_number":177,"context_line":"            with self.context(self.verifier, verification):"},{"line_number":178,"context_line":"                LOG.debug(\"Test(s) started by the command: \u0027%s\u0027.\","},{"line_number":179,"context_line":"                          \" \".join(cmd))"},{"line_number":180,"context_line":"                stream \u003d subprocess.Popen(cmd, env\u003dself.tempest_environ,"},{"line_number":181,"context_line":"                                          cwd\u003dself.verifier.manager.repo_dir,"},{"line_number":182,"context_line":"                                          stdout\u003dsubprocess.PIPE,"},{"line_number":183,"context_line":"                                          stderr\u003dsubprocess.STDOUT)"},{"line_number":184,"context_line":"                xfail_list \u003d run_args.get(\"xfail_list\")"},{"line_number":185,"context_line":"                skip_list \u003d run_args.get(\"skip_list\")"},{"line_number":186,"context_line":"                results \u003d subunit_v2.parse(stream.stdout, live\u003dTrue,"},{"line_number":187,"context_line":"                                           expected_failures\u003dxfail_list,"},{"line_number":188,"context_line":"                                           skipped_tests\u003dskip_list,"},{"line_number":189,"context_line":"                                           logger_name\u003dself.verifier.name)"},{"line_number":190,"context_line":"                stream.wait()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return results"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_45a8b18d","line":192,"range":{"start_line":170,"start_character":4,"end_line":192,"end_character":22},"updated":"2016-12-15 00:07:23.000000000","message":"move to TestrLauncher","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    \"\u0027pattern\u0027 argument should be a regexp or set name \""},{"line_number":168,"context_line":"                    \"(format: \u0027regex\u003dtempest.api.identity.v3\u0027, \u0027set\u003dsmoke\u0027).\")"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def run(self, verification, **run_args):"},{"line_number":171,"context_line":"        \"\"\"Run Tempest tests.\"\"\""},{"line_number":172,"context_line":"        if run_args.get(\"pattern\"):"},{"line_number":173,"context_line":"            pattern \u003d self._transform_pattern(run_args[\"pattern\"])"},{"line_number":174,"context_line":"            run_args.update({\"pattern\": pattern})"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        with context.TestrContext(self.verifier, **run_args) as cmd:"},{"line_number":177,"context_line":"            with self.context(self.verifier, verification):"},{"line_number":178,"context_line":"                LOG.debug(\"Test(s) started by the command: \u0027%s\u0027.\","},{"line_number":179,"context_line":"                          \" \".join(cmd))"},{"line_number":180,"context_line":"                stream \u003d subprocess.Popen(cmd, env\u003dself.tempest_environ,"},{"line_number":181,"context_line":"                                          cwd\u003dself.verifier.manager.repo_dir,"},{"line_number":182,"context_line":"                                          stdout\u003dsubprocess.PIPE,"},{"line_number":183,"context_line":"                                          stderr\u003dsubprocess.STDOUT)"},{"line_number":184,"context_line":"                xfail_list \u003d run_args.get(\"xfail_list\")"},{"line_number":185,"context_line":"                skip_list \u003d run_args.get(\"skip_list\")"},{"line_number":186,"context_line":"                results \u003d subunit_v2.parse(stream.stdout, live\u003dTrue,"},{"line_number":187,"context_line":"                                           expected_failures\u003dxfail_list,"},{"line_number":188,"context_line":"                                           skipped_tests\u003dskip_list,"},{"line_number":189,"context_line":"                                           logger_name\u003dself.verifier.name)"},{"line_number":190,"context_line":"                stream.wait()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        return results"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_f39b2764","line":192,"range":{"start_line":170,"start_character":4,"end_line":192,"end_character":22},"in_reply_to":"1a6eadb0_45a8b18d","updated":"2016-12-15 14:47:20.000000000","message":"ditto","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"}],"rally/ui/report.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Make JSON report.\"\"\""},{"line_number":81,"context_line":"        return json.dumps(self._tests, indent\u003dindent)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def to_csv(self, **kwargs):"},{"line_number":84,"context_line":"        \"\"\"Make CSV report.\"\"\""},{"line_number":85,"context_line":"        header \u003d [\"test name\", \"tags\", \"has errors\"]"},{"line_number":86,"context_line":"        for uuid in self._uuids:"},{"line_number":87,"context_line":"            header.extend([\"%s status\" % uuid, \"%s duration\" % uuid])"},{"line_number":88,"context_line":"        rows \u003d [header]"},{"line_number":89,"context_line":"        for test in self._tests:"},{"line_number":90,"context_line":"            row \u003d [test[\"name\"], \" \".join(test[\"tags\"])]"},{"line_number":91,"context_line":"            for uuid in self._uuids:"},{"line_number":92,"context_line":"                if uuid not in test[\"by_verification\"]:"},{"line_number":93,"context_line":"                    row.extend([None, None])"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"                row.append(test[\"by_verification\"][uuid][\"status\"])"},{"line_number":96,"context_line":"                row.append(test[\"by_verification\"][uuid][\"duration\"])"},{"line_number":97,"context_line":"            rows.append(row)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        with io.BytesIO() as stream:"},{"line_number":100,"context_line":"            csv.writer(stream, **kwargs).writerows(rows)"},{"line_number":101,"context_line":"            return stream.getvalue()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_859c895e","side":"PARENT","line":101,"range":{"start_line":83,"start_character":0,"end_line":101,"end_character":36},"updated":"2016-12-15 00:07:23.000000000","message":"Let\u0027s save it in main `rally verify report`, since it can be realy helpful.","commit_id":"1c85e84a7392868d646428d6b53f647d57a5cca0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Make JSON report.\"\"\""},{"line_number":81,"context_line":"        return json.dumps(self._tests, indent\u003dindent)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def to_csv(self, **kwargs):"},{"line_number":84,"context_line":"        \"\"\"Make CSV report.\"\"\""},{"line_number":85,"context_line":"        header \u003d [\"test name\", \"tags\", \"has errors\"]"},{"line_number":86,"context_line":"        for uuid in self._uuids:"},{"line_number":87,"context_line":"            header.extend([\"%s status\" % uuid, \"%s duration\" % uuid])"},{"line_number":88,"context_line":"        rows \u003d [header]"},{"line_number":89,"context_line":"        for test in self._tests:"},{"line_number":90,"context_line":"            row \u003d [test[\"name\"], \" \".join(test[\"tags\"])]"},{"line_number":91,"context_line":"            for uuid in self._uuids:"},{"line_number":92,"context_line":"                if uuid not in test[\"by_verification\"]:"},{"line_number":93,"context_line":"                    row.extend([None, None])"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"                row.append(test[\"by_verification\"][uuid][\"status\"])"},{"line_number":96,"context_line":"                row.append(test[\"by_verification\"][uuid][\"duration\"])"},{"line_number":97,"context_line":"            rows.append(row)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        with io.BytesIO() as stream:"},{"line_number":100,"context_line":"            csv.writer(stream, **kwargs).writerows(rows)"},{"line_number":101,"context_line":"            return stream.getvalue()"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_33f75f8c","side":"PARENT","line":101,"range":{"start_line":83,"start_character":0,"end_line":101,"end_character":36},"in_reply_to":"1a6eadb0_859c895e","updated":"2016-12-15 14:47:20.000000000","message":"will do.","commit_id":"1c85e84a7392868d646428d6b53f647d57a5cca0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def to_json(self, indent\u003d4):"},{"line_number":79,"context_line":"        \"\"\"Generate JSON report.\"\"\""},{"line_number":80,"context_line":"        report \u003d copy.deepcopy(self.report)"},{"line_number":81,"context_line":"        for test_id, result in report[\"tests\"].items():"},{"line_number":82,"context_line":"            del result[\"has_details\"]"},{"line_number":83,"context_line":"        return json.dumps(report, indent\u003dindent)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_65e5adda","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":37},"updated":"2016-12-15 00:07:23.000000000","message":"what about adding \"has_details\" in `to_html` method instead of deleting it here.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def to_json(self, indent\u003d4):"},{"line_number":79,"context_line":"        \"\"\"Generate JSON report.\"\"\""},{"line_number":80,"context_line":"        report \u003d copy.deepcopy(self.report)"},{"line_number":81,"context_line":"        for test_id, result in report[\"tests\"].items():"},{"line_number":82,"context_line":"            del result[\"has_details\"]"},{"line_number":83,"context_line":"        return json.dumps(report, indent\u003dindent)"}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_d3ad4b85","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":37},"in_reply_to":"1a6eadb0_65e5adda","updated":"2016-12-15 14:47:20.000000000","message":"Done","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"}],"rally/verification/context.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __init__(self, **ctx):"},{"line_number":28,"context_line":"        super(VerifierContext, self).__init__(ctx)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # There is no terms \"task\" in verification."},{"line_number":31,"context_line":"        del self.task"},{"line_number":32,"context_line":"        self.verification \u003d self.context.get(\"verification\", {})"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_a185efad","line":30,"range":{"start_line":30,"start_character":22,"end_line":30,"end_character":27},"updated":"2016-12-26 09:53:29.000000000","message":"term","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"}],"rally/verification/launcher.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"35624b13e7516c98b054f5f004c1bb0b9e9d8b1e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    cmd, env\u003dself.environ,"},{"line_number":153,"context_line":"                    cwd\u003dself.verifier.manager.repo_dir,"},{"line_number":154,"context_line":"                    stdout\u003dsubprocess.PIPE,"},{"line_number":155,"context_line":"                    stderr\u003dsubprocess.STDOUT)"},{"line_number":156,"context_line":"                results \u003d subunit_v2.parse(verification.stdout, live\u003dTrue,"},{"line_number":157,"context_line":"                                           expected_failures\u003dxfails_list,"},{"line_number":158,"context_line":"                                           skipped_tests\u003dskip_list,"}],"source_content_type":"text/x-python","patch_set":36,"id":"7a77a97e_a6cf00b2","line":155,"updated":"2016-11-22 16:43:14.000000000","message":"add here:\n\n    preexec_fn\u003dos.setsid","commit_id":"3719c10858ac4eb0d6bcb666ed6ded1a2ca86b08"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"35624b13e7516c98b054f5f004c1bb0b9e9d8b1e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                           expected_failures\u003dxfails_list,"},{"line_number":158,"context_line":"                                           skipped_tests\u003dskip_list,"},{"line_number":159,"context_line":"                                           logger_name\u003d\"verifier\")"},{"line_number":160,"context_line":"                verification.wait()"},{"line_number":161,"context_line":"        return results"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def discover_tests(self, pattern\u003d\"\"):"}],"source_content_type":"text/x-python","patch_set":36,"id":"7a77a97e_865044d6","line":160,"range":{"start_line":160,"start_character":16,"end_line":160,"end_character":35},"updated":"2016-11-22 16:43:14.000000000","message":"I have a great idea! Let\u0027s replace this line with:\n\n    while verification.poll() is None:\n        # process is running\n        if self.verify.get_status() \u003d\u003d \"ABORTING\":\n             # we can kill process and we will have results!\n             os.killpg(os.getpgid(verification.pid), signal.SIGTERM)\n             break\n        time.sleep(1)\n    verification.wait()","commit_id":"3719c10858ac4eb0d6bcb666ed6ded1a2ca86b08"}],"rally/verification/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            LOG.info(\"Switching verifier repo to the \u0027%s\u0027 version.\" % version)"},{"line_number":130,"context_line":"            utils.check_output([\"git\", \"checkout\", version], cwd\u003dself.repo_dir)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _initialize_testr(self):"},{"line_number":133,"context_line":"        \"\"\"Initialize a new repository for testr.\"\"\""},{"line_number":134,"context_line":"        test_repository_dir \u003d os.path.join(self.base_dir, \".testrepository\")"},{"line_number":135,"context_line":"        if not os.path.isdir(test_repository_dir):"},{"line_number":136,"context_line":"            LOG.debug(\"Initializing a new repository for \u0027testr\u0027.\")"},{"line_number":137,"context_line":"            try:"},{"line_number":138,"context_line":"                utils.check_output([\"testr\", \"init\"], cwd\u003dself.repo_dir,"},{"line_number":139,"context_line":"                                   env\u003dself.environ)"},{"line_number":140,"context_line":"            except (subprocess.CalledProcessError, OSError):"},{"line_number":141,"context_line":"                if os.path.exists(test_repository_dir):"},{"line_number":142,"context_line":"                    shutil.rmtree(test_repository_dir)"},{"line_number":143,"context_line":"                raise VerifierSetupFailure("},{"line_number":144,"context_line":"                    \"Failed to initialize a new repository for \u0027testr\u0027.\","},{"line_number":145,"context_line":"                    verifier\u003dself.verifier.name)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def install(self):"},{"line_number":148,"context_line":"        \"\"\"Install a verifier.\"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_a5226550","line":145,"range":{"start_line":132,"start_character":4,"end_line":145,"end_character":48},"updated":"2016-12-15 00:07:23.000000000","message":"move to TestrLauncher.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            LOG.info(\"Switching verifier repo to the \u0027%s\u0027 version.\" % version)"},{"line_number":130,"context_line":"            utils.check_output([\"git\", \"checkout\", version], cwd\u003dself.repo_dir)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _initialize_testr(self):"},{"line_number":133,"context_line":"        \"\"\"Initialize a new repository for testr.\"\"\""},{"line_number":134,"context_line":"        test_repository_dir \u003d os.path.join(self.base_dir, \".testrepository\")"},{"line_number":135,"context_line":"        if not os.path.isdir(test_repository_dir):"},{"line_number":136,"context_line":"            LOG.debug(\"Initializing a new repository for \u0027testr\u0027.\")"},{"line_number":137,"context_line":"            try:"},{"line_number":138,"context_line":"                utils.check_output([\"testr\", \"init\"], cwd\u003dself.repo_dir,"},{"line_number":139,"context_line":"                                   env\u003dself.environ)"},{"line_number":140,"context_line":"            except (subprocess.CalledProcessError, OSError):"},{"line_number":141,"context_line":"                if os.path.exists(test_repository_dir):"},{"line_number":142,"context_line":"                    shutil.rmtree(test_repository_dir)"},{"line_number":143,"context_line":"                raise VerifierSetupFailure("},{"line_number":144,"context_line":"                    \"Failed to initialize a new repository for \u0027testr\u0027.\","},{"line_number":145,"context_line":"                    verifier\u003dself.verifier.name)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def install(self):"},{"line_number":148,"context_line":"        \"\"\"Install a verifier.\"\"\""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_333e7f28","line":145,"range":{"start_line":132,"start_character":4,"end_line":145,"end_character":48},"in_reply_to":"1a6eadb0_a5226550","updated":"2016-12-15 14:47:20.000000000","message":"Where we should put this class?","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    \"Failed to initialize a new repository for \u0027testr\u0027.\","},{"line_number":145,"context_line":"                    verifier\u003dself.verifier.name)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def install(self):"},{"line_number":148,"context_line":"        \"\"\"Install a verifier.\"\"\""},{"line_number":149,"context_line":"        self._clone()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_85e009fc","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":22},"updated":"2016-12-15 00:07:23.000000000","message":"create install method in TestrLauncher like:\n\n    def install(self):\n        super(TestrLauncher, self).install()\n        self._initialize_testr()","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    \"Failed to initialize a new repository for \u0027testr\u0027.\","},{"line_number":145,"context_line":"                    verifier\u003dself.verifier.name)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def install(self):"},{"line_number":148,"context_line":"        \"\"\"Install a verifier.\"\"\""},{"line_number":149,"context_line":"        self._clone()"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_b318cfd4","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":22},"in_reply_to":"1a6eadb0_85e009fc","updated":"2016-12-15 14:47:20.000000000","message":"ditto","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4187c23348f627ced61ce242d8b53d50a1fb161","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            self.install_venv()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self._initialize_testr()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def uninstall(self, full\u003dFalse):"},{"line_number":159,"context_line":"        \"\"\"Uninstall a verifier."}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_25bc95db","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":32},"updated":"2016-12-15 00:07:23.000000000","message":"it can be redundant in case of non-testr verifiers.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a3ebba8134583286c73ca3cb17391c4b226da74b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            self.install_venv()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        self._initialize_testr()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def uninstall(self, full\u003dFalse):"},{"line_number":159,"context_line":"        \"\"\"Uninstall a verifier."}],"source_content_type":"text/x-python","patch_set":59,"id":"1a6eadb0_04293b37","line":156,"range":{"start_line":156,"start_character":8,"end_line":156,"end_character":32},"in_reply_to":"1a6eadb0_25bc95db","updated":"2016-12-15 14:47:20.000000000","message":"Right.","commit_id":"6f849ab431cc9619d65d8f56a6a012e655d5a8cb"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class VerifierSetupFailure(exceptions.RallyException):"},{"line_number":35,"context_line":"    msg_fmt \u003d \"Failed to setup verifier \u0027%(verifier)s\u0027: %(message)s\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def configure(name, namespace\u003d\"default\", default_repo\u003dNone,"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_17a46ea4","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":30},"updated":"2016-12-23 12:01:24.000000000","message":"set up","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    :param namespace: Plugin namespace"},{"line_number":44,"context_line":"    :param default_repo: Default repository to clone"},{"line_number":45,"context_line":"    :param default_version: Default version to checkout"},{"line_number":46,"context_line":"    :param context: list of contexts that should be executed for verification"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def decorator(plugin):"},{"line_number":49,"context_line":"        plugin._configure(name, namespace)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_b7e002ce","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":21},"updated":"2016-12-23 12:01:24.000000000","message":"L","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4464f5ca3e173c7d1e162ffdad5458eb75c4d336","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    :param namespace: Plugin namespace"},{"line_number":44,"context_line":"    :param default_repo: Default repository to clone"},{"line_number":45,"context_line":"    :param default_version: Default version to checkout"},{"line_number":46,"context_line":"    :param context: list of contexts that should be executed for verification"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def decorator(plugin):"},{"line_number":49,"context_line":"        plugin._configure(name, namespace)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_8fa9167e","line":46,"range":{"start_line":46,"start_character":20,"end_line":46,"end_character":21},"in_reply_to":"da4df55a_b7e002ce","updated":"2016-12-23 16:58:06.000000000","message":"Done","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # NOTE(ylobankov): Use \u0027develop mode\u0027 installation to provide an"},{"line_number":156,"context_line":"        #                  ability to advanced users to change tests or"},{"line_number":157,"context_line":"        #                  develop new ones in verifier repo on the fly."},{"line_number":158,"context_line":"        utils.check_output([\"pip\", \"install\", \"-e\", \"./\"],"},{"line_number":159,"context_line":"                           cwd\u003dself.repo_dir, env\u003dself.environ)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def check_system_wide(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d7b66689","line":158,"updated":"2016-12-23 12:01:24.000000000","message":"Please, return --src here. It is really needed.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4464f5ca3e173c7d1e162ffdad5458eb75c4d336","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # NOTE(ylobankov): Use \u0027develop mode\u0027 installation to provide an"},{"line_number":156,"context_line":"        #                  ability to advanced users to change tests or"},{"line_number":157,"context_line":"        #                  develop new ones in verifier repo on the fly."},{"line_number":158,"context_line":"        utils.check_output([\"pip\", \"install\", \"-e\", \"./\"],"},{"line_number":159,"context_line":"                           cwd\u003dself.repo_dir, env\u003dself.environ)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def check_system_wide(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_cfb95ecd","line":158,"in_reply_to":"da4df55a_d7b66689","updated":"2016-12-23 16:58:06.000000000","message":"not sure... as for me, \"./\" from repo dir should be enough.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        #   configure from different places, let\u0027s do not raise"},{"line_number":192,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":193,"context_line":"        if extra_options is not None:"},{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_9a5ec3e7","line":194,"range":{"start_line":194,"start_character":39,"end_line":194,"end_character":47},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4464f5ca3e173c7d1e162ffdad5458eb75c4d336","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        #   configure from different places, let\u0027s do not raise"},{"line_number":192,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":193,"context_line":"        if extra_options is not None:"},{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_6fdcf212","line":194,"range":{"start_line":194,"start_character":39,"end_line":194,"end_character":47},"in_reply_to":"da4df55a_9a5ec3e7","updated":"2016-12-23 16:58:06.000000000","message":"Done","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":193,"context_line":"        if extra_options is not None:"},{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_d73bc6e9","line":195,"range":{"start_line":195,"start_character":39,"end_line":195,"end_character":59},"updated":"2016-12-23 12:01:24.000000000","message":"any configuration yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4464f5ca3e173c7d1e162ffdad5458eb75c4d336","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":193,"context_line":"        if extra_options is not None:"},{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_8fee76b2","line":195,"range":{"start_line":195,"start_character":39,"end_line":195,"end_character":59},"in_reply_to":"da4df55a_d73bc6e9","updated":"2016-12-23 16:58:06.000000000","message":"\"yet\" is a wrong word here. Since some of verifiers will not support configuration in future(for example they do not need any pre-configuration)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_9a37a3af","line":197,"range":{"start_line":197,"start_character":33,"end_line":197,"end_character":41},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_170d4e3e","line":197,"range":{"start_line":197,"start_character":61,"end_line":197,"end_character":74},"updated":"2016-12-23 12:01:24.000000000","message":"any configuration yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise NotImplementedError(\"Verifier %s doesn\u0027t support \""},{"line_number":195,"context_line":"                                      \"configuration at all.\" %"},{"line_number":196,"context_line":"                                      self.get_name())"},{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_372172b5","line":197,"range":{"start_line":197,"start_character":29,"end_line":197,"end_character":31},"updated":"2016-12-23 12:01:24.000000000","message":"do","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        LOG.info(\"Nothing to to. Verifier %s doesn\u0027t support configuration.\" %"},{"line_number":198,"context_line":"                 self.get_name())"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"},{"line_number":201,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":203,"context_line":"                                  \"at all.\" % self.get_name())"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_1a149342","line":200,"range":{"start_line":200,"start_character":17,"end_line":200,"end_character":23},"updated":"2016-12-23 12:01:24.000000000","message":"configuration?","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                 self.get_name())"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"},{"line_number":201,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":203,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_9a9b23c9","line":201,"range":{"start_line":201,"start_character":28,"end_line":201,"end_character":30},"updated":"2016-12-23 12:01:24.000000000","message":"Either remove it or add it in all methods.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"},{"line_number":201,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":203,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def extend_configuration(self, extra_options):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_facd0fb8","line":202,"range":{"start_line":202,"start_character":35,"end_line":202,"end_character":43},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def override_config(self, new_content):"},{"line_number":201,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":203,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":206,"context_line":"        \"\"\"Extend verifier configuration with new options.\"\"\""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_ba29c78b","line":203,"range":{"start_line":202,"start_character":63,"end_line":203,"end_character":41},"updated":"2016-12-23 12:01:24.000000000","message":"any configuration yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":206,"context_line":"        \"\"\"Extend verifier configuration with new options.\"\"\""},{"line_number":207,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":208,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def get_configuration(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_9ad08355","line":207,"range":{"start_line":207,"start_character":35,"end_line":207,"end_character":43},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":206,"context_line":"        \"\"\"Extend verifier configuration with new options.\"\"\""},{"line_number":207,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support configuration \""},{"line_number":208,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def get_configuration(self):"},{"line_number":211,"context_line":"        \"\"\"Get verifier configuration(for example, content of config file).\"\"\""}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_ba50e70b","line":208,"range":{"start_line":207,"start_character":63,"end_line":208,"end_character":42},"updated":"2016-12-23 12:01:24.000000000","message":"any configuration yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d643d9da5be44178df7124a9e420f70c79407134","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def get_configuration(self):"},{"line_number":211,"context_line":"        \"\"\"Get verifier configuration(for example, content of config file).\"\"\""},{"line_number":212,"context_line":"        return \"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def install_extension(self, source, version\u003dNone, extra\u003dNone):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_a05ef6e6","line":211,"range":{"start_line":211,"start_character":11,"end_line":211,"end_character":74},"updated":"2016-12-23 12:21:25.000000000","message":"Get verifier configuration (e.g., the config file content)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4464f5ca3e173c7d1e162ffdad5458eb75c4d336","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                                  \"at all.\" % self.get_name())"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def get_configuration(self):"},{"line_number":211,"context_line":"        \"\"\"Get verifier configuration(for example, content of config file).\"\"\""},{"line_number":212,"context_line":"        return \"\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def install_extension(self, source, version\u003dNone, extra\u003dNone):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_ef5aa282","line":211,"range":{"start_line":211,"start_character":11,"end_line":211,"end_character":74},"in_reply_to":"da4df55a_a05ef6e6","updated":"2016-12-23 16:58:06.000000000","message":"Done","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def install_extension(self, source, version\u003dNone, extra\u003dNone):"},{"line_number":215,"context_line":"        \"\"\"Install a verifier extension.\"\"\""},{"line_number":216,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support extensions.\" %"},{"line_number":217,"context_line":"                                  self.get_name())"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def list_extensions(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_7ae3df33","line":216,"range":{"start_line":216,"start_character":35,"end_line":216,"end_character":43},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def install_extension(self, source, version\u003dNone, extra\u003dNone):"},{"line_number":215,"context_line":"        \"\"\"Install a verifier extension.\"\"\""},{"line_number":216,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support extensions.\" %"},{"line_number":217,"context_line":"                                  self.get_name())"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def list_extensions(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_5a045bbf","line":216,"range":{"start_line":216,"start_character":63,"end_line":216,"end_character":73},"updated":"2016-12-23 12:01:24.000000000","message":"any extensions yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def uninstall_extension(self, name):"},{"line_number":224,"context_line":"        \"\"\"Uninstall a verifier extension.\"\"\""},{"line_number":225,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support extensions.\" %"},{"line_number":226,"context_line":"                                  self.get_name())"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_daf3eb08","line":225,"range":{"start_line":225,"start_character":35,"end_line":225,"end_character":43},"updated":"2016-12-23 12:01:24.000000000","message":"Verifier with type","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def uninstall_extension(self, name):"},{"line_number":224,"context_line":"        \"\"\"Uninstall a verifier extension.\"\"\""},{"line_number":225,"context_line":"        raise NotImplementedError(\"Verifier %s doesn\u0027t support extensions.\" %"},{"line_number":226,"context_line":"                                  self.get_name())"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_faf6eff7","line":225,"range":{"start_line":225,"start_character":63,"end_line":225,"end_character":73},"updated":"2016-12-23 12:01:24.000000000","message":"any extensions yet","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class VerifierSetupFailure(exceptions.RallyException):"},{"line_number":35,"context_line":"    msg_fmt \u003d \"Failed to setup verifier \u0027%(verifier)s\u0027: %(message)s\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def configure(name, namespace\u003d\"default\", default_repo\u003dNone,"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_416e0302","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":30},"updated":"2016-12-26 09:53:29.000000000","message":"set up","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19fb106b09e611a9cbe65d5f42b21b93e79f179a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class VerifierSetupFailure(exceptions.RallyException):"},{"line_number":35,"context_line":"    msg_fmt \u003d \"Failed to setup verifier \u0027%(verifier)s\u0027: %(message)s\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def configure(name, namespace\u003d\"default\", default_repo\u003dNone,"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_a7225e50","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":30},"in_reply_to":"da4df55a_416e0302","updated":"2016-12-26 11:01:05.000000000","message":"Done","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def home_dir(self):"},{"line_number":87,"context_line":"        return os.path.join("},{"line_number":88,"context_line":"            self.base_dir,"},{"line_number":89,"context_line":"            \"for-deployment-%s\" % self.verifier.deployment[\"uuid\"])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @property"},{"line_number":92,"context_line":"    def repo_dir(self):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_61486788","line":89,"range":{"start_line":89,"start_character":13,"end_line":89,"end_character":27},"updated":"2016-12-26 09:53:29.000000000","message":"What about just \"deployment-%s\" like it is done for verifiers?","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19fb106b09e611a9cbe65d5f42b21b93e79f179a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def home_dir(self):"},{"line_number":87,"context_line":"        return os.path.join("},{"line_number":88,"context_line":"            self.base_dir,"},{"line_number":89,"context_line":"            \"for-deployment-%s\" % self.verifier.deployment[\"uuid\"])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @property"},{"line_number":92,"context_line":"    def repo_dir(self):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_c7e68214","line":89,"range":{"start_line":89,"start_character":13,"end_line":89,"end_character":27},"in_reply_to":"da4df55a_61486788","updated":"2016-12-26 11:01:05.000000000","message":"verifiers directories include only verifiers code. In case of \"for-deployment\" dirs they will include different kinds of data and not deployment itself.","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        utils.check_output([\"git\", \"checkout\", version], cwd\u003dself.repo_dir)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def configure(self, extra_options\u003dNone):"},{"line_number":229,"context_line":"        \"\"\"Configure verifier.\"\"\""},{"line_number":230,"context_line":"        # NOTE(andreykurilin): Verifier may not require any kind of"},{"line_number":231,"context_line":"        #   configuration and works with cli arguments or with environment"},{"line_number":232,"context_line":"        #   variables. Since we do not store anywhere information about require"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_e102970a","line":229,"range":{"start_line":229,"start_character":21,"end_line":229,"end_character":29},"updated":"2016-12-26 09:53:29.000000000","message":"a verifier","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19fb106b09e611a9cbe65d5f42b21b93e79f179a","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        utils.check_output([\"git\", \"checkout\", version], cwd\u003dself.repo_dir)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def configure(self, extra_options\u003dNone):"},{"line_number":229,"context_line":"        \"\"\"Configure verifier.\"\"\""},{"line_number":230,"context_line":"        # NOTE(andreykurilin): Verifier may not require any kind of"},{"line_number":231,"context_line":"        #   configuration and works with cli arguments or with environment"},{"line_number":232,"context_line":"        #   variables. Since we do not store anywhere information about require"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_27bcaedb","line":229,"range":{"start_line":229,"start_character":21,"end_line":229,"end_character":29},"in_reply_to":"da4df55a_e102970a","updated":"2016-12-26 11:01:05.000000000","message":"Done","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3b365e877a6962415cfd38500c1dad058280eddc","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        #   verifier configuration or not and we have hardcoded calls to"},{"line_number":234,"context_line":"        #   configure from different places, let\u0027s do not raise"},{"line_number":235,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":236,"context_line":"        if extra_options is not None:"},{"line_number":237,"context_line":"            raise NotImplementedError("},{"line_number":238,"context_line":"                _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at \""},{"line_number":239,"context_line":"                    \"all.\") % self.get_name())"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_a1608e02","line":236,"updated":"2016-12-26 10:07:20.000000000","message":"msg \u003d \"Verifiers with type \u0027%s\u0027 don\u0027t support configuration.\" % self.get_name()\nif extra_options is not None:\n    raise NotImplementedError(_LE(msg))\nLOG.info(\"Nothing to do. \" + msg)","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":236,"context_line":"        if extra_options is not None:"},{"line_number":237,"context_line":"            raise NotImplementedError("},{"line_number":238,"context_line":"                _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at \""},{"line_number":239,"context_line":"                    \"all.\") % self.get_name())"},{"line_number":240,"context_line":"        LOG.info(_LI(\"Nothing to do. Type \u0027%s\u0027 of verifier doesn\u0027t support \""},{"line_number":241,"context_line":"                     \"configuration.\") % self.get_name())"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_617a2679","line":238,"range":{"start_line":238,"start_character":21,"end_line":238,"end_character":50},"updated":"2016-12-26 09:53:29.000000000","message":"It sounds really weird. Type is like a tag of a verifier. Tag cannot support anything, but verifiers with some tag can.\n\n\nVerifiers with type \u0027%s\u0027 don\u0027t","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2bf0900114188d73a552835a5273f20524551bb3","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        #   NotImplementedError by default. Only do it in case of extra options"},{"line_number":236,"context_line":"        if extra_options is not None:"},{"line_number":237,"context_line":"            raise NotImplementedError("},{"line_number":238,"context_line":"                _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at \""},{"line_number":239,"context_line":"                    \"all.\") % self.get_name())"},{"line_number":240,"context_line":"        LOG.info(_LI(\"Nothing to do. Type \u0027%s\u0027 of verifier doesn\u0027t support \""},{"line_number":241,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_c16cb237","line":239,"range":{"start_line":238,"start_character":73,"end_line":239,"end_character":24},"updated":"2016-12-26 10:04:02.000000000","message":"I think \u0027at all\u0027 can be omitted. Just\n\n\nVerifiers with type \u0027%s\u0027 don\u0027t support configuration","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            raise NotImplementedError("},{"line_number":238,"context_line":"                _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at \""},{"line_number":239,"context_line":"                    \"all.\") % self.get_name())"},{"line_number":240,"context_line":"        LOG.info(_LI(\"Nothing to do. Type \u0027%s\u0027 of verifier doesn\u0027t support \""},{"line_number":241,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def override_config(self, new_content):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_416522b3","line":240,"range":{"start_line":240,"start_character":37,"end_line":240,"end_character":66},"updated":"2016-12-26 09:53:29.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        LOG.info(_LI(\"Nothing to do. Type \u0027%s\u0027 of verifier doesn\u0027t support \""},{"line_number":241,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def override_config(self, new_content):"},{"line_number":244,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":245,"context_line":"        raise NotImplementedError("},{"line_number":246,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_410c42ed","line":243,"range":{"start_line":243,"start_character":17,"end_line":243,"end_character":23},"updated":"2016-12-26 09:53:29.000000000","message":"configuration?","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2bf0900114188d73a552835a5273f20524551bb3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def override_config(self, new_content):"},{"line_number":244,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":245,"context_line":"        raise NotImplementedError("},{"line_number":246,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"},{"line_number":247,"context_line":"            % self.get_name())"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_41e442e0","line":244,"range":{"start_line":244,"start_character":28,"end_line":244,"end_character":30},"updated":"2016-12-26 10:04:02.000000000","message":"Please, remove it","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2bf0900114188d73a552835a5273f20524551bb3","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def override_config(self, new_content):"},{"line_number":244,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":245,"context_line":"        raise NotImplementedError("},{"line_number":246,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"},{"line_number":247,"context_line":"            % self.get_name())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def extend_configuration(self, extra_options):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_4167e24c","line":246,"range":{"start_line":246,"start_character":69,"end_line":246,"end_character":75},"updated":"2016-12-26 10:04:02.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def override_config(self, new_content):"},{"line_number":244,"context_line":"        \"\"\"Override verifier\u0027s configuration.\"\"\""},{"line_number":245,"context_line":"        raise NotImplementedError("},{"line_number":246,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"},{"line_number":247,"context_line":"            % self.get_name())"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def extend_configuration(self, extra_options):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_8112aa07","line":246,"range":{"start_line":246,"start_character":17,"end_line":246,"end_character":46},"updated":"2016-12-26 09:53:29.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2bf0900114188d73a552835a5273f20524551bb3","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":250,"context_line":"        \"\"\"Extend verifier configuration with new options.\"\"\""},{"line_number":251,"context_line":"        raise NotImplementedError("},{"line_number":252,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"},{"line_number":253,"context_line":"            % self.get_name())"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def get_configuration(self):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_014a3aac","line":252,"range":{"start_line":252,"start_character":69,"end_line":252,"end_character":75},"updated":"2016-12-26 10:04:02.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":250,"context_line":"        \"\"\"Extend verifier configuration with new options.\"\"\""},{"line_number":251,"context_line":"        raise NotImplementedError("},{"line_number":252,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support configuration at all.\")"},{"line_number":253,"context_line":"            % self.get_name())"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def get_configuration(self):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_e101b6b0","line":252,"range":{"start_line":252,"start_character":17,"end_line":252,"end_character":46},"updated":"2016-12-26 09:53:29.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    def install_extension(self, source, version\u003dNone, extra\u003dNone):"},{"line_number":260,"context_line":"        \"\"\"Install a verifier extension.\"\"\""},{"line_number":261,"context_line":"        raise NotImplementedError("},{"line_number":262,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support extensions.\")"},{"line_number":263,"context_line":"            % self.get_name())"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def list_extensions(self):"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_413362ab","line":262,"range":{"start_line":262,"start_character":17,"end_line":262,"end_character":46},"updated":"2016-12-26 09:53:29.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    def uninstall_extension(self, name):"},{"line_number":270,"context_line":"        \"\"\"Uninstall a verifier extension.\"\"\""},{"line_number":271,"context_line":"        raise NotImplementedError("},{"line_number":272,"context_line":"            _LE(\"Type \u0027%s\u0027 of verifier doesn\u0027t support extensions.\")"},{"line_number":273,"context_line":"            % self.get_name())"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_a1224e50","line":272,"range":{"start_line":272,"start_character":17,"end_line":272,"end_character":46},"updated":"2016-12-26 09:53:29.000000000","message":"ditto","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"}],"rally/verification/utils.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def check_output(*args, **kwargs):"},{"line_number":28,"context_line":"    msg_on_err \u003d kwargs.pop(\"msg_on_err\", None)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    kwargs[\"stderr\"] \u003d subprocess.STDOUT"},{"line_number":31,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_1a0d733e","line":28,"updated":"2016-12-23 12:01:24.000000000","message":"Please, take a look at patch set 66. We need one more line here.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def check_output(*args, **kwargs):"},{"line_number":28,"context_line":"    msg_on_err \u003d kwargs.pop(\"msg_on_err\", None)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    kwargs[\"stderr\"] \u003d subprocess.STDOUT"},{"line_number":31,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_dd09252e","line":28,"updated":"2016-12-23 12:01:24.000000000","message":"Please, take a look at patch set 66. We need one more line here.\n\n\ndebug \u003d kwargs.pop(\"debug\", True)","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c5c1dc17cbd427475686d6a2670a0fa11cde7b5e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def check_output(*args, **kwargs):"},{"line_number":28,"context_line":"    msg_on_err \u003d kwargs.pop(\"msg_on_err\", None)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    kwargs[\"stderr\"] \u003d subprocess.STDOUT"},{"line_number":31,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_2bf4a785","line":28,"in_reply_to":"da4df55a_dd09252e","updated":"2016-12-23 12:53:11.000000000","message":"I ddid not find any usage of debug. let\u0027s add it when we need it.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d92327627eee7cbbae26e68fbed12c614ab80549","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        LOG.error(\"Error output: \u0027%s\u0027\" % encodeutils.safe_decode(exc.output))"},{"line_number":38,"context_line":"        raise"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    if output:"},{"line_number":41,"context_line":"        LOG.debug(\"Subprocess output: \u0027%s\u0027\" % encodeutils.safe_decode(output))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    return output"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_9d26bdb8","line":40,"range":{"start_line":40,"start_character":7,"end_line":40,"end_character":13},"updated":"2016-12-23 12:01:24.000000000","message":"output and debug","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"}],"tests/unit/common/objects/test_verifier.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"0f61c550d6b26df6fa68f57670075b1a2b234d44","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertRaises(exceptions.RallyException, getattr, v, \"deployment\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch(\"rally.common.objects.verifier.manager\")"},{"line_number":82,"context_line":"    def test_lazy_loading_of_manager(self, mock_manager):"},{"line_number":83,"context_line":"        v \u003d objects.Verifier(self.db_obj)"},{"line_number":84,"context_line":"        self.assertIsNone(v._manager)"},{"line_number":85,"context_line":"        self.assertFalse(mock_manager.VerifierManager.get.called)"}],"source_content_type":"text/x-python","patch_set":72,"id":"da4df55a_40cd4a5c","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":36},"updated":"2016-12-23 12:26:10.000000000","message":"Let\u0027s name it \u0027test_manager_property\u0027 to keep consistency.","commit_id":"2bf3e7689c8986e528d0de851f57daf2d67ca8c1"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"7b7c581ca7a9fe355928795f435a5059fa84eae1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertRaises(exceptions.RallyException, getattr, v, \"deployment\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch(\"rally.common.objects.verifier.manager\")"},{"line_number":82,"context_line":"    def test_lazy_loading_of_manager(self, mock_manager):"},{"line_number":83,"context_line":"        self.db_obj[\"type\"] \u003d \"some\""},{"line_number":84,"context_line":"        self.db_obj[\"namespace\"] \u003d \"namespace\""},{"line_number":85,"context_line":"        v \u003d objects.Verifier(self.db_obj)"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_e1eff6e6","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":36},"updated":"2016-12-26 09:53:29.000000000","message":"Let\u0027s name it \u0027test_manager_property\u0027 to keep consistency.","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19fb106b09e611a9cbe65d5f42b21b93e79f179a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertRaises(exceptions.RallyException, getattr, v, \"deployment\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch(\"rally.common.objects.verifier.manager\")"},{"line_number":82,"context_line":"    def test_lazy_loading_of_manager(self, mock_manager):"},{"line_number":83,"context_line":"        self.db_obj[\"type\"] \u003d \"some\""},{"line_number":84,"context_line":"        self.db_obj[\"namespace\"] \u003d \"namespace\""},{"line_number":85,"context_line":"        v \u003d objects.Verifier(self.db_obj)"}],"source_content_type":"text/x-python","patch_set":74,"id":"da4df55a_07ffaaaa","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":36},"in_reply_to":"da4df55a_e1eff6e6","updated":"2016-12-26 11:01:05.000000000","message":"Done","commit_id":"5400ce741129ca816cd000efe620668221ba7f88"}]}
