)]}'
{"rally-jobs/cinder.yaml":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"617e20ca4b2d1056922d8f67922af65639e49c1f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"          users_per_tenant: 2"},{"line_number":266,"context_line":"      sla:"},{"line_number":267,"context_line":"        failure_rate:"},{"line_number":268,"context_line":"          max: 0"},{"line_number":269,"context_line":"    -"},{"line_number":270,"context_line":"      args:"},{"line_number":271,"context_line":"        size:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a8ec9b2_28752ef9","line":268,"updated":"2016-09-21 16:43:00.000000000","message":"This doesn\u0027t test the change you made. You need to create a volume from an image with the volumes context, and then use that volume in a scenario. Either of the CinderVolumes.create_and_{list,delete}_snapshot scenarios should be appropriate.","commit_id":"226ea66862582dd2985fb03ef8f1b7c537962354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"c0fabaaa616a2d2b1d139e76747ef959aacbc0c9","unresolved":false,"context_lines":[{"line_number":474,"context_line":"          tenants: 1"},{"line_number":475,"context_line":"          users_per_tenant: 1"},{"line_number":476,"context_line":"        volumes:"},{"line_number":477,"context_line":"          size: 1"},{"line_number":478,"context_line":"      sla:"},{"line_number":479,"context_line":"        failure_rate:"},{"line_number":480,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a8bc5a2_2a304856","line":477,"updated":"2016-09-22 13:35:26.000000000","message":"This doesn\u0027t test your change; you just create a volume and then snapshot it. The image_name argument is actually passed to cinder_client.create_snapshot(), where it is silently ignored. You need something like:\n\n    args:\n      size: 1\n    context:\n      volumes:\n        size: 1\n        image_name: {{ image_name }}","commit_id":"1ea0b76e8c5d49ad661c6f1cfbdc33c1db7c5774"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bb21385645bc1556d5e6c189447702ef946b296f","unresolved":false,"context_lines":[{"line_number":470,"context_line":"          users_per_tenant: 1"},{"line_number":471,"context_line":"        volumes:"},{"line_number":472,"context_line":"          size: 1"},{"line_number":473,"context_line":"        image_name: {{image_name}}"},{"line_number":474,"context_line":"      runner:"},{"line_number":475,"context_line":"        type: \"constant\""},{"line_number":476,"context_line":"        times: 2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a8bc5a2_391256b5","line":473,"updated":"2016-09-22 18:11:06.000000000","message":"image_name needs to be a property of volumes.\n\nI\u0027m really surprised this passed gates -- that should have produced an error.","commit_id":"c80b87389f21a45de8059be2a74600fee1f8c6c4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c60df799f4bf9a86343baa1174c33d6c0a1bb01e","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        size: 1"},{"line_number":467,"context_line":"      context:"},{"line_number":468,"context_line":"        users:"},{"line_number":469,"context_line":"          tenants: 1"},{"line_number":470,"context_line":"          users_per_tenant: 1"},{"line_number":471,"context_line":"        volumes:"},{"line_number":472,"context_line":"          size: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a95cdbc_a621c3b6","line":469,"updated":"2016-10-05 20:41:40.000000000","message":"please increase it to 2","commit_id":"eea00eea76259b4bdb8eea5d9f1aef496cf5418c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c60df799f4bf9a86343baa1174c33d6c0a1bb01e","unresolved":false,"context_lines":[{"line_number":467,"context_line":"      context:"},{"line_number":468,"context_line":"        users:"},{"line_number":469,"context_line":"          tenants: 1"},{"line_number":470,"context_line":"          users_per_tenant: 1"},{"line_number":471,"context_line":"        volumes:"},{"line_number":472,"context_line":"          size: 1"},{"line_number":473,"context_line":"          image: {{image_name}}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a95cdbc_c6308f04","line":470,"updated":"2016-10-05 20:41:40.000000000","message":"please increase it to 2","commit_id":"eea00eea76259b4bdb8eea5d9f1aef496cf5418c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d621ba97f2610ccbe0b02543befe8397148df707","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set image_name \u003d \"^(cirros.*uec|TestVM)$\" %}"},{"line_number":2,"context_line":"{% set full_image_name \u003d \"cirros-0.3.4-x86_64-uec\" %}"},{"line_number":3,"context_line":"{% set flavor_name \u003d \"m1.tiny\" %}"},{"line_number":4,"context_line":"---"},{"line_number":5,"context_line":"  Authenticate.validate_cinder:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a95cdbc_011793ed","line":2,"updated":"2016-10-06 17:53:59.000000000","message":"this is bad. Earlier we\u0027ve got similar bug. Image by default was changed and we\u0027ve got an error on the gate. We\u0027ve decided to use regex that is in the 1st line. Thus you need to deal with it.","commit_id":"b64c54469fdeed89252a040b1a0a7b0a748955d3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d621ba97f2610ccbe0b02543befe8397148df707","unresolved":false,"context_lines":[{"line_number":693,"context_line":"          users_per_tenant: 2"},{"line_number":694,"context_line":"        volumes:"},{"line_number":695,"context_line":"          size: 1"},{"line_number":696,"context_line":"          image_name: {{full_image_name}}"},{"line_number":697,"context_line":"      runner:"},{"line_number":698,"context_line":"        type: \"constant\""},{"line_number":699,"context_line":"        times: 2"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a95cdbc_e1dc6714","line":696,"updated":"2016-10-06 17:53:59.000000000","message":"I so that you got an error when using {{image_name}}. But why? It should work. Did you debug an error?","commit_id":"b64c54469fdeed89252a040b1a0a7b0a748955d3"},{"author":{"_account_id":10433,"name":"Tyler North","email":"tynorth@cisco.com","username":"tnorth"},"change_message_id":"bc1eaeddc9c0a80b16fe8a3b5e74c47f58f4be52","unresolved":false,"context_lines":[{"line_number":693,"context_line":"          users_per_tenant: 2"},{"line_number":694,"context_line":"        volumes:"},{"line_number":695,"context_line":"          size: 1"},{"line_number":696,"context_line":"          image_name: {{full_image_name}}"},{"line_number":697,"context_line":"      runner:"},{"line_number":698,"context_line":"        type: \"constant\""},{"line_number":699,"context_line":"        times: 2"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a95cdbc_61a05744","line":696,"in_reply_to":"1a95cdbc_e1dc6714","updated":"2016-10-06 18:00:11.000000000","message":"It did give me an error when I tried to pass in the regex name, I couldn\u0027t find a good log to tell me why, it seemed odd since I copied the logic over from another place where \"image_name\" was getting passed in. I can give it another try though.","commit_id":"b64c54469fdeed89252a040b1a0a7b0a748955d3"}],"rally/plugins/openstack/context/cinder/volumes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"9ac7cd7452c95ca897c5564b0afc175befa9ca1c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally.plugins.openstack.wrappers import glance as glance_wrapper"},{"line_number":21,"context_line":"from rally.plugins.openstack.cleanup import manager as resource_manager"},{"line_number":22,"context_line":"from rally.plugins.openstack.scenarios.cinder import utils as cinder_utils"},{"line_number":23,"context_line":"from rally.plugins.openstack.scenarios.glance import utils as glance_utils"},{"line_number":24,"context_line":"from rally.task import context"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_70775f02","line":23,"updated":"2016-09-20 20:10:32.000000000","message":"Unused import","commit_id":"3f520ce1e8d62471a56416d354233662a7f5da6c"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"9ac7cd7452c95ca897c5564b0afc175befa9ca1c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                for image in glance_wrap.list_images():"},{"line_number":78,"context_line":"                    if image.name \u003d\u003d image_name:"},{"line_number":79,"context_line":"                        image_id \u003d image.id"},{"line_number":80,"context_line":"                        break"},{"line_number":81,"context_line":"            cinder_util \u003d cinder_utils.CinderScenario("},{"line_number":82,"context_line":"                {\"user\": user,"},{"line_number":83,"context_line":"                 \"task\": self.context[\"task\"],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_105d3b79","line":80,"updated":"2016-09-20 20:10:32.000000000","message":"This for loop needs an else clause that raises an exception if the image name isn\u0027t found.","commit_id":"3f520ce1e8d62471a56416d354233662a7f5da6c"}],"tests/unit/plugins/openstack/context/cinder/test_volumes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"617e20ca4b2d1056922d8f67922af65639e49c1f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \"size\": 1,"},{"line_number":175,"context_line":"                    \"type\": \"volume_type\","},{"line_number":176,"context_line":"                    \"volumes_per_tenant\": 5,"},{"line_number":177,"context_line":"                    \"image_name\": \"image_name\","},{"line_number":178,"context_line":"                },"},{"line_number":179,"context_line":"                \"api_versions\": api_version"},{"line_number":180,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_28e36ea5","line":177,"updated":"2016-09-21 16:43:00.000000000","message":"This doesn\u0027t test your change. You need to add a dataset to lines 51-54, and then ensure that the image id is looked up and used properly in test_setup().","commit_id":"226ea66862582dd2985fb03ef8f1b7c537962354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"c0fabaaa616a2d2b1d139e76747ef959aacbc0c9","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        volumes_ctx \u003d volumes.VolumeGenerator(self.context)"},{"line_number":105,"context_line":"        volumes_ctx.setup()"},{"line_number":106,"context_line":"        self.assertEqual(new_context, self.context)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @mock.patch(\"%s.cinder.volumes.resource_manager.cleanup\" % CTX)"},{"line_number":109,"context_line":"    def test_cleanup(self, mock_cleanup):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_aa6a9818","line":106,"updated":"2016-09-22 13:35:26.000000000","message":"You need an assertion in here somewhere to ensure that the image ID is actually used when image_name is passed in.","commit_id":"1ea0b76e8c5d49ad661c6f1cfbdc33c1db7c5774"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"c0fabaaa616a2d2b1d139e76747ef959aacbc0c9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                    \"size\": 1,"},{"line_number":182,"context_line":"                    \"type\": \"volume_type\","},{"line_number":183,"context_line":"                    \"volumes_per_tenant\": 5,"},{"line_number":184,"context_line":"                    \"image_name\": \"image_name\","},{"line_number":185,"context_line":"                },"},{"line_number":186,"context_line":"                \"api_versions\": api_version"},{"line_number":187,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_ca77e400","line":184,"updated":"2016-09-22 13:35:26.000000000","message":"This isn\u0027t necessary. (Or it shouldn\u0027t be, at least.)","commit_id":"1ea0b76e8c5d49ad661c6f1cfbdc33c1db7c5774"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bb21385645bc1556d5e6c189447702ef946b296f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            image_checker \u003d fake_image.id"},{"line_number":112,"context_line":"        type_checker \u003d None"},{"line_number":113,"context_line":"        if \"type\" in self.context[\"config\"][\"volumes\"]:"},{"line_number":114,"context_line":"            type_checker \u003d self.context[\"config\"][\"volumes\"][\"type\"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        mock_cinder_scenario__create_volume.assert_called_with("},{"line_number":117,"context_line":"            self.context[\"config\"][\"volumes\"][\"size\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_b954a654","line":114,"updated":"2016-09-22 18:11:06.000000000","message":"These three lines can become:\n\n    type_checker \u003d self.context[\"config\"][\"volumes\"].get(\"type\")","commit_id":"c80b87389f21a45de8059be2a74600fee1f8c6c4"}]}
