)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9607a76340a2994a2a7e38a0bb68e84fba9629d5","unresolved":false,"context_lines":[{"line_number":650,"context_line":"      runner:"},{"line_number":651,"context_line":"        type: \"constant\""},{"line_number":652,"context_line":"        times: 5"},{"line_number":653,"context_line":"        concurrency: 2"},{"line_number":654,"context_line":"      sla:"},{"line_number":655,"context_line":"        failure_rate:"},{"line_number":656,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_6418aa1e","line":653,"updated":"2016-09-22 21:29:04.000000000","message":"please add user context\n      context:\n        users:\n          tenants: 2\n          users_per_tenant: 2","commit_id":"89afe8b97cc781793d9aed7fb5c58313a03f8125"}],"rally/plugins/openstack/scenarios/nova/hypervisors.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9607a76340a2994a2a7e38a0bb68e84fba9629d5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        hypervisors \u003d self._list_hypervisors(detailed)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        for hypervisor in hypervisors:"},{"line_number":58,"context_line":"            hypervisor \u003d self._get_hypervisor(hypervisor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_8405b6c3","line":57,"updated":"2016-09-22 21:29:04.000000000","message":"please use here an approach:\n    for i in range(repetitions):\n        with atomic.ActionTimer(instance_of_action_timer, \"name_of_action\"):\n            self.clients(\u003cclient\u003e).\u003coperation\u003e","commit_id":"89afe8b97cc781793d9aed7fb5c58313a03f8125"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5cf89b0aa761c5f5f0fb20c4e4b07d000b814f4c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"@validation.required_openstack(admin\u003dTrue)"},{"line_number":42,"context_line":"@scenario.configure(name\u003d\"NovaHypervisors.list_and_get_hypervisors\")"},{"line_number":43,"context_line":"class ListAndGetHypervisors(utils.NovaScenario):"},{"line_number":44,"context_line":"    \"\"\"List and Get hypervisors.\"\"\""},{"line_number":45,"context_line":"    def run(self, detailed\u003dTrue):"},{"line_number":46,"context_line":"        \"\"\"List and Get hypervisors."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_48ef3ee8","line":44,"updated":"2016-09-29 10:55:24.000000000","message":"delete this line. its duplicate 46th","commit_id":"dffc1d5258c00427a678e79103834e355f4e2179"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9607a76340a2994a2a7e38a0bb68e84fba9629d5","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        return self.admin_clients(\"nova\").hypervisors.list(detailed)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    @atomic.action_timer(\"nova.get_hypervisor\")"},{"line_number":867,"context_line":"    def _get_hypervisor(self, hypervisor):"},{"line_number":868,"context_line":"        \"\"\"Get a specific hypervisor."},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        :param hypervisor: Hypervisor  to get"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_04fa86bd","line":867,"updated":"2016-09-22 21:29:04.000000000","message":"and thus you need to add optional action decorator to the function https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/murano/utils.py#L84","commit_id":"89afe8b97cc781793d9aed7fb5c58313a03f8125"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"60d49c94bcd6a1582810c594b367286cfcc2ced4","unresolved":false,"context_lines":[{"line_number":867,"context_line":"    def _get_hypervisor(self, hypervisor):"},{"line_number":868,"context_line":"        \"\"\"Get a specific hypervisor."},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        :param hypervisor: Hypervisor to get"},{"line_number":871,"context_line":"        \"\"\""},{"line_number":872,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":873,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_d3d9fc23","line":870,"updated":"2016-09-24 21:51:09.000000000","message":"You forget to document returns value and atomic action parameter https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/murano/utils.py#L94 like here","commit_id":"2474379a2c9d4918411c38b269a62dc2389474a6"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5cf89b0aa761c5f5f0fb20c4e4b07d000b814f4c","unresolved":false,"context_lines":[{"line_number":870,"context_line":"        :param hypervisor: Hypervisor to get."},{"line_number":871,"context_line":"        :param atomic_action: True if this is atomic action. added and"},{"line_number":872,"context_line":"                              handled by the optional_action_timer()"},{"line_number":873,"context_line":"                              decorator."},{"line_number":874,"context_line":"        \"\"\""},{"line_number":875,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_88a6a6bf","line":873,"updated":"2016-09-29 10:55:24.000000000","message":"return value also should be documeted","commit_id":"dffc1d5258c00427a678e79103834e355f4e2179"}],"samples/tasks/scenarios/nova/list-and-get-hypervisors.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b47b09f314fa2e8e03b9af7bf04da68a2e71791","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"runner\": {"},{"line_number":5,"context_line":"        \"type\": \"constant\","},{"line_number":6,"context_line":"        \"concurrency\": 1,"},{"line_number":7,"context_line":"        \"times\": 1"},{"line_number":8,"context_line":"      },"},{"line_number":9,"context_line":"      \"args\": {"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_e681224c","line":6,"updated":"2016-10-05 13:42:03.000000000","message":"please increase it to 2","commit_id":"38e480b0c8c37743f39c9ce441e6400b87cf14d7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b47b09f314fa2e8e03b9af7bf04da68a2e71791","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      \"runner\": {"},{"line_number":5,"context_line":"        \"type\": \"constant\","},{"line_number":6,"context_line":"        \"concurrency\": 1,"},{"line_number":7,"context_line":"        \"times\": 1"},{"line_number":8,"context_line":"      },"},{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"detailed\": true"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_0697ee90","line":7,"updated":"2016-10-05 13:42:03.000000000","message":"please increase it to 2","commit_id":"38e480b0c8c37743f39c9ce441e6400b87cf14d7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b47b09f314fa2e8e03b9af7bf04da68a2e71791","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      },"},{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"detailed\": true"},{"line_number":11,"context_line":"      },"},{"line_number":12,"context_line":"      \"sla\": {"},{"line_number":13,"context_line":"        \"failure_rate\": {"},{"line_number":14,"context_line":"          \"max\": 0"}],"source_content_type":"application/json","patch_set":4,"id":"1a95cdbc_2666aaed","line":11,"updated":"2016-10-05 13:42:03.000000000","message":"missed here user context please add it","commit_id":"38e480b0c8c37743f39c9ce441e6400b87cf14d7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c84b6c7732589e9b60d318d1377b11d1a24c7f96","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      \"context\": {"},{"line_number":13,"context_line":"        \"users\": {"},{"line_number":14,"context_line":"        \"tenants\": 3,"},{"line_number":15,"context_line":"        \"users_per_tenant\": 2"},{"line_number":16,"context_line":"        }"},{"line_number":17,"context_line":"      },"},{"line_number":18,"context_line":"      \"sla\": {"}],"source_content_type":"application/json","patch_set":5,"id":"1a95cdbc_24a1a6f8","line":15,"updated":"2016-10-10 04:33:38.000000000","message":"wrong indentation. please fix it","commit_id":"6acabbc4a81ac202ca3dbfdc7de276ac45f14df7"}],"samples/tasks/scenarios/nova/list-and-get-hypervisors.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b47b09f314fa2e8e03b9af7bf04da68a2e71791","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        detailed: True"},{"line_number":6,"context_line":"      runner:"},{"line_number":7,"context_line":"        type: \"constant\""},{"line_number":8,"context_line":"        times: 1"},{"line_number":9,"context_line":"        concurrency: 1"},{"line_number":10,"context_line":"      sla:"},{"line_number":11,"context_line":"        failure_rate:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a95cdbc_e6f842e8","line":8,"updated":"2016-10-05 13:42:03.000000000","message":"please increase it to 2","commit_id":"38e480b0c8c37743f39c9ce441e6400b87cf14d7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b47b09f314fa2e8e03b9af7bf04da68a2e71791","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      runner:"},{"line_number":7,"context_line":"        type: \"constant\""},{"line_number":8,"context_line":"        times: 1"},{"line_number":9,"context_line":"        concurrency: 1"},{"line_number":10,"context_line":"      sla:"},{"line_number":11,"context_line":"        failure_rate:"},{"line_number":12,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a95cdbc_26adcae9","line":9,"updated":"2016-10-05 13:42:03.000000000","message":"please increase it to 2\nalso missed here user context please add it","commit_id":"38e480b0c8c37743f39c9ce441e6400b87cf14d7"}]}