)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57e9b4b3a4fc85e87d0701ae0364f80023655176","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            name: \"{{flavor_name}}\""},{"line_number":336,"context_line":"        image:"},{"line_number":337,"context_line":"            name: \"{{image_name}}\""},{"line_number":338,"context_line":"        console_type: \"xvpvnc\""},{"line_number":339,"context_line":"      runner:"},{"line_number":340,"context_line":"        type: \"constant\""},{"line_number":341,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_29ccbb88","line":338,"updated":"2016-09-22 21:12:46.000000000","message":"those two are pretty the same except one parameter. Its reasonable to use here the power of jinja2 templates","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"fbadbd24159a7e13574fab4d0d5c669041af362e","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            name: \"{{flavor_name}}\""},{"line_number":336,"context_line":"        image:"},{"line_number":337,"context_line":"            name: \"{{image_name}}\""},{"line_number":338,"context_line":"        console_type: \"xvpvnc\""},{"line_number":339,"context_line":"      runner:"},{"line_number":340,"context_line":"        type: \"constant\""},{"line_number":341,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_cf4509b4","line":338,"in_reply_to":"5a8bc5a2_29ccbb88","updated":"2016-09-23 06:42:16.000000000","message":"Done","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57e9b4b3a4fc85e87d0701ae0364f80023655176","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        :param image: image to be used to boot an instance"},{"line_number":947,"context_line":"        :param flavor: flavor to be used to boot an instance"},{"line_number":948,"context_line":"        :param console_type: Type of vnc console (\"novnc\" or \"xvpvnc\")"},{"line_number":949,"context_line":"        :param kwargs: Optional additional arguments for server creation"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        :returns: Vnc console url to server"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_c90c3797","line":948,"updated":"2016-09-22 21:12:46.000000000","message":"What will I get I specify something else then (\"novnc\" or \"xvpvnc\")? If its a trace then we need validator on that, otherwise its ok","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"fbadbd24159a7e13574fab4d0d5c669041af362e","unresolved":false,"context_lines":[{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        :param image: image to be used to boot an instance"},{"line_number":947,"context_line":"        :param flavor: flavor to be used to boot an instance"},{"line_number":948,"context_line":"        :param console_type: Type of vnc console (\"novnc\" or \"xvpvnc\")"},{"line_number":949,"context_line":"        :param kwargs: Optional additional arguments for server creation"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"        :returns: Vnc console url to server"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_4fec998f","line":948,"in_reply_to":"5a8bc5a2_c90c3797","updated":"2016-09-23 06:42:16.000000000","message":"Done","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b397ce770a9758a783bac578ecc6d878b6b40d4f","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        \"\"\""},{"line_number":951,"context_line":"        server \u003d self._boot_server(image, flavor, **kwargs)"},{"line_number":952,"context_line":"        CONSOLE_TYPE \u003d [\"novnc\", \"xvpvnc\"]"},{"line_number":953,"context_line":"        if console_type in CONSOLE_TYPE:"},{"line_number":954,"context_line":"            self._get_vnc_console_server(server, console_type)"},{"line_number":955,"context_line":"        else:"},{"line_number":956,"context_line":"            msg \u003d (\"Invalid console_type \u0027%s\u0027, console_type must be \""},{"line_number":957,"context_line":"                   \"\u0027novnc\u0027 or \u0027xvpvnc\u0027.\" % console_type)"},{"line_number":958,"context_line":"            raise rally_exceptions.InvalidArgumentsException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_ac4a7d81","line":958,"range":{"start_line":953,"start_character":8,"end_line":958,"end_character":73},"updated":"2016-09-23 11:04:02.000000000","message":"validator realized in Rally in following way https://github.com/openstack/rally/blob/master/rally/task/validation.py and then you will add one more decorator above the scanario class","commit_id":"75c5cdeac262330e8ef8086b6795c1d575c761fe"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2aa348b8cd74e727515ace17d29f360331bec589","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"                    name\u003d\"NovaServers.boot_and_get_vnc_console\")"},{"line_number":1081,"context_line":"class BootAndGetVncConsole(utils.NovaScenario):"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"    def run(self, image, flavor, console_type, **kwargs):"},{"line_number":1084,"context_line":"        \"\"\"Get a vnc console to a server."},{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"        This simple scenario tests the nova get-vnc-console command by"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_d5b90115","line":1083,"range":{"start_line":1083,"start_character":33,"end_line":1083,"end_character":45},"updated":"2017-06-16 02:31:22.000000000","message":"We need use the validation of enum to limit it\u0027s values.","commit_id":"b555ac5ad0c1a822e31efd2275cc715121d6d299"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"353c7833bec1a1870be0cffffd725174d46b8ed1","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NOVA])"},{"line_number":1080,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":1081,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"},{"line_number":1082,"context_line":"                    name\u003d\"NovaServers.boot_and_get_vnc_console\")"},{"line_number":1083,"context_line":"class BootAndGetVncConsole(utils.NovaScenario):"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def run(self, image, flavor, console_type, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_e684c760","line":1082,"range":{"start_line":1082,"start_character":47,"end_line":1082,"end_character":62},"updated":"2017-06-22 12:16:02.000000000","message":"I do not know the history of that command in novaclient, but I always wondered why they split different consoles by different commands. I really dislike such approach. \nAs for the code of novaclient, they added one public method for obtaining all types of consoles[*]. I suggest you create a single scenario for obtaining all kind of consoles.\n\n[*] - https://github.com/openstack/python-novaclient/blob/7.1.0/novaclient/v2/servers.py#L979","commit_id":"36c15885fe4eefc48f00519eba861dec6cb8dfd9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14372cf96101f26e74c3d9c5a85aaf2c1871f613","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NOVA])"},{"line_number":1080,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":1081,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"},{"line_number":1082,"context_line":"                    name\u003d\"NovaServers.boot_and_get_vnc_console\")"},{"line_number":1083,"context_line":"class BootAndGetVncConsole(utils.NovaScenario):"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def run(self, image, flavor, console_type, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_eb92f956","line":1082,"range":{"start_line":1082,"start_character":47,"end_line":1082,"end_character":62},"in_reply_to":"3f1d235d_a0c78564","updated":"2017-07-05 09:48:45.000000000","message":"I prefer to add support for all types, but check in gates only those which are possible(without checking project-config)","commit_id":"36c15885fe4eefc48f00519eba861dec6cb8dfd9"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e3b8858aa9505736297381874406c2ca6f82737d","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NOVA])"},{"line_number":1080,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":1081,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"},{"line_number":1082,"context_line":"                    name\u003d\"NovaServers.boot_and_get_vnc_console\")"},{"line_number":1083,"context_line":"class BootAndGetVncConsole(utils.NovaScenario):"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def run(self, image, flavor, console_type, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_a0c78564","line":1082,"range":{"start_line":1082,"start_character":47,"end_line":1082,"end_character":62},"in_reply_to":"5f201791_e684c760","updated":"2017-07-05 05:59:26.000000000","message":"Hi Andrey:\n  The openstack client do only remains command \"openstack console url show\".\n  The question is openstack-infra now only enable vnc console by default. There are five kind of console urls in openstack(vnc, serial, spice, rdp, mks). Among them, spice is exclusive with vnc. rdp is used only for hyper-v. mks is for vmware. About serial console, I can try to add it in openstack-infra.\n  Do I still need to rewrite it to a public scenario?","commit_id":"36c15885fe4eefc48f00519eba861dec6cb8dfd9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e5d430839f3c932bc7dd11d5bfae4277194280f","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"@validation.add(\"enum\", param_name\u003d\"console_type\","},{"line_number":1069,"context_line":"                values\u003d[\"novnc\", \"xvpvnc\"])"},{"line_number":1070,"context_line":"@types.convert(image\u003d{\"type\": \"glance_image\"},"},{"line_number":1071,"context_line":"               flavor\u003d{\"type\": \"nova_flavor\"})"},{"line_number":1072,"context_line":"@validation.add(\"image_valid_on_flavor\", flavor_param\u003d\"flavor\","}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_feeba70f","line":1069,"range":{"start_line":1069,"start_character":23,"end_line":1069,"end_character":42},"updated":"2017-07-06 10:18:32.000000000","message":"please, extend it with all supported types.","commit_id":"072360a04ac56be2dc540fd5e0342ef51eb66b99"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e5d430839f3c932bc7dd11d5bfae4277194280f","unresolved":false,"context_lines":[{"line_number":1090,"context_line":"                             webmks for protocol mks (since version 2.8)."},{"line_number":1091,"context_line":"        :param kwargs: Optional additional arguments for server creation"},{"line_number":1092,"context_line":"        \"\"\""},{"line_number":1093,"context_line":"        LOG.warning(\"Now gates only can be possible to test vnc console. \""},{"line_number":1094,"context_line":"                    \"Only novnc or xvpvnc can be input as console_type.\")"},{"line_number":1095,"context_line":"        server \u003d self._boot_server(image, flavor, **kwargs)"},{"line_number":1096,"context_line":"        self._get_console_url_server(server, console_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_fe9de7bb","line":1094,"range":{"start_line":1093,"start_character":0,"end_line":1094,"end_character":73},"updated":"2017-07-06 10:18:32.000000000","message":"it is redundant. I think, if we test only one console type in gate it will be a prove that integration with novaclient is done in proper way","commit_id":"072360a04ac56be2dc540fd5e0342ef51eb66b99"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57e9b4b3a4fc85e87d0701ae0364f80023655176","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        :param server: The server whose vnc console to retrieve"},{"line_number":200,"context_line":"        :param console_type: Type of vnc console (\"novnc\" or \"xvpvnc\")"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        :returns: Vnc console url to server"},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        return self.clients(\"nova\").servers.get_vnc_console(server,"},{"line_number":205,"context_line":"                                                            console_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_09d29f00","line":202,"updated":"2016-09-22 21:12:46.000000000","message":"But the docs says that it returns dict https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L904","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"fbadbd24159a7e13574fab4d0d5c669041af362e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        :param server: The server whose vnc console to retrieve"},{"line_number":200,"context_line":"        :param console_type: Type of vnc console (\"novnc\" or \"xvpvnc\")"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        :returns: Vnc console url to server"},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        return self.clients(\"nova\").servers.get_vnc_console(server,"},{"line_number":205,"context_line":"                                                            console_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_0f1611a7","line":202,"in_reply_to":"5a8bc5a2_09d29f00","updated":"2016-09-23 06:42:16.000000000","message":"Done","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"}],"samples/tasks/scenarios/nova/boot-and-get-vnc-console.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57e9b4b3a4fc85e87d0701ae0364f80023655176","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \"tenants\": 3,"},{"line_number":45,"context_line":"                    \"users_per_tenant\": 2"},{"line_number":46,"context_line":"                }"},{"line_number":47,"context_line":"            }"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"5a8bc5a2_a97e0be2","line":47,"updated":"2016-09-22 21:12:46.000000000","message":"missed sla section in the samples","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"fbadbd24159a7e13574fab4d0d5c669041af362e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    \"tenants\": 3,"},{"line_number":45,"context_line":"                    \"users_per_tenant\": 2"},{"line_number":46,"context_line":"                }"},{"line_number":47,"context_line":"            }"},{"line_number":48,"context_line":"        }"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"5a8bc5a2_efc72510","line":47,"in_reply_to":"5a8bc5a2_a97e0be2","updated":"2016-09-23 06:42:16.000000000","message":"Done","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"}],"samples/tasks/scenarios/nova/boot-and-get-vnc-console.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"57e9b4b3a4fc85e87d0701ae0364f80023655176","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      context:"},{"line_number":33,"context_line":"        users:"},{"line_number":34,"context_line":"          tenants: 3"},{"line_number":35,"context_line":"          users_per_tenant: 2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_096e1f2f","line":35,"updated":"2016-09-22 21:12:46.000000000","message":"missed sla section in the samples","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"fbadbd24159a7e13574fab4d0d5c669041af362e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      context:"},{"line_number":33,"context_line":"        users:"},{"line_number":34,"context_line":"          tenants: 3"},{"line_number":35,"context_line":"          users_per_tenant: 2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_2f5bcd88","line":35,"in_reply_to":"5a8bc5a2_096e1f2f","updated":"2016-09-23 06:42:16.000000000","message":"Done","commit_id":"22f0795ba0c30253c84709850c0e58177111d8bc"}]}