)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0ff1930a116894816de5b3bc358660519fe9a56","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        quotas:"},{"line_number":808,"context_line":"          nova:"},{"line_number":809,"context_line":"            security_groups: -1"},{"line_number":810,"context_line":"            security_group_rules: -1"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"  NovaKeypair.create_and_delete_keypair:"},{"line_number":813,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a98d1f4_7e659043","line":810,"updated":"2016-09-29 11:33:25.000000000","message":"please add missed sla section","commit_id":"f65b0604cf1c0cced14bf4995e2c1b56914b7df7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"06937c3e9eb8119793c72240a58dfe14e34df484","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        failure_rate:"},{"line_number":813,"context_line":"          max: 0"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"  NovaKeypair.create_and_delete_keypair:"},{"line_number":817,"context_line":"    -"},{"line_number":818,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a95cdbc_665352e2","line":815,"updated":"2016-10-05 13:49:48.000000000","message":"redundant line. remove it please","commit_id":"100f88461af75d5e8e356cbaba15d8fc104c2911"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0ff1930a116894816de5b3bc358660519fe9a56","unresolved":false,"context_lines":[{"line_number":958,"context_line":""},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"@validation.required_parameters(\"security_group_count\","},{"line_number":961,"context_line":"                                \"rules_per_security_group\")"},{"line_number":962,"context_line":"@validation.required_contexts(\"network\")"},{"line_number":963,"context_line":"@validation.required_services(consts.Service.NOVA)"},{"line_number":964,"context_line":"@validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_bea47857","line":961,"updated":"2016-09-29 11:33:25.000000000","message":"please add default values for them and remove this validator for better user experience.","commit_id":"f65b0604cf1c0cced14bf4995e2c1b56914b7df7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fe53f073aad2ace4775b7c794e32c944eb9923fe","unresolved":false,"context_lines":[{"line_number":937,"context_line":"@validation.required_contexts(\"network\")"},{"line_number":938,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"},{"line_number":939,"context_line":"                    name\u003d\"NovaServers.boot_server_and_add_secgroups\")"},{"line_number":940,"context_line":"class BootServerAndAddSecgroups(utils.NovaScenario):"},{"line_number":941,"context_line":"    \"\"\"Benchmark scenarios for Nova Secgroup API.\"\"\""},{"line_number":942,"context_line":"    def run(self, image, flavor, security_group_count\u003d1,"},{"line_number":943,"context_line":"            rules_per_security_group\u003d1, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_cccfa17d","line":940,"updated":"2016-10-12 23:11:23.000000000","message":"Move it here https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/security_group.py please. Its more about secgroups","commit_id":"0c0cb2a110f213e3d96f2430fbf1fb88cfad042e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fe53f073aad2ace4775b7c794e32c944eb9923fe","unresolved":false,"context_lines":[{"line_number":938,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"},{"line_number":939,"context_line":"                    name\u003d\"NovaServers.boot_server_and_add_secgroups\")"},{"line_number":940,"context_line":"class BootServerAndAddSecgroups(utils.NovaScenario):"},{"line_number":941,"context_line":"    \"\"\"Benchmark scenarios for Nova Secgroup API.\"\"\""},{"line_number":942,"context_line":"    def run(self, image, flavor, security_group_count\u003d1,"},{"line_number":943,"context_line":"            rules_per_security_group\u003d1, **kwargs):"},{"line_number":944,"context_line":"        \"\"\"Boot a server and add a security group to it."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_8c7da970","line":941,"updated":"2016-10-12 23:11:23.000000000","message":"remove it please. It not only about secgroups and better to write such things in run()","commit_id":"0c0cb2a110f213e3d96f2430fbf1fb88cfad042e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fe53f073aad2ace4775b7c794e32c944eb9923fe","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"        with atomic.ActionTimer(self, \"nova.add_server_secgroups\"):"},{"line_number":963,"context_line":"            for sg in security_groups:"},{"line_number":964,"context_line":"                self._add_server_secgroups(server, sg.name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_ec91c553","line":964,"updated":"2016-10-12 23:11:23.000000000","message":"please pass here atomic_action\u003dFalse","commit_id":"0c0cb2a110f213e3d96f2430fbf1fb88cfad042e"}],"samples/tasks/scenarios/nova/boot-server-and-add-secgroup.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"fe53f073aad2ace4775b7c794e32c944eb9923fe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            },"},{"line_number":29,"context_line":"            \"sla\": {"},{"line_number":30,"context_line":"                \"failure_rate\": {"},{"line_number":31,"context_line":"                \"max\": 0"},{"line_number":32,"context_line":"                }"},{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":"        }"}],"source_content_type":"application/json","patch_set":6,"id":"fa6399be_6c6215af","line":31,"updated":"2016-10-12 23:11:23.000000000","message":"please fix an indention","commit_id":"0c0cb2a110f213e3d96f2430fbf1fb88cfad042e"}]}
