)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":813,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":814,"context_line":"    -"},{"line_number":815,"context_line":"     args:"},{"line_number":816,"context_line":"        public_key: \"/root/.ssh/public_key\""},{"line_number":817,"context_line":"     runner:"},{"line_number":818,"context_line":"        type: \"constant\""},{"line_number":819,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_1415ee47","line":816,"updated":"2016-09-26 11:20:30.000000000","message":"Is it exist in the gates? If no then you may create it here https://github.com/openstack/rally/tree/master/rally-jobs/extra and use that path in the samples","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":824,"context_line":"          users_per_tenant: 2"},{"line_number":825,"context_line":"      sla:"},{"line_number":826,"context_line":"        failure_rate:"},{"line_number":827,"context_line":"          max: 0"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"  NovaKeypair.boot_and_delete_server_with_keypair:"},{"line_number":830,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_b4c8ba23","line":827,"updated":"2016-09-26 11:20:30.000000000","message":"1) There is an error in the job - http://logs.openstack.org/88/376288/1/check/gate-rally-dsvm-rally-nova/8e323ae/console.html#_2016-09-26_08_41_21_168569\n2) Please add second workload with public_key: None\n   Those two workloads will be pretty like so you need to use jinja2 template power here","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5dfc2cf9318c78b8471ebcdf6e5a06b5f656022c","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        type: \"constant\""},{"line_number":820,"context_line":"        times: 4"},{"line_number":821,"context_line":"        concurrency: 4"},{"line_number":822,"context_line":"      context:"},{"line_number":823,"context_line":"        users:"},{"line_number":824,"context_line":"          tenants: 3"},{"line_number":825,"context_line":"          users_per_tenant: 2"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a98d1f4_858de87d","line":822,"updated":"2016-09-28 13:15:25.000000000","message":"http://logs.openstack.org/88/376288/2/check/gate-rally-dsvm-rally-nova/8650ff0/console.html#_2016-09-28_06_36_01_811283","commit_id":"75ca4eb6bdda1f705bd096d7259da8f0caa50ac3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"811dfb4b2437858e7804ac6d03ce07079caa511e","unresolved":false,"context_lines":[{"line_number":834,"context_line":"  {% for s in (\"None\", \"~/.rally/extra/public_key\") %}"},{"line_number":835,"context_line":"    -"},{"line_number":836,"context_line":"     args:"},{"line_number":837,"context_line":"        public_key: {s}"},{"line_number":838,"context_line":"     runner:"},{"line_number":839,"context_line":"        type: \"constant\""},{"line_number":840,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a98d1f4_de26a415","line":837,"updated":"2016-09-29 11:29:55.000000000","message":"http://logs.openstack.org/88/376288/3/check/gate-rally-dsvm-rally-nova/1638311/rally-plot/results.html.gz#/NovaKeypair.create_keypair_with_public_key/failures","commit_id":"5d6b06af62c9b433b6462083aff6c53fa75002d2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"129151f8eecf592e75a1023bb3974ca7def4b3e1","unresolved":false,"context_lines":[{"line_number":831,"context_line":"          max: 0"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":834,"context_line":"  {% for s in (\"None\", \"~/.rally/extra/public_key\") %}"},{"line_number":835,"context_line":"    -"},{"line_number":836,"context_line":"     args:"},{"line_number":837,"context_line":"        public_key: {s}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_4e48532e","line":834,"updated":"2016-10-10 20:50:27.000000000","message":"You have an issue with jinja2 templates. Look at how jinja2 converts values at http://logs.openstack.org/88/376288/4/check/gate-rally-dsvm-rally-nova/54ef214/rally-plot/results.html.gz#/NovaKeypair.create_keypair_with_public_key/task it pass:\ns: null\nwhich is obviously nova doesn\u0027t proccess","commit_id":"acf7a807edc4b5fe98f58c4ae8a5bd6f51398fbb"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"370472195af4fcfd80677f439e92621cdf60ffe9","unresolved":false,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":834,"context_line":"    -"},{"line_number":835,"context_line":"     args:"},{"line_number":836,"context_line":"     runner:"},{"line_number":837,"context_line":"        type: \"constant\""},{"line_number":838,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_af3d9b2c","line":835,"updated":"2016-10-14 22:36:18.000000000","message":"args: {}","commit_id":"5b0dcdf44bb3c76811fdbcdc1d648f05e97edd96"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"eaa68dd4f22100f32202e08c22d66fd5dbdcc185","unresolved":false,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":834,"context_line":"    -"},{"line_number":835,"context_line":"     args:"},{"line_number":836,"context_line":"     runner:"},{"line_number":837,"context_line":"        type: \"constant\""},{"line_number":838,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa6399be_a3df530b","line":835,"in_reply_to":"fa6399be_af3d9b2c","updated":"2016-10-17 11:07:08.000000000","message":"agree","commit_id":"5b0dcdf44bb3c76811fdbcdc1d648f05e97edd96"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6d15310cd3a31d8e60d0f901417543f970e56df","unresolved":false,"context_lines":[{"line_number":832,"context_line":""},{"line_number":833,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":834,"context_line":"    -"},{"line_number":835,"context_line":"     args:"},{"line_number":836,"context_line":"     runner:"},{"line_number":837,"context_line":"        type: \"constant\""},{"line_number":838,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da6895a0_34318da3","line":835,"range":{"start_line":835,"start_character":5,"end_line":835,"end_character":10},"updated":"2016-10-21 17:47:55.000000000","message":"if you want to do not transmit args at all, just remove args section at all)","commit_id":"4ffed771661a17b40a833075a8894aef787e405d"}],"rally/plugins/openstack/scenarios/nova/keypairs.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"129151f8eecf592e75a1023bb3974ca7def4b3e1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if public_key \u003d\u003d \"None\":"},{"line_number":117,"context_line":"            self._create_keypair(**kwargs)"},{"line_number":118,"context_line":"        else:"},{"line_number":119,"context_line":"            self._create_keypair(public_key\u003dpublic_key, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_8e8d0b7e","line":117,"updated":"2016-10-10 20:50:27.000000000","message":"Why not just to pass public_key through kwargs any time? https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/keypairs.py#L91 public_key has default value None. So it accept None as a value","commit_id":"acf7a807edc4b5fe98f58c4ae8a5bd6f51398fbb"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"370472195af4fcfd80677f439e92621cdf60ffe9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        :param kwargs: Optional additional arguments for keypair creation"},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if public_key \u003d\u003d \"None\":"},{"line_number":117,"context_line":"            public_key\u003dNone"},{"line_number":118,"context_line":"        self._create_keypair(public_key\u003dpublic_key, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_4f34ff48","line":116,"updated":"2016-10-14 22:36:18.000000000","message":"This is the problem of users that they set \"None\" as a string in parameter that except string values. We should remove it. Its wrong public key","commit_id":"5b0dcdf44bb3c76811fdbcdc1d648f05e97edd96"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"7910975bfbba9479d31bd1402fe486ebd19040d9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        :param kwargs: Optional additional arguments for keypair creation"},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if public_key \u003d\u003d \"None\":"},{"line_number":117,"context_line":"            public_key\u003dNone"},{"line_number":118,"context_line":"        self._create_keypair(public_key\u003dpublic_key, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_283bfe9d","line":116,"in_reply_to":"fa6399be_4f34ff48","updated":"2016-10-20 07:25:51.000000000","message":"the scenario need public_key to test,but user maybe have not that public_key, how to do? what should I set the public_key value in sample?  I had aleardy created public_key in rally-jobs/extra/","commit_id":"5b0dcdf44bb3c76811fdbcdc1d648f05e97edd96"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6d15310cd3a31d8e60d0f901417543f970e56df","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self._delete_server(server)"},{"line_number":100,"context_line":"        self._delete_keypair(keypair)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"@validation.required_services(consts.Service.NOVA)"},{"line_number":104,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":105,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6895a0_34d8ad53","line":102,"updated":"2016-10-21 17:47:55.000000000","message":"`file_exists` validator should be used for public_key argument.\n\nhttps://git.openstack.org/cgit/openstack/rally/tree/rally/task/validation.py#n149","commit_id":"4ffed771661a17b40a833075a8894aef787e405d"}],"samples/tasks/scenarios/nova/create-keypair-with-public-key.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"NovaKeypair.create_keypair_with_public_key\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"           \"args\": {"},{"line_number":5,"context_line":"               \"public_key\": \"/root/.ssh/public_key\""},{"line_number":6,"context_line":"           },"},{"line_number":7,"context_line":"           \"runner\": {"},{"line_number":8,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":1,"id":"5a8bc5a2_94673eb6","line":5,"updated":"2016-09-26 11:20:30.000000000","message":"better to set it to None. User may not have file by this path","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                    \"users_per_tenant\": 2"},{"line_number":16,"context_line":"                }"},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        }"},{"line_number":19,"context_line":"    ]"},{"line_number":20,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"5a8bc5a2_34982ac0","line":18,"updated":"2016-09-26 11:20:30.000000000","message":"please add sla section","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"}],"samples/tasks/scenarios/nova/create-keypair-with-public-key.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  NovaKeypair.create_keypair_with_public_key:"},{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"     args:"},{"line_number":5,"context_line":"       public_key: \"/root/.ssh/public_key\""},{"line_number":6,"context_line":"     runner:"},{"line_number":7,"context_line":"       type: \"constant\""},{"line_number":8,"context_line":"       times: 10"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_d46466ba","line":5,"updated":"2016-09-26 11:20:30.000000000","message":"better to set it to None. User may not have file by this path","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e305a104b5d7097fb1d101fdfcb971318f025d98","unresolved":false,"context_lines":[{"line_number":10,"context_line":"     context:"},{"line_number":11,"context_line":"       users:"},{"line_number":12,"context_line":"         tenants: 3"},{"line_number":13,"context_line":"         users_per_tenant: 2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_14f6cef8","line":13,"updated":"2016-09-26 11:20:30.000000000","message":"please add sla","commit_id":"7973104da9826cbd897a75ce55f3888dc7f32bdc"}]}
