)]}'
{"rally-jobs/rally-keystone-api-v2.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9210e7f405c94adc4afb4967f9874dc1d396f1d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{%- set cirros_image_url \u003d \"http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\" %}"},{"line_number":2,"context_line":"---"},{"line_number":3,"context_line":"  KeystoneBasic.get_token:"},{"line_number":4,"context_line":"    -"},{"line_number":5,"context_line":"      args:"},{"line_number":6,"context_line":"        username: \"admin\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a95cdbc_63a73abd","line":3,"updated":"2016-10-08 06:53:43.000000000","message":"it failed http://logs.openstack.org/97/377397/4/check/gate-rally-dsvm-keystone-v2api-rally/a8d6162/rally-plot/results.html.gz#/KeystoneBasic.get_token/failures","commit_id":"ab42c93026aa180eabb6b30dd24afc1d0b38f763"}],"rally/plugins/openstack/scenarios/keystone/basic.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"79d3352a67580b097a376c057a936216ca7e4dbc","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@validation.required_openstack(admin\u003dTrue)"},{"line_number":26,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"keystone\"]},"},{"line_number":27,"context_line":"                    name\u003d\"KeystoneBasic.get_token\")"},{"line_number":28,"context_line":"class GetToken(kutils.KeystoneScenario):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @logging.log_deprecated_args("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_c07c2223","line":27,"updated":"2016-09-28 21:15:29.000000000","message":"please add @validation.required_api_versions(component\u003d\"keystone\", versions\u003d[2.0])","commit_id":"ca8ae06e0cc219625b4bbcade7715807c4a3cdea"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"79d3352a67580b097a376c057a936216ca7e4dbc","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @logging.log_deprecated_args("},{"line_number":31,"context_line":"        \"The \u0027name_length\u0027 argument to get token is ignored\","},{"line_number":32,"context_line":"        \"0.1.2\", [\"name_length\"], once\u003dTrue)"},{"line_number":33,"context_line":"    def run(self, username\u003dNone, password\u003dNone, name_length\u003d10, **kwargs):"},{"line_number":34,"context_line":"        \"\"\"get token with username and password."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_2e63feb2","line":32,"updated":"2016-09-28 21:15:29.000000000","message":"Don\u0027t add name_length. Its already deprecated.","commit_id":"ca8ae06e0cc219625b4bbcade7715807c4a3cdea"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4f4ed458b5c026f94f0fe2b551f1e3d5ee2aee5c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                    name\u003d\"KeystoneBasic.get_token\")"},{"line_number":29,"context_line":"class GetToken(kutils.KeystoneScenario):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def run(self, username\u003dNone, password\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"get token with username and password."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        :param kwargs: Other optional parameters to get token like"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_f492a04a","line":31,"updated":"2016-09-29 11:49:03.000000000","message":"Think that they shouldn\u0027t have default values https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v2_0/tokens.py#L53","commit_id":"214d1aabae5253281bef485c913a97eb6145194f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9210e7f405c94adc4afb4967f9874dc1d396f1d7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                    name\u003d\"KeystoneBasic.get_token\")"},{"line_number":29,"context_line":"class GetToken(kutils.KeystoneScenario):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def run(self, username\u003d\"admin\", password\u003d\"myadminpass\", **kwargs):"},{"line_number":32,"context_line":"        \"\"\"get token with username and password."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        :param kwargs: Other optional parameters to get token like"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_e3c8aa57","line":31,"updated":"2016-10-08 06:53:43.000000000","message":"lets us use default values that are used in https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v2_0/tokens.py#L44\nI mean admin-\u003eNone, myadminpass-\u003eNone","commit_id":"ab42c93026aa180eabb6b30dd24afc1d0b38f763"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":25,"context_line":"@validation.required_openstack(admin\u003dTrue)"},{"line_number":26,"context_line":"@validation.required_api_versions(component\u003d\"keystone\", versions\u003d[2.0])"},{"line_number":27,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"keystone\"]},"},{"line_number":28,"context_line":"                    name\u003d\"KeystoneBasic.get_token\")"},{"line_number":29,"context_line":"class GetToken(kutils.KeystoneScenario):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def run(self, username\u003dNone, password\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_24065e86","line":28,"updated":"2016-10-13 11:15:34.000000000","message":"Rename it please to the proper name from keystoneclient authenticate_token","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"}],"rally/plugins/openstack/scenarios/keystone/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class KeystoneScenario(scenario.OpenStackScenario):"},{"line_number":23,"context_line":"    \"\"\"Base class for Keystone scenarios with basic atomic actions.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @atomic.action_timer(\"keystone.get_token\")"},{"line_number":26,"context_line":"    def _get_token(self, username, password, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"Get token with username and password."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_e4ef06e7","line":25,"updated":"2016-10-13 11:15:34.000000000","message":"keystone.authenticate_token","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Base class for Keystone scenarios with basic atomic actions.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @atomic.action_timer(\"keystone.get_token\")"},{"line_number":26,"context_line":"    def _get_token(self, username, password, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"Get token with username and password."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param kwargs: Other optional parameters to get token like"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_e418e620","line":26,"updated":"2016-10-13 11:15:34.000000000","message":"_authenticate_token\nutils function also should have default values like in scenario","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _get_token(self, username, password, **kwargs):"},{"line_number":27,"context_line":"        \"\"\"Get token with username and password."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param kwargs: Other optional parameters to get token like"},{"line_number":30,"context_line":"                        \"tenantname\"."},{"line_number":31,"context_line":"        :returns: token"},{"line_number":32,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_a4d7f221","line":29,"updated":"2016-10-13 11:15:34.000000000","message":"Not all parameter documented","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"}],"rally/plugins/openstack/wrappers/keystone.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9210e7f405c94adc4afb4967f9874dc1d396f1d7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        self.client.users.delete(user_id)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def get_token(self,username, password):"},{"line_number":150,"context_line":"        return self.client.tokens.authenticate(username, password)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def list_users(self):"},{"line_number":153,"context_line":"        return map(KeystoneV2Wrapper._wrap_v2_user, self.client.users.list())"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_c3a64ead","line":150,"updated":"2016-10-08 06:53:43.000000000","message":"this is not used elsewhere. So please use it. Also why it used in wrappers if we can use it only in v2 version? Thus we will not have analogue in v3 and thus its useless","commit_id":"ab42c93026aa180eabb6b30dd24afc1d0b38f763"}],"samples/tasks/scenarios/keystone/get-token.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4f4ed458b5c026f94f0fe2b551f1e3d5ee2aee5c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"type\": \"constant\","},{"line_number":7,"context_line":"                \"times\": 100,"},{"line_number":8,"context_line":"                \"concurrency\":10"},{"line_number":9,"context_line":"            }"},{"line_number":10,"context_line":"        }"},{"line_number":11,"context_line":"    ]"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"3a98d1f4_f4b9c0cc","line":9,"updated":"2016-09-29 11:49:03.000000000","message":"please add sla section","commit_id":"214d1aabae5253281bef485c913a97eb6145194f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"KeystoneBasic.get_token\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {\"username\": \"admin\",\"password\":\"myadminpass\"},"},{"line_number":5,"context_line":"            \"runner\": {"},{"line_number":6,"context_line":"                \"type\": \"constant\","},{"line_number":7,"context_line":"                \"times\": 100,"}],"source_content_type":"application/json","patch_set":6,"id":"fa6399be_c4da02e8","line":4,"updated":"2016-10-13 11:15:34.000000000","message":"please fix an identation","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            \"sla\": {"},{"line_number":11,"context_line":"                \"failure_rate\": {"},{"line_number":12,"context_line":"                \"max\": 0"},{"line_number":13,"context_line":"                }"},{"line_number":14,"context_line":"            }"},{"line_number":15,"context_line":"        }"}],"source_content_type":"application/json","patch_set":6,"id":"fa6399be_b821bcb6","line":12,"updated":"2016-10-13 11:15:34.000000000","message":"please fix an indention and add user context with tenants 2 and users_per_tenant: 2","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"}],"samples/tasks/scenarios/keystone/get-token.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4f4ed458b5c026f94f0fe2b551f1e3d5ee2aee5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      runner:"},{"line_number":8,"context_line":"        type: \"constant\""},{"line_number":9,"context_line":"        times: 100"},{"line_number":10,"context_line":"        concurrency: 10"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a98d1f4_34b408d0","line":10,"updated":"2016-09-29 11:49:03.000000000","message":"please add sla section","commit_id":"214d1aabae5253281bef485c913a97eb6145194f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"342a8711bcb65f083377a1207e6b2dee0b3bd019","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      runner:"},{"line_number":8,"context_line":"        type: \"constant\""},{"line_number":9,"context_line":"        times: 100"},{"line_number":10,"context_line":"        concurrency: 10"},{"line_number":11,"context_line":"      sla:"},{"line_number":12,"context_line":"        failure_rate:"},{"line_number":13,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa6399be_0a396ba4","line":10,"updated":"2016-10-13 11:15:34.000000000","message":"add user context with tenants 2 and users_per_tenant: 2","commit_id":"c093d2cce22b10e1eec4f29445a1d2961350f92c"}]}