)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8a8ee1d89892127a204cb44b03890ba30213bbd5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      context:"},{"line_number":136,"context_line":"        users:"},{"line_number":137,"context_line":"          tenants: {{smoke or 5}}"},{"line_number":138,"context_line":"          users_per_tenant: {{smoke or 1}}"},{"line_number":139,"context_line":"        quotas:"},{"line_number":140,"context_line":"          neutron:"},{"line_number":141,"context_line":"             floatingip: -1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_279d7dbc","line":138,"updated":"2016-10-13 12:10:50.000000000","message":"please increase it.\n{{smoke or 2}}","commit_id":"953d5ebc4d37563c41cd32621ccf9049565d6947"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d29ac4abcbd7d9cdd74253155b8621e796dd8609","unresolved":false,"context_lines":[{"line_number":78,"context_line":"              end: \"193.168.73.90\""},{"line_number":79,"context_line":"        subnet_cidr: \"193.168.73.0/16\""},{"line_number":80,"context_line":"        floating_ip_args:"},{"line_number":81,"context_line":"          floating_ip_address: \"193.168.73.88\""},{"line_number":82,"context_line":"      runner:"},{"line_number":83,"context_line":"        type: \"constant\""},{"line_number":84,"context_line":"        times: {{smoke or 1}}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a629dbe_43d57cb7","line":81,"updated":"2016-11-14 11:14:10.000000000","message":"This limits scenario to single iteration, which makes testing not very useful.\n\nCan this scenario create many FIPs ?","commit_id":"d683d70f237a0d866bc9f3b625172f298a5819e1"}],"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":349,"context_line":"    @validation.external_network_exists(\"floating_network\")"},{"line_number":350,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":351,"context_line":"    def create_and_list_static_floating_ips(self, floating_network\u003dNone,"},{"line_number":352,"context_line":"                                            floating_ip_address\u003dNone,"},{"line_number":353,"context_line":"                                            floating_ip_args\u003dNone):"},{"line_number":354,"context_line":"        \"\"\"Create a static floatingip and then list static floating IPs."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_9aa20afc","line":351,"updated":"2016-10-07 10:29:51.000000000","message":"Please move scenario under class base. See an example in other scenarios","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        :param floating_ip_args: dict, POST /floatingips request options"},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":364,"context_line":"        floating_ip_address \u003d floating_ip_address"},{"line_number":365,"context_line":"        self._create_static_floatingip(floating_network, floating_ip_address,"},{"line_number":366,"context_line":"                                       **floating_ip_args)"},{"line_number":367,"context_line":"        self._list_floating_ips()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_9a7bea8b","line":364,"updated":"2016-10-07 10:29:51.000000000","message":"What does it mean?","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8a8ee1d89892127a204cb44b03890ba30213bbd5","unresolved":false,"context_lines":[{"line_number":374,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":375,"context_line":"@validation.external_network_exists(\"floating_network\")"},{"line_number":376,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":377,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_static_floating_ips\")"},{"line_number":378,"context_line":"class CreateAndListStaticFloatingIps(utils.NeutronScenario):"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def run(self, floating_network\u003dNone, floating_ip_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_2701fd05","line":377,"updated":"2016-10-13 12:10:50.000000000","message":"please rename scenario to\ncreate_list_and_delete_floating_ip","commit_id":"953d5ebc4d37563c41cd32621ccf9049565d6947"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8a8ee1d89892127a204cb44b03890ba30213bbd5","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        :param floating_ip_args: dict, POST /floatingips request options"},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":391,"context_line":"        floating_ip \u003d self._create_floatingip(floating_network,"},{"line_number":392,"context_line":"                                              **floating_ip_args)"},{"line_number":393,"context_line":"        self._list_floating_ips()"},{"line_number":394,"context_line":"        self._delete_floating_ip(floating_ip[\"floatingip\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_c74a0126","line":391,"updated":"2016-10-13 12:10:50.000000000","message":"http://logs.openstack.org/60/380060/2/check/gate-rally-dsvm-neutron-rally/1c626a9/rally-plot/results.html.gz#/NeutronNetworks.create_and_list_static_floating_ips/failures\n\nLooks like it disallowed by Neutron policy to create floating_ip with specified ip","commit_id":"953d5ebc4d37563c41cd32621ccf9049565d6947"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d29ac4abcbd7d9cdd74253155b8621e796dd8609","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        :param floating_ip_args: dict, POST /floatingips request options"},{"line_number":389,"context_line":"        \"\"\""},{"line_number":390,"context_line":"        network \u003d self._create_network(network_create_args or {})"},{"line_number":391,"context_line":"        subnet \u003d self._create_subnet(network, subnet_create_args, subnet_cidr)"},{"line_number":392,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":393,"context_line":"        floating_ip \u003d self._create_floatingip(network[\"network\"][\"name\"],"},{"line_number":394,"context_line":"                                              **floating_ip_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_a3dad815","line":391,"updated":"2016-11-14 11:14:10.000000000","message":"Use `subnet_create_args or {}\u0027, otherwise there will be AttributeError in case if subnet_create_args are not explicitly passed to scenario (None hasn\u0027t method `get()\u0027)\n\nhttps://github.com/openstack/rally/blob/0.7.0/rally/plugins/openstack/scenarios/neutron/utils.py#L110","commit_id":"d683d70f237a0d866bc9f3b625172f298a5819e1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"321ceba8dae0e28ff1b10a594faf92d9b833d304","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":413,"context_line":"        if not floating_ip_args[\"floating_ip_address\"]:"},{"line_number":414,"context_line":"            net \u003d ip.IPNetwork(subnet_create_args[\"cidr\"])"},{"line_number":415,"context_line":"            ips \u003d [net[0], net[1], net[-1]]"},{"line_number":416,"context_line":"            while True:"},{"line_number":417,"context_line":"                ip_addr \u003d random.choice(net)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_ede8e4e4","line":414,"updated":"2016-11-24 23:51:03.000000000","message":"we could get here traceback https://github.com/drkjam/netaddr/blob/rel-0.7.x/netaddr/ip/__init__.py#L924","commit_id":"d6e1ab88f81da38ebdf881d779ffe455f4dbe376"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"321ceba8dae0e28ff1b10a594faf92d9b833d304","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":413,"context_line":"        if not floating_ip_args[\"floating_ip_address\"]:"},{"line_number":414,"context_line":"            net \u003d ip.IPNetwork(subnet_create_args[\"cidr\"])"},{"line_number":415,"context_line":"            ips \u003d [net[0], net[1], net[-1]]"},{"line_number":416,"context_line":"            while True:"},{"line_number":417,"context_line":"                ip_addr \u003d random.choice(net)"},{"line_number":418,"context_line":"                if ip_addr not in ips:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_ad9a6c61","line":415,"updated":"2016-11-24 23:51:03.000000000","message":"do we have always directly 3 nets in net?\nwe have 2 potential bugs here:\n1) IndexError(i\u0027m not sure)\n2) endless cycle in 416 line","commit_id":"d6e1ab88f81da38ebdf881d779ffe455f4dbe376"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"321ceba8dae0e28ff1b10a594faf92d9b833d304","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        network \u003d self._create_network(network_create_args or {})"},{"line_number":424,"context_line":"        self._create_subnet(network, subnet_create_args or {})"},{"line_number":425,"context_line":"        self._create_floatingip(network[\"network\"][\"name\"],"},{"line_number":426,"context_line":"                                **floating_ip_args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_6d05b478","line":425,"updated":"2016-11-24 23:51:03.000000000","message":"Guess we still aren\u0027t create multiple fips in scenario. So what is the actual anwer to @Alexander question previosly \"This limits scenario to single iteration, which makes testing not very useful.\nCan this scenario create many FIPs ?\" ? Are you going to maintain this? If no, then why?","commit_id":"d6e1ab88f81da38ebdf881d779ffe455f4dbe376"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    @atomic.action_timer(\"neutron.create_static_floating_ip\")"},{"line_number":451,"context_line":"    def _create_static_floatingip(self, floating_network, floating_ip_address,"},{"line_number":452,"context_line":"                                  **floating_ip_args):"},{"line_number":453,"context_line":"        \"\"\"Create a static floating IP with floating_network."},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        param: floating_network: str, external network to create floating IP"},{"line_number":456,"context_line":"        param: floating_ip_args: dict, POST /floatingips create options"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_bac8a6a9","line":453,"updated":"2016-10-07 10:29:51.000000000","message":"Why its static? https://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/floatingip.py#L44","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"}],"samples/tasks/scenarios/neutron/create-and-list-static-floating-ips.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            \"runner\": {"},{"line_number":10,"context_line":"                \"type\": \"constant\","},{"line_number":11,"context_line":"                \"times\": 1,"},{"line_number":12,"context_line":"                \"concurrency\": 1"},{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"}],"source_content_type":"application/json","patch_set":1,"id":"1a95cdbc_fad06e21","line":11,"updated":"2016-10-07 10:29:51.000000000","message":"please increase it to 2","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            \"runner\": {"},{"line_number":10,"context_line":"                \"type\": \"constant\","},{"line_number":11,"context_line":"                \"times\": 1,"},{"line_number":12,"context_line":"                \"concurrency\": 1"},{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"},{"line_number":15,"context_line":"                \"users\": {"}],"source_content_type":"application/json","patch_set":1,"id":"1a95cdbc_1acefa81","line":12,"updated":"2016-10-07 10:29:51.000000000","message":"please increase it to 2","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        \"floatingip\": -1"},{"line_number":22,"context_line":"                    }"},{"line_number":23,"context_line":"                }"},{"line_number":24,"context_line":"            }"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":"    ]"},{"line_number":27,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"1a95cdbc_fae94ee7","line":24,"updated":"2016-10-07 10:29:51.000000000","message":"please add sla section","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8a8ee1d89892127a204cb44b03890ba30213bbd5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"runner\": {"},{"line_number":11,"context_line":"                \"type\": \"constant\","},{"line_number":12,"context_line":"                \"times\": 5,"},{"line_number":13,"context_line":"                \"concurrency\": 1"},{"line_number":14,"context_line":"            },"},{"line_number":15,"context_line":"            \"context\": {"},{"line_number":16,"context_line":"                \"users\": {"}],"source_content_type":"application/json","patch_set":2,"id":"fa6399be_676cd5d0","line":13,"updated":"2016-10-13 12:10:50.000000000","message":"increase it to 2","commit_id":"953d5ebc4d37563c41cd32621ccf9049565d6947"}],"samples/tasks/scenarios/neutron/create-and-list-static-floating-ips.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          users_per_tenant: 3"},{"line_number":16,"context_line":"        quotas:"},{"line_number":17,"context_line":"          neutron:"},{"line_number":18,"context_line":"            floatingip: -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_1a7c3a1e","line":18,"updated":"2016-10-07 10:29:51.000000000","message":"the same comments as in json sample","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"}],"samples/tasks/scenarios/neutron/create-list-and-delete-floating-ip.json":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d29ac4abcbd7d9cdd74253155b8621e796dd8609","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \"runner\": {"},{"line_number":23,"context_line":"                \"type\": \"constant\","},{"line_number":24,"context_line":"                \"times\": 1,"},{"line_number":25,"context_line":"                \"concurrency\": 3"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \"context\": {"},{"line_number":28,"context_line":"                \"users\": {"}],"source_content_type":"application/json","patch_set":5,"id":"9a629dbe_a3f1f897","line":25,"updated":"2016-11-14 11:14:10.000000000","message":"There is no reason to run 1 iteration with 3 processes","commit_id":"d683d70f237a0d866bc9f3b625172f298a5819e1"}],"tests/unit/plugins/openstack/scenarios/neutron/test_network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":396,"context_line":"         \"floating_ip_args\": {},"},{"line_number":397,"context_line":"         \"floating_ip_address\": \"193.168.73.88\"},"},{"line_number":398,"context_line":"    )"},{"line_number":399,"context_line":"    @ddt.unpack"},{"line_number":400,"context_line":"    def test_create_and_list_static_floating_ips(self, floating_network\u003dNone,"},{"line_number":401,"context_line":"                                                 floating_ip_address\u003dNone,"},{"line_number":402,"context_line":"                                                 floating_ip_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_da9c925f","line":399,"updated":"2016-10-07 10:29:51.000000000","message":"here ddt is useless. Add one more input or remove it","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":799,"context_line":"    @ddt.data("},{"line_number":800,"context_line":"        {\"floating_ip_args\": {\"floating_ip_address\": \"193.168.73.88\"},"},{"line_number":801,"context_line":"         \"floating_network\": \"public\","},{"line_number":802,"context_line":"         \"floating_ip_address\": \"193.168.73.88\"},"},{"line_number":803,"context_line":"    )"},{"line_number":804,"context_line":"    @ddt.unpack"},{"line_number":805,"context_line":"    def test__create_static_floating_ip(self, floating_network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_9abdaab9","line":802,"updated":"2016-10-07 10:29:51.000000000","message":"the same as in previous file","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"664f454043a0fe0c7ec4560d59b13822682ebb75","unresolved":false,"context_lines":[{"line_number":818,"context_line":"        expected_fip_data \u003d {\"floatingip\": args}"},{"line_number":819,"context_line":"        resultant_fip \u003d self.scenario._create_floatingip("},{"line_number":820,"context_line":"            floating_network, **floating_ip_args)"},{"line_number":821,"context_line":"        self.assertEqual(resultant_fip, fip)"},{"line_number":822,"context_line":"        self.clients(\"neutron\").create_floatingip.assert_called_once_with("},{"line_number":823,"context_line":"            expected_fip_data)"},{"line_number":824,"context_line":"        mock_get_network_id.assert_called_once_with(floating_network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_7adffe0c","line":821,"updated":"2016-10-07 10:29:51.000000000","message":"wrong order of parameters","commit_id":"85385ca7a41f6e9eff91780176c66fd7fb515a4b"}]}
