)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     astaroverov \u003castaroverov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-10 15:03:31 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Proposal for new rally.osclients base class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia412dbcc675166029942f38bfa500d7a349c9d46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_1fdf753a","line":7,"updated":"2016-10-10 16:23:48.000000000","message":"add tag [spec] in start of title","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"}],"doc/specs/in-progress/rally_osclient_base_class.rst":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Base class for \u0027rally.osclients\u0027 plugin"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implement parrent class for class-aggregator \u0027rally.osclients.Clients\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_ff7ac975","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":17},"updated":"2016-10-10 16:23:48.000000000","message":"s/parrent/parent","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":47,"context_line":"..code-block:: python"},{"line_number":48,"context_line":"    @plugin.base()"},{"line_number":49,"context_line":"    class Client(plugin.Plugin):"},{"line_number":50,"context_line":"        def __init__(self, env, system_config, **kwargs):"},{"line_number":51,"context_line":"            self.env \u003d env"},{"line_number":52,"context_line":"            self.system_config \u003d system_config"},{"line_number":53,"context_line":"            # kwargs can be used for client initialization"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_9f4f0533","line":50,"range":{"start_line":50,"start_character":32,"end_line":50,"end_character":45},"updated":"2016-10-10 16:23:48.000000000","message":"please leave a comment that this variable should cover `api_versions`, which theoretically can\u0027t cover different cloud settings","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            self._kwargs \u003d kwargs"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"3. Class rally.oscients.Clients should be renamed as"},{"line_number":57,"context_line":"OpenstackClients and based on new class Class without any changes"},{"line_number":58,"context_line":"of methods of class:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"..code-block:: python"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_ff5649cc","line":57,"range":{"start_line":57,"start_character":40,"end_line":57,"end_character":45},"updated":"2016-10-10 16:23:48.000000000","message":"s/Class/Client","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            self._kwargs \u003d kwargs"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"3. Class rally.oscients.Clients should be renamed as"},{"line_number":57,"context_line":"OpenstackClients and based on new class Class without any changes"},{"line_number":58,"context_line":"of methods of class:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"..code-block:: python"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_5f701d72","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":16},"updated":"2016-10-10 16:23:48.000000000","message":"s/OpenstackClients/OpenStackClients","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"29e9854501b37bfcfafbbeb75484b87cd1f10068","unresolved":false,"context_lines":[{"line_number":64,"context_line":"          …"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"4. All new plugins should have the same name, ‘base_client’, for"},{"line_number":67,"context_line":"example, and contains following code implementation:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"..code-block:: python"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_5ff73dd2","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":52},"updated":"2016-10-10 16:23:48.000000000","message":"plugins should not contain following implementation. This code looks more like an example of unified usage if clients in task engine.","commit_id":"ebd0c819f4beafc0d07b2ac68c5e1a151f1f6ee5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Current implementation of openstack clients realizes support"},{"line_number":27,"context_line":"of multi-plugin architecture, but other systems have one entry-point"},{"line_number":28,"context_line":"per client. In that case, usage of multi-plugin architecture is"},{"line_number":29,"context_line":"useless."},{"line_number":30,"context_line":"Also current realization of ‘rally.osclients’ is one of the few"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_6b4fce33","line":27,"updated":"2016-11-13 14:08:38.000000000","message":"I want you to pay more our attention, in the proposed change section, on how actually your solution will differ from our common plugin stuff. I saw some renaming and transfer plugins to proper place. But how this will adapt us to `one entry-point per client` problem?","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"of multi-plugin architecture, but other systems have one entry-point"},{"line_number":28,"context_line":"per client. In that case, usage of multi-plugin architecture is"},{"line_number":29,"context_line":"useless."},{"line_number":30,"context_line":"Also current realization of ‘rally.osclients’ is one of the few"},{"line_number":31,"context_line":"hardcoded places to OpenStack, which prevents to use Rally with"},{"line_number":32,"context_line":"wider infrastructure."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_9591a149","line":30,"updated":"2016-11-13 14:08:38.000000000","message":"realization vs implementation\nI think the second one would be better here","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"useless."},{"line_number":30,"context_line":"Also current realization of ‘rally.osclients’ is one of the few"},{"line_number":31,"context_line":"hardcoded places to OpenStack, which prevents to use Rally with"},{"line_number":32,"context_line":"wider infrastructure."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_9539a1a6","line":32,"updated":"2016-11-13 14:08:38.000000000","message":"what does mean here \"wider infrastructure\"?","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"1. All current clients can be moved into rally.plugins.openstack"},{"line_number":38,"context_line":"directory"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"2. Create new base class for all clients:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. code-block:: python"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_40cae46f","line":40,"updated":"2016-11-13 14:08:38.000000000","message":"From the snippets below I understand that Client is the base class for aggregator-classes not the replacement of the current OSClient(base class for all current clients)","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.env \u003d env"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            # this variable should cover \u0027api_versions\u0027, which theoretically"},{"line_number":50,"context_line":"            # can\u0027t cover different cloud settings"},{"line_number":51,"context_line":"            self.system_config \u003d system_config"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            # kwargs can be used for client initialization"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_d0fc0774","line":50,"updated":"2016-11-13 14:08:38.000000000","message":"what do you mean under `cloud settings`, could you provide an example? What we should pass here and not to pass to kwargs?","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. code-block:: python"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"     @plugin.base()"},{"line_number":63,"context_line":"     class OpenStackClients(Clients):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_ebf4bef1","line":62,"updated":"2016-11-13 14:08:38.000000000","message":"guess it is not base class","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":60,"context_line":".. code-block:: python"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"     @plugin.base()"},{"line_number":63,"context_line":"     class OpenStackClients(Clients):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"4. All new plugins should have the same name, ‘base_client’, for"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_abee461f","line":63,"updated":"2016-11-13 14:08:38.000000000","message":"it should be complete python snippet.","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"     class OpenStackClients(Clients):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"4. All new plugins should have the same name, ‘base_client’, for"},{"line_number":67,"context_line":"example. Following code is example of unified usage if clients in task engine:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_4be68a44","line":66,"updated":"2016-11-13 14:08:38.000000000","message":"I don\u0027t understand what you mean here except all openstack client plugins should keep an old name for compatibility","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cf4ae32e23575c030576ec514779c8f952daca1e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"rally.osclients"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_b1916249","line":98,"updated":"2016-11-13 14:08:38.000000000","message":"what does it mean? Here should be something like:\nRename Clients to OpenStackClients\nMove all openstack clients implementations to...\nCreate new base class\nCreate new aggregator class like OpenStackClients for non-openstack clients (on-demand)","commit_id":"d5bfb28c9d11b07e342503a5e29a1c2c32db7631"}]}
