)]}'
{"rally/plugins/openstack/hook/fault_injection.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0662dc9742d363cb9333ca454e01f1929c09a493","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @staticmethod"},{"line_number":45,"context_line":"    def get_cloud_config():"},{"line_number":46,"context_line":"        deployment_uuid \u003d envutils.get_global(envutils.ENV_DEPLOYMENT)"},{"line_number":47,"context_line":"        deployment \u003d api.Deployment.get(deployment_uuid)"},{"line_number":48,"context_line":"        deployment_config \u003d deployment[\"config\"]"},{"line_number":49,"context_line":"        if deployment_config[\"type\"] !\u003d \"ExistingCloud\":"},{"line_number":50,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_12ed9c8b","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":56},"updated":"2016-10-26 10:16:21.000000000","message":"you should not do like that. Rally supports --deployment cli argument. In this case real deployment uuid will be not the same as env_deployment. Also, env_deployment can be missed due to usage of \"--no-use\" argument while creating deployment.\n\nsolution: hook has self.task property. It should be instance of https://github.com/openstack/rally/blob/master/rally/common/objects/task.py#L319 . Task object should include both deployment_uuid item and full deployment object","commit_id":"875f168688fce2edc628f28eee8fd595292098ef"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0662dc9742d363cb9333ca454e01f1929c09a493","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if deployment_config[\"type\"] !\u003d \"ExistingCloud\":"},{"line_number":50,"context_line":"            return None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        extra_config \u003d deployment_config.get(\"extra\", {})"},{"line_number":53,"context_line":"        return extra_config.get(\"cloud_config\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def run(self):"},{"line_number":56,"context_line":"        # get cloud configuration"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_52ad5430","line":53,"range":{"start_line":52,"start_character":8,"end_line":53,"end_character":47},"updated":"2016-10-26 10:16:21.000000000","message":"you need to include info about this option in class docstring. It will help users to discover this plugin with rally plugin show","commit_id":"875f168688fce2edc628f28eee8fd595292098ef"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6ffbe50c7015b5bbd879bd0952bce345b2a617f7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        action - string that represents an action (more info in [1])"},{"line_number":32,"context_line":"        verify - whether to verify connection to cloud nodes or not"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This plugin discovers config of ExistingCloud[\"config\"][\"extra\"]"},{"line_number":35,"context_line":"    and looks for \"cloud_config\" field. If cloud_config is present then"},{"line_number":36,"context_line":"    it will be used to connect to the cloud by os-faults."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_0e771b3b","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":68},"updated":"2016-10-27 13:16:26.000000000","message":"Please, replace to something like: \"This plugin works only with ExistingClooud deployment and discovers config from \u0027extra\u0027 property of deployment\". Also, it would be nice to note expected format or at least add a link about it.","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0e314d3b04ea7b689011fcd5eac1f931201b8f19","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        action - string that represents an action (more info in [1])"},{"line_number":32,"context_line":"        verify - whether to verify connection to cloud nodes or not"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This plugin discovers config of ExistingCloud[\"config\"][\"extra\"]"},{"line_number":35,"context_line":"    and looks for \"cloud_config\" field. If cloud_config is present then"},{"line_number":36,"context_line":"    it will be used to connect to the cloud by os-faults."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_0e78fbf1","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":68},"in_reply_to":"ba5da102_0e771b3b","updated":"2016-10-27 13:22:51.000000000","message":"Actually, it works with other deployments if os-faults configuration provided with OS_FAULTS_CONFIG env variable.\nAll information is available in provided link [1].","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"6d95274d8f2fe91d3e6947cd25b44db03254801e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        action - string that represents an action (more info in [1])"},{"line_number":32,"context_line":"        verify - whether to verify connection to cloud nodes or not"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This plugin discovers config of ExistingCloud[\"config\"][\"extra\"]"},{"line_number":35,"context_line":"    and looks for \"cloud_config\" field. If cloud_config is present then"},{"line_number":36,"context_line":"    it will be used to connect to the cloud by os-faults."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_29abf975","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":68},"in_reply_to":"ba5da102_0e78fbf1","updated":"2016-10-27 13:45:27.000000000","message":"Added this information to docstring.","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6ffbe50c7015b5bbd879bd0952bce345b2a617f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"},{"line_number":44,"context_line":"        \"properties\": {"},{"line_number":45,"context_line":"            \"action\": {\"type\": \"string\"},"},{"line_number":46,"context_line":"            \"verify\": {\"type\": \"boolean\"},"},{"line_number":47,"context_line":"        },"},{"line_number":48,"context_line":"        \"required\": ["},{"line_number":49,"context_line":"            \"action\","}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_2eabff75","line":46,"updated":"2016-10-27 13:16:26.000000000","message":"should we allow setting cloud_config  directly throw hook config? it can help to use os-faults plugin in case of pre-created deployment without specified \"extra\" field","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6ffbe50c7015b5bbd879bd0952bce345b2a617f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def get_cloud_config(self):"},{"line_number":55,"context_line":"        deployment \u003d api.Deployment.get(self.task[\"deployment_uuid\"])"},{"line_number":56,"context_line":"        deployment_config \u003d deployment[\"config\"]"},{"line_number":57,"context_line":"        if deployment_config[\"type\"] !\u003d \"ExistingCloud\":"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        extra_config \u003d deployment_config.get(\"extra\", {})"},{"line_number":61,"context_line":"        return extra_config.get(\"cloud_config\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def run(self):"},{"line_number":64,"context_line":"        # get cloud configuration"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_eec74743","line":61,"range":{"start_line":57,"start_character":8,"end_line":61,"end_character":47},"updated":"2016-10-27 13:16:26.000000000","message":"What is expected behavior of os-faults in case of None cloud_config? Should we raise any excpetion in this case?","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0e314d3b04ea7b689011fcd5eac1f931201b8f19","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def get_cloud_config(self):"},{"line_number":55,"context_line":"        deployment \u003d api.Deployment.get(self.task[\"deployment_uuid\"])"},{"line_number":56,"context_line":"        deployment_config \u003d deployment[\"config\"]"},{"line_number":57,"context_line":"        if deployment_config[\"type\"] !\u003d \"ExistingCloud\":"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        extra_config \u003d deployment_config.get(\"extra\", {})"},{"line_number":61,"context_line":"        return extra_config.get(\"cloud_config\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def run(self):"},{"line_number":64,"context_line":"        # get cloud configuration"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_4e4af384","line":61,"range":{"start_line":57,"start_character":8,"end_line":61,"end_character":47},"in_reply_to":"ba5da102_eec74743","updated":"2016-10-27 13:22:51.000000000","message":"we look for OS_FAULTS_CONFIG env variable that points to yaml config if no cloud_config provided.","commit_id":"b7dd60f73af314903a7b0ce85652dd075a823268"}],"requirements.txt":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"59e186131994bbbce6029112d9471b075325ef15","unresolved":false,"context_lines":[{"line_number":28,"context_line":"boto\u003e\u003d2.32.1                                           # MIT"},{"line_number":29,"context_line":"gnocchiclient\u003e\u003d2.2.0                                   # Apache Software License"},{"line_number":30,"context_line":"keystoneauth1\u003e\u003d2.10.0                                  # Apache Software License"},{"line_number":31,"context_line":"os-faults                                              # Apache License, Version 2.0"},{"line_number":32,"context_line":"python-ceilometerclient\u003e\u003d2.5.0                         # Apache Software License"},{"line_number":33,"context_line":"python-cinderclient\u003e\u003d1.6.0,!\u003d1.7.0,!\u003d1.7.1             # Apache Software License"},{"line_number":34,"context_line":"python-cueclient\u003e\u003d1.0.0                                # Apache License, Version 2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"1a95cdbc_01a48ab7","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":9},"updated":"2016-10-10 12:53:47.000000000","message":"will be changed to os-faults\u003e\u003d0.1 after first release of os-faults","commit_id":"df05e61cd5ba1111d62b44a971854639d59c0694"}]}
