)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2f2cd15d5f680e4f2a8f6e8197b7dc1495db78ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangzhang \u003czhangzh.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-25 07:36:26 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova.ListServerInHypervisor scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List all servers belonging to specific hypervisor."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba5da102_a079e531","line":7,"updated":"2016-10-27 08:37:46.000000000","message":"This is inaccurate.","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"478872b5f018743bd6edae6d515897f4e5a6fb60","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangzhang \u003czhangzh.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-25 07:36:26 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova.ListServerInHypervisor scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"List all servers belonging to specific hypervisor."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba5da102_7ae9231a","line":7,"in_reply_to":"ba5da102_a079e531","updated":"2016-10-28 02:46:36.000000000","message":"Done","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"}],"rally/plugins/openstack/scenarios/nova/hypervisors.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6e003fcd43a0e542fb2d37d5ec54af11dd80f8ae","unresolved":false,"context_lines":[{"line_number":65,"context_line":"@validation.required_services(consts.Service.NOVA)"},{"line_number":66,"context_line":"@validation.required_openstack(admin\u003dTrue)"},{"line_number":67,"context_line":"@scenario.configure(name\u003d\"NovaHypervisors.search_hypervisors\")"},{"line_number":68,"context_line":"class SearchHypervisors(utils.NovaScenario):"},{"line_number":69,"context_line":"    def run(self, detailed\u003dTrue):"},{"line_number":70,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_aa9509e5","line":68,"updated":"2016-10-12 13:36:39.000000000","message":"ListAndSearchHypervisors","commit_id":"f793919bf5ec263db3ef9ae6db62e7de3719fcc1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6e003fcd43a0e542fb2d37d5ec54af11dd80f8ae","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def run(self, detailed\u003dTrue):"},{"line_number":70,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        The scenario fist list all hypervisors,then find its hostname,"},{"line_number":73,"context_line":"        then list all servers belonging to the hypervisor"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        Measure the \"nova hypervisor-servers \u003chostname\u003e\" command performance."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8ae1259d","line":72,"updated":"2016-10-12 13:36:39.000000000","message":"typo","commit_id":"f793919bf5ec263db3ef9ae6db62e7de3719fcc1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4d416e3539a61047c8a22216dbf40b64592534a8","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        with atomic.ActionTimer(self, \"nova.get_hypervisor\"):"},{"line_number":61,"context_line":"            for hypervisor in hypervisors:"},{"line_number":62,"context_line":"                self._get_hypervisor(hypervisor)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"@validation.required_services(consts.Service.NOVA)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_18eaa80f","line":62,"updated":"2016-10-13 08:52:54.000000000","message":"Could you fix in the next patch this line too? Here should be passed atomic_action\u003dFalse","commit_id":"6f91b3660041ef949ea99cf458f811ed5fa15315"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"766ef5f9df5517b42b09ba3c7365e9670fbd4606","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\""},{"line_number":102,"context_line":"        hypervisors \u003d self._list_hypervisors(detailed)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        with atomic.ActionTimer(self, \"nova.search_hypervisors\"):"},{"line_number":105,"context_line":"            for hypervisor in hypervisors:"},{"line_number":106,"context_line":"                self._search_hypervisors(hypervisor.hypervisor_hostname,"},{"line_number":107,"context_line":"                                         atomic_action\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_1ec80422","line":104,"updated":"2016-10-24 11:10:45.000000000","message":"It is desirable to know how many hypervisors are searched,\nthis number can be added into atomic action name","commit_id":"b9a8bdfc5664c0472fa930710e1d6e0e9a9c4e66"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6e003fcd43a0e542fb2d37d5ec54af11dd80f8ae","unresolved":false,"context_lines":[{"line_number":876,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"    @atomic.optional_action_timer(\"nova.search_hypervisors\")"},{"line_number":879,"context_line":"    def _search_hypervisors(self, hostname, servers\u003dFalse):"},{"line_number":880,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"        :param host_name: Hypervisor\u0027s host name."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_057266ad","line":879,"updated":"2016-10-12 13:36:39.000000000","message":"first parameter have differ name https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/hypervisors.py#L68","commit_id":"f793919bf5ec263db3ef9ae6db62e7de3719fcc1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6e003fcd43a0e542fb2d37d5ec54af11dd80f8ae","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                              decorator."},{"line_number":886,"context_line":"        :returns: Hypervisor object"},{"line_number":887,"context_line":"        \"\"\""},{"line_number":888,"context_line":"        self.admin_clients(\"nova\").hypervisors.search(hostname, servers\u003dTrue)"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    @atomic.action_timer(\"nova.lock_server\")"},{"line_number":891,"context_line":"    def _lock_server(self, server):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ea3b81e9","line":888,"updated":"2016-10-12 13:36:39.000000000","message":"servers didn\u0027t passed","commit_id":"f793919bf5ec263db3ef9ae6db62e7de3719fcc1"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"83653e7b11fd379fc441571f6ec82cad450c8b89","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        \"\"\""},{"line_number":899,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    def _search_hypervisors(self, hypervisor_match, servers\u003dFalse,"},{"line_number":902,"context_line":"                            atomic_action\u003dFalse):"},{"line_number":903,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":904,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6895a0_a003600c","line":901,"updated":"2016-10-25 08:35:43.000000000","message":"Parameter \"atomic_action\" is not in use. To make it working, add decorator https://github.com/openstack/rally/blob/0.7.0/rally/task/atomic.py#L90","commit_id":"97c36733e2611e05a7785d89a2eefb9088d23459"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2f2cd15d5f680e4f2a8f6e8197b7dc1495db78ca","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        return self.admin_clients(\"nova\").hypervisors.statistics()"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    @atomic.optional_action_timer(\"nova.get_hypervisor\")"},{"line_number":890,"context_line":"    def _get_hypervisor(self, hypervisor, atomic_action\u003dFalse):"},{"line_number":891,"context_line":"        \"\"\"Get a specific hypervisor."},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"        :param hypervisor: Hypervisor to get."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_e0c59d5b","line":890,"updated":"2016-10-27 08:37:46.000000000","message":"The optional_action_timer() decorator adds this kwarg itself, so you don\u0027t need to add it.","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2f2cd15d5f680e4f2a8f6e8197b7dc1495db78ca","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    @atomic.optional_action_timer(\"nova.search_hypervisors\")"},{"line_number":902,"context_line":"    def _search_hypervisors(self, hypervisor_match, servers\u003dFalse,"},{"line_number":903,"context_line":"                            atomic_action\u003dFalse):"},{"line_number":904,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":905,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_8095c141","line":902,"updated":"2016-10-27 08:37:46.000000000","message":"This function is poorly named. _list_servers_in_hypervisor() would be better.","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"478872b5f018743bd6edae6d515897f4e5a6fb60","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        return self.admin_clients(\"nova\").hypervisors.get(hypervisor)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    @atomic.optional_action_timer(\"nova.search_hypervisors\")"},{"line_number":902,"context_line":"    def _search_hypervisors(self, hypervisor_match, servers\u003dFalse,"},{"line_number":903,"context_line":"                            atomic_action\u003dFalse):"},{"line_number":904,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":905,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_1aad87e9","line":902,"in_reply_to":"ba5da102_8095c141","updated":"2016-10-28 02:46:36.000000000","message":"We should keep in line with clients\u0027s function name.\nplease refer to https://review.openstack.org/#/c/365469/1/rally/plugins/openstack/scenarios/nova/utils.py","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2f2cd15d5f680e4f2a8f6e8197b7dc1495db78ca","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    @atomic.optional_action_timer(\"nova.search_hypervisors\")"},{"line_number":902,"context_line":"    def _search_hypervisors(self, hypervisor_match, servers\u003dFalse,"},{"line_number":903,"context_line":"                            atomic_action\u003dFalse):"},{"line_number":904,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        :param hypervisor_match: Hypervisor\u0027s host name."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_00a1b1a9","line":903,"updated":"2016-10-27 08:37:46.000000000","message":"Same here.","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"478872b5f018743bd6edae6d515897f4e5a6fb60","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    @atomic.optional_action_timer(\"nova.search_hypervisors\")"},{"line_number":902,"context_line":"    def _search_hypervisors(self, hypervisor_match, servers\u003dFalse,"},{"line_number":903,"context_line":"                            atomic_action\u003dFalse):"},{"line_number":904,"context_line":"        \"\"\"List all servers belonging to specific hypervisor."},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        :param hypervisor_match: Hypervisor\u0027s host name."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_dacf8fae","line":903,"in_reply_to":"ba5da102_00a1b1a9","updated":"2016-10-28 02:46:36.000000000","message":"ok","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"}],"tests/unit/plugins/openstack/scenarios/nova/test_hypervisors.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4d416e3539a61047c8a22216dbf40b64592534a8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        scenario._list_hypervisors.assert_called_once_with(False)"},{"line_number":50,"context_line":"        scenario._search_hypervisors.assert_called_once_with(\"fake_hostname\","},{"line_number":51,"context_line":"                                                             atomic_action\u003dFalse)"},{"line_number":52,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":53,"context_line":"                                       \"nova.search_hypervisors\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_78456415","line":51,"updated":"2016-10-13 08:52:54.000000000","message":"pep8 failed(","commit_id":"6f91b3660041ef949ea99cf458f811ed5fa15315"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2f2cd15d5f680e4f2a8f6e8197b7dc1495db78ca","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        scenario._list_hypervisors.assert_called_once_with(False)"},{"line_number":68,"context_line":"        scenario._search_hypervisors.assert_called_once_with("},{"line_number":69,"context_line":"            \"fake_hostname\", atomic_action\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_6087cd0f","line":69,"updated":"2016-10-27 08:37:46.000000000","message":"You need to add tests for the atomic action timers.","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"478872b5f018743bd6edae6d515897f4e5a6fb60","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        scenario._list_hypervisors.assert_called_once_with(False)"},{"line_number":68,"context_line":"        scenario._search_hypervisors.assert_called_once_with("},{"line_number":69,"context_line":"            \"fake_hostname\", atomic_action\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_5a8e1f79","line":69,"in_reply_to":"ba5da102_6087cd0f","updated":"2016-10-28 02:46:36.000000000","message":"ok","commit_id":"0c6f2a02cbe844a8e7287618bcd9d2031f50de36"}]}
