)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sunguoshuai \u003csungs@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-13 23:00:39 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add NeutronNetworks.create_and_list_subnetpools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The scenario creates a subnetpool and then"},{"line_number":10,"context_line":"lists all subnetpools."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_349e3407","line":7,"updated":"2016-10-16 10:51:30.000000000","message":"Add NeutronNetworks.create_and_list_subnetpools scenario","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add NeutronNetworks.create_and_list_subnetpools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The scenario creates a subnetpool and then"},{"line_number":10,"context_line":"lists all subnetpools."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieb7380366c895ab023ed24cf57ffdcbb81db9ea7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_948700b4","line":10,"updated":"2016-10-16 10:51:30.000000000","message":"Also add new neutron resource subnetpool and two atomic actions...","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"}],"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          prefixes: [\"10.1.0.0/18\"]"},{"line_number":54,"context_line":"      runner:"},{"line_number":55,"context_line":"        type: \"constant\""},{"line_number":56,"context_line":"        times: {{smoke or 2 }}"},{"line_number":57,"context_line":"        concurrency:  {{smoke or 1}}"},{"line_number":58,"context_line":"      context:"},{"line_number":59,"context_line":"        network: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_f4975ce9","line":56,"updated":"2016-10-16 10:51:30.000000000","message":"please increase it to 20","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      runner:"},{"line_number":55,"context_line":"        type: \"constant\""},{"line_number":56,"context_line":"        times: {{smoke or 2 }}"},{"line_number":57,"context_line":"        concurrency:  {{smoke or 1}}"},{"line_number":58,"context_line":"      context:"},{"line_number":59,"context_line":"        network: {}"},{"line_number":60,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_149bf018","line":57,"updated":"2016-10-16 10:51:30.000000000","message":"please increase it to 10","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"43efedd4676c67973b12cb488d222adb80d4dade","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      context:"},{"line_number":58,"context_line":"        network: {}"},{"line_number":59,"context_line":"        users:"},{"line_number":60,"context_line":"          tenants: {{smoke or 1}}"},{"line_number":61,"context_line":"          users_per_tenant: {{smoke or 1}}"},{"line_number":62,"context_line":"        quotas:"},{"line_number":63,"context_line":"          neutron:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_1148175b","line":60,"updated":"2016-10-18 12:12:50.000000000","message":"please increase it to 2","commit_id":"e181235a490a19861faadef6379b0bd4324d672c"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"43efedd4676c67973b12cb488d222adb80d4dade","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        network: {}"},{"line_number":59,"context_line":"        users:"},{"line_number":60,"context_line":"          tenants: {{smoke or 1}}"},{"line_number":61,"context_line":"          users_per_tenant: {{smoke or 1}}"},{"line_number":62,"context_line":"        quotas:"},{"line_number":63,"context_line":"          neutron:"},{"line_number":64,"context_line":"            network: -1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_31735bb6","line":61,"updated":"2016-10-18 12:12:50.000000000","message":"please increase it to 2","commit_id":"e181235a490a19861faadef6379b0bd4324d672c"}],"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    pass"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"@base.resource(\"neutron\", \"subnetpool\", order\u003dnext(_neutron_order),"},{"line_number":408,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":409,"context_line":"class NeutronSubnetpool(NeutronMixin):"},{"line_number":410,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f4f03c69","line":407,"updated":"2016-10-16 10:51:30.000000000","message":"you should add you resource here https://github.com/openstack/rally/blob/master/tests/ci/osresources.py#L159 too","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"}],"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self._delete_network(network[\"network\"])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"@validation.required_parameters(\"subnetpool_create_args\")"},{"line_number":83,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":84,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":85,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_34e714ad","line":82,"updated":"2016-10-16 10:51:30.000000000","message":"it confuse me. argument has default value at 89 line but its required. Looks like we don\u0027t nee this validator","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"e4af104ff6689d6398dfce632ab42d1a7c034090","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        Measure the \"neutron subnetpool-create\" and \"subnetpool-delete\""},{"line_number":93,"context_line":"        command performance."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param subnetpool_create_args: dict, POST /v2.0/subnetpools"},{"line_number":96,"context_line":"                                       request options"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        self._create_subnetpool(subnetpool_create_args)"},{"line_number":99,"context_line":"        self._list_subnetpools()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_1215f53e","line":96,"range":{"start_line":95,"start_character":9,"end_line":96,"end_character":54},"updated":"2016-10-14 05:11:14.000000000","message":"the subnetpool_create_args,you can explain that Optional additional arguments for subnetpool creation","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                       request options"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        self._create_subnetpool(subnetpool_create_args)"},{"line_number":99,"context_line":"        self._list_subnetpools()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b4fb2446","line":99,"updated":"2016-10-16 10:51:30.000000000","message":"kwargs aren\u0027t passed","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        subnetpool_create_args \u003d subnetpool_create_args or {}"},{"line_number":115,"context_line":"        subnetpool \u003d self._create_subnetpool(subnetpool_create_args)"},{"line_number":116,"context_line":"        msg \u003d \"subnetpool isn\u0027t created\""},{"line_number":117,"context_line":"        self.assertTrue(subnetpool, err_msg\u003dmsg)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        pool_list \u003d self._list_subnetpools()"},{"line_number":120,"context_line":"        msg \u003d (\"subnetpool not included into list of available subnetpools\\n\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_5b732a15","line":117,"updated":"2017-03-03 06:35:27.000000000","message":"Here is inappropriate with using assertTrue. And i think this line is unnecessary.","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"e4af104ff6689d6398dfce632ab42d1a7c034090","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.clients(\"neutron\").delete_network(network[\"id\"])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @atomic.action_timer(\"neutron.create_subnetpool\")"},{"line_number":101,"context_line":"    def _create_subnetpool(self, subnetpool_create_args):"},{"line_number":102,"context_line":"        \"\"\"Create neutron subnetpool."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param subnetpool_create_args: dict, POST /v2.0/subnetpools"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f27081a6","line":101,"range":{"start_line":101,"start_character":33,"end_line":101,"end_character":55},"updated":"2016-10-14 05:11:14.000000000","message":"add Default value,subnetpool_create_args\u003dNone","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :returns: neutron subnetpool dict"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        return self.clients(\"neutron\").create_subnetpool("},{"line_number":109,"context_line":"            {\"subnetpool\": subnetpool_create_args})"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @atomic.action_timer(\"neutron.list_subnetpools\")"},{"line_number":112,"context_line":"    def _list_subnetpools(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_74050c44","line":109,"updated":"2016-10-16 10:51:30.000000000","message":"we shouldn\u0027t allow custom name. So name should be replaced by self.generate_random_name()","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @atomic.action_timer(\"neutron.list_subnetpools\")"},{"line_number":112,"context_line":"    def _list_subnetpools(self, **kwargs):"},{"line_number":113,"context_line":"        \"\"\"Return subnetpool list.\"\"\""},{"line_number":114,"context_line":"        return self.clients(\"neutron\").list_subnetpools(**kwargs)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @atomic.action_timer(\"neutron.create_subnet\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_54eac874","line":113,"updated":"2016-10-16 10:51:30.000000000","message":"pease document all parameters and return value in proper way","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.clients(\"neutron\").delete_network(network[\"id\"])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @atomic.action_timer(\"neutron.create_subnetpool\")"},{"line_number":141,"context_line":"    def _create_subnetpool(self, subnetpool_create_args\u003dNone):"},{"line_number":142,"context_line":"        \"\"\"Create neutron subnetpool."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        :param subnetpool_create_args: dict, POST /v2.0/subnetpools"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_1ba3729e","line":141,"updated":"2017-03-03 06:35:27.000000000","message":"Here, subnetpool_args value is not allowed to equal None","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"}],"tests/unit/plugins/openstack/scenarios/neutron/test_network.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        self.assertRaises(rally_exceptions.RallyAssertionError,"},{"line_number":174,"context_line":"                          scenario.run,"},{"line_number":175,"context_line":"                          subnetpool_create_args)"},{"line_number":176,"context_line":"        scenario._create_subnetpool.assert_called_with("},{"line_number":177,"context_line":"            subnetpool_create_args)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Negative case2: subnetpool isn\u0027t listed"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_1bdb72ed","line":176,"updated":"2017-03-03 06:35:27.000000000","message":"we can use assert_called_once_with","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            subnetpool_create_args)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Negative case2: subnetpool isn\u0027t listed"},{"line_number":180,"context_line":"        scenario._create_subnetpool.return_value \u003d subnetpool"},{"line_number":181,"context_line":"        scenario._list_subnetpools.return_value \u003d pool_list"},{"line_number":182,"context_line":"        self.assertRaises(rally_exceptions.RallyAssertionError,"},{"line_number":183,"context_line":"                          scenario.run,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_3b92f6f6","line":180,"updated":"2017-03-03 06:35:27.000000000","message":"we must reset mock before second test.","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertRaises(rally_exceptions.RallyAssertionError,"},{"line_number":183,"context_line":"                          scenario.run,"},{"line_number":184,"context_line":"                          subnetpool_create_args)"},{"line_number":185,"context_line":"        scenario._create_subnetpool.assert_called_with("},{"line_number":186,"context_line":"            subnetpool_create_args)"},{"line_number":187,"context_line":"        scenario._list_subnetpools.assert_called_with()"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_7bc9ce25","line":185,"updated":"2017-03-03 06:35:27.000000000","message":"same here","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4e2856c0eeb12f57045146dfe0215e3242e7088b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                          subnetpool_create_args)"},{"line_number":185,"context_line":"        scenario._create_subnetpool.assert_called_with("},{"line_number":186,"context_line":"            subnetpool_create_args)"},{"line_number":187,"context_line":"        scenario._list_subnetpools.assert_called_with()"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_create_and_list_subnets(self):"},{"line_number":190,"context_line":"        network_create_args \u003d {\"router:external\": True}"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_9bce822c","line":187,"updated":"2017-03-03 06:35:27.000000000","message":"same here","commit_id":"128a4d926ddf998fadac9e310049f6f1e4ac52ab"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e715ec88c0cb287acccb30e95efb41e02fbec4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            subnetpool_create_args)"},{"line_number":194,"context_line":"        self.clients(\"neutron\").create_subnetpool.assert_called_once_with("},{"line_number":195,"context_line":"            expected_subnetpool)"},{"line_number":196,"context_line":"        self.assertEqual(result_subnetpool, expected_subnetpool)"},{"line_number":197,"context_line":"        self._test_atomic_action_timer(self.scenario.atomic_actions(),"},{"line_number":198,"context_line":"                                       \"neutron.create_subnetpool\")"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_9400e035","line":196,"updated":"2016-10-16 10:51:30.000000000","message":"wrong order of parameters (expected, actual)","commit_id":"8f25e9c35ea67138bbaec5a003cb1e0ca604c204"}]}
