)]}'
{"rally/plugins/openstack/scenarios/neutron/bgpvpn.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@validation.required_neutron_extensions(\"bgpvpn\")"},{"line_number":22,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":23,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":24,"context_line":"                    name\u003d\"NeutronBGPVPN.create_and_delete_bgpvpns\")"},{"line_number":25,"context_line":"class CreateAndDeleteBgpvpns(utils.NeutronScenario):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_65609f36","line":22,"updated":"2016-10-22 23:27:13.000000000","message":"need to add validator that required admin openstack","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                    name\u003d\"NeutronBGPVPN.create_and_delete_bgpvpns\")"},{"line_number":25,"context_line":"class CreateAndDeleteBgpvpns(utils.NeutronScenario):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def run(self, create_args\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"create and delete bgpvpns.\"\"\""},{"line_number":29,"context_line":"        bgpvpn \u003d self._create_bgpvpn(create_args or {})"},{"line_number":30,"context_line":"        self._delete_bgpvpn(bgpvpn)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_c55fab70","line":27,"updated":"2016-10-22 23:27:13.000000000","message":"lets make this scenario more useful.\nAdd parameter bgpvpn_count that mean how many bgpvpns need to create. Wrap it into:\nwith atomic.AtomicAction:\n  for ..\n    create..(.., atomic_action\u003dfalse)","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def run(self, create_args\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"create and delete bgpvpns.\"\"\""},{"line_number":29,"context_line":"        bgpvpn \u003d self._create_bgpvpn(create_args or {})"},{"line_number":30,"context_line":"        self._delete_bgpvpn(bgpvpn)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_e554af55","line":30,"updated":"2016-10-22 23:27:13.000000000","message":"the same as for create","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        returns: dict, bgpvpn resource details"},{"line_number":581,"context_line":"        \"\"\""},{"line_number":582,"context_line":"        args \u003d {\"name\": self.generate_random_name()}"},{"line_number":583,"context_line":"        args.update(bgpvpn_create_args)"},{"line_number":584,"context_line":"        return self.admin_clients(\"neutron\").create_ext("},{"line_number":585,"context_line":"            self.bgpvpns_path, {\"bgpvpn\": args})"},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_257867f2","line":583,"updated":"2016-10-22 23:27:13.000000000","message":"lets make code more readable\nif \"name\" not in ..:\n  kwargs[\"name\"] \u003d","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    def _delete_bgpvpn(self, bgpvpn):"},{"line_number":589,"context_line":"        \"\"\"Delete Bgpvpn resource.(DELETE /bgpvpn/bgpvpns/{id})"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        param: bgpvpn: dict, bgpvpn"},{"line_number":592,"context_line":"        \"\"\""},{"line_number":593,"context_line":"        return self.admin_clients(\"neutron\").delete_ext("},{"line_number":594,"context_line":"            self.bgpvpn_path, bgpvpn[\"bgpvpn\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_454c7bc7","line":591,"updated":"2016-10-22 23:27:13.000000000","message":"returns should be documented too","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f6c9e25221449a7d582e5d495882c3a939ab530f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    HM_DELAY \u003d 20"},{"line_number":46,"context_line":"    HM_TIMEOUT \u003d 10"},{"line_number":47,"context_line":"    # BGPVPN"},{"line_number":48,"context_line":"    bgpvpns_path \u003d \"/bgpvpn/bgpvpns\""},{"line_number":49,"context_line":"    bgpvpn_path \u003d \"/bgpvpn/bgpvpns/%s\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _get_network_id(self, network, **kwargs):"},{"line_number":52,"context_line":"        \"\"\"Get Neutron network ID for the network name."}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_2004c949","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":38},"updated":"2017-04-26 01:23:29.000000000","message":"Why not move them to _create_bgpvpn and _delete_bgpvpn? i saw them were used only in _create_bgpvpn and _delete_bgpvpn.\nIf we should declare them here, i think it would be better to use upper case. :)","commit_id":"acf259f22df155d20e24db50f6f6448f06e9e35b"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f6c9e25221449a7d582e5d495882c3a939ab530f","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        param: bgpvpn_create_args: dict bgpvpn options"},{"line_number":708,"context_line":"        returns: dict, bgpvpn resource details"},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        if \"name\" not in bgpvpn_create_args:"},{"line_number":711,"context_line":"            bgpvpn_create_args[\"name\"] \u003d self.generate_random_name()"},{"line_number":712,"context_line":"        return self.admin_clients(\"neutron\").create_ext("},{"line_number":713,"context_line":"            self.bgpvpns_path, {\"bgpvpn\": bgpvpn_create_args})"},{"line_number":714,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_a01a197a","line":711,"range":{"start_line":710,"start_character":0,"end_line":711,"end_character":68},"updated":"2017-04-26 01:23:29.000000000","message":"If it is not special necessary, we hope the name is created by  self.generate_random_name, because it is useful to cleanup manager. Here i want we could restrict the name argument in CreateAndDeleteBgpvpns. like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/volumes.py#L155","commit_id":"acf259f22df155d20e24db50f6f6448f06e9e35b"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f6c9e25221449a7d582e5d495882c3a939ab530f","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        if \"name\" not in bgpvpn_create_args:"},{"line_number":711,"context_line":"            bgpvpn_create_args[\"name\"] \u003d self.generate_random_name()"},{"line_number":712,"context_line":"        return self.admin_clients(\"neutron\").create_ext("},{"line_number":713,"context_line":"            self.bgpvpns_path, {\"bgpvpn\": bgpvpn_create_args})"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @atomic.action_timer(\"neutron.delete_bgpvpn\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_9b9b10c8","line":712,"range":{"start_line":712,"start_character":19,"end_line":712,"end_character":45},"updated":"2017-04-26 01:23:29.000000000","message":"I do not know bgpvpn, just have a question :). Should we use admin clients to create or delete bgpvpn ? If not, it would better to use general client.\nIf we should use admin client, please switch the validation to admin for CreateAndDeleteBgpvpns. like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/volume_types.py#L31","commit_id":"acf259f22df155d20e24db50f6f6448f06e9e35b"}],"samples/tasks/scenarios/neutron/create-and-delete-bgpvpns.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":13,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"                }"},{"line_number":16,"context_line":"              }"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":"    ]"},{"line_number":19,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"da6895a0_85ccd336","line":16,"updated":"2016-10-22 23:27:13.000000000","message":"please fix an indention and add sla section","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9191f405f7f2547fe9938d464e8c69d2c74d2e86","unresolved":false,"context_lines":[{"line_number":874,"context_line":"        expected_bv_data \u003d {\"bgpvpn\": args}"},{"line_number":875,"context_line":"        resultant_bv \u003d self.scenario._create_bgpvpn("},{"line_number":876,"context_line":"            bgpvpn_create_args\u003dbgpvpn_create_args)"},{"line_number":877,"context_line":"        self.assertEqual(resultant_bv, bv)"},{"line_number":878,"context_line":"        self.admin_clients(\"neutron\").create_ext.assert_called_once_with("},{"line_number":879,"context_line":"            self.scenario.bgpvpns_path, expected_bv_data)"},{"line_number":880,"context_line":"        if atomic_action:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_a5d1d7cf","line":877,"updated":"2016-10-22 23:27:13.000000000","message":"wrong order of parameters","commit_id":"9c86aa7c57265fdf8a95292bfffd809c3a8641ca"}]}
