)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7873b13988415dee93b32e6c1dddc334a6be1734","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangzhang \u003czhangzh.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-14 03:21:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add neutron.CreateNetworkWithType"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a network with type and then list all networks."},{"line_number":10,"context_line":"This type must be supported in your environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_f1f051cb","line":7,"updated":"2016-10-15 13:33:38.000000000","message":"what this name means? This is scenario, sample or what?","commit_id":"4dd9b4a650012436b51cf40aa11afa200a7b21e0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7873b13988415dee93b32e6c1dddc334a6be1734","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add neutron.CreateNetworkWithType"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a network with type and then list all networks."},{"line_number":10,"context_line":"This type must be supported in your environment."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id0f0aa6b7768f60d7686214a08e6d757bec6683e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_d1cc2d8b","line":9,"updated":"2016-10-15 13:33:38.000000000","message":"As I understand this is just one more input into existing scenario. So you need to change its sample and add this task config into gate job https://github.com/openstack/rally/blob/master/rally-jobs/rally-neutron.yaml#L5","commit_id":"4dd9b4a650012436b51cf40aa11afa200a7b21e0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7873b13988415dee93b32e6c1dddc334a6be1734","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add neutron.CreateNetworkWithType"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a network with type and then list all networks."},{"line_number":10,"context_line":"This type must be supported in your environment."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id0f0aa6b7768f60d7686214a08e6d757bec6683e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_71b3610a","line":10,"updated":"2016-10-15 13:33:38.000000000","message":"Such stuff should be validated by new validator not by user itself because it will lead to the traceback","commit_id":"4dd9b4a650012436b51cf40aa11afa200a7b21e0"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"3ecef9248ef5fd5ded0dd1f7ee4c7d431a431b84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangzhang \u003czhangzh.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 07:19:55 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add neutron.CreateNetworkWithType"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a network with type and then list all networks."},{"line_number":10,"context_line":"This type must be supported in your environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_0004517c","line":7,"updated":"2016-10-27 08:42:37.000000000","message":"This strongly suggests that you\u0027re adding a new scenario, which is misleading. All you\u0027re adding is new tests and samples. Please reword.","commit_id":"e5d2df91c74c0d6ac96e183aab1d017dd82e4d47"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"92991682b28c9ef02bca13a7c3e8b57fb4561507","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangzhang \u003czhangzh.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 07:19:55 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add neutron.CreateNetworkWithType"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create a network with type and then list all networks."},{"line_number":10,"context_line":"This type must be supported in your environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_5aab7f74","line":7,"in_reply_to":"ba5da102_0004517c","updated":"2016-10-28 03:29:16.000000000","message":"Done","commit_id":"e5d2df91c74c0d6ac96e183aab1d017dd82e4d47"}],"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b64c3dc46e8993b91aebe6206f1809ea27fce570","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          neutron:"},{"line_number":19,"context_line":"             network: -1"},{"line_number":20,"context_line":"        roles:"},{"line_number":21,"context_line":"          - \"admin\""},{"line_number":22,"context_line":"      sla:"},{"line_number":23,"context_line":"        failure_rate:"},{"line_number":24,"context_line":"          max: 20"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_e7a92126","line":21,"updated":"2016-10-18 13:00:55.000000000","message":"it was working without admin role, so please remove it","commit_id":"d130496a0870507ff3e5da79d098f8bbaf50dc42"}],"samples/tasks/scenarios/neutron/create-network-with-type.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7873b13988415dee93b32e6c1dddc334a6be1734","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"NeutronNetworks.create_and_list_networks\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"network_create_args\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_d11eed0a","line":2,"updated":"2016-10-15 13:33:38.000000000","message":"this is not the separate scenario so it should be in https://github.com/openstack/rally/blob/master/samples/tasks/scenarios/neutron/create-and-list-networks.yaml","commit_id":"4dd9b4a650012436b51cf40aa11afa200a7b21e0"}],"tests/unit/plugins/openstack/scenarios/neutron/test_network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7873b13988415dee93b32e6c1dddc334a6be1734","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @mock.patch(\"%s.CreateAndListNetworks._list_networks\" % BASE)"},{"line_number":51,"context_line":"    @mock.patch(\"%s.CreateAndListNetworks._create_network\" % BASE)"},{"line_number":52,"context_line":"    def test_create_network_with_type(self,"},{"line_number":53,"context_line":"                                      mock__create_network,"},{"line_number":54,"context_line":"                                      mock__list_networks):"},{"line_number":55,"context_line":"        scenario \u003d network.CreateAndListNetworks(self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_51d9fd55","line":52,"updated":"2016-10-15 13:33:38.000000000","message":"looks like its the same as above test except input arguments in scenario. So please use ddt module here, line384 an example","commit_id":"4dd9b4a650012436b51cf40aa11afa200a7b21e0"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"3ecef9248ef5fd5ded0dd1f7ee4c7d431a431b84","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        network_create_args \u003d {\"provider:network_type\": \"vxlan\"}"},{"line_number":59,"context_line":"        scenario.run(network_create_args\u003dnetwork_create_args)"},{"line_number":60,"context_line":"        mock__create_network.assert_called_once_with(network_create_args)"},{"line_number":61,"context_line":"        mock__list_networks.assert_called_once_with()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._update_network\" % BASE)"},{"line_number":64,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._create_network\" % BASE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_c0f2599a","line":61,"updated":"2016-10-27 08:42:37.000000000","message":"Instead of adding this test case, use DDT to run create_and_list_networks() tests with a variety of different inputs, including the two in the original test above, a network_type, and anything else you think is valuable.\n\nAdd atomic action tests to it, too.","commit_id":"e5d2df91c74c0d6ac96e183aab1d017dd82e4d47"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"65a2279732daeda922e37033e10bce6998bb04db","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        network_create_args \u003d {\"provider:network_type\": \"vxlan\"}"},{"line_number":59,"context_line":"        scenario.run(network_create_args\u003dnetwork_create_args)"},{"line_number":60,"context_line":"        mock__create_network.assert_called_once_with(network_create_args)"},{"line_number":61,"context_line":"        mock__list_networks.assert_called_once_with()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._update_network\" % BASE)"},{"line_number":64,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._create_network\" % BASE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_df459317","line":61,"in_reply_to":"ba5da102_1a7ae724","updated":"2016-10-31 12:27:24.000000000","message":"Actually, don\u0027t worry about atomic action tests; those belong in the utils tests, not here.","commit_id":"e5d2df91c74c0d6ac96e183aab1d017dd82e4d47"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"92991682b28c9ef02bca13a7c3e8b57fb4561507","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        network_create_args \u003d {\"provider:network_type\": \"vxlan\"}"},{"line_number":59,"context_line":"        scenario.run(network_create_args\u003dnetwork_create_args)"},{"line_number":60,"context_line":"        mock__create_network.assert_called_once_with(network_create_args)"},{"line_number":61,"context_line":"        mock__list_networks.assert_called_once_with()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._update_network\" % BASE)"},{"line_number":64,"context_line":"    @mock.patch(\"%s.CreateAndUpdateNetworks._create_network\" % BASE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_1a7ae724","line":61,"in_reply_to":"ba5da102_c0f2599a","updated":"2016-10-28 03:29:16.000000000","message":"\u003eInstead of adding this test case, use DDT to run create_and_list_networks() tests with a variety of different inputs, including the two in the original test above, a network_type, and anything else you think is valuable.\nok I hace done\n\n\u003eAdd atomic action tests to it, too.\nhow to do?","commit_id":"e5d2df91c74c0d6ac96e183aab1d017dd82e4d47"}]}