)]}'
{"rally-jobs/rally-keystone-api-v2.yaml":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c170a92de846611d777fd158c0d7898a64a0104d","unresolved":false,"context_lines":[{"line_number":977,"context_line":"        failure_rate:"},{"line_number":978,"context_line":"          max: 0"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"#  GlanceImages.create_image_and_boot_instances:"},{"line_number":981,"context_line":"#    -"},{"line_number":982,"context_line":"#      args:"},{"line_number":983,"context_line":"#        image_location: \"{{ cirros_image_url }}\""},{"line_number":984,"context_line":"#        container_format: \"bare\""},{"line_number":985,"context_line":"#        disk_format: \"qcow2\""},{"line_number":986,"context_line":"#        flavor:"},{"line_number":987,"context_line":"#            name: \"m1.tiny\""},{"line_number":988,"context_line":"#        number_instances: 2"},{"line_number":989,"context_line":"#      runner:"},{"line_number":990,"context_line":"#        type: \"constant\""},{"line_number":991,"context_line":"#        times: 1"},{"line_number":992,"context_line":"#        concurrency: 1"},{"line_number":993,"context_line":"#      context:"},{"line_number":994,"context_line":"#        users:"},{"line_number":995,"context_line":"#          tenants: 3"},{"line_number":996,"context_line":"#          users_per_tenant: 1"},{"line_number":997,"context_line":"#      sla:"},{"line_number":998,"context_line":"#        failure_rate:"},{"line_number":999,"context_line":"#          max: 0"},{"line_number":1000,"context_line":"#"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"  GlanceImages.create_image_and_boot_instances:"},{"line_number":1003,"context_line":"    -"},{"line_number":1004,"context_line":"      args:"},{"line_number":1005,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1006,"context_line":"        container_format: \"bare\""},{"line_number":1007,"context_line":"        disk_format: \"qcow2\""},{"line_number":1008,"context_line":"        flavor:"},{"line_number":1009,"context_line":"            name: \"m1.tiny\""},{"line_number":1010,"context_line":"        number_instances: 2"},{"line_number":1011,"context_line":"      runner:"},{"line_number":1012,"context_line":"        type: \"constant\""},{"line_number":1013,"context_line":"        times: 1"},{"line_number":1014,"context_line":"        concurrency: 1"},{"line_number":1015,"context_line":"      context:"},{"line_number":1016,"context_line":"        users:"},{"line_number":1017,"context_line":"          tenants: 3"},{"line_number":1018,"context_line":"          users_per_tenant: 1"},{"line_number":1019,"context_line":"      sla:"},{"line_number":1020,"context_line":"        failure_rate:"},{"line_number":1021,"context_line":"          max: 0"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1024,"context_line":"  {% for s in (1, 2) %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da4df55a_243a5f37","line":1021,"range":{"start_line":980,"start_character":0,"end_line":1021,"end_character":16},"updated":"2016-12-22 03:24:07.000000000","message":"unrelated to this patch","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"9ceba2e051c1efde7316d53c688edfca4b3b771d","unresolved":false,"context_lines":[{"line_number":977,"context_line":"        failure_rate:"},{"line_number":978,"context_line":"          max: 0"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"#  GlanceImages.create_image_and_boot_instances:"},{"line_number":981,"context_line":"#    -"},{"line_number":982,"context_line":"#      args:"},{"line_number":983,"context_line":"#        image_location: \"{{ cirros_image_url }}\""},{"line_number":984,"context_line":"#        container_format: \"bare\""},{"line_number":985,"context_line":"#        disk_format: \"qcow2\""},{"line_number":986,"context_line":"#        flavor:"},{"line_number":987,"context_line":"#            name: \"m1.tiny\""},{"line_number":988,"context_line":"#        number_instances: 2"},{"line_number":989,"context_line":"#      runner:"},{"line_number":990,"context_line":"#        type: \"constant\""},{"line_number":991,"context_line":"#        times: 1"},{"line_number":992,"context_line":"#        concurrency: 1"},{"line_number":993,"context_line":"#      context:"},{"line_number":994,"context_line":"#        users:"},{"line_number":995,"context_line":"#          tenants: 3"},{"line_number":996,"context_line":"#          users_per_tenant: 1"},{"line_number":997,"context_line":"#      sla:"},{"line_number":998,"context_line":"#        failure_rate:"},{"line_number":999,"context_line":"#          max: 0"},{"line_number":1000,"context_line":"#"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"  GlanceImages.create_image_and_boot_instances:"},{"line_number":1003,"context_line":"    -"},{"line_number":1004,"context_line":"      args:"},{"line_number":1005,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1006,"context_line":"        container_format: \"bare\""},{"line_number":1007,"context_line":"        disk_format: \"qcow2\""},{"line_number":1008,"context_line":"        flavor:"},{"line_number":1009,"context_line":"            name: \"m1.tiny\""},{"line_number":1010,"context_line":"        number_instances: 2"},{"line_number":1011,"context_line":"      runner:"},{"line_number":1012,"context_line":"        type: \"constant\""},{"line_number":1013,"context_line":"        times: 1"},{"line_number":1014,"context_line":"        concurrency: 1"},{"line_number":1015,"context_line":"      context:"},{"line_number":1016,"context_line":"        users:"},{"line_number":1017,"context_line":"          tenants: 3"},{"line_number":1018,"context_line":"          users_per_tenant: 1"},{"line_number":1019,"context_line":"      sla:"},{"line_number":1020,"context_line":"        failure_rate:"},{"line_number":1021,"context_line":"          max: 0"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1024,"context_line":"  {% for s in (1, 2) %}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da4df55a_860d9340","line":1021,"range":{"start_line":980,"start_character":0,"end_line":1021,"end_character":16},"in_reply_to":"da4df55a_243a5f37","updated":"2016-12-23 09:53:19.000000000","message":"Done","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c491c6f63ce30e4abccc3de9febfac8ec2ae04d1","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1099,"context_line":"    -"},{"line_number":1100,"context_line":"      args:"},{"line_number":1101,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1102,"context_line":"        container_format: \"bare\""},{"line_number":1103,"context_line":"        disk_format: \"qcow2\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_46ada5e7","line":1100,"range":{"start_line":1100,"start_character":6,"end_line":1100,"end_character":10},"updated":"2016-10-17 11:23:11.000000000","message":"please add  args:{\n                       xxx:xxx\n                       xxx:xxx  }","commit_id":"d478e7b93691e07682a9a9a11165c058dd367acc"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"7896cc302156ac9c4d950c6f0d8621d31b0d4e06","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1099,"context_line":"    -"},{"line_number":1100,"context_line":"      args:"},{"line_number":1101,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1102,"context_line":"        container_format: \"bare\""},{"line_number":1103,"context_line":"        disk_format: \"qcow2\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_83886bc8","line":1100,"range":{"start_line":1100,"start_character":6,"end_line":1100,"end_character":10},"in_reply_to":"fa6399be_46ada5e7","updated":"2016-10-18 03:37:38.000000000","message":"Are you serious？ Its not json file","commit_id":"d478e7b93691e07682a9a9a11165c058dd367acc"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"88d4d0830353f1f4ec71e2e854b8312eee3706f8","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1099,"context_line":"    -"},{"line_number":1100,"context_line":"      args:"},{"line_number":1101,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1102,"context_line":"        container_format: \"bare\""},{"line_number":1103,"context_line":"        disk_format: \"qcow2\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_877f3765","line":1100,"range":{"start_line":1100,"start_character":6,"end_line":1100,"end_character":10},"in_reply_to":"fa6399be_46ada5e7","updated":"2016-10-20 01:25:09.000000000","message":"the syntax error","commit_id":"d478e7b93691e07682a9a9a11165c058dd367acc"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"299bcff89afad6b6be2299523f7e59fb572f9781","unresolved":false,"context_lines":[{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":1099,"context_line":"    -"},{"line_number":1100,"context_line":"      args:"},{"line_number":1101,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":1102,"context_line":"        container_format: \"bare\""},{"line_number":1103,"context_line":"        disk_format: \"qcow2\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa6399be_07c4075d","line":1100,"range":{"start_line":1100,"start_character":6,"end_line":1100,"end_character":10},"in_reply_to":"fa6399be_877f3765","updated":"2016-10-20 02:03:09.000000000","message":"sorry，I didn\u0027t say it clearly ,\nthis patch is correct here.\n\nzhubingbing\u0027s comment is wrong.","commit_id":"d478e7b93691e07682a9a9a11165c058dd367acc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b755c1e2d910927a2bd1e4e0e6dd6c84a71da9a8","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"          users_per_tenant: 3"},{"line_number":1112,"context_line":"        api_versions:"},{"line_number":1113,"context_line":"          glance:"},{"line_number":1114,"context_line":"            version: 2"},{"line_number":1115,"context_line":"      sla:"},{"line_number":1116,"context_line":"        failure_rate:"},{"line_number":1117,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6895a0_2dd4c045","line":1114,"updated":"2016-10-24 09:40:27.000000000","message":"why we test only second version?","commit_id":"3d1cba2ac9e5fc05a3204e6b3820a2d369e3af50"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c170a92de846611d777fd158c0d7898a64a0104d","unresolved":false,"context_lines":[{"line_number":984,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":985,"context_line":"        container_format: \"bare\""},{"line_number":986,"context_line":"        disk_format: \"qcow2\""},{"line_number":987,"context_line":"        image_number: 2"},{"line_number":988,"context_line":"        create_image_kwargs: {}"},{"line_number":989,"context_line":"        update_image_kwargs: {}"},{"line_number":990,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da4df55a_049f1b04","line":987,"updated":"2016-12-22 03:24:07.000000000","message":"could you add some properties for create_image, then remove by remove_props for testing \u0027remove_props\u0027 ?","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"9ceba2e051c1efde7316d53c688edfca4b3b771d","unresolved":false,"context_lines":[{"line_number":984,"context_line":"        image_location: \"{{ cirros_image_url }}\""},{"line_number":985,"context_line":"        container_format: \"bare\""},{"line_number":986,"context_line":"        disk_format: \"qcow2\""},{"line_number":987,"context_line":"        image_number: 2"},{"line_number":988,"context_line":"        create_image_kwargs: {}"},{"line_number":989,"context_line":"        update_image_kwargs: {}"},{"line_number":990,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da4df55a_06328310","line":987,"in_reply_to":"da4df55a_049f1b04","updated":"2016-12-23 09:53:19.000000000","message":"Done","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"39bc517a9014b630561a1e91d7a7e893fa611df2","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        users:"},{"line_number":596,"context_line":"          tenants: 2"},{"line_number":597,"context_line":"          users_per_tenant: 2"},{"line_number":598,"context_line":"        api_versions:"},{"line_number":599,"context_line":"          glance:"},{"line_number":600,"context_line":"            version: 2"},{"line_number":601,"context_line":"      sla:"},{"line_number":602,"context_line":"        failure_rate:"},{"line_number":603,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ff52f3f_deab1473","line":600,"range":{"start_line":598,"start_character":0,"end_line":600,"end_character":22},"updated":"2017-04-13 07:48:24.000000000","message":"Why need api_version context option?","commit_id":"d5f7906da32d6887dfb078d3d56d03bc34b52920"}],"rally/plugins/openstack/scenarios/glance/images.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"399dc724a67551762a9edca3fca5fe246942615b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        image \u003d self._create_image(container_format,"},{"line_number":152,"context_line":"                                   image_location,"},{"line_number":153,"context_line":"                                   disk_format)"},{"line_number":154,"context_line":"        image_id \u003d image.id"},{"line_number":155,"context_line":"        self._update_image(image_id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f14db1c4","line":154,"updated":"2016-10-15 14:26:49.000000000","message":"remove this line please","commit_id":"2df01d28cfb2a72ee7557a6f1f7f87a524cb0f97"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"749f46b4ef1a837d1c064f2ba9325fd94e8aebf0","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        image \u003d self._create_image(container_format,"},{"line_number":152,"context_line":"                                   image_location,"},{"line_number":153,"context_line":"                                   disk_format)"},{"line_number":154,"context_line":"        image_id \u003d image.id"},{"line_number":155,"context_line":"        self._update_image(image_id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_2b596a35","line":154,"in_reply_to":"fa6399be_f14db1c4","updated":"2016-10-17 02:44:05.000000000","message":"Done","commit_id":"2df01d28cfb2a72ee7557a6f1f7f87a524cb0f97"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b755c1e2d910927a2bd1e4e0e6dd6c84a71da9a8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"class CreateAndUpdateImage(utils.GlanceScenario):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def run(self, container_format, image_location, disk_format,"},{"line_number":137,"context_line":"            remove_props\u003dNone, **kwargs):"},{"line_number":138,"context_line":"        \"\"\"Create an image then update it."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        Measure the \"glance image-create\" and \"glance image-update\" commands"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6895a0_6a485e88","line":137,"updated":"2016-10-24 09:40:27.000000000","message":"replace kwargs into create_image_kwargs and update_image_kwargs","commit_id":"3d1cba2ac9e5fc05a3204e6b3820a2d369e3af50"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b755c1e2d910927a2bd1e4e0e6dd6c84a71da9a8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":148,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":149,"context_line":"        :param kwargs: optional parameters to update image"},{"line_number":150,"context_line":"        \"\"\""},{"line_number":151,"context_line":"        image \u003d self._create_image(container_format,"},{"line_number":152,"context_line":"                                   image_location,"},{"line_number":153,"context_line":"                                   disk_format)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6895a0_406ffbc4","line":150,"updated":"2016-10-24 09:40:27.000000000","message":"Lets make scenario more flexible and useful. We can add argument `image_number` and then \nwith atomic.AtomicAction():\n  for image_number:\n    create_image(.., atomic_action\u003dFalse)\nwith atomic.AtomicAction():\n  for image_number:\n    update_image(.., atomic_action\u003dFalse)","commit_id":"3d1cba2ac9e5fc05a3204e6b3820a2d369e3af50"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b755c1e2d910927a2bd1e4e0e6dd6c84a71da9a8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \"\"\""},{"line_number":151,"context_line":"        image \u003d self._create_image(container_format,"},{"line_number":152,"context_line":"                                   image_location,"},{"line_number":153,"context_line":"                                   disk_format)"},{"line_number":154,"context_line":"        self._update_image(image.id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6895a0_8a7852c6","line":153,"updated":"2016-10-24 09:40:27.000000000","message":"https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/glance/utils.py#L48 kwargs should be passed too","commit_id":"3d1cba2ac9e5fc05a3204e6b3820a2d369e3af50"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ac0fdab7cf05e35374308c3824f39bee92e4c4b4","unresolved":false,"context_lines":[{"line_number":173,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":174,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":175,"context_line":"                    name\u003d\"GlanceImages.create_and_update_image\")"},{"line_number":176,"context_line":"class CreateAndUpdateImage(GlanceBasic):"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def run(self, container_format, image_location, disk_format,"},{"line_number":179,"context_line":"            remove_props\u003dNone, visibility\u003d\"private\", create_min_disk\u003d0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ffa3b31_75ecd128","line":176,"updated":"2017-04-18 15:45:54.000000000","message":"image_name or name need to be restricted. pls use https://github.com/openstack/rally/blob/master/rally/task/validation.py#L656 to restrict the param of name.","commit_id":"859c8e23ca25cee4a425f21c691b24dd55069ac7"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d6a1fcc75831fd8a5bfe71838894f2750a385b1c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":174,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":175,"context_line":"                    name\u003d\"GlanceImages.create_and_update_image\")"},{"line_number":176,"context_line":"class CreateAndUpdateImage(GlanceBasic):"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def run(self, container_format, image_location, disk_format,"},{"line_number":179,"context_line":"            remove_props\u003dNone, visibility\u003d\"private\", create_min_disk\u003d0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ffa3b31_176467b8","line":176,"in_reply_to":"7ffa3b31_75ecd128","updated":"2017-04-18 23:53:09.000000000","message":"@Hai Shi, Here the arguments are specified exactly, there are unnecessary to add other validation. :)","commit_id":"859c8e23ca25cee4a425f21c691b24dd55069ac7"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"46ee00a751982d9ecf44e6e40cd73e6f8089eaef","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image_location: image file location"},{"line_number":189,"context_line":"        :param disk_format: disk format of image. Acceptable formats:"},{"line_number":190,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":191,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":192,"context_line":"        :param visibility: The access permission for the created image"},{"line_number":193,"context_line":"        :param create_min_disk: The min disk of created images"},{"line_number":194,"context_line":"        :param create_min_ram: The min ram of created images"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ffa3b31_583117a2","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":61},"updated":"2017-04-18 11:48:02.000000000","message":"Let\u0027s add note that it is supported only by Glance v2","commit_id":"859c8e23ca25cee4a425f21c691b24dd55069ac7"}],"rally/plugins/openstack/scenarios/glance/utils.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c170a92de846611d777fd158c0d7898a64a0104d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        :param image_location: image file location"},{"line_number":54,"context_line":"        :param disk_format: disk format of image. Acceptable formats:"},{"line_number":55,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":56,"context_line":"        :param atomic_action: bool, enable create container to be"},{"line_number":57,"context_line":"                              tracked as an atomic action. added and"},{"line_number":58,"context_line":"                              handled by the optional_action_timer()"},{"line_number":59,"context_line":"                              decorator"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_8476ab3c","line":56,"range":{"start_line":56,"start_character":50,"end_line":56,"end_character":59},"updated":"2016-12-22 03:24:07.000000000","message":"image","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"9ceba2e051c1efde7316d53c688edfca4b3b771d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        :param image_location: image file location"},{"line_number":54,"context_line":"        :param disk_format: disk format of image. Acceptable formats:"},{"line_number":55,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":56,"context_line":"        :param atomic_action: bool, enable create container to be"},{"line_number":57,"context_line":"                              tracked as an atomic action. added and"},{"line_number":58,"context_line":"                              handled by the optional_action_timer()"},{"line_number":59,"context_line":"                              decorator"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_c6079b1a","line":56,"range":{"start_line":56,"start_character":50,"end_line":56,"end_character":59},"in_reply_to":"da4df55a_8476ab3c","updated":"2016-12-23 09:53:19.000000000","message":"Done","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c170a92de846611d777fd158c0d7898a64a0104d","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param image_id: ID of the image to modify"},{"line_number":92,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":93,"context_line":"        :param atomic_action: bool, enable create container to be"},{"line_number":94,"context_line":"                              tracked as an atomic action. added and"},{"line_number":95,"context_line":"                              handled by the optional_action_timer()"},{"line_number":96,"context_line":"                              decorator"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_a473af4c","line":93,"range":{"start_line":93,"start_character":43,"end_line":93,"end_character":59},"updated":"2016-12-22 03:24:07.000000000","message":"update image","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"9ceba2e051c1efde7316d53c688edfca4b3b771d","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param image_id: ID of the image to modify"},{"line_number":92,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":93,"context_line":"        :param atomic_action: bool, enable create container to be"},{"line_number":94,"context_line":"                              tracked as an atomic action. added and"},{"line_number":95,"context_line":"                              handled by the optional_action_timer()"},{"line_number":96,"context_line":"                              decorator"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_0100ad00","line":93,"range":{"start_line":93,"start_character":43,"end_line":93,"end_character":59},"in_reply_to":"da4df55a_a473af4c","updated":"2016-12-23 09:53:19.000000000","message":"Done","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c170a92de846611d777fd158c0d7898a64a0104d","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :returns: Updated image object"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":102,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":103,"context_line":"        client \u003d glance_wrapper.wrap(self._clients.glance, self)"},{"line_number":104,"context_line":"        return client.update_image(image_id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_a4ef2faf","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":56},"updated":"2016-12-22 03:24:07.000000000","message":"name is random generated in the client side if not exist, so it could be removed here.","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5cbfbd7e97f79daf4f5283674ff4ac50ea96028b","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :returns: Updated image object"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":102,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":103,"context_line":"        client \u003d glance_wrapper.wrap(self._clients.glance, self)"},{"line_number":104,"context_line":"        return client.update_image(image_id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_8f3803f1","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":56},"in_reply_to":"da4df55a_2151310f","updated":"2016-12-27 03:01:14.000000000","message":"see my comment in the latest ps9","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"9ceba2e051c1efde7316d53c688edfca4b3b771d","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :returns: Updated image object"},{"line_number":100,"context_line":"        \"\"\""},{"line_number":101,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":102,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":103,"context_line":"        client \u003d glance_wrapper.wrap(self._clients.glance, self)"},{"line_number":104,"context_line":"        return client.update_image(image_id, remove_props, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_2151310f","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":56},"in_reply_to":"da4df55a_a4ef2faf","updated":"2016-12-23 09:53:19.000000000","message":"It cannot be removed, error will be output:\nError AttributeError: \u0027GlanceV1Wrapper\u0027 object has no attribute \u0027generate_random_name\u0027","commit_id":"3ad88b888325476b725bd7c9fa1d79789e36945a"}],"rally/plugins/openstack/services/image/glance_v1.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"46ee00a751982d9ecf44e6e40cd73e6f8089eaef","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        :param image_name: Image name to be updated to"},{"line_number":185,"context_line":"        :param min_disk: The min disk of updated image"},{"line_number":186,"context_line":"        :param min_ram: The min ram of updated image"},{"line_number":187,"context_line":"        :param remove_props: List of property names to remove"},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        image_obj \u003d self._impl.update_image("},{"line_number":190,"context_line":"            image_id\u003dimage_id,"},{"line_number":191,"context_line":"            image_name\u003dimage_name,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7ffa3b31_d8f3e7e6","line":188,"range":{"start_line":187,"start_character":8,"end_line":188,"end_character":11},"updated":"2017-04-18 11:48:02.000000000","message":"since Glance V1 doesn\u0027t support remove_props. Method update_image of UnifiedGlanceV1Service should accept it, check that it is None(if not - raise Exception) and do not transmit it to GlanceV1Service","commit_id":"859c8e23ca25cee4a425f21c691b24dd55069ac7"}],"rally/plugins/openstack/wrappers/glance.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"82b6fbfed72d595b2402182356612c8c60d327eb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def update_image(self, image_id, remove_props\u003dNone, **kwargs):"},{"line_number":139,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":140,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":141,"context_line":"        return self.client.images.update(image_id,"},{"line_number":142,"context_line":"                                         **kwargs)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da4df55a_0f5ed343","line":140,"updated":"2016-12-27 03:01:19.000000000","message":"self.owner.generate_random_name()","commit_id":"45b5be6f6d30fe7499e9a025c2e4fe66679bd5ca"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e8cf10a80fa9576d54c8306bfe9a0567cbda1add","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def update_image(self, image_id, remove_props\u003dNone, **kwargs):"},{"line_number":139,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":140,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":141,"context_line":"        return self.client.images.update(image_id,"},{"line_number":142,"context_line":"                                         **kwargs)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da4df55a_f87957c9","line":140,"in_reply_to":"da4df55a_0f5ed343","updated":"2016-12-27 06:46:38.000000000","message":"got it!","commit_id":"45b5be6f6d30fe7499e9a025c2e4fe66679bd5ca"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"82b6fbfed72d595b2402182356612c8c60d327eb","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def update_image(self, image_id, remove_props\u003dNone, **kwargs):"},{"line_number":213,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":214,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":215,"context_line":"        return self.client.images.update(image_id, remove_props,"},{"line_number":216,"context_line":"                                         **kwargs)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da4df55a_cf476b75","line":214,"updated":"2016-12-27 03:01:19.000000000","message":"self.owner.generate_random_name()","commit_id":"45b5be6f6d30fe7499e9a025c2e4fe66679bd5ca"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e8cf10a80fa9576d54c8306bfe9a0567cbda1add","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def update_image(self, image_id, remove_props\u003dNone, **kwargs):"},{"line_number":213,"context_line":"        if not kwargs.get(\"name\"):"},{"line_number":214,"context_line":"            kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":215,"context_line":"        return self.client.images.update(image_id, remove_props,"},{"line_number":216,"context_line":"                                         **kwargs)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da4df55a_986a0bed","line":214,"in_reply_to":"da4df55a_cf476b75","updated":"2016-12-27 06:46:38.000000000","message":"Thank you very much for teaching me.","commit_id":"45b5be6f6d30fe7499e9a025c2e4fe66679bd5ca"}],"samples/tasks/scenarios/glance/create-and-update-image.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"399dc724a67551762a9edca3fca5fe246942615b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            \"runner\": {"},{"line_number":10,"context_line":"                \"type\": \"constant\","},{"line_number":11,"context_line":"                \"times\": 10,"},{"line_number":12,"context_line":"                \"concurrency\": 2"},{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_5169fdf7","line":11,"updated":"2016-10-15 14:26:49.000000000","message":"this will significantly decrease time execution of this sample locally. Lets decrease it to 2","commit_id":"2df01d28cfb2a72ee7557a6f1f7f87a524cb0f97"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"749f46b4ef1a837d1c064f2ba9325fd94e8aebf0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            },"},{"line_number":9,"context_line":"            \"runner\": {"},{"line_number":10,"context_line":"                \"type\": \"constant\","},{"line_number":11,"context_line":"                \"times\": 10,"},{"line_number":12,"context_line":"                \"concurrency\": 2"},{"line_number":13,"context_line":"            },"},{"line_number":14,"context_line":"            \"context\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_eb521212","line":11,"in_reply_to":"fa6399be_5169fdf7","updated":"2016-10-17 02:44:05.000000000","message":"Done","commit_id":"2df01d28cfb2a72ee7557a6f1f7f87a524cb0f97"}],"tests/unit/plugins/openstack/services/image/test_glance_v1.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"39bc517a9014b630561a1e91d7a7e893fa611df2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                     \"name\": image_name,"},{"line_number":88,"context_line":"                     \"min_disk\": min_disk,"},{"line_number":89,"context_line":"                     \"min_ram\": min_ram}"},{"line_number":90,"context_line":"        self.service.update_image(image_id\u003dimage_id,"},{"line_number":91,"context_line":"                                  image_name\u003dimage_name,"},{"line_number":92,"context_line":"                                  min_disk\u003dmin_disk,"},{"line_number":93,"context_line":"                                  min_ram\u003dmin_ram,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ff52f3f_5edca445","line":90,"updated":"2017-04-13 07:48:24.000000000","message":"pls assert returned value of self.service.update_image.","commit_id":"d5f7906da32d6887dfb078d3d56d03bc34b52920"}],"tests/unit/plugins/openstack/services/image/test_glance_v2.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"39bc517a9014b630561a1e91d7a7e893fa611df2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                     \"min_disk\": min_disk,"},{"line_number":88,"context_line":"                     \"min_ram\": min_ram,"},{"line_number":89,"context_line":"                     \"remove_props\": remove_props}"},{"line_number":90,"context_line":"        self.service.update_image(image_id\u003dimage_id,"},{"line_number":91,"context_line":"                                  image_name\u003dimage_name,"},{"line_number":92,"context_line":"                                  min_disk\u003dmin_disk,"},{"line_number":93,"context_line":"                                  min_ram\u003dmin_ram,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ff52f3f_1e94dc43","line":90,"updated":"2017-04-13 07:48:24.000000000","message":"pls assert returned value of self.service.update_image, and add the test case if name \u003d None.\nThe same for v1","commit_id":"d5f7906da32d6887dfb078d3d56d03bc34b52920"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"c5a8e4deac4960fa75f2a401270a3776f9e249c4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.assertEqual(image, self.mock_wait_for_status.mock.return_value)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def test_update_image(self):"},{"line_number":79,"context_line":"        image_id \u003d \"image_id\""},{"line_number":80,"context_line":"        image_name \u003d self.name_generator.return_value"},{"line_number":81,"context_line":"        min_disk \u003d 0"},{"line_number":82,"context_line":"        min_ram \u003d 0"},{"line_number":83,"context_line":"        remove_props \u003d None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        call_args \u003d {\"image_id\": image_id,"},{"line_number":86,"context_line":"                     \"name\": image_name,"},{"line_number":87,"context_line":"                     \"min_disk\": min_disk,"},{"line_number":88,"context_line":"                     \"min_ram\": min_ram,"},{"line_number":89,"context_line":"                     \"remove_props\": remove_props}"},{"line_number":90,"context_line":"        image \u003d self.service.update_image(image_id\u003dimage_id,"},{"line_number":91,"context_line":"                                          image_name\u003dNone,"},{"line_number":92,"context_line":"                                          min_disk\u003dmin_disk,"},{"line_number":93,"context_line":"                                          min_ram\u003dmin_ram,"},{"line_number":94,"context_line":"                                          remove_props\u003dremove_props)"},{"line_number":95,"context_line":"        self.assertEqual(self.gc.images.update.return_value, image)"},{"line_number":96,"context_line":"        self.gc.images.update.assert_called_once_with(**call_args)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_get_image(self):"},{"line_number":99,"context_line":"        image_id \u003d \"image_id\""}],"source_content_type":"text/x-python","patch_set":14,"id":"7ffa3b31_6f98ce69","line":96,"range":{"start_line":79,"start_character":0,"end_line":96,"end_character":66},"updated":"2017-04-14 09:17:21.000000000","message":"@MaXinjian, my means we should test all cases. Here is image_name equals None or not. If image_name is None,  self.name_generator should be called.","commit_id":"d0570fae180cea810468d4c9f4d5e24bf910a4e8"}]}
