)]}'
{"rally-jobs/cinder.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        failure_rate:"},{"line_number":553,"context_line":"          max: 0"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  CinderVolumes.create_incremental_volume_backup:"},{"line_number":556,"context_line":"    -"},{"line_number":557,"context_line":"      args:"},{"line_number":558,"context_line":"        size: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_6c7b387c","line":555,"updated":"2016-10-18 12:29:30.000000000","message":"CinderVolumeBackups.create_incremental_volume_backup","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":556,"context_line":"    -"},{"line_number":557,"context_line":"      args:"},{"line_number":558,"context_line":"        size: 1"},{"line_number":559,"context_line":"        do_delete: True"},{"line_number":560,"context_line":"      runner:"},{"line_number":561,"context_line":"        type: \"constant\""},{"line_number":562,"context_line":"        times: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_6cf25808","line":559,"updated":"2016-10-18 12:29:30.000000000","message":"please use jinja2, if you want to test both do_delete: True, False. Those configs pretty similar","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        concurrency: 2"},{"line_number":564,"context_line":"      context:"},{"line_number":565,"context_line":"        users:"},{"line_number":566,"context_line":"          tenants: 1"},{"line_number":567,"context_line":"          users_per_tenant: 1"},{"line_number":568,"context_line":"        roles:"},{"line_number":569,"context_line":"          - \"Member\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_11d8171d","line":566,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":564,"context_line":"      context:"},{"line_number":565,"context_line":"        users:"},{"line_number":566,"context_line":"          tenants: 1"},{"line_number":567,"context_line":"          users_per_tenant: 1"},{"line_number":568,"context_line":"        roles:"},{"line_number":569,"context_line":"          - \"Member\""},{"line_number":570,"context_line":"      sla:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_d1cdbf5e","line":567,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"16c77b6efd13aeb3dc0d628cc01ec7c6e9b1366b","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        do_delete: False"},{"line_number":577,"context_line":"      runner:"},{"line_number":578,"context_line":"        type: \"constant\""},{"line_number":579,"context_line":"        times: 2"},{"line_number":580,"context_line":"        concurrency: 2"},{"line_number":581,"context_line":"      context:"},{"line_number":582,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_cc9fe44e","line":579,"range":{"start_line":579,"start_character":12,"end_line":579,"end_character":13},"updated":"2016-10-18 12:36:12.000000000","message":"Please make it like in c0nfig above, 5","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        concurrency: 2"},{"line_number":581,"context_line":"      context:"},{"line_number":582,"context_line":"        users:"},{"line_number":583,"context_line":"          tenants: 1"},{"line_number":584,"context_line":"          users_per_tenant: 1"},{"line_number":585,"context_line":"        roles:"},{"line_number":586,"context_line":"          - \"Member\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_31035b78","line":583,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":581,"context_line":"      context:"},{"line_number":582,"context_line":"        users:"},{"line_number":583,"context_line":"          tenants: 1"},{"line_number":584,"context_line":"          users_per_tenant: 1"},{"line_number":585,"context_line":"        roles:"},{"line_number":586,"context_line":"          - \"Member\""},{"line_number":587,"context_line":"      sla:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_71fdd36d","line":584,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9d575afef6c42e70ce0c561d4b80c977df21174b","unresolved":false,"context_lines":[{"line_number":567,"context_line":"          tenants: 2"},{"line_number":568,"context_line":"          users_per_tenant: 2"},{"line_number":569,"context_line":"        roles:"},{"line_number":570,"context_line":"          - \"Member\""},{"line_number":571,"context_line":"      sla:"},{"line_number":572,"context_line":"        failure_rate:"},{"line_number":573,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_cc025d09","line":570,"updated":"2016-10-30 19:16:16.000000000","message":"maybe admin role will fix scenario?","commit_id":"3370d985c05a1f306fbd9e0941eb77a05cb655e1"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"5dac11b188b47358b8295d6073d8da6b9ec8e975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"da4df55a_b782c392","updated":"2016-12-23 11:08:18.000000000","message":"Recommended setting times,concurrency,users,tenants to 1.","commit_id":"59427f403d9a111a56eb6c8ba5ea2b23260a2840"}],"rally/plugins/openstack/scenarios/cinder/volume_backups.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Fujitsu Fnst."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f1f1e396","line":1,"updated":"2016-10-18 12:29:30.000000000","message":"please remove the first line","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\"\"\"Scenarios for Cinder Volume Backup.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@validation.required_cinder_services(\"cinder-backup\")"},{"line_number":28,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":29,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":30,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d1fe9f37","line":27,"updated":"2016-10-18 12:29:30.000000000","message":"https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/network.py#L82 please add such validator for size","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"c853501de6a4e1a8c11b357ae85eb222ac3d3e33","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class CreateIncrementalVolumeBackup(cinder_utils.CinderScenario,"},{"line_number":34,"context_line":"                                    nova_utils.NovaScenario,"},{"line_number":35,"context_line":"                                    glance_utils.GlanceScenario):"},{"line_number":36,"context_line":"    def run(self, size, do_delete\u003dTrue, create_volume_kwargs\u003dNone,"},{"line_number":37,"context_line":"            create_backup_kwargs\u003dNone):"},{"line_number":38,"context_line":"        \"\"\"Create a incremental volume backup."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_1d74b333","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":66},"updated":"2016-10-27 12:05:23.000000000","message":"Here and everywhere in the code \u0027do_delete\u0027 parameter is always set to True. Maybe make sense to set it to \u0027False\u0027 by default?","commit_id":"70be90693e650046d91144de84d634f49e67b720"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"c963995d26d8a26301b1bcf2ef8b93bf63907d10","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class CreateIncrementalVolumeBackup(cinder_utils.CinderScenario,"},{"line_number":34,"context_line":"                                    nova_utils.NovaScenario,"},{"line_number":35,"context_line":"                                    glance_utils.GlanceScenario):"},{"line_number":36,"context_line":"    def run(self, size, do_delete\u003dTrue, create_volume_kwargs\u003dNone,"},{"line_number":37,"context_line":"            create_backup_kwargs\u003dNone):"},{"line_number":38,"context_line":"        \"\"\"Create a incremental volume backup."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_efed778c","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":66},"in_reply_to":"ba5da102_1d74b333","updated":"2016-10-28 01:43:48.000000000","message":"sorry,I don\u0027t think so.I don\u0027t know what the meaning is to set it to \u0027False\u0027 by default?","commit_id":"70be90693e650046d91144de84d634f49e67b720"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e4093d15c2752996e8f4a111fa1f04f618b11204","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    name\u003d\"CinderVolumeBackups.\""},{"line_number":32,"context_line":"                    \"create_incremental_volume_backup\")"},{"line_number":33,"context_line":"class CreateIncrementalVolumeBackup(cinder_utils.CinderScenario,"},{"line_number":34,"context_line":"                                    nova_utils.NovaScenario,"},{"line_number":35,"context_line":"                                    glance_utils.GlanceScenario):"},{"line_number":36,"context_line":"    def run(self, size, do_delete\u003dTrue, create_volume_kwargs\u003dNone,"},{"line_number":37,"context_line":"            create_backup_kwargs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_ddf47b5c","line":34,"updated":"2016-12-05 18:41:14.000000000","message":"Why do we need nova and glance utils here?","commit_id":"276719cc40e9c0a36c7dec5086e07ae4457a1b28"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4ee7ae3b02e07dcdeca7dc8abfe48f74ceb35630","unresolved":false,"context_lines":[{"line_number":28,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\"]},"},{"line_number":29,"context_line":"                    name\u003d\"CinderVolumeBackups.\""},{"line_number":30,"context_line":"                    \"create_incremental_volume_backup\")"},{"line_number":31,"context_line":"class CreateIncrementalVolumeBackup(cinder_utils.CinderScenario):"},{"line_number":32,"context_line":"    def run(self, size, create_volume_kwargs\u003dNone,"},{"line_number":33,"context_line":"            create_backup_kwargs\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Create a incremental volume backup."}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_9bc40660","line":31,"updated":"2017-01-16 05:29:17.000000000","message":"Rename it to CreateIncrementalVolumeBackupAndDelete, for example, or return do_delete parameter","commit_id":"9ed6d9aca227c48c91efcba7f8a3d0b061f596d1"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"62fb8a3d1c782b6d019471f3bfde50ee2c376ed9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\"]},"},{"line_number":29,"context_line":"                    name\u003d\"CinderVolumeBackups.\""},{"line_number":30,"context_line":"                    \"create_incremental_volume_backup\")"},{"line_number":31,"context_line":"class CreateIncrementalVolumeBackup(cinder_utils.CinderScenario):"},{"line_number":32,"context_line":"    def run(self, size, create_volume_kwargs\u003dNone,"},{"line_number":33,"context_line":"            create_backup_kwargs\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Create a incremental volume backup."}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_5b3b7e38","line":31,"in_reply_to":"7a3c09a3_9bc40660","updated":"2017-01-16 07:23:48.000000000","message":"Done","commit_id":"9ed6d9aca227c48c91efcba7f8a3d0b061f596d1"}],"samples/tasks/scenarios/cinder/create-incremental-volume-backup.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"runner\": {"},{"line_number":11,"context_line":"                \"type\": \"constant\","},{"line_number":12,"context_line":"                \"times\": 2,"},{"line_number":13,"context_line":"                \"concurrency\": 1"},{"line_number":14,"context_line":"            },"},{"line_number":15,"context_line":"            \"context\": {"},{"line_number":16,"context_line":"                \"users\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_d1693f27","line":13,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            },"},{"line_number":15,"context_line":"            \"context\": {"},{"line_number":16,"context_line":"                \"users\": {"},{"line_number":17,"context_line":"                    \"tenants\": 1,"},{"line_number":18,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":19,"context_line":"                },"},{"line_number":20,"context_line":"                \"roles\": [\"Member\"]"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_f1764305","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":30},"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"context\": {"},{"line_number":16,"context_line":"                \"users\": {"},{"line_number":17,"context_line":"                    \"tenants\": 1,"},{"line_number":18,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":19,"context_line":"                },"},{"line_number":20,"context_line":"                \"roles\": [\"Member\"]"},{"line_number":21,"context_line":"            },"}],"source_content_type":"application/json","patch_set":1,"id":"fa6399be_51644f48","line":18,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"}],"samples/tasks/scenarios/cinder/create-incremental-volume-backup.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      runner:"},{"line_number":10,"context_line":"        type: \"constant\""},{"line_number":11,"context_line":"        times: 2"},{"line_number":12,"context_line":"        concurrency: 1"},{"line_number":13,"context_line":"      context:"},{"line_number":14,"context_line":"        users:"},{"line_number":15,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_d1505f61","line":12,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        concurrency: 1"},{"line_number":13,"context_line":"      context:"},{"line_number":14,"context_line":"        users:"},{"line_number":15,"context_line":"          tenants: 1"},{"line_number":16,"context_line":"          users_per_tenant: 1"},{"line_number":17,"context_line":"        roles:"},{"line_number":18,"context_line":"          - \"Member\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_51cb6f1e","line":15,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      context:"},{"line_number":14,"context_line":"        users:"},{"line_number":15,"context_line":"          tenants: 1"},{"line_number":16,"context_line":"          users_per_tenant: 1"},{"line_number":17,"context_line":"        roles:"},{"line_number":18,"context_line":"          - \"Member\""},{"line_number":19,"context_line":"      sla:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_f14d63c5","line":16,"updated":"2016-10-18 12:29:30.000000000","message":"please increase it to 2","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volume_backup.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b34a399c5815f3f8cbe149d5a516edba88c0a460","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    name \u003d \"fake\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@ddt.ddt"},{"line_number":31,"context_line":"class CinderBackupTestCase(test.ScenarioTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_create_incremental_volume_backup(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ec4ae854","line":30,"updated":"2016-10-18 12:29:30.000000000","message":"I don\u0027t see usage of it","commit_id":"cd1cd26ed1ab05633a06be5af7e03709e3d49e3f"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volume_backups.py":[{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"c853501de6a4e1a8c11b357ae85eb222ac3d3e33","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.plugins.openstack.scenarios.cinder import volume_backups"},{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"CINDER_VOLUMES \u003d (\"rally.plugins.openstack.scenarios.cinder.volume_backups\""},{"line_number":21,"context_line":"                  \".CinderVolumeBackups\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class fake_type(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_7df3ef0a","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":41},"updated":"2016-10-27 12:05:23.000000000","message":"This constant is never used, please remove","commit_id":"70be90693e650046d91144de84d634f49e67b720"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"c853501de6a4e1a8c11b357ae85eb222ac3d3e33","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    name \u003d \"fake\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class CinderBackupTestCase(test.ScenarioTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_create_incremental_volume_backup(self):"},{"line_number":31,"context_line":"        fake_volume \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_3db6d7dc","line":28,"updated":"2016-10-27 12:05:23.000000000","message":"Is it make sense to add test for case when \u0027do_delete\u0027 is set to False?","commit_id":"70be90693e650046d91144de84d634f49e67b720"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"c853501de6a4e1a8c11b357ae85eb222ac3d3e33","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        scenario._delete_volume.assert_called_once_with(fake_volume)"},{"line_number":44,"context_line":"        scenario._delete_backup.assert_called_once_with(fake_backup)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_scenario(self, scenario, fake_volume,"},{"line_number":47,"context_line":"                      fake_backup, fake_restore\u003dNone):"},{"line_number":48,"context_line":"        scenario._create_volume \u003d mock.MagicMock(return_value\u003dfake_volume)"},{"line_number":49,"context_line":"        scenario._create_backup \u003d mock.MagicMock(return_value\u003dfake_backup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_7d0f6fe1","line":46,"updated":"2016-10-27 12:05:23.000000000","message":"Please define method before calling","commit_id":"70be90693e650046d91144de84d634f49e67b720"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"75235935e6d5cc3150d3e57de67a668914690b41","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class fake_type(object):"},{"line_number":22,"context_line":"    name \u003d \"fake\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_ae70360c","line":21,"updated":"2016-11-03 12:50:09.000000000","message":"Please use standard CamelCase naming convention for class name","commit_id":"1dc17516b97b103d5db83d9ebd09326e62143667"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"75235935e6d5cc3150d3e57de67a668914690b41","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        scenario._delete_volume.assert_called_once_with(fake_volume)"},{"line_number":41,"context_line":"        scenario._delete_backup.assert_called_once_with(fake_backup)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_scenario(self, scenario, fake_volume,"},{"line_number":44,"context_line":"                      fake_backup, fake_restore\u003dNone):"},{"line_number":45,"context_line":"        scenario._create_volume \u003d mock.MagicMock(return_value\u003dfake_volume)"},{"line_number":46,"context_line":"        scenario._create_backup \u003d mock.MagicMock(return_value\u003dfake_backup)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_ae8cb6da","line":43,"updated":"2016-11-03 12:50:09.000000000","message":"All actions in this method are implicit.\n\nPlease change them to explicit (return the scenario explicitly), for example:\n\n def _get_scenario(self, context, fake_volume,\n                      fake_backup, fake_restore\u003dNone)\n     scenario \u003d volume_backups.CreateIncrementalVolumeBackup(context)\n     scenario._create_volume \u003d ...\n     ...\n     return scenario","commit_id":"1dc17516b97b103d5db83d9ebd09326e62143667"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e4093d15c2752996e8f4a111fa1f04f618b11204","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FakeType(object):"},{"line_number":22,"context_line":"    name \u003d \"fake\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_9d4923ba","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":15},"updated":"2016-12-05 18:41:14.000000000","message":"This class is defined but not used","commit_id":"276719cc40e9c0a36c7dec5086e07ae4457a1b28"}]}