)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2e6be422e4110fcf2de4bad8a9dc812ac5f8af80","unresolved":false,"context_lines":[{"line_number":12,"context_line":"To avoid that DEFAULT_CONFIG is instantiated in"},{"line_number":13,"context_line":"the __init__ method now"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: 1634474"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib81298223f31a68d9f79e267654dc35eba58cb95"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8b994822","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":12},"updated":"2016-10-18 16:28:01.000000000","message":"it sounds like \"Closes-Bug: #\"","commit_id":"2e105c2782c08691541670ce3e7c1eb3f11cbb26"}],"rally/plugins/openstack/context/keystone/users.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a18d9e86b97020e1518314c5131b815d08b34db7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def __init__(self, context):"},{"line_number":142,"context_line":"        UserGenerator.DEFAULT_CONFIG \u003d {"},{"line_number":143,"context_line":"            \"tenants\": 1,"},{"line_number":144,"context_line":"            \"users_per_tenant\": 1,"},{"line_number":145,"context_line":"            \"resource_management_workers\":"},{"line_number":146,"context_line":"                cfg.CONF.users_context.resource_management_workers,"},{"line_number":147,"context_line":"            \"project_domain\": cfg.CONF.users_context.project_domain,"},{"line_number":148,"context_line":"            \"user_domain\": cfg.CONF.users_context.user_domain,"},{"line_number":149,"context_line":"            \"user_choice_method\": \"random\","},{"line_number":150,"context_line":"        }"},{"line_number":151,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":152,"context_line":"        self.credential \u003d self.context[\"admin\"][\"credential\"]"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8bf2286e","line":150,"range":{"start_line":142,"start_character":8,"end_line":150,"end_character":9},"updated":"2016-10-18 16:27:22.000000000","message":"it is strange. moving DEFAULT_CONFIG to __init__ method should not help at all, since values from it are used in super init method. At point of time when super init method is called, DEFAULT_CONFIG will exists, so nothing is changed.\n\nI think we should leave DEFAULT_CONFIG variable where it was, remove project_domain and user_domain from it, but add following block in __init__ method instead:\n\n   def __init__(self, ctx):\n       self.credential \u003d ctx[\"admin\"][\"credential\"] \n       self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain\n       self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain\n       super(...)","commit_id":"2e105c2782c08691541670ce3e7c1eb3f11cbb26"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9226a15c08961ce1880aad6cb8dbeea23dcfdc1e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        \"additionalProperties\": False"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        DEFAULT_CONFIG \u003d {"},{"line_number":142,"context_line":"            \"tenants\": 1,"},{"line_number":143,"context_line":"            \"users_per_tenant\": 1,"},{"line_number":144,"context_line":"            \"resource_management_workers\":"},{"line_number":145,"context_line":"                cfg.CONF.users_context.resource_management_workers,"},{"line_number":146,"context_line":"            \"user_choice_method\": \"random\","},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_792c9c4a","line":147,"range":{"start_line":141,"start_character":0,"end_line":147,"end_character":9},"updated":"2016-10-19 15:57:39.000000000","message":"this block has extra indentation.","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":13340,"name":"Konstantin Baikov","email":"konstantin.baikov@gmail.com","username":"kbaikov"},"change_message_id":"16cb74a1c99bdc7cc08662277bd010d5dd3be08d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        \"additionalProperties\": False"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        DEFAULT_CONFIG \u003d {"},{"line_number":142,"context_line":"            \"tenants\": 1,"},{"line_number":143,"context_line":"            \"users_per_tenant\": 1,"},{"line_number":144,"context_line":"            \"resource_management_workers\":"},{"line_number":145,"context_line":"                cfg.CONF.users_context.resource_management_workers,"},{"line_number":146,"context_line":"            \"user_choice_method\": \"random\","},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_8a7e5068","line":147,"range":{"start_line":141,"start_character":0,"end_line":147,"end_character":9},"in_reply_to":"fa6399be_792c9c4a","updated":"2016-10-20 11:42:39.000000000","message":"Done","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9226a15c08961ce1880aad6cb8dbeea23dcfdc1e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "},{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_5968b887","line":150,"range":{"start_line":150,"start_character":56,"end_line":150,"end_character":57},"updated":"2016-10-19 15:57:39.000000000","message":"remove this whitespace","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":13340,"name":"Konstantin Baikov","email":"konstantin.baikov@gmail.com","username":"kbaikov"},"change_message_id":"16cb74a1c99bdc7cc08662277bd010d5dd3be08d","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "},{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_6a79fc81","line":150,"range":{"start_line":150,"start_character":56,"end_line":150,"end_character":57},"in_reply_to":"fa6399be_5968b887","updated":"2016-10-20 11:42:39.000000000","message":"Done","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9226a15c08961ce1880aad6cb8dbeea23dcfdc1e","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "},{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":154,"context_line":"        self.credential \u003d self.context[\"admin\"][\"credential\"]"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_79a1fca8","line":152,"range":{"start_line":151,"start_character":8,"end_line":152,"end_character":115},"updated":"2016-10-19 15:57:39.000000000","message":"pep8 job will not pass, since length of line \u003e 79 characters. You can split it like:\n\n        project_domain \u003d (self.credential.project_domain_name or\n                          cfg.CONF.users_context.project_domain)\n        user_domain \u003d (self.credential.user_domain_name or \n                       cfg.CONF.users_context.user_domain)\n        self.DEFAULT_CONFIG[\"project_domain\"] \u003d project_domain\n        self.DEFAULT_CONFIG[\"user_domain\"] \u003d user_domain","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":13340,"name":"Konstantin Baikov","email":"konstantin.baikov@gmail.com","username":"kbaikov"},"change_message_id":"16cb74a1c99bdc7cc08662277bd010d5dd3be08d","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, context):"},{"line_number":150,"context_line":"        self.credential \u003d context[\"admin\"][\"credential\"] "},{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":154,"context_line":"        self.credential \u003d self.context[\"admin\"][\"credential\"]"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_4a88b871","line":152,"range":{"start_line":151,"start_character":8,"end_line":152,"end_character":115},"in_reply_to":"fa6399be_79a1fca8","updated":"2016-10-20 11:42:39.000000000","message":"Done","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9226a15c08961ce1880aad6cb8dbeea23dcfdc1e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":154,"context_line":"        self.credential \u003d self.context[\"admin\"][\"credential\"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _remove_default_security_group(self):"},{"line_number":157,"context_line":"        \"\"\"Delete default security group for tenants.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_996170ab","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":61},"updated":"2016-10-19 15:57:39.000000000","message":"this line is redundant now","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"},{"author":{"_account_id":13340,"name":"Konstantin Baikov","email":"konstantin.baikov@gmail.com","username":"kbaikov"},"change_message_id":"16cb74a1c99bdc7cc08662277bd010d5dd3be08d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.DEFAULT_CONFIG[\"project_domain\"] \u003d self.credential.project_domain_name or cfg.CONF.users_context.project_domain"},{"line_number":152,"context_line":"        self.DEFAULT_CONFIG[\"user_domain\"] \u003d self.credential.user_domain_name or cfg.CONF.users_context.user_domain"},{"line_number":153,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":154,"context_line":"        self.credential \u003d self.context[\"admin\"][\"credential\"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _remove_default_security_group(self):"},{"line_number":157,"context_line":"        \"\"\"Delete default security group for tenants.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_aa97948e","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":61},"in_reply_to":"fa6399be_996170ab","updated":"2016-10-20 11:42:39.000000000","message":"Done","commit_id":"04748fd69b168fd904b87e638d34722bd68ae20a"}]}
