)]}'
{"rally-jobs/cinder.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9c896bc834ef64309d0077bb08fdc491f3c26a8d","unresolved":false,"context_lines":[{"line_number":303,"context_line":"      args:"},{"line_number":304,"context_line":"        size: 1"},{"line_number":305,"context_line":"        image:"},{"line_number":306,"context_line":"          name: {{image_name}}"},{"line_number":307,"context_line":"      runner:"},{"line_number":308,"context_line":"        type: \"constant\""},{"line_number":309,"context_line":"        times: 3"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_12018eaf","line":306,"updated":"2016-10-20 15:49:43.000000000","message":"please use jinja2. They are similar","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e66f6de8195b909d87c0f8ac6586f2755509cf11","unresolved":false,"context_lines":[{"line_number":303,"context_line":"      args:"},{"line_number":304,"context_line":"        size: 1"},{"line_number":305,"context_line":"        image:"},{"line_number":306,"context_line":"          name: {{image_name}}"},{"line_number":307,"context_line":"      runner:"},{"line_number":308,"context_line":"        type: \"constant\""},{"line_number":309,"context_line":"        times: 3"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6895a0_8c2fcaa0","line":306,"in_reply_to":"fa6399be_12018eaf","updated":"2016-10-21 03:39:19.000000000","message":"sorry，I have tried but failed... \n{% for s in (\"None\", \"{{image_name}}\" %}\n ...\n image:\n          name: {{s}}\n ...\n{% endfor %}\n\ncreate a bootable volume with setting name to None is different with create a  none bootable volume","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"}],"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9c896bc834ef64309d0077bb08fdc491f3c26a8d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        return self.clients(\"nova\").servers.get(server_id)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @atomic.action_timer(\"cinder.transfer_create\")"},{"line_number":362,"context_line":"    def _transfer_create(self, volume_id, name\u003dNone):"},{"line_number":363,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        :param volume_id: The ID of the volume to transfer"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_72c00a51","line":362,"updated":"2016-10-20 15:49:43.000000000","message":"you need to add transfers into the https://github.com/openstack/rally/blob/master/tests/ci/osresources.py#L231","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e66f6de8195b909d87c0f8ac6586f2755509cf11","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        return self.clients(\"nova\").servers.get(server_id)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @atomic.action_timer(\"cinder.transfer_create\")"},{"line_number":362,"context_line":"    def _transfer_create(self, volume_id, name\u003dNone):"},{"line_number":363,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        :param volume_id: The ID of the volume to transfer"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_2c179e52","line":362,"in_reply_to":"fa6399be_72c00a51","updated":"2016-10-21 03:39:19.000000000","message":"Done","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9c896bc834ef64309d0077bb08fdc491f3c26a8d","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        :param volume_id: The ID of the volume to transfer"},{"line_number":366,"context_line":"        :param name: The name of the transfer"},{"line_number":367,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":"        return self.clients(\"cinder\").transfers.create(volume_id, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d296364b","line":366,"updated":"2016-10-20 15:49:43.000000000","message":"we shouldn\u0027t allow custom names. please use generate_random_name()","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e66f6de8195b909d87c0f8ac6586f2755509cf11","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        :param volume_id: The ID of the volume to transfer"},{"line_number":366,"context_line":"        :param name: The name of the transfer"},{"line_number":367,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":"        return self.clients(\"cinder\").transfers.create(volume_id, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_4c0cd242","line":366,"in_reply_to":"fa6399be_d296364b","updated":"2016-10-21 03:39:19.000000000","message":"Done","commit_id":"d59f72f811565a9d1ade7c5b1615feb6935c51ab"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a7d20e9fe53cba964f2d12d9f07402e5e35cc274","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        :param volume_id: The ID of the volume to transfer"},{"line_number":400,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        name \u003d self.generate_random_name()"},{"line_number":403,"context_line":"        return self.clients(\"cinder\").transfers.create(volume_id, name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_f3c77561","line":400,"updated":"2016-11-03 12:22:45.000000000","message":":returns: VolumeTransfer\n\n\n:class: is confusing 1) this form of documenting is at least rare and 2) this sounds like return value is a class, not its instance\n\nThere is a special label for specifying return value type,\nhowever even in this case just name of class is enough:\n\n :rtype: VolumeTransfer","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"3663e4bce56e70309682a46f090322a767a1ee3d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        \"\"\"Create a volume transfer."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        :param volume_id: The ID of the volume to transfer"},{"line_number":400,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        name \u003d self.generate_random_name()"},{"line_number":403,"context_line":"        return self.clients(\"cinder\").transfers.create(volume_id, name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_ce131a0c","line":400,"in_reply_to":"ba5da102_f3c77561","updated":"2016-11-09 09:25:09.000000000","message":"Done","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5520e6372f2979446b2bb5c4d0d414c94044c1d0","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param transfer_id: The ID of the transfer to accept."},{"line_number":410,"context_line":"        :param auth_key: The auth_key of the transfer."},{"line_number":411,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.clients(\"cinder\").transfers.accept(transfer_id, auth_key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_139a296e","line":411,"updated":"2016-11-03 12:25:38.000000000","message":"same here","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"3663e4bce56e70309682a46f090322a767a1ee3d","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param transfer_id: The ID of the transfer to accept."},{"line_number":410,"context_line":"        :param auth_key: The auth_key of the transfer."},{"line_number":411,"context_line":"        :returns: :class:`VolumeTransfer`"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.clients(\"cinder\").transfers.accept(transfer_id, auth_key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_0ef6f2d6","line":411,"in_reply_to":"ba5da102_139a296e","updated":"2016-11-09 09:25:09.000000000","message":"Done","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"20d59b8cb3624a1846a852bbd33e7836bf786d96","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        Measure the \"cinder transfer-create\" and \"cinder transfer-accept\""},{"line_number":781,"context_line":"        command performace."},{"line_number":782,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":783,"context_line":"        :param kwargs: optional args to create a volume"},{"line_number":784,"context_line":"        \"\"\""},{"line_number":785,"context_line":"        if image:"},{"line_number":786,"context_line":"            kwargs[\"imageRef\"] \u003d image"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_741e7c64","line":783,"updated":"2016-11-08 17:28:46.000000000","message":"Document the image param.","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"866fcf5eadab47fee4623a6cef6f6fd1b152537f","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        Measure the \"cinder transfer-create\" and \"cinder transfer-accept\""},{"line_number":781,"context_line":"        command performace."},{"line_number":782,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":783,"context_line":"        :param kwargs: optional args to create a volume"},{"line_number":784,"context_line":"        \"\"\""},{"line_number":785,"context_line":"        if image:"},{"line_number":786,"context_line":"            kwargs[\"imageRef\"] \u003d image"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_4131aa04","line":783,"in_reply_to":"9a629dbe_741e7c64","updated":"2016-11-09 02:36:14.000000000","message":"Done","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volumes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"20d59b8cb3624a1846a852bbd33e7836bf786d96","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        self.assertFalse(scenario._delete_snapshot.called)"},{"line_number":657,"context_line":"        self.assertFalse(scenario._delete_volume.called)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def test_create_and_accept_transfer(self):"},{"line_number":660,"context_line":"        fake_volume \u003d mock.MagicMock()"},{"line_number":661,"context_line":"        fake_transfer \u003d mock.MagicMock()"},{"line_number":662,"context_line":"        scenario \u003d volumes.CreateAndAcceptTransfer(self._get_context())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_7463dcdc","line":659,"updated":"2016-11-08 17:28:46.000000000","message":"We should also test this with an image. Maybe use ddt to avoid duplicating code when you add that.","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"866fcf5eadab47fee4623a6cef6f6fd1b152537f","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        self.assertFalse(scenario._delete_snapshot.called)"},{"line_number":657,"context_line":"        self.assertFalse(scenario._delete_volume.called)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def test_create_and_accept_transfer(self):"},{"line_number":660,"context_line":"        fake_volume \u003d mock.MagicMock()"},{"line_number":661,"context_line":"        fake_transfer \u003d mock.MagicMock()"},{"line_number":662,"context_line":"        scenario \u003d volumes.CreateAndAcceptTransfer(self._get_context())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_e4af2c92","line":659,"in_reply_to":"9a629dbe_7463dcdc","updated":"2016-11-09 02:36:14.000000000","message":"Thank your suggestion. Done","commit_id":"90252f96b0e8941e618128f9cada2c90ed5d8144"}]}
