)]}'
{"rally-jobs/cinder.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"766890db75e132009a0e9d7b5a20450dabb46b58","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        failure_rate:"},{"line_number":771,"context_line":"          max: 0"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"  CinderVolumesTypes.create_volume_type:"},{"line_number":774,"context_line":"    -"},{"line_number":775,"context_line":"      args: {}"},{"line_number":776,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba5da102_1f1de765","line":773,"updated":"2016-11-02 21:22:24.000000000","message":"CinderVolumeTypes.create_and_delete_volume_type","commit_id":"087c02e0c89fa98aeb4c3808f6ece9d8d431192e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"766890db75e132009a0e9d7b5a20450dabb46b58","unresolved":false,"context_lines":[{"line_number":782,"context_line":"          tenants: 2"},{"line_number":783,"context_line":"          users_per_tenant: 2"},{"line_number":784,"context_line":"      sla:"},{"line_number":785,"context_line":"          failure_rate:"},{"line_number":786,"context_line":"            max: 0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba5da102_c4b80678","line":785,"updated":"2016-11-02 21:22:24.000000000","message":"please an indention","commit_id":"087c02e0c89fa98aeb4c3808f6ece9d8d431192e"}],"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b4bad4f45aa0b24f926a83dbf2fc5f3987011cd8","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        :param kwargs: Optional additional arguments for volume type creation"},{"line_number":366,"context_line":"        :returns: class:`VolumeType`"},{"line_number":367,"context_line":"        \"\"\""},{"line_number":368,"context_line":"        name \u003d self.generate_random_name()"},{"line_number":369,"context_line":"        return self.admin_clients(\"cinder\").volume_types.create(name, **kwargs)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    @atomic.action_timer(\"cinder.delete_volume_type\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_6dbcabbb","line":368,"updated":"2016-10-20 16:06:15.000000000","message":"multiple values for keyword argument name\nkwargs[\"name\"] \u003d self.generate_random_name()","commit_id":"e76905eaf0edbe51dd2d3091a18f24605d1913e7"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b4bad4f45aa0b24f926a83dbf2fc5f3987011cd8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def _delete_volume_type(self, volume_type):"},{"line_number":373,"context_line":"        \"\"\"delete a volume type."},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":376,"context_line":"        \"\"\""},{"line_number":377,"context_line":"        self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_2d8b9369","line":375,"updated":"2016-10-20 16:06:15.000000000","message":"it has return value https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volume_types.py#L114","commit_id":"e76905eaf0edbe51dd2d3091a18f24605d1913e7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"221b7ffd2263b2c2b9976d131d5be4e22bdda9c8","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        \"\"\"create volume type."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        :param kwargs: Optional additional arguments for volume type creation"},{"line_number":400,"context_line":"        :returns: class:`VolumeType`"},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":403,"context_line":"        return self.admin_clients(\"cinder\").volume_types.create(**kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_0206591f","line":400,"updated":"2016-11-03 12:04:46.000000000","message":"Actually an instance. Please remove word `class\u0027","commit_id":"11b556055a8b879d0fe8c8c42020972e8a268cc0"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"70f597db5e43dde3e242afccc8ede87c888b9f9b","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        \"\"\"create volume type."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        :param kwargs: Optional additional arguments for volume type creation"},{"line_number":400,"context_line":"        :returns: class:`VolumeType`"},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":403,"context_line":"        return self.admin_clients(\"cinder\").volume_types.create(**kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_390a9226","line":400,"in_reply_to":"ba5da102_0206591f","updated":"2016-11-04 02:10:44.000000000","message":"ok，thanks","commit_id":"11b556055a8b879d0fe8c8c42020972e8a268cc0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"221b7ffd2263b2c2b9976d131d5be4e22bdda9c8","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"delete a volume type."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: A tuple of http Response and body"},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_b8e07c2a","line":410,"updated":"2016-11-03 12:04:46.000000000","message":"Is that useful to have HTTP response as result? I would recommend to return bool result whether the resource has been actually deleted or not","commit_id":"11b556055a8b879d0fe8c8c42020972e8a268cc0"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"70f597db5e43dde3e242afccc8ede87c888b9f9b","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"delete a volume type."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: A tuple of http Response and body"},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_143d93c3","line":410,"in_reply_to":"ba5da102_b8e07c2a","updated":"2016-11-04 02:10:44.000000000","message":"ok，thanks","commit_id":"11b556055a8b879d0fe8c8c42020972e8a268cc0"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c8c771daa6fe4c54ff6fb70b34fb51b0f1b4dfee","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: bool result whether the resource has"},{"line_number":411,"context_line":"                  been actually deleted or not"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_f63ad9e6","line":411,"updated":"2016-11-07 12:36:18.000000000","message":"Now this docstring is totally wrong its not return bool. It return tuple. Alex don\u0027t like tuple so he suggested to patch client return value and to return in our atomic not the same as the client function. As I understand the suggestion is: base on client response return True if it deleted or False.","commit_id":"93fa0a4bd42f62a8ceac8b42905a0254931783b9"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"407f898437f81370d0a9ed40bf7d4819918026bf","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: bool result whether the resource has"},{"line_number":411,"context_line":"                  been actually deleted or not"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_5520bb9b","line":411,"in_reply_to":"9a629dbe_f63ad9e6","updated":"2016-11-08 03:14:45.000000000","message":"Thank you for your suggestion","commit_id":"93fa0a4bd42f62a8ceac8b42905a0254931783b9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"130a700a517598ece231aa70ae5288c129b9fe53","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"delete a volume type."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: base on client response return True if the resource"},{"line_number":411,"context_line":"                  has been actually deleted or not"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_ff027708","line":410,"updated":"2016-11-08 12:43:42.000000000","message":"This says that return value type is bool.\n\nI\u0027m in doubts that `bool\u0027 type is actually returned. Please clarify this\n\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L327","commit_id":"d1c17869ce01f5435bb09b7f5d53ddf5ed1edc41"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"799760f14d5e58c195091583e56aabd50c0ecdd5","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        \"\"\"delete a volume type."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :param volume_type: Name or Id of the volume type"},{"line_number":410,"context_line":"        :returns: base on client response return True if the resource"},{"line_number":411,"context_line":"                  has been actually deleted or not"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        return self.admin_clients(\"cinder\").volume_types.delete(volume_type)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_243764e4","line":410,"in_reply_to":"9a629dbe_ff027708","updated":"2016-11-09 04:11:05.000000000","message":"Sorry, I am wrong. I will fix the bug.\n\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L327\n\nthe value \u0027\u003cResponse [202]\u003e None\u0027 is returned.","commit_id":"d1c17869ce01f5435bb09b7f5d53ddf5ed1edc41"}],"rally/plugins/openstack/scenarios/cinder/volume_types.py":[{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"2af0ef0299b344836be48c40bc54b028afaba5a3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":27,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_delete_volume_type\")"},{"line_number":28,"context_line":"class CreateAndDeleteVolumeType(cinder_utils.CinderScenario):"},{"line_number":29,"context_line":"    def run(self, **kwargs):"},{"line_number":30,"context_line":"        \"\"\"Create and delete volume Type."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        :param kwargs: Optional parameters used during volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_3ed8b1ef","line":29,"updated":"2016-10-26 08:05:20.000000000","message":"Please add empty line between name of class and definition of method","commit_id":"0fd98e21f5cf714a84f2b88622e56871ad16ea1e"}],"tests/unit/plugins/openstack/cleanup/test_resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"766890db75e132009a0e9d7b5a20450dabb46b58","unresolved":false,"context_lines":[{"line_number":961,"context_line":"        volume_types \u003d [mock.MagicMock(name\u003d\"rally_foo1\"),"},{"line_number":962,"context_line":"                        mock.MagicMock(name\u003d\"rally_foo2\"),"},{"line_number":963,"context_line":"                        mock.MagicMock(name\u003d\"foo3\")]"},{"line_number":964,"context_line":"        mock_name_matches_object.side_effect \u003d [False, True, True]"},{"line_number":965,"context_line":"        mock_resource_manager__manager().list.return_value \u003d volume_types"},{"line_number":966,"context_line":"        self.assertEqual(volume_types[1:], resources.CinderVolumeType().list())"},{"line_number":967,"context_line":"        mock_name_matches_object.assert_has_calls("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_a4f23204","line":964,"updated":"2016-11-02 21:22:24.000000000","message":"this may confuse. If pattern here is rally_ then it should be [True, True, False]","commit_id":"087c02e0c89fa98aeb4c3808f6ece9d8d431192e"}],"tests/unit/plugins/openstack/scenarios/cinder/test_utils.py":[{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"1eadd6e6d1123b23d5aaec0133ecfe6fa0d9241b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        self._test_atomic_action_timer(self.scenario.atomic_actions(),"},{"line_number":350,"context_line":"                                       \"cinder.create_volume_type\")"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def test_delete_volume_type(self):"},{"line_number":353,"context_line":"        volume_type \u003d mock.Mock()"},{"line_number":354,"context_line":"        self.scenario._delete_volume_type(volume_type)"},{"line_number":355,"context_line":"        admin_clients \u003d self.admin_clients(\"cinder\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_dc7684a2","line":352,"updated":"2016-10-19 12:22:25.000000000","message":"Please add \u0027_\u0027 into name of test","commit_id":"11012547510c9f6cb238a7bfce47260781f79ac5"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volume_types.py":[{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"1eadd6e6d1123b23d5aaec0133ecfe6fa0d9241b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from rally.plugins.openstack.scenarios.cinder import volume_types"},{"line_number":20,"context_line":"from tests.unit import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CINDER_VOLUMES \u003d (\"rally.plugins.openstack.scenarios.cinder.volume_types\""},{"line_number":23,"context_line":"                  \".CinderVolumeTypes\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5c919499","line":22,"updated":"2016-10-19 12:22:25.000000000","message":"This constant is never used, please remove it.","commit_id":"11012547510c9f6cb238a7bfce47260781f79ac5"}]}