)]}'
{"rally-jobs/plugins/rally_profile.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a0abcb3b1b7b558e9eeb68e5bab24ac396f22e2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_22b5efcc","line":1,"updated":"2016-10-26 11:54:15.000000000","message":"2016","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a0abcb3b1b7b558e9eeb68e5bab24ac396f22e2b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RallyProfile(scenario.Scenario, utils.RandomNameGeneratorMixin):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @scenario.configure()"},{"line_number":25,"context_line":"    def generate_names_in_atomic(self, number_of_names):"},{"line_number":26,"context_line":"        \"\"\"Generate random names in atomic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param number_of_names: int number of names to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_e293f74d","line":25,"updated":"2016-10-26 11:54:15.000000000","message":"1) Do we need this scenario? Method \"generate_random_name\" is something internal so we can just make private test in local file, maybe there is no need to expose this test as scenario.\n\nIf answer is \"yes wee need\", do we need to have scenarios which measure different classes (e.g. wrappers) instantiation time as well?\n\n2) This is an old style (method-based scenario). We have already switched to class-based style","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"146b8b53b430b98e2d456269228f91774cc46e6e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RallyProfile(scenario.Scenario, utils.RandomNameGeneratorMixin):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @scenario.configure()"},{"line_number":25,"context_line":"    def generate_names_in_atomic(self, number_of_names):"},{"line_number":26,"context_line":"        \"\"\"Generate random names in atomic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param number_of_names: int number of names to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_98c54a5d","line":25,"in_reply_to":"ba5da102_9869ca8e","updated":"2016-10-26 12:47:03.000000000","message":"Regarding \"1)\" - got it","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"99c85251e67a3a724f0a1b7bb55d3247ddded42c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RallyProfile(scenario.Scenario, utils.RandomNameGeneratorMixin):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @scenario.configure()"},{"line_number":25,"context_line":"    def generate_names_in_atomic(self, number_of_names):"},{"line_number":26,"context_line":"        \"\"\"Generate random names in atomic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param number_of_names: int number of names to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9869ca8e","line":25,"in_reply_to":"ba5da102_e293f74d","updated":"2016-10-26 12:44:12.000000000","message":"1) some folks think that generation name takes too much time and affects \"real numbers of benchmarks\". Separate scenario, instead of just unit test, can simulate \"real usage of generate_name call\" and it is easier to share results with somebody.\nSince it is a check for \"internal thing\", it is located in ci plugins, not in our main plugin location:)\n\n2) +1","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"102271ba46183239009d73188b832b4697f20af4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RallyProfile(scenario.Scenario, utils.RandomNameGeneratorMixin):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @scenario.configure()"},{"line_number":25,"context_line":"    def generate_names_in_atomic(self, number_of_names):"},{"line_number":26,"context_line":"        \"\"\"Generate random names in atomic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param number_of_names: int number of names to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f8aac684","line":25,"in_reply_to":"ba5da102_e293f74d","updated":"2016-10-26 12:47:14.000000000","message":"\u003eIf answer is \"yes wee need\", do we need to have scenarios which measure different classes (e.g. wrappers) instantiation time as well?\n\nBtw, we have \"self\" job for such scenarios, but it is not configured in proper way. It was created long time ago and is waiting for time when we will abandon alignment to keystone. As soon as we able to use this job, we will add more similar scenarios.","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"454a10d456d9e6e724111677cfcc20f5f21b931a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class RallyProfile(scenario.Scenario, utils.RandomNameGeneratorMixin):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @scenario.configure()"},{"line_number":25,"context_line":"    def generate_names_in_atomic(self, number_of_names):"},{"line_number":26,"context_line":"        \"\"\"Generate random names in atomic."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param number_of_names: int number of names to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_a43107ef","line":25,"in_reply_to":"ba5da102_f8aac684","updated":"2016-10-26 14:46:43.000000000","message":"2) Done","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a0abcb3b1b7b558e9eeb68e5bab24ac396f22e2b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \"\"\""},{"line_number":30,"context_line":"        with atomic.ActionTimer("},{"line_number":31,"context_line":"                self, \"generate_%s_names\" % number_of_names):"},{"line_number":32,"context_line":"            [self.generate_random_name() for i in range(number_of_names)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_c2b513d1","line":32,"updated":"2016-10-26 11:54:15.000000000","message":"This makes a (possible large) list object in memory, which should also take extra time (many append() calls). Simple \"for\" works clearer","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"454a10d456d9e6e724111677cfcc20f5f21b931a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \"\"\""},{"line_number":30,"context_line":"        with atomic.ActionTimer("},{"line_number":31,"context_line":"                self, \"generate_%s_names\" % number_of_names):"},{"line_number":32,"context_line":"            [self.generate_random_name() for i in range(number_of_names)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_c44c3b79","line":32,"in_reply_to":"ba5da102_c2b513d1","updated":"2016-10-26 14:46:43.000000000","message":"Done","commit_id":"65ed48dcc63b101efd296a8a6553db9c011d6c11"}]}
