)]}'
{"rally/plugins/openstack/scenarios/cinder/qos_specs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c98459677e58470f2544540f902e457460febb3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        vol_type \u003d self._create_volume_type(**kwargs)"},{"line_number":41,"context_line":"        qos_specs \u003d self._create_qos(keydict)"},{"line_number":42,"context_line":"        keydict \u003d {\"write_iops_sec\": 11, \"read_iops_sec\": 1001}"},{"line_number":43,"context_line":"        self._set_qos(qos_specs.id, keydict)"},{"line_number":44,"context_line":"        self._associate_qos(qos_specs, vol_type.id)"},{"line_number":45,"context_line":"        self._disassociate_qos(qos_specs, vol_type.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_dd69dbfa","line":42,"updated":"2016-12-05 18:45:43.000000000","message":"Can we get IOPS data from scenario config?\n\nI don\u0027t like the idea to re-define method\u0027s param","commit_id":"e1dbab858496716d5cd78a3ab247ccbf10d09699"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    \"create_and_set_then_associate_and_disassociate_qos\")"},{"line_number":31,"context_line":"class CreateAndSetThenAssociateAndDisassociateQos(utils.CinderScenario):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def run(self, create_qos_args, set_qos_args, **kwargs):"},{"line_number":34,"context_line":"        \"\"\"Create a qos and set then associate and disassociate it."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param keydict: A dict of key/value pairs to be set"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_9053b3e1","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":33},"updated":"2016-12-06 08:47:59.000000000","message":"please set default value \"create_qos_args\u003dNone\",\"set_qos_args\u003dNone\"","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def run(self, create_qos_args, set_qos_args, **kwargs):"},{"line_number":34,"context_line":"        \"\"\"Create a qos and set then associate and disassociate it."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param keydict: A dict of key/value pairs to be set"},{"line_number":37,"context_line":"        :param new_keydict: A dict of key/value pairs to be set"},{"line_number":38,"context_line":"        :param kwargs: Optional parameters used during volume"},{"line_number":39,"context_line":"                       type creation."},{"line_number":40,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_d02d2b47","line":37,"range":{"start_line":36,"start_character":8,"end_line":37,"end_character":63},"updated":"2016-12-06 08:47:59.000000000","message":"it is wrong, please add explanation of create_qos_args and set_qos_args","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"}],"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        return self.clients(\"cinder\").volumes.get(volume_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @atomic.action_timer(\"cinder.qos-create\")"},{"line_number":72,"context_line":"    def _create_qos(self, specs):"},{"line_number":73,"context_line":"        \"\"\"Create a qos specs."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_b09a6f6c","line":71,"range":{"start_line":71,"start_character":26,"end_line":71,"end_character":43},"updated":"2016-12-06 08:47:59.000000000","message":"please keep consistent with other style, change it to \u0027cinder.qos_create\u0027","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        name \u003d self.generate_random_name()"},{"line_number":80,"context_line":"        return self.admin_clients(\"cinder\").qos_specs.create(name, specs)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @atomic.action_timer(\"cinder.qos-set\")"},{"line_number":83,"context_line":"    def _set_qos(self, qos_specs, specs):"},{"line_number":84,"context_line":"        \"\"\"Update a qos specs with new specifications."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_10aec380","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":42},"updated":"2016-12-06 08:47:59.000000000","message":"ditto","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        return self.admin_clients(\"cinder\").qos_specs.set_keys(qos_specs,"},{"line_number":91,"context_line":"                                                               specs)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @atomic.action_timer(\"cinder.qos-associate\")"},{"line_number":94,"context_line":"    def _associate_qos(self, qos_specs, vol_type_id):"},{"line_number":95,"context_line":"        \"\"\"Associate a volume type with specific qos specs."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_50ccbb69","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":48},"updated":"2016-12-06 08:47:59.000000000","message":"ditto","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\"Associate a volume type with specific qos specs."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param qos_specs: The qos specs to be associated with"},{"line_number":98,"context_line":"        :param vol_type_id: The volume type id to be associated with"},{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        return self.admin_clients(\"cinder\").qos_specs.associate(qos_specs,"},{"line_number":101,"context_line":"                                                                vol_type_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_904733bb","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":68},"updated":"2016-12-06 08:47:59.000000000","message":"please add return value","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return self.admin_clients(\"cinder\").qos_specs.associate(qos_specs,"},{"line_number":101,"context_line":"                                                                vol_type_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @atomic.action_timer(\"cinder.qos-disassociate\")"},{"line_number":104,"context_line":"    def _disassociate_qos(self, qos_specs, vol_type_id):"},{"line_number":105,"context_line":"        \"\"\"Disassociate qos specs from volume type."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_b0bfcfa8","line":103,"range":{"start_line":103,"start_character":4,"end_line":103,"end_character":51},"updated":"2016-12-06 08:47:59.000000000","message":"ditto","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"9ceea6ef8420171a53dea65d8d44f33c073cb825","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        \"\"\"Disassociate qos specs from volume type."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :param qos_specs: The qos specs to be associated with"},{"line_number":108,"context_line":"        :param vol_type_id: The volume type id to be associated with"},{"line_number":109,"context_line":"        \"\"\""},{"line_number":110,"context_line":"        return self.admin_clients(\"cinder\").qos_specs.disassociate(qos_specs,"},{"line_number":111,"context_line":"                                                                   vol_type_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_f01867d5","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":68},"updated":"2016-12-06 08:47:59.000000000","message":"please add return value","commit_id":"e3b8634c4976d57c3edbee1f5f3d910b6b350854"}],"tests/unit/plugins/openstack/scenarios/cinder/test_qos_specs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5c98459677e58470f2544540f902e457460febb3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"              \".CinderQos\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class fake_type(object):"},{"line_number":27,"context_line":"    name \u003d \"fake\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_dd371bfd","line":26,"updated":"2016-12-05 18:45:43.000000000","message":"Why do we need this class?","commit_id":"e1dbab858496716d5cd78a3ab247ccbf10d09699"}]}
