)]}'
{"rally/plugins/openstack/scenarios/nova/aggregates.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"89fbb5d66c59e77b6b4a20e733debce5168f2fb6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if aggregate:"},{"line_number":54,"context_line":"            all_aggregates \u003d self._list_aggregates()"},{"line_number":55,"context_line":"            if aggregate in all_aggregates:"},{"line_number":56,"context_line":"                return all_aggregates"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                raise exceptions.RallyException(\"Created aggregate is not in\""},{"line_number":59,"context_line":"                                                \" the list of all available\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_feca5aa0","line":56,"range":{"start_line":56,"start_character":16,"end_line":56,"end_character":23},"updated":"2016-11-24 15:52:13.000000000","message":"scenario should not return anything. `if aggregate not in all_aggregates` check should be enough. It relates to all your changes.","commit_id":"e9657e2ca6ada3f2ce00ca43f3768bfdd30cec45"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"89fbb5d66c59e77b6b4a20e733debce5168f2fb6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                raise exceptions.RallyException(\"Created aggregate is not in\""},{"line_number":59,"context_line":"                                                \" the list of all available\""},{"line_number":60,"context_line":"                                                \" aggregates\")"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            raise exceptions.RallyException(\"Aggregate isn\u0027t created\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"@validation.required_services(consts.Service.NOVA)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_fe0fbade","line":62,"range":{"start_line":61,"start_character":8,"end_line":62,"end_character":70},"updated":"2016-11-24 15:52:13.000000000","message":"what about using next construction?\n\n    self.assertIsNotNone(aggregate, \"Aggregate isn\u0027t created\")","commit_id":"e9657e2ca6ada3f2ce00ca43f3768bfdd30cec45"}],"rally/plugins/openstack/scenarios/nova/keypairs.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0d5624a78f7fa8cd529c4aa9b53d41280b16cb3a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        :param kwargs: Optional additional arguments for keypair creation"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        keypair_name \u003d self._create_keypair(**kwargs)"},{"line_number":42,"context_line":"        self.assertTrue(keypair_name, \"Keypair isn\u0027t created\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        list_keypairs \u003d self._list_keypairs()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_8e23a1bc","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":20},"updated":"2016-12-12 13:10:01.000000000","message":"it looks like this variable should be named as keypair_id :)","commit_id":"a3ecfd74a0db628b2a7286883511ead9109e1c0b"}],"rally/task/functional.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"edc2b769e59bb5d6cc4a6976fd1dd574d36ce62d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise exceptions.RallyAssertionError("},{"line_number":132,"context_line":"                self._concatenate_message(msg, err_msg))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def assertLessEqual(self, first, second, err_msg\u003dNone):"},{"line_number":135,"context_line":"        msg \u003d \"%s is greater than %s\" % (repr(first),"},{"line_number":136,"context_line":"                                         repr(second))"},{"line_number":137,"context_line":"        if isinstance(first, list) and isinstance(second, list):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_0ef1dbcd","line":134,"updated":"2016-11-30 10:02:43.000000000","message":"Method name is not consistent with functional.","commit_id":"d4292078c797ae1c5ead8297262216d49d3c0e4a"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"8fd37a856699e2f3bed285dbd0b186354145bd46","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise exceptions.RallyAssertionError("},{"line_number":132,"context_line":"                self._concatenate_message(msg, err_msg))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def assertLessEqual(self, first, second, err_msg\u003dNone):"},{"line_number":135,"context_line":"        msg \u003d \"%s is greater than %s\" % (repr(first),"},{"line_number":136,"context_line":"                                         repr(second))"},{"line_number":137,"context_line":"        if isinstance(first, list) and isinstance(second, list):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_db6b2284","line":134,"in_reply_to":"5a74a57a_0ef1dbcd","updated":"2016-11-30 11:29:38.000000000","message":"This method checks what first \u003c\u003d second. If first \u003e second, exception raises.\nThis method works like Unittest assertLessEqual method, but raise RallyAssertError exception.\nExample from docs:\n\u003e\u003e\u003e self.assertGreaterEqual(3, 4)\nAssertionError: \"3\" unexpectedly not greater than or equal to \"4\"","commit_id":"d4292078c797ae1c5ead8297262216d49d3c0e4a"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        msg \u003d \"%s not found in %s\" % (repr(member),"},{"line_number":100,"context_line":"                                      repr(container))"},{"line_number":101,"context_line":"        if isinstance(member, list):"},{"line_number":102,"context_line":"            if set(member) - set(container):"},{"line_number":103,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":104,"context_line":"                    self._concatenate_message(msg, err_msg))"},{"line_number":105,"context_line":"        elif member not in container:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_835e6ce7","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":44},"updated":"2016-12-09 08:06:56.000000000","message":"Explicit is better than implicit.\nTo me, it is better to write:\n\n    assertFalse(set(a) - set(b), \"a is not subset of b\")\n\nthan hide this logic in \u0027assertIn\u0027.\nOr even write separate \u0027assertIsSubset\u0027, \u0027assertIsNotSubset\u0027","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        msg \u003d \"%s is greater than %s\" % (repr(first),"},{"line_number":136,"context_line":"                                         repr(second))"},{"line_number":137,"context_line":"        if isinstance(first, list) and isinstance(second, list):"},{"line_number":138,"context_line":"            if len(first) \u003e len(second):"},{"line_number":139,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":140,"context_line":"                    self._concatenate_message(msg, err_msg))"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_03d25c00","line":138,"range":{"start_line":138,"start_character":15,"end_line":138,"end_character":39},"updated":"2016-12-09 08:06:56.000000000","message":"I think it is more clear to write: \n\n    assertLessEqual(len(a), len(b))\n\nthan add type checking to assertLessEqual","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def assertLessEqual(self, first, second, err_msg\u003dNone):"},{"line_number":135,"context_line":"        msg \u003d \"%s is greater than %s\" % (repr(first),"},{"line_number":136,"context_line":"                                         repr(second))"},{"line_number":137,"context_line":"        if isinstance(first, list) and isinstance(second, list):"},{"line_number":138,"context_line":"            if len(first) \u003e len(second):"},{"line_number":139,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":140,"context_line":"                    self._concatenate_message(msg, err_msg))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def assertLess(self, first, second, err_msg\u003dNone):"},{"line_number":143,"context_line":"        msg \u003d \"%s is greater or equal to %s\" % (repr(first),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_43ba9424","line":140,"range":{"start_line":137,"start_character":8,"end_line":140,"end_character":60},"updated":"2016-12-09 08:06:56.000000000","message":"No support for other types. What if i write:\n\n    assertLessEqual(5, 2)","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def assertLess(self, first, second, err_msg\u003dNone):"},{"line_number":143,"context_line":"        msg \u003d \"%s is greater or equal to %s\" % (repr(first),"},{"line_number":144,"context_line":"                                                repr(second))"},{"line_number":145,"context_line":"        if isinstance(first, list) and isinstance(second, list):"},{"line_number":146,"context_line":"            if len(first) \u003e\u003d len(second):"},{"line_number":147,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":148,"context_line":"                    self._concatenate_message(msg, err_msg))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_63b5d02f","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":64},"updated":"2016-12-09 08:06:56.000000000","message":"ditto","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def assertGreaterEqual(self, first, second, err_msg\u003dNone):"},{"line_number":151,"context_line":"        msg \u003d \"%s is less than %s\" % (repr(first),"},{"line_number":152,"context_line":"                                      repr(second))"},{"line_number":153,"context_line":"        if isinstance(first, list) and isinstance(second, list):"},{"line_number":154,"context_line":"            if len(first) \u003c len(second):"},{"line_number":155,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":156,"context_line":"                    self._concatenate_message(msg, err_msg))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_8382ec50","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":64},"updated":"2016-12-09 08:06:56.000000000","message":"ditto","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"ba22f1262b48c426f8a677e87d5296220ac8d04d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def assertGreater(self, first, second, err_msg\u003dNone):"},{"line_number":159,"context_line":"        msg \u003d \"%s is less or equal to %s\" % (repr(first),"},{"line_number":160,"context_line":"                                             repr(second))"},{"line_number":161,"context_line":"        if isinstance(first, list) and isinstance(second, list):"},{"line_number":162,"context_line":"            if len(first) \u003c\u003d len(second):"},{"line_number":163,"context_line":"                raise exceptions.RallyAssertionError("},{"line_number":164,"context_line":"                    self._concatenate_message(msg, err_msg))"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_a385285a","line":161,"range":{"start_line":161,"start_character":8,"end_line":161,"end_character":64},"updated":"2016-12-09 08:06:56.000000000","message":"ditto","commit_id":"d8762cda569531e1de334a52d971c079c55b8154"}]}
