)]}'
{"rally/task/exporter.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"df8dccd3e9ac95f59f07ab508c51ea7883b77a21","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@exporter.plugin.base()"},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":34,"context_line":"class Exporter(exporter.BaseExporter):"},{"line_number":35,"context_line":"    \"\"\"Task results base exporter.\"\"\""},{"line_number":36,"context_line":"    pass"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_f883b000","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":14},"updated":"2016-12-07 10:58:50.000000000","message":"What about name it just TaskExporter and delete L39?","commit_id":"354a8ff5a27ddda34b4fa976efdf637aa1b491fc"}],"rally/verification/exporter.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"df8dccd3e9ac95f59f07ab508c51ea7883b77a21","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class VerifyExporter(exporter.BaseExporter):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def export(self, verification_uuid):"},{"line_number":38,"context_line":"        \"\"\"Export results of the task to the task storage."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param verification_uuid: uuid of verification results"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_f8e810b5","line":37,"updated":"2016-12-07 10:58:50.000000000","message":"This method is already abstract in BaseExporter class. I think we should put \u0027pass\u0027 here like it is done in TaskExporter.","commit_id":"354a8ff5a27ddda34b4fa976efdf637aa1b491fc"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8d91f105b880af82914d4e1401e7e2e3f73a53f1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class VerifyExporter(exporter.BaseExporter):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def export(self, verification_uuid):"},{"line_number":38,"context_line":"        \"\"\"Export results of the task to the task storage."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param verification_uuid: uuid of verification results"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_32cb45a7","line":37,"in_reply_to":"3a71b18c_f8e810b5","updated":"2017-01-03 15:14:11.000000000","message":"it changes a name of argument and clarifies docstring ;)","commit_id":"354a8ff5a27ddda34b4fa976efdf637aa1b491fc"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"d459f83379dd11a5a1873d1e29d51cc55a684132","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class VerifyExporter(exporter.BaseExporter):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def export(self, verification_uuid):"},{"line_number":38,"context_line":"        \"\"\"Export results of the task to the task storage."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param verification_uuid: uuid of verification results"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_30d9c884","line":37,"in_reply_to":"ba5201f7_32cb45a7","updated":"2017-01-09 09:12:34.000000000","message":"The name of this variable is named as \u0027entity_uuid\u0027 and I think this name is understandable both for task UUID and verification UUID. Also, doc string looks good for two cases. IMHO, we should delete this or return the same method for tasks.","commit_id":"354a8ff5a27ddda34b4fa976efdf637aa1b491fc"}]}
