)]}'
{"rally/task/atomic.py":[{"author":{"_account_id":14758,"name":"Rajath Agasthya","email":"rajagast@cisco.com","username":"rajathagasthya"},"change_message_id":"b0b317855f63658636281a2b04e9f8dfb9e475eb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if n is None:"},{"line_number":62,"context_line":"            raise Exception(\"n is %s! [%r] [%s]\" % (n, instance, name))"},{"line_number":63,"context_line":"        self.name \u003d n"},{"line_number":64,"context_line":"        if self.name is None:"},{"line_number":65,"context_line":"            raise Exception(\"self.name is None!\")"},{"line_number":66,"context_line":"        self.instance._atomic_actions[self.name] \u003d None"},{"line_number":67,"context_line":"        if name in self.instance._actions_stack[-1][\"names\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_b3768bd6","line":64,"updated":"2016-12-08 08:28:14.000000000","message":"What is the difference between this if statement and the one right above it? Both of them are checking if \"n\" is None.","commit_id":"f9d9be7efb54c748dc193458bbf4af97134dbff9"},{"author":{"_account_id":14758,"name":"Rajath Agasthya","email":"rajagast@cisco.com","username":"rajathagasthya"},"change_message_id":"b0b317855f63658636281a2b04e9f8dfb9e475eb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        if self.name is None:"},{"line_number":65,"context_line":"            raise Exception(\"self.name is None!\")"},{"line_number":66,"context_line":"        self.instance._atomic_actions[self.name] \u003d None"},{"line_number":67,"context_line":"        if name in self.instance._actions_stack[-1][\"names\"]:"},{"line_number":68,"context_line":"            i \u003d 1"},{"line_number":69,"context_line":"            name_ \u003d name"},{"line_number":70,"context_line":"            while name_ in self.instance._actions_stack[-1][\"names\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_aef8e4c5","line":67,"range":{"start_line":67,"start_character":19,"end_line":67,"end_character":60},"updated":"2016-12-08 08:28:14.000000000","message":"Instead of using this multiple times in the same method, you can extract this as a local variable and re-use it. You also avoid doing dict lookup for \"names\" multiple times that way.","commit_id":"f9d9be7efb54c748dc193458bbf4af97134dbff9"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"705d4b8dc7c3716f3d5947208fd899d73338d726","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if n is None:"},{"line_number":62,"context_line":"            raise Exception(\"n is %s! [%r] [%s]\" % (n, instance, name))"},{"line_number":63,"context_line":"        self.name \u003d n"},{"line_number":64,"context_line":"        if self.name is None:"},{"line_number":65,"context_line":"            raise Exception(\"self.name is None!\")"},{"line_number":66,"context_line":"        self.instance._atomic_actions[self.name] \u003d None"},{"line_number":67,"context_line":"        if name in self.instance._actions_stack[-1][\"names\"]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_9f26d466","line":64,"updated":"2017-02-21 02:14:40.000000000","message":"I feel this entrance is duplicated with line #61","commit_id":"f37ad30a31b55947857d59d41371cd936c4d0fb0"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"705d4b8dc7c3716f3d5947208fd899d73338d726","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        self._actions[\"started_at\"] \u003d self.timestamp()"},{"line_number":101,"context_line":"        self._actions[\"finished_at\"] \u003d self.finish_timestamp()"},{"line_number":102,"context_line":"        del self.instance._actions_stack[-1][\"names\"]"},{"line_number":103,"context_line":"        self.instance._actions_stack.pop()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_1f1bc41c","line":102,"updated":"2017-02-21 02:14:40.000000000","message":"Lets remove this line, line #103 is enough.","commit_id":"f37ad30a31b55947857d59d41371cd936c4d0fb0"}],"rally/task/service.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"9fc19184c6dcdaf03cfd06466dadd292700f562f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        return self._atomic_actions"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def actions(self):"},{"line_number":86,"context_line":"        return []"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __getattr__(self, name):"},{"line_number":89,"context_line":"        return getattr(self._service, name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_d1fc6174","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":17},"updated":"2017-03-03 02:06:42.000000000","message":"return self._actions","commit_id":"f37ad30a31b55947857d59d41371cd936c4d0fb0"}]}