)]}'
{"rally/common/db/sqlalchemy/api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1b78754c479907cbdf7539e42cf90b7c9084831d","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def _verifier_get(self, verifier_id, session\u003dNone):"},{"line_number":669,"context_line":"        # search by name"},{"line_number":670,"context_line":"        verifier \u003d self.model_query("},{"line_number":671,"context_line":"            models.Verifier, session\u003dsession).filter_by("},{"line_number":672,"context_line":"            name\u003dverifier_id).first()"},{"line_number":673,"context_line":"        if not verifier:"},{"line_number":674,"context_line":"            # search by uuid"},{"line_number":675,"context_line":"            verifier \u003d self.model_query("},{"line_number":676,"context_line":"                models.Verifier, session\u003dsession).filter_by("},{"line_number":677,"context_line":"                uuid\u003dverifier_id).first()"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if not verifier:"},{"line_number":680,"context_line":"            raise exceptions.ResourceNotFound(id\u003dverifier_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_45adaa30","line":677,"range":{"start_line":670,"start_character":8,"end_line":677,"end_character":41},"updated":"2016-12-21 21:44:05.000000000","message":"I know that we use such construction before, but I found that sqlalchemy support OR natively, so we can make one request to filter for both UUID or name\n\nhttp://docs.sqlalchemy.org/en/rel_0_9/core/sqlelement.html#sqlalchemy.sql.expression.or_","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"bd3122adeafbc94f098f57fcf1d9c4a0a505532e","unresolved":false,"context_lines":[{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    def _verifier_get(self, verifier_id, session\u003dNone):"},{"line_number":669,"context_line":"        # search by name"},{"line_number":670,"context_line":"        verifier \u003d self.model_query("},{"line_number":671,"context_line":"            models.Verifier, session\u003dsession).filter_by("},{"line_number":672,"context_line":"            name\u003dverifier_id).first()"},{"line_number":673,"context_line":"        if not verifier:"},{"line_number":674,"context_line":"            # search by uuid"},{"line_number":675,"context_line":"            verifier \u003d self.model_query("},{"line_number":676,"context_line":"                models.Verifier, session\u003dsession).filter_by("},{"line_number":677,"context_line":"                uuid\u003dverifier_id).first()"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if not verifier:"},{"line_number":680,"context_line":"            raise exceptions.ResourceNotFound(id\u003dverifier_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_bead728a","line":677,"range":{"start_line":670,"start_character":8,"end_line":677,"end_character":41},"in_reply_to":"da4df55a_45adaa30","updated":"2016-12-22 10:29:32.000000000","message":"Done","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1b78754c479907cbdf7539e42cf90b7c9084831d","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        session \u003d get_session()"},{"line_number":692,"context_line":"        with session.begin():"},{"line_number":693,"context_line":"            # search by name"},{"line_number":694,"context_line":"            count \u003d self.model_query("},{"line_number":695,"context_line":"                models.Verifier, session\u003dsession).filter_by("},{"line_number":696,"context_line":"                name\u003dverifier_id).delete(synchronize_session\u003dFalse)"},{"line_number":697,"context_line":"            if not count:"},{"line_number":698,"context_line":"                # search by uuid"},{"line_number":699,"context_line":"                count \u003d self.model_query("},{"line_number":700,"context_line":"                    models.Verifier, session\u003dsession).filter_by("},{"line_number":701,"context_line":"                    uuid\u003dverifier_id).delete(synchronize_session\u003dFalse)"},{"line_number":702,"context_line":"                if not count:"},{"line_number":703,"context_line":"                    raise exceptions.ResourceNotFound(id\u003dverifier_id)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_85a7924e","line":701,"range":{"start_line":694,"start_character":12,"end_line":701,"end_character":71},"updated":"2016-12-21 21:44:05.000000000","message":"same here","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"bd3122adeafbc94f098f57fcf1d9c4a0a505532e","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        session \u003d get_session()"},{"line_number":692,"context_line":"        with session.begin():"},{"line_number":693,"context_line":"            # search by name"},{"line_number":694,"context_line":"            count \u003d self.model_query("},{"line_number":695,"context_line":"                models.Verifier, session\u003dsession).filter_by("},{"line_number":696,"context_line":"                name\u003dverifier_id).delete(synchronize_session\u003dFalse)"},{"line_number":697,"context_line":"            if not count:"},{"line_number":698,"context_line":"                # search by uuid"},{"line_number":699,"context_line":"                count \u003d self.model_query("},{"line_number":700,"context_line":"                    models.Verifier, session\u003dsession).filter_by("},{"line_number":701,"context_line":"                    uuid\u003dverifier_id).delete(synchronize_session\u003dFalse)"},{"line_number":702,"context_line":"                if not count:"},{"line_number":703,"context_line":"                    raise exceptions.ResourceNotFound(id\u003dverifier_id)"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_deaa3670","line":701,"range":{"start_line":694,"start_character":12,"end_line":701,"end_character":71},"in_reply_to":"da4df55a_85a7924e","updated":"2016-12-22 10:29:32.000000000","message":"Done","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"}],"rally/common/db/sqlalchemy/migrations/versions/484cd9413e66_new_db_schema_for_verification_component.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1b78754c479907cbdf7539e42cf90b7c9084831d","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        sa.Column(\"status\", sa.String(36), default\u003d\"init\", nullable\u003dFalse),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        sa.Column(\"extra\", sa_types.MutableJSONEncodedDict, nullable\u003dTrue),"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        sa.Column(\"created_at\", sa.DateTime),"},{"line_number":108,"context_line":"        sa.Column(\"updated_at\", sa.DateTime)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_a0fe4403","line":105,"range":{"start_line":105,"start_character":9,"end_line":105,"end_character":75},"updated":"2016-12-21 21:44:05.000000000","message":"we made a migration(porting to new schema) long time ago, so we can\u0027t modify it now. it can break someone. We need to add one more migration or just ignore(old name is not so bad, imo)","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"bd3122adeafbc94f098f57fcf1d9c4a0a505532e","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        sa.Column(\"status\", sa.String(36), default\u003d\"init\", nullable\u003dFalse),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        sa.Column(\"extra\", sa_types.MutableJSONEncodedDict, nullable\u003dTrue),"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        sa.Column(\"created_at\", sa.DateTime),"},{"line_number":108,"context_line":"        sa.Column(\"updated_at\", sa.DateTime)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_bc349ade","line":105,"range":{"start_line":105,"start_character":9,"end_line":105,"end_character":75},"in_reply_to":"da4df55a_a0fe4403","updated":"2016-12-22 10:29:32.000000000","message":"Done","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"}],"rally/common/objects/verifier.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1b78754c479907cbdf7539e42cf90b7c9084831d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def create(cls, name, source, vtype, namespace, version, system_wide,"},{"line_number":45,"context_line":"               extra\u003dNone):"},{"line_number":46,"context_line":"        db_entry \u003d db.verifier_create(name, source, vtype, namespace,"},{"line_number":47,"context_line":"                                      version, system_wide, extra\u003dextra)"},{"line_number":48,"context_line":"        return cls(db_entry)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_406598df","line":47,"range":{"start_line":46,"start_character":38,"end_line":47,"end_character":72},"updated":"2016-12-21 21:44:05.000000000","message":"potentially, it can led to errors in future. let\u0027s use keyword arguments in all cases, when we have more then 2 arguments.","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"bd3122adeafbc94f098f57fcf1d9c4a0a505532e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @classmethod"},{"line_number":44,"context_line":"    def create(cls, name, source, vtype, namespace, version, system_wide,"},{"line_number":45,"context_line":"               extra\u003dNone):"},{"line_number":46,"context_line":"        db_entry \u003d db.verifier_create(name, source, vtype, namespace,"},{"line_number":47,"context_line":"                                      version, system_wide, extra\u003dextra)"},{"line_number":48,"context_line":"        return cls(db_entry)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_48ddac41","line":47,"range":{"start_line":46,"start_character":38,"end_line":47,"end_character":72},"in_reply_to":"da4df55a_406598df","updated":"2016-12-22 10:29:32.000000000","message":"Done","commit_id":"141f4ea8386dfaf05cdde30b6baf376c4dc001c9"}]}