)]}'
{"rally/plugins/openstack/scenarios/neutron/security_groups.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"51b41f20664b9ff3d7f918ff97d27cb663039a70","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        security_group_create_args \u003d security_group_create_args or {}"},{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d (\"security_group isn\u0027t created\")"},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_739fae03","line":62,"range":{"start_line":62,"start_character":14,"end_line":62,"end_character":46},"updated":"2017-03-01 08:04:57.000000000","message":"Why we need `()`?","commit_id":"3b0d02d69ab537db2e957b2cb9e94bcb6388da4f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"021eac9658077f4d1cc69f6b044a3e935230cdc8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d \"security_group isn\u0027t created\""},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_0a8bd71f","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":52},"updated":"2017-03-13 08:22:55.000000000","message":"Let us remove this line;)","commit_id":"7ed0714abc74bb4ba7119d685ebbbf135116e4cc"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"7fae0c54e3cdb32dfa058e59f5317c880b20111f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d \"security_group isn\u0027t created\""},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a25e98e_5d7c9120","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":52},"in_reply_to":"7a25e98e_7a923359","updated":"2017-03-14 04:05:52.000000000","message":"I agree with your view. I always think the assertTrue is dispensable. osp environment will tell us error. but you should persuade andrey to belive this.","commit_id":"7ed0714abc74bb4ba7119d685ebbbf135116e4cc"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"1087f6cb0b7f77be69f8f4c8e45085c85b7f32a7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d \"security_group isn\u0027t created\""},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_ca57ff23","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":52},"in_reply_to":"9a30ddce_0a8bd71f","updated":"2017-03-13 08:39:37.000000000","message":"why? andrey said \u0027there are only two known clients which we should check - k8sclient(I heard a story that sometimes it returns None) and neutron (I do not know how it works)\u0027","commit_id":"7ed0714abc74bb4ba7119d685ebbbf135116e4cc"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"2caddd0d0f0679d8af447774a6d7cc9b6f560caa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d \"security_group isn\u0027t created\""},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_cafb7f45","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":52},"in_reply_to":"9a30ddce_0a8bd71f","updated":"2017-03-13 08:35:06.000000000","message":"why? andrey said \u0027there are only two known clients which we should check - k8sclient(I heard a story that sometimes it returns None) and neutron (I do not know how it works)\u0027","commit_id":"7ed0714abc74bb4ba7119d685ebbbf135116e4cc"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8368956c833ca36862b66c5fcad118e82a80fb09","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        security_group \u003d self._create_security_group("},{"line_number":61,"context_line":"            **security_group_create_args)"},{"line_number":62,"context_line":"        msg \u003d \"security_group isn\u0027t created\""},{"line_number":63,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":64,"context_line":"        self._show_security_group(security_group)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a25e98e_7a923359","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":52},"in_reply_to":"9a30ddce_ca57ff23","updated":"2017-03-14 03:14:50.000000000","message":"Neutron send a request based on keystoneauth https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L642-L657 and other client do the same behavior, so I think we need remove this line.","commit_id":"7ed0714abc74bb4ba7119d685ebbbf135116e4cc"}]}