)]}'
{"rally/plugins/openstack/context/network/security_groups.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"5b1f800e7d147b1a755467d8466c01b4eaf270d7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \"ip_protocol\": \"icmp\","},{"line_number":43,"context_line":"            \"to_port\": -1,"},{"line_number":44,"context_line":"            \"from_port\": -1,"},{"line_number":45,"context_line":"            \"cidr\": \"0.0.0.0/0\""},{"line_number":46,"context_line":"        })"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    for rule_port in range(rules_amount):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_76d778ed","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":31},"updated":"2017-01-20 08:56:25.000000000","message":"could we change the cidr?","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":7261,"name":"Peter Lomakin","email":"plomakin@mirantis.com","username":"mrpit"},"change_message_id":"fbfb6ea6e5c0b32ff984142789cf49ef6571578b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \"ip_protocol\": \"icmp\","},{"line_number":43,"context_line":"            \"to_port\": -1,"},{"line_number":44,"context_line":"            \"from_port\": -1,"},{"line_number":45,"context_line":"            \"cidr\": \"0.0.0.0/0\""},{"line_number":46,"context_line":"        })"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    for rule_port in range(rules_amount):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_401609a8","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":31},"in_reply_to":"5a3905b3_76d778ed","updated":"2017-01-20 21:41:36.000000000","message":"Thanks, will fix move it to config schema.","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"5b1f800e7d147b1a755467d8466c01b4eaf270d7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        })"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    for rule_port in range(rules_amount):"},{"line_number":49,"context_line":"        protocol \u003d random.choice(protocol_list)"},{"line_number":50,"context_line":"        rule \u003d {"},{"line_number":51,"context_line":"            \"parent_group_id\": secgroup.id,"},{"line_number":52,"context_line":"            \"ip_protocol\": protocol,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_d6b02ce0","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":47},"updated":"2017-01-20 08:56:25.000000000","message":"I would prefer to specify the protocol in yaml or json.","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":7261,"name":"Peter Lomakin","email":"plomakin@mirantis.com","username":"mrpit"},"change_message_id":"fbfb6ea6e5c0b32ff984142789cf49ef6571578b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        })"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    for rule_port in range(rules_amount):"},{"line_number":49,"context_line":"        protocol \u003d random.choice(protocol_list)"},{"line_number":50,"context_line":"        rule \u003d {"},{"line_number":51,"context_line":"            \"parent_group_id\": secgroup.id,"},{"line_number":52,"context_line":"            \"ip_protocol\": protocol,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_20a2ddae","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":47},"in_reply_to":"5a3905b3_d6b02ce0","updated":"2017-01-20 21:41:36.000000000","message":"Thanks will move it to config schema then.","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"5b1f800e7d147b1a755467d8466c01b4eaf270d7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    return secgroup.id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@context.configure(name\u003d\"security_groups\", order\u003d420)"},{"line_number":63,"context_line":"class CreateSecurityGroups(context.Context):"},{"line_number":64,"context_line":"    \"\"\"Create networking security groups and rules in them."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_f6d448be","line":62,"range":{"start_line":62,"start_character":43,"end_line":62,"end_character":53},"updated":"2017-01-20 08:56:25.000000000","message":"VolumeGenerator has this order of 420 in https://github.com/openstack/rally/blob/8ff0f2ee8c92f748e99138b24124a5c008918555/rally/plugins/openstack/context/cinder/volumes.py#L27","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":7261,"name":"Peter Lomakin","email":"plomakin@mirantis.com","username":"mrpit"},"change_message_id":"fbfb6ea6e5c0b32ff984142789cf49ef6571578b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    return secgroup.id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@context.configure(name\u003d\"security_groups\", order\u003d420)"},{"line_number":63,"context_line":"class CreateSecurityGroups(context.Context):"},{"line_number":64,"context_line":"    \"\"\"Create networking security groups and rules in them."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_e0c9b579","line":62,"range":{"start_line":62,"start_character":43,"end_line":62,"end_character":53},"in_reply_to":"5a3905b3_f6d448be","updated":"2017-01-20 21:41:36.000000000","message":"Thanks, will fix.","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"5b1f800e7d147b1a755467d8466c01b4eaf270d7","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `security_groups`\"))"},{"line_number":99,"context_line":"    def setup(self):"},{"line_number":100,"context_line":"        user \u003d (self.context.get(\"admin\") or self.context.get(\"users\")[0])"},{"line_number":101,"context_line":"        net_wrapper \u003d network.wrap("},{"line_number":102,"context_line":"            osclients.Clients(user[\"credential\"]),"},{"line_number":103,"context_line":"            self, config\u003dself.config)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_168ab4bf","line":100,"range":{"start_line":100,"start_character":42,"end_line":100,"end_character":74},"updated":"2017-01-20 08:56:25.000000000","message":"is it necessary?","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"},{"author":{"_account_id":7261,"name":"Peter Lomakin","email":"plomakin@mirantis.com","username":"mrpit"},"change_message_id":"fbfb6ea6e5c0b32ff984142789cf49ef6571578b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `security_groups`\"))"},{"line_number":99,"context_line":"    def setup(self):"},{"line_number":100,"context_line":"        user \u003d (self.context.get(\"admin\") or self.context.get(\"users\")[0])"},{"line_number":101,"context_line":"        net_wrapper \u003d network.wrap("},{"line_number":102,"context_line":"            osclients.Clients(user[\"credential\"]),"},{"line_number":103,"context_line":"            self, config\u003dself.config)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_2061fd39","line":100,"range":{"start_line":100,"start_character":42,"end_line":100,"end_character":74},"in_reply_to":"5a3905b3_168ab4bf","updated":"2017-01-20 21:41:36.000000000","message":"nope, will fix. thank you","commit_id":"fd6636547c1e3f7a31b4acd2758a360dfd0d6517"}]}
