)]}'
{"rally/verification/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4b6edf9291705701c132fcb7b8a137cf573427ad","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if not self.verifier.system_wide:"},{"line_number":91,"context_line":"            # activate virtual environment"},{"line_number":92,"context_line":"            env[\"VIRTUAL_ENV\"] \u003d self.venv_dir"},{"line_number":93,"context_line":"            env[\"PATH\"] \u003d os.path.join(self.venv_dir, \"bin:%s\" % env[\"PATH\"])"},{"line_number":94,"context_line":"        return env"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def validate_args(self, args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_5cc1fa7f","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":77},"updated":"2016-12-29 17:37:17.000000000","message":"this join merges two separate things. If you want to use join here, do it something like:\n\n    env[\"PATH\"] \u003d os.path.join(self.venv_dir, \"bin\") + \":\" + env[\"PATH\"]","commit_id":"c0a094518d69b5c7d4712defa6ec6a37c4e2a0d3"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3c378cce25e576ef1c3350526fc61669a7fbfff5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        if not self.verifier.system_wide:"},{"line_number":91,"context_line":"            # activate virtual environment"},{"line_number":92,"context_line":"            env[\"VIRTUAL_ENV\"] \u003d self.venv_dir"},{"line_number":93,"context_line":"            env[\"PATH\"] \u003d os.path.join(self.venv_dir, \"bin:%s\" % env[\"PATH\"])"},{"line_number":94,"context_line":"        return env"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def validate_args(self, args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_02d54c42","line":93,"range":{"start_line":93,"start_character":26,"end_line":93,"end_character":77},"in_reply_to":"ba5201f7_5cc1fa7f","updated":"2016-12-29 19:40:57.000000000","message":"Done","commit_id":"c0a094518d69b5c7d4712defa6ec6a37c4e2a0d3"}],"tests/ci/rally_verify.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4b6edf9291705701c132fcb7b8a137cf573427ad","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.\""},{"line_number":47,"context_line":"    \"test_get_vnc_console[id-c6bc11bf-592e-4015-9319-1c98dc64daf5]: \""},{"line_number":48,"context_line":"    \"This test fails because \u0027novnc\u0027 console type is unavailable\")"},{"line_number":49,"context_line":"TEST_NAME_RE \u003d re.compile(r\"^[a-zA-Z_.0-9]+(\\[[a-zA-Z-,\u003d0-9]*\\])?$\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# NOTE(andreykurilin): this variable is used to generate output file names"},{"line_number":52,"context_line":"# with prefix ${CALL_COUNT}_ ."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_3c4b562d","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":68},"updated":"2016-12-29 17:37:17.000000000","message":"le\u0027ts import this regexp from testr module","commit_id":"c0a094518d69b5c7d4712defa6ec6a37c4e2a0d3"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"3c378cce25e576ef1c3350526fc61669a7fbfff5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"tempest.api.compute.servers.test_server_actions.ServerActionsTestJSON.\""},{"line_number":47,"context_line":"    \"test_get_vnc_console[id-c6bc11bf-592e-4015-9319-1c98dc64daf5]: \""},{"line_number":48,"context_line":"    \"This test fails because \u0027novnc\u0027 console type is unavailable\")"},{"line_number":49,"context_line":"TEST_NAME_RE \u003d re.compile(r\"^[a-zA-Z_.0-9]+(\\[[a-zA-Z-,\u003d0-9]*\\])?$\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# NOTE(andreykurilin): this variable is used to generate output file names"},{"line_number":52,"context_line":"# with prefix ${CALL_COUNT}_ ."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_e25da8ed","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":68},"in_reply_to":"ba5201f7_3c4b562d","updated":"2016-12-29 19:40:57.000000000","message":"I think it is not worth importing this from testr module. Verifiers can be launched via various runners (pytest, nose, etc), and depending on it TEST_NAME_RE should be changed.","commit_id":"c0a094518d69b5c7d4712defa6ec6a37c4e2a0d3"}]}
