)]}'
{"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"7f7a2a08f3094760fb8ec1ea6d2601c276278247","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                      tenant_sgs)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"@base.resource(\"neutron\", \"security_group_rule\", order\u003dnext(_neutron_order),"},{"line_number":468,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":469,"context_line":"class NeutronSecurityGroupRule(NeutronMixin):"},{"line_number":470,"context_line":"    pass"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"@base.resource(\"neutron\", \"quota\", order\u003dnext(_neutron_order),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_12d02d53","line":470,"range":{"start_line":467,"start_character":0,"end_line":470,"end_character":8},"updated":"2017-03-15 10:19:14.000000000","message":"I\u0027m not sure but I think the rules will be deleted along with security group they belong to. So it is not required to add this resource manager.","commit_id":"b76273089d33332589e3073fc9d5434d39d7c83f"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"23e3e80d35bc054b2fee87f78f8658b6470ee1c8","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                      tenant_sgs)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"@base.resource(\"neutron\", \"security_group_rule\", order\u003dnext(_neutron_order),"},{"line_number":468,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":469,"context_line":"class NeutronSecurityGroupRule(NeutronMixin):"},{"line_number":470,"context_line":"    pass"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"@base.resource(\"neutron\", \"quota\", order\u003dnext(_neutron_order),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_dd73e413","line":470,"range":{"start_line":467,"start_character":0,"end_line":470,"end_character":8},"in_reply_to":"3a1ff146_12d02d53","updated":"2017-03-17 06:59:00.000000000","message":"Thanks for your comment, Before I have the same idea as you. but now i think security_group_rule also is a independent resource, it can be deleted by deleting security_group, but it also be deleted by itself. so why not add this resources manager,Maybe it is useless for my patch.","commit_id":"b76273089d33332589e3073fc9d5434d39d7c83f"}],"rally/plugins/openstack/scenarios/neutron/security_groups.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"f9f77b8b51e59ea3c023173f3050d52f62009629","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        msg \u003d (\"security_group_rule isn\u0027t created\")"},{"line_number":121,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self._list_security_group_rules()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_8a41b9ab","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":41},"updated":"2017-02-14 18:11:37.000000000","message":"Let\u0027s add a check that created security_group_rule is in the list.","commit_id":"36c54cca88a56641ba0ff0bb1858b3d16a77d70b"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"be6abda954d7f646fbcebd916e22be8a4b9e4ed0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        msg \u003d (\"security_group_rule isn\u0027t created\")"},{"line_number":121,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self._list_security_group_rules()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_fc2911e7","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":41},"in_reply_to":"fa31d9ce_8a41b9ab","updated":"2017-02-15 05:50:10.000000000","message":"if I use \u0027self.assertIn(security_group_rule, pool_list)\u0027, will get an \u0027TypeError: unhashable type: \u0027_DictWithMeta\u0027\u0027 ERROR. the pool_list \u003d self._list_security_group_rules()","commit_id":"36c54cca88a56641ba0ff0bb1858b3d16a77d70b"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"a77de10238fadfc7ae127fa7cacccb283e767cd9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        msg \u003d (\"security_group_rule isn\u0027t created\")"},{"line_number":121,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self._list_security_group_rules()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_4c4ee8c1","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":41},"in_reply_to":"fa31d9ce_fc2911e7","updated":"2017-02-15 07:58:16.000000000","message":"Try to use id fields:\n\n  security_group_rules \u003d self._list_security_group_rules()\n  self.assertIn(security_group_rule[\"id\"],\n                [sgr[\"id\"] for sgr in security_group_rules])","commit_id":"36c54cca88a56641ba0ff0bb1858b3d16a77d70b"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"3be9255b67c41a0109e882be2ade7646d49c3fb1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        security_group_rule_args \u003d security_group_rule_args or {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        security_group \u003d self._create_security_group(**security_group_args)"},{"line_number":115,"context_line":"        msg \u003d (\"security_group isn\u0027t created\")"},{"line_number":116,"context_line":"        self.assertTrue(security_group, err_msg\u003dmsg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        security_group_rule \u003d self._create_security_group_rule("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_d9515b64","line":115,"range":{"start_line":115,"start_character":7,"end_line":115,"end_character":46},"updated":"2017-03-01 08:49:54.000000000","message":"Why we need `()`","commit_id":"4fb1c395a4d4540cab67902914ffa4c081f959a8"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"3be9255b67c41a0109e882be2ade7646d49c3fb1","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        security_group_rule \u003d self._create_security_group_rule("},{"line_number":119,"context_line":"            security_group[\"security_group\"][\"id\"], **security_group_rule_args)"},{"line_number":120,"context_line":"        msg \u003d (\"security_group_rule isn\u0027t created\")"},{"line_number":121,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        security_group_rules \u003d self._list_security_group_rules()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_d9ff9b32","line":120,"range":{"start_line":120,"start_character":7,"end_line":120,"end_character":51},"updated":"2017-03-01 08:49:54.000000000","message":"ditto","commit_id":"4fb1c395a4d4540cab67902914ffa4c081f959a8"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"3937ce028fc7b446541291bc9c0078ebaf606f09","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":118,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":119,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":120,"context_line":"                    name\u003d(\"NeutronSecurityGroup\""},{"line_number":121,"context_line":"                          \".create_and_list_security_group_rules\"))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ff73747_a7ce86b1","line":118,"updated":"2017-04-27 00:44:09.000000000","message":"lets use @validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue) instead of this validation.\n\nhttp://logs.openstack.org/08/415608/9/check/gate-rally-dsvm-neutron-rally-ubuntu-xenial/d5d3206/console.html#_2017-04-25_03_25_11_865016","commit_id":"6dbafb5aca9d5a3c5bcc9a283065bdc92e172c1a"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f250a7f90baf3abf4b7372294d1b768005c873ec","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                                                          **lb_list_args)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    @atomic.action_timer(\"neutron.create_security_group_rule\")"},{"line_number":661,"context_line":"    def _create_security_group_rule(self, security_group_id,"},{"line_number":662,"context_line":"                                    direction\u003d\"ingress\","},{"line_number":663,"context_line":"                                    **security_group_rule_args):"},{"line_number":664,"context_line":"        \"\"\"Create Neutron security-group-rule."},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        param: security_group_id: id of neutron security_group"},{"line_number":667,"context_line":"        param: security_group_rule_args: dict, POST"},{"line_number":668,"context_line":"               /v2.0/security-group-rules request options"},{"line_number":669,"context_line":"        return: dict, neutron security-group-rule"},{"line_number":670,"context_line":"        \"\"\""},{"line_number":671,"context_line":"        security_group_rule_args[\"security_group_id\"] \u003d security_group_id"},{"line_number":672,"context_line":"        security_group_rule_args[\"direction\"] \u003d direction"},{"line_number":673,"context_line":"        return self.clients(\"neutron\").create_security_group_rule("},{"line_number":674,"context_line":"            {\"security_group_rule\": security_group_rule_args})"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @atomic.action_timer(\"neutron.list_security_group_rules\")"},{"line_number":677,"context_line":"    def _list_security_group_rules(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_6c51030f","line":674,"range":{"start_line":661,"start_character":1,"end_line":674,"end_character":62},"updated":"2017-04-22 04:23:54.000000000","message":"i do not see the argument direction in scenario , i want to we could remove the argument direction, then use\nif \"direction\" not in security_group_rule_args:\n    security_group_rule_args[\"direction\"] \u003d \"ingress\"\n\nOtherwise, if user specify direction argument in security_group_rule_args, here will specify direction with ingress  again.","commit_id":"f9e5e0e07a2d2f414d0ca0476b5b297df82478b4"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"7ec11ecac89cd65c3872590ab2d78cb85fd69b8e","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                                                          **lb_list_args)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    @atomic.action_timer(\"neutron.create_security_group_rule\")"},{"line_number":661,"context_line":"    def _create_security_group_rule(self, security_group_id,"},{"line_number":662,"context_line":"                                    direction\u003d\"ingress\","},{"line_number":663,"context_line":"                                    **security_group_rule_args):"},{"line_number":664,"context_line":"        \"\"\"Create Neutron security-group-rule."},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        param: security_group_id: id of neutron security_group"},{"line_number":667,"context_line":"        param: security_group_rule_args: dict, POST"},{"line_number":668,"context_line":"               /v2.0/security-group-rules request options"},{"line_number":669,"context_line":"        return: dict, neutron security-group-rule"},{"line_number":670,"context_line":"        \"\"\""},{"line_number":671,"context_line":"        security_group_rule_args[\"security_group_id\"] \u003d security_group_id"},{"line_number":672,"context_line":"        security_group_rule_args[\"direction\"] \u003d direction"},{"line_number":673,"context_line":"        return self.clients(\"neutron\").create_security_group_rule("},{"line_number":674,"context_line":"            {\"security_group_rule\": security_group_rule_args})"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @atomic.action_timer(\"neutron.list_security_group_rules\")"},{"line_number":677,"context_line":"    def _list_security_group_rules(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_abd7e723","line":674,"range":{"start_line":661,"start_character":1,"end_line":674,"end_character":62},"in_reply_to":"5ff73747_6c51030f","updated":"2017-04-24 05:06:47.000000000","message":"you are right, thanks for your comment.","commit_id":"f9e5e0e07a2d2f414d0ca0476b5b297df82478b4"}]}
