)]}'
{"rally-jobs/rally-keystone-api-v2.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":860,"context_line":"          disk_format: \"qcow2\""},{"line_number":861,"context_line":"          container_format: \"bare\""},{"line_number":862,"context_line":"          images_per_tenant: 1"},{"line_number":863,"context_line":"        roles:"},{"line_number":864,"context_line":"          - \"admin\""},{"line_number":865,"context_line":"      sla:"},{"line_number":866,"context_line":"        failure_rate:"},{"line_number":867,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"da36d5c6_38102359","line":864,"range":{"start_line":863,"start_character":8,"end_line":864,"end_character":19},"updated":"2017-02-23 22:39:13.000000000","message":"why we need it?","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a1b0c73de5d8755e82367c6ee0075a615857a8d3","unresolved":false,"context_lines":[{"line_number":860,"context_line":"          disk_format: \"qcow2\""},{"line_number":861,"context_line":"          container_format: \"bare\""},{"line_number":862,"context_line":"          images_per_tenant: 1"},{"line_number":863,"context_line":"        roles:"},{"line_number":864,"context_line":"          - \"admin\""},{"line_number":865,"context_line":"      sla:"},{"line_number":866,"context_line":"        failure_rate:"},{"line_number":867,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"da36d5c6_a714cb4c","line":864,"range":{"start_line":863,"start_character":8,"end_line":864,"end_character":19},"in_reply_to":"da36d5c6_0096813e","updated":"2017-02-25 01:10:41.000000000","message":"it is strange because it doesn\u0027t require admin previously (with glance wrapper)","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"738cbd00654a8f23e586148e13311b77b77305bd","unresolved":false,"context_lines":[{"line_number":860,"context_line":"          disk_format: \"qcow2\""},{"line_number":861,"context_line":"          container_format: \"bare\""},{"line_number":862,"context_line":"          images_per_tenant: 1"},{"line_number":863,"context_line":"        roles:"},{"line_number":864,"context_line":"          - \"admin\""},{"line_number":865,"context_line":"      sla:"},{"line_number":866,"context_line":"        failure_rate:"},{"line_number":867,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"da36d5c6_0096813e","line":864,"range":{"start_line":863,"start_character":8,"end_line":864,"end_character":19},"in_reply_to":"da36d5c6_38102359","updated":"2017-02-24 02:13:33.000000000","message":"Because I get a 403 problem:(\nhttp://logs.openstack.org/40/415740/33/check/gate-rally-dsvm-keystone-v2api-rally/dbc8f40/rally-plot/results.html.gz#/","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c1a36c13722ba598aa6648e06ee7284992f66ed6","unresolved":false,"context_lines":[{"line_number":860,"context_line":"          disk_format: \"qcow2\""},{"line_number":861,"context_line":"          container_format: \"bare\""},{"line_number":862,"context_line":"          images_per_tenant: 1"},{"line_number":863,"context_line":"        roles:"},{"line_number":864,"context_line":"          - \"admin\""},{"line_number":865,"context_line":"      sla:"},{"line_number":866,"context_line":"        failure_rate:"},{"line_number":867,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"ba2be162_baad848a","line":864,"range":{"start_line":863,"start_character":8,"end_line":864,"end_character":19},"in_reply_to":"da36d5c6_a714cb4c","updated":"2017-03-01 01:23:45.000000000","message":"I understand. Because glancewrapper don\u0027t use the visibility param in gate, so it is not show me the error. But if we use visibility, I think glancewrapper would show me the 403 error too.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"24a20f7741def1833b9977ec6e6d3fcec3492eb5","unresolved":false,"context_lines":[{"line_number":860,"context_line":"          disk_format: \"qcow2\""},{"line_number":861,"context_line":"          container_format: \"bare\""},{"line_number":862,"context_line":"          images_per_tenant: 1"},{"line_number":863,"context_line":"        roles:"},{"line_number":864,"context_line":"          - \"admin\""},{"line_number":865,"context_line":"      sla:"},{"line_number":866,"context_line":"        failure_rate:"},{"line_number":867,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"da36d5c6_2201a906","line":864,"range":{"start_line":863,"start_character":8,"end_line":864,"end_character":19},"in_reply_to":"da36d5c6_a714cb4c","updated":"2017-02-25 03:02:56.000000000","message":"yeap. So I add the role of admin~~","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":942,"context_line":"          users_per_tenant: 1"},{"line_number":943,"context_line":"        api_versions:"},{"line_number":944,"context_line":"          glance:"},{"line_number":945,"context_line":"            version: 1"},{"line_number":946,"context_line":"        roles:"},{"line_number":947,"context_line":"          - \"admin\""},{"line_number":948,"context_line":"      sla:"},{"line_number":949,"context_line":"        failure_rate:"},{"line_number":950,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"da36d5c6_5815d746","line":947,"range":{"start_line":945,"start_character":22,"end_line":947,"end_character":19},"updated":"2017-02-23 22:39:13.000000000","message":"same question here","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cec729dd0758875e413961284b660c2f9ffea76a","unresolved":false,"context_lines":[{"line_number":837,"context_line":"          disk_format: \"qcow2\""},{"line_number":838,"context_line":"          container_format: \"bare\""},{"line_number":839,"context_line":"          images_per_tenant: 1"},{"line_number":840,"context_line":"        roles:"},{"line_number":841,"context_line":"          - \"admin\""},{"line_number":842,"context_line":"      sla:"},{"line_number":843,"context_line":"        failure_rate:"},{"line_number":844,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"ffe62b97_9baaae6e","line":841,"range":{"start_line":840,"start_character":0,"end_line":841,"end_character":19},"updated":"2017-03-28 10:33:26.000000000","message":"we do not need that roles anymore","commit_id":"f43f442a67107477e814900590897b858e2769a4"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"e37435c1457443478f8c51ee3e335de50267be30","unresolved":false,"context_lines":[{"line_number":837,"context_line":"          disk_format: \"qcow2\""},{"line_number":838,"context_line":"          container_format: \"bare\""},{"line_number":839,"context_line":"          images_per_tenant: 1"},{"line_number":840,"context_line":"        roles:"},{"line_number":841,"context_line":"          - \"admin\""},{"line_number":842,"context_line":"      sla:"},{"line_number":843,"context_line":"        failure_rate:"},{"line_number":844,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"ffe62b97_1199dac2","line":841,"range":{"start_line":840,"start_character":0,"end_line":841,"end_character":19},"in_reply_to":"ffe62b97_9baaae6e","updated":"2017-03-28 12:18:02.000000000","message":"All roles have been removed.","commit_id":"f43f442a67107477e814900590897b858e2769a4"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b29bd3de629da847d15616a625fdb0b127656383","unresolved":false,"context_lines":[{"line_number":885,"context_line":"          disk_format: \"qcow2\""},{"line_number":886,"context_line":"          container_format: \"bare\""},{"line_number":887,"context_line":"          images_per_tenant: 1"},{"line_number":888,"context_line":"        roles:"},{"line_number":889,"context_line":"          - \"admin\""},{"line_number":890,"context_line":"      sla:"},{"line_number":891,"context_line":"        failure_rate:"},{"line_number":892,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"1a1ced50_2323e606","line":889,"range":{"start_line":888,"start_character":8,"end_line":889,"end_character":19},"updated":"2017-03-20 16:00:10.000000000","message":"please, remove all `roles: \"admin\"`. It is not a fix for an issue. I\u0027ll help to discover an issue of failues","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2fadf0c061fa4205aa242d8429bc15f04f23fbf3","unresolved":false,"context_lines":[{"line_number":885,"context_line":"          disk_format: \"qcow2\""},{"line_number":886,"context_line":"          container_format: \"bare\""},{"line_number":887,"context_line":"          images_per_tenant: 1"},{"line_number":888,"context_line":"        roles:"},{"line_number":889,"context_line":"          - \"admin\""},{"line_number":890,"context_line":"      sla:"},{"line_number":891,"context_line":"        failure_rate:"},{"line_number":892,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"1a1ced50_ab7064dd","line":889,"range":{"start_line":888,"start_character":8,"end_line":889,"end_character":19},"in_reply_to":"1a1ced50_2323e606","updated":"2017-03-21 12:15:09.000000000","message":"I compared those test previously. In my opinion, previous version, rally can transmit visibility or is_public, but no scenarios transmit this param.So when we port glanceWrapper to glance-service, it occur this problem","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cec729dd0758875e413961284b660c2f9ffea76a","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        users:"},{"line_number":1017,"context_line":"          tenants: 3"},{"line_number":1018,"context_line":"          users_per_tenant: 1"},{"line_number":1019,"context_line":"        roles:"},{"line_number":1020,"context_line":"          - \"admin\""},{"line_number":1021,"context_line":"      sla:"},{"line_number":1022,"context_line":"        failure_rate:"},{"line_number":1023,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":51,"id":"ffe62b97_dbcdd666","line":1020,"range":{"start_line":1019,"start_character":0,"end_line":1020,"end_character":19},"updated":"2017-03-28 10:33:26.000000000","message":"and here","commit_id":"f43f442a67107477e814900590897b858e2769a4"}],"rally/plugins/openstack/context/glance/images.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"966c2533663e2d9f64790ed94bdfce5d29447e9c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":98,"context_line":"                LOG.warning(\"The \u0027min_ram\u0027 argument is deprecated; specify \""},{"line_number":99,"context_line":"                            \"arbitrary arguments with \u0027image_args\u0027 instead\")"},{"line_number":100,"context_line":"                kwargs[\"min_ram\"] \u003d self.config[\"min_ram\"]"},{"line_number":101,"context_line":"            if self.config.get(\"min_disk\") is not None:"},{"line_number":102,"context_line":"                LOG.warning(\"The \u0027min_disk\u0027 argument is deprecated; specify \""},{"line_number":103,"context_line":"                            \"arbitrary arguments with \u0027image_args\u0027 instead\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_a0405235","side":"PARENT","line":100,"range":{"start_line":100,"start_character":16,"end_line":100,"end_character":58},"updated":"2017-02-08 07:44:45.000000000","message":"Why is it removed?","commit_id":"f523285dd03c82425b92b004709ef1f021025bab"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"e530712e908e7445b755b0988fd0f1029b94ce65","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":98,"context_line":"                LOG.warning(\"The \u0027min_ram\u0027 argument is deprecated; specify \""},{"line_number":99,"context_line":"                            \"arbitrary arguments with \u0027image_args\u0027 instead\")"},{"line_number":100,"context_line":"                kwargs[\"min_ram\"] \u003d self.config[\"min_ram\"]"},{"line_number":101,"context_line":"            if self.config.get(\"min_disk\") is not None:"},{"line_number":102,"context_line":"                LOG.warning(\"The \u0027min_disk\u0027 argument is deprecated; specify \""},{"line_number":103,"context_line":"                            \"arbitrary arguments with \u0027image_args\u0027 instead\")"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_66ebe278","side":"PARENT","line":100,"range":{"start_line":100,"start_character":16,"end_line":100,"end_character":58},"in_reply_to":"1a430d35_a0405235","updated":"2017-02-08 08:47:53.000000000","message":"Thanks for review my patch:).Because glance-service use the exact params and the min_ram is deprecated, so I don\u0027t add this param.","commit_id":"f523285dd03c82425b92b004709ef1f021025bab"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"966c2533663e2d9f64790ed94bdfce5d29447e9c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":94,"context_line":"            image_service \u003d image.Image("},{"line_number":95,"context_line":"                clients,"},{"line_number":96,"context_line":"                name_generator\u003dself.generate_random_name())"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            kwargs \u003d self.config.get(\"image_args\", {})"},{"line_number":99,"context_line":"            is_public \u003d kwargs.get(\"is_public\", False)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_c57570fa","line":96,"range":{"start_line":96,"start_character":16,"end_line":96,"end_character":58},"updated":"2017-02-08 07:44:45.000000000","message":"name_generator should be a callable: https://github.com/openstack/rally/blob/master/rally/task/service.py#L218-L220","commit_id":"7b1116f8666630d8e12f72dbcbffa9f8f3b91817"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"e530712e908e7445b755b0988fd0f1029b94ce65","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":94,"context_line":"            image_service \u003d image.Image("},{"line_number":95,"context_line":"                clients,"},{"line_number":96,"context_line":"                name_generator\u003dself.generate_random_name())"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            kwargs \u003d self.config.get(\"image_args\", {})"},{"line_number":99,"context_line":"            is_public \u003d kwargs.get(\"is_public\", False)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_5aa876db","line":96,"range":{"start_line":96,"start_character":16,"end_line":96,"end_character":58},"in_reply_to":"1a430d35_c57570fa","updated":"2017-02-08 08:47:53.000000000","message":"I will fix it.","commit_id":"7b1116f8666630d8e12f72dbcbffa9f8f3b91817"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"966c2533663e2d9f64790ed94bdfce5d29447e9c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            clients \u003d osclients.Clients("},{"line_number":139,"context_line":"                user[\"credential\"],"},{"line_number":140,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":141,"context_line":"            image_service \u003d image.Image(clients, self.generate_random_name())"},{"line_number":142,"context_line":"            for image_id in self.context[\"tenants\"][tenant_id].get("},{"line_number":143,"context_line":"                    \"images\", []):"},{"line_number":144,"context_line":"                image_service.delete_image(image_id\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_2567144e","line":141,"range":{"start_line":141,"start_character":49,"end_line":141,"end_character":76},"updated":"2017-02-08 07:44:45.000000000","message":"name_generator should be a callable: https://github.com/openstack/rally/blob/master/rally/task/service.py#L218-L220","commit_id":"7b1116f8666630d8e12f72dbcbffa9f8f3b91817"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"image_name\": {"},{"line_number":56,"context_line":"                \"type\": \"string\","},{"line_number":57,"context_line":"            },"},{"line_number":58,"context_line":"            \"min_ram\": {  # megabytes"},{"line_number":59,"context_line":"                \"type\": \"integer\","},{"line_number":60,"context_line":"                \"minimum\": 0"},{"line_number":61,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_192d6246","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":37},"updated":"2017-02-14 14:20:07.000000000","message":"while we are here, let\u0027s move this comment under \"description\" field, like it is done here - https://review.openstack.org/#/c/431043/4/rally/plugins/openstack/context/nova/servers.py . It will allow to display the proper description at our docs.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"11983951896c7ad31ab79b72ec1b44321034c4c0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"image_name\": {"},{"line_number":56,"context_line":"                \"type\": \"string\","},{"line_number":57,"context_line":"            },"},{"line_number":58,"context_line":"            \"min_ram\": {  # megabytes"},{"line_number":59,"context_line":"                \"type\": \"integer\","},{"line_number":60,"context_line":"                \"minimum\": 0"},{"line_number":61,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_8537dcfd","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":37},"in_reply_to":"fa31d9ce_192d6246","updated":"2017-02-15 02:56:51.000000000","message":"I will use another patch to change this CONFIG_SCHEMA.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \"image_name\": {"},{"line_number":56,"context_line":"                \"type\": \"string\","},{"line_number":57,"context_line":"            },"},{"line_number":58,"context_line":"            \"min_ram\": {  # megabytes"},{"line_number":59,"context_line":"                \"type\": \"integer\","},{"line_number":60,"context_line":"                \"minimum\": 0"},{"line_number":61,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d994518c","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":37},"in_reply_to":"fa31d9ce_8537dcfd","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \"type\": \"integer\","},{"line_number":60,"context_line":"                \"minimum\": 0"},{"line_number":61,"context_line":"            },"},{"line_number":62,"context_line":"            \"min_disk\": {  # gigabytes"},{"line_number":63,"context_line":"                \"type\": \"integer\","},{"line_number":64,"context_line":"                \"minimum\": 0"},{"line_number":65,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_99215250","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":38},"updated":"2017-02-14 14:20:07.000000000","message":"same here","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \"type\": \"integer\","},{"line_number":60,"context_line":"                \"minimum\": 0"},{"line_number":61,"context_line":"            },"},{"line_number":62,"context_line":"            \"min_disk\": {  # gigabytes"},{"line_number":63,"context_line":"                \"type\": \"integer\","},{"line_number":64,"context_line":"                \"minimum\": 0"},{"line_number":65,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_198b4969","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":38},"in_reply_to":"fa31d9ce_99215250","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"            \"image_args\": {"},{"line_number":71,"context_line":"                \"type\": \"object\","},{"line_number":72,"context_line":"                \"additionalProperties\": True"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        },"},{"line_number":75,"context_line":"        \"required\": [\"image_url\", \"image_type\", \"image_container\","}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_c30ad378","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":44},"updated":"2017-02-14 14:20:07.000000000","message":"I totally dislike such behaviour. Possibly it can break everything, since we do not validate what user can transmit here. Let\u0027s make this schema strict with listing all expected parameters. Based on [1][2] I can assume that we should expect next list of parameters:\n\n- disk_format\n- container_format (old image_container)\n- min_disk\n- min_ram\n- size\n- visibility (an enum type, like at L49)\n- is_public (make it deprecated and use visibility by default)\n- protected (not sure that we need it)\n\n[1] - https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/images.py#L26-L34\n[2] - https://developer.openstack.org/api-ref/image/v2/index.html?expanded\u003dcreate-an-image-detail#images","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"1e23eaef057e605fb5e2448653db2135af642855","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"            \"image_args\": {"},{"line_number":71,"context_line":"                \"type\": \"object\","},{"line_number":72,"context_line":"                \"additionalProperties\": True"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        },"},{"line_number":75,"context_line":"        \"required\": [\"image_url\", \"image_type\", \"image_container\","}],"source_content_type":"text/x-python","patch_set":21,"id":"da36d5c6_e77b7126","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":44},"in_reply_to":"fa31d9ce_c30ad378","updated":"2017-02-23 01:07:26.000000000","message":"I can not add size param too. Because create_image has not this param in docs:https://developer.openstack.org/api-ref/image/v2/index.html?expanded\u003dcreate-an-image-detail. And I put this param in create_image, I would meet a error.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"            \"image_args\": {"},{"line_number":71,"context_line":"                \"type\": \"object\","},{"line_number":72,"context_line":"                \"additionalProperties\": True"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        },"},{"line_number":75,"context_line":"        \"required\": [\"image_url\", \"image_type\", \"image_container\","}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_79c9a5ab","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":44},"in_reply_to":"fa31d9ce_c30ad378","updated":"2017-02-15 12:08:35.000000000","message":"I don\u0027t add protected param now :)","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                name_generator\u003dself.generate_random_name)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            kwargs \u003d self.config.get(\"image_args\", {})"},{"line_number":99,"context_line":"            is_public \u003d kwargs.get(\"is_public\", False)"},{"line_number":100,"context_line":"            visibility \u003d \"public\" if is_public is True else \"private\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":103,"context_line":"                LOG.error(_(\"The \u0027min_ram\u0027 argument is deprecated; \""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_19056279","line":100,"range":{"start_line":99,"start_character":12,"end_line":100,"end_character":69},"updated":"2017-02-14 14:20:07.000000000","message":"It took off an ability to transmit \"visibility\" parameter. We switched to Glance V2 as default version in previous Rally release + visibility covers is_public property and even more cases. Let\u0027s do not limit by public/private images","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                name_generator\u003dself.generate_random_name)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            kwargs \u003d self.config.get(\"image_args\", {})"},{"line_number":99,"context_line":"            is_public \u003d kwargs.get(\"is_public\", False)"},{"line_number":100,"context_line":"            visibility \u003d \"public\" if is_public is True else \"private\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":103,"context_line":"                LOG.error(_(\"The \u0027min_ram\u0027 argument is deprecated; \""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_1967c9b7","line":100,"range":{"start_line":99,"start_character":12,"end_line":100,"end_character":69},"in_reply_to":"fa31d9ce_19056279","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            visibility \u003d \"public\" if is_public is True else \"private\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":103,"context_line":"                LOG.error(_(\"The \u0027min_ram\u0027 argument is deprecated; \""},{"line_number":104,"context_line":"                            \"specify arbitrary arguments with \""},{"line_number":105,"context_line":"                            \"\u0027image_args\u0027 instead\"))"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_fee930e7","line":103,"range":{"start_line":103,"start_character":20,"end_line":103,"end_character":25},"updated":"2017-02-14 14:20:07.000000000","message":"LOG.error is redundant in case of validation errors. If it should be an error, config schema should be modified and an error should be displayed at validation step.\n\nIn general, I prefer to leave deprecation message and support the backward compatibility. Let\u0027s extend deprecations with release when it was deprecated(Let it be 0.8.0)","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            visibility \u003d \"public\" if is_public is True else \"private\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if self.config.get(\"min_ram\") is not None:"},{"line_number":103,"context_line":"                LOG.error(_(\"The \u0027min_ram\u0027 argument is deprecated; \""},{"line_number":104,"context_line":"                            \"specify arbitrary arguments with \""},{"line_number":105,"context_line":"                            \"\u0027image_args\u0027 instead\"))"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_39080dda","line":103,"range":{"start_line":103,"start_character":20,"end_line":103,"end_character":25},"in_reply_to":"fa31d9ce_fee930e7","updated":"2017-02-15 12:08:35.000000000","message":"Copy that.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                else:"},{"line_number":122,"context_line":"                    cur_name \u003d self.generate_random_name()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                image_obj \u003d image_service.create_image("},{"line_number":125,"context_line":"                    image_name\u003dcur_name,"},{"line_number":126,"context_line":"                    container_format\u003dimage_container,"},{"line_number":127,"context_line":"                    image_location\u003dimage_url,"},{"line_number":128,"context_line":"                    disk_format\u003dimage_type,"},{"line_number":129,"context_line":"                    visibility\u003dvisibility)"},{"line_number":130,"context_line":"                current_images.append(image_obj.id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            self.context[\"tenants\"][tenant_id][\"images\"] \u003d current_images"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_b90d12ea","line":129,"range":{"start_line":124,"start_character":16,"end_line":129,"end_character":42},"updated":"2017-02-14 14:20:07.000000000","message":"you do not transmit kwargs, so min_disk, min_ram will be lost...","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                else:"},{"line_number":122,"context_line":"                    cur_name \u003d self.generate_random_name()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                image_obj \u003d image_service.create_image("},{"line_number":125,"context_line":"                    image_name\u003dcur_name,"},{"line_number":126,"context_line":"                    container_format\u003dimage_container,"},{"line_number":127,"context_line":"                    image_location\u003dimage_url,"},{"line_number":128,"context_line":"                    disk_format\u003dimage_type,"},{"line_number":129,"context_line":"                    visibility\u003dvisibility)"},{"line_number":130,"context_line":"                current_images.append(image_obj.id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            self.context[\"tenants\"][tenant_id][\"images\"] \u003d current_images"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d9f7f1d0","line":129,"range":{"start_line":124,"start_character":16,"end_line":129,"end_character":42},"in_reply_to":"fa31d9ce_62c3b357","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"11983951896c7ad31ab79b72ec1b44321034c4c0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                else:"},{"line_number":122,"context_line":"                    cur_name \u003d self.generate_random_name()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                image_obj \u003d image_service.create_image("},{"line_number":125,"context_line":"                    image_name\u003dcur_name,"},{"line_number":126,"context_line":"                    container_format\u003dimage_container,"},{"line_number":127,"context_line":"                    image_location\u003dimage_url,"},{"line_number":128,"context_line":"                    disk_format\u003dimage_type,"},{"line_number":129,"context_line":"                    visibility\u003dvisibility)"},{"line_number":130,"context_line":"                current_images.append(image_obj.id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            self.context[\"tenants\"][tenant_id][\"images\"] \u003d current_images"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_c546347a","line":129,"range":{"start_line":124,"start_character":16,"end_line":129,"end_character":42},"in_reply_to":"fa31d9ce_b90d12ea","updated":"2017-02-15 02:56:51.000000000","message":"I see the info of deprecated min_disk, so I don\u0027t add these params. Let us add these params.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b9a5def16c72866e2432fecc953b1cbd681396ec","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                else:"},{"line_number":122,"context_line":"                    cur_name \u003d self.generate_random_name()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                image_obj \u003d image_service.create_image("},{"line_number":125,"context_line":"                    image_name\u003dcur_name,"},{"line_number":126,"context_line":"                    container_format\u003dimage_container,"},{"line_number":127,"context_line":"                    image_location\u003dimage_url,"},{"line_number":128,"context_line":"                    disk_format\u003dimage_type,"},{"line_number":129,"context_line":"                    visibility\u003dvisibility)"},{"line_number":130,"context_line":"                current_images.append(image_obj.id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            self.context[\"tenants\"][tenant_id][\"images\"] \u003d current_images"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_62c3b357","line":129,"range":{"start_line":124,"start_character":16,"end_line":129,"end_character":42},"in_reply_to":"fa31d9ce_c546347a","updated":"2017-02-15 08:39:42.000000000","message":"it was deprecated in the case of specifying them via config directly. \"image_args\" field of config should be used instead","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            clients \u003d osclients.Clients("},{"line_number":139,"context_line":"                user[\"credential\"],"},{"line_number":140,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":141,"context_line":"            image_service \u003d image.Image(clients, self.generate_random_name)"},{"line_number":142,"context_line":"            for image_id in self.context[\"tenants\"][tenant_id].get("},{"line_number":143,"context_line":"                    \"images\", []):"},{"line_number":144,"context_line":"                image_service.delete_image(image_id\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d90f2686","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":74},"updated":"2017-02-14 14:20:07.000000000","message":"image_service in cleanup doesn\u0027t need to create anything, so there is no need transmit that optional parameter.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            clients \u003d osclients.Clients("},{"line_number":139,"context_line":"                user[\"credential\"],"},{"line_number":140,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":141,"context_line":"            image_service \u003d image.Image(clients, self.generate_random_name)"},{"line_number":142,"context_line":"            for image_id in self.context[\"tenants\"][tenant_id].get("},{"line_number":143,"context_line":"                    \"images\", []):"},{"line_number":144,"context_line":"                image_service.delete_image(image_id\u003dimage_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_19fee9ad","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":74},"in_reply_to":"fa31d9ce_d90f2686","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \"images_per_tenant\": {"},{"line_number":67,"context_line":"                \"type\": \"integer\","},{"line_number":68,"context_line":"                \"minimum\": 1"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"            \"image_args\": {"},{"line_number":71,"context_line":"                \"type\": \"object\","},{"line_number":72,"context_line":"                \"additionalProperties\": True"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        },"},{"line_number":75,"context_line":"        \"required\": [\"image_url\", \"image_type\", \"image_container\","},{"line_number":76,"context_line":"                     \"images_per_tenant\"],"},{"line_number":77,"context_line":"        \"additionalProperties\": False"},{"line_number":78,"context_line":"    }"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_d801c707","side":"PARENT","line":76,"range":{"start_line":69,"start_character":12,"end_line":76,"end_character":42},"updated":"2017-02-23 22:39:13.000000000","message":"we should leave all old names for backward compatibility :( at least for two rally releases.","commit_id":"14ec480b16306ac4093fe9b565e190d035869481"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"738cbd00654a8f23e586148e13311b77b77305bd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \"images_per_tenant\": {"},{"line_number":67,"context_line":"                \"type\": \"integer\","},{"line_number":68,"context_line":"                \"minimum\": 1"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"            \"image_args\": {"},{"line_number":71,"context_line":"                \"type\": \"object\","},{"line_number":72,"context_line":"                \"additionalProperties\": True"},{"line_number":73,"context_line":"            }"},{"line_number":74,"context_line":"        },"},{"line_number":75,"context_line":"        \"required\": [\"image_url\", \"image_type\", \"image_container\","},{"line_number":76,"context_line":"                     \"images_per_tenant\"],"},{"line_number":77,"context_line":"        \"additionalProperties\": False"},{"line_number":78,"context_line":"    }"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_3b0c983a","side":"PARENT","line":76,"range":{"start_line":69,"start_character":12,"end_line":76,"end_character":42},"in_reply_to":"da36d5c6_d801c707","updated":"2017-02-24 02:13:33.000000000","message":"ok, I would recover the old names:)","commit_id":"14ec480b16306ac4093fe9b565e190d035869481"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if is_public:"},{"line_number":97,"context_line":"            LOG.warning(_(\"The \u0027is_public\u0027 argument is deprecated \""},{"line_number":98,"context_line":"                          \"since Rally 0.8.0; specify visibility \""},{"line_number":99,"context_line":"                          \"arguments instead\"))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":102,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_ec75ec97","line":99,"updated":"2017-02-23 22:39:13.000000000","message":"again, we need backward compatibility. so let\u0027s add an additional check and line from one of your prevous patch-sets:\n\n   LOG.warning(\"is_public...\")\n   if \"visibility\" not in self.config:\n       visibility \u003d \"public\" if is_public else \"private\"","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"764b3ec9de0db9f7d0ee881f17f3dc464a54f3d9","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if is_public:"},{"line_number":111,"context_line":"            LOG.warning(_(\"The \u0027is_public\u0027 argument is deprecated \""},{"line_number":112,"context_line":"                          \"since Rally 0.8.0; specify visibility \""},{"line_number":113,"context_line":"                          \"arguments instead\"))"},{"line_number":114,"context_line":"            if \"visibility\" not in self.config:"},{"line_number":115,"context_line":"                visibility \u003d \"public\" if is_public else \"private\""}],"source_content_type":"text/x-python","patch_set":41,"id":"3a1ff146_cd996f70","line":112,"range":{"start_line":112,"start_character":39,"end_line":112,"end_character":44},"updated":"2017-03-16 08:54:56.000000000","message":"0.10.0","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"0bed111f577e16fe1d3d376ae2262cb10cbeba5a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if is_public:"},{"line_number":111,"context_line":"            LOG.warning(_(\"The \u0027is_public\u0027 argument is deprecated \""},{"line_number":112,"context_line":"                          \"since Rally 0.8.0; specify visibility \""},{"line_number":113,"context_line":"                          \"arguments instead\"))"},{"line_number":114,"context_line":"            if \"visibility\" not in self.config:"},{"line_number":115,"context_line":"                visibility \u003d \"public\" if is_public else \"private\""}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_3b0efd34","line":112,"range":{"start_line":112,"start_character":39,"end_line":112,"end_character":44},"in_reply_to":"3a1ff146_cd996f70","updated":"2017-03-17 02:20:13.000000000","message":"It is already done in rally-0.8.0, so I don\u0027t think we need change it.But to other infos, we need change this info.","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"764b3ec9de0db9f7d0ee881f17f3dc464a54f3d9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                          \"arguments instead\"))"},{"line_number":127,"context_line":"            container_format \u003d image_container"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if image_args:"},{"line_number":130,"context_line":"            LOG.warning(_(\"The \u0027kwargs\u0027 argument is deprecated since \""},{"line_number":131,"context_line":"                          \"Rally 0.8.0; specify exact arguments instead\"))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":134,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":41,"id":"3a1ff146_45147343","line":131,"range":{"start_line":129,"start_character":8,"end_line":131,"end_character":74},"updated":"2017-03-16 08:54:56.000000000","message":"Can we add backward compatibility here?","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"0bed111f577e16fe1d3d376ae2262cb10cbeba5a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                          \"arguments instead\"))"},{"line_number":127,"context_line":"            container_format \u003d image_container"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if image_args:"},{"line_number":130,"context_line":"            LOG.warning(_(\"The \u0027kwargs\u0027 argument is deprecated since \""},{"line_number":131,"context_line":"                          \"Rally 0.8.0; specify exact arguments instead\"))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":134,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_9881b792","line":131,"range":{"start_line":129,"start_character":8,"end_line":131,"end_character":74},"in_reply_to":"3a1ff146_45147343","updated":"2017-03-17 02:20:13.000000000","message":"No, we use exact params here, so we can not support kwargs of all params. It has the potential error.","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            \"visibility\": {"},{"line_number":76,"context_line":"                \"enum\": [\"public\", \"private\", \"shared\", \"community\"]"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"            \"is_public\": {"},{"line_number":79,"context_line":"                \"type\": \"boolean\""},{"line_number":80,"context_line":"            },"},{"line_number":81,"context_line":"            \"images_per_tenant\": {"},{"line_number":82,"context_line":"                \"type\": \"integer\","},{"line_number":83,"context_line":"                \"minimum\": 1"}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_b5ff0c66","line":80,"range":{"start_line":78,"start_character":12,"end_line":80,"end_character":14},"updated":"2017-03-20 15:53:54.000000000","message":"it is redundant since we have more generic \"visibility\" property + it was not there, so we do not need it for backward compatibility","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                \"type\": \"integer\","},{"line_number":83,"context_line":"                \"minimum\": 1"},{"line_number":84,"context_line":"            },"},{"line_number":85,"context_line":"            \"image_args\": {"},{"line_number":86,"context_line":"                \"type\": \"object\","},{"line_number":87,"context_line":"                \"additionalProperties\": True"},{"line_number":88,"context_line":"            }"},{"line_number":89,"context_line":"        },"},{"line_number":90,"context_line":"        \"required\": [\"image_url\", \"disk_format\", \"container_format\","}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_952f70f5","line":87,"range":{"start_line":85,"start_character":27,"end_line":87,"end_character":44},"updated":"2017-03-20 15:53:54.000000000","message":"since we support \"description\" field now, let\u0027s add here descr like \"DEPRECATED\"","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                \"additionalProperties\": True"},{"line_number":88,"context_line":"            }"},{"line_number":89,"context_line":"        },"},{"line_number":90,"context_line":"        \"required\": [\"image_url\", \"disk_format\", \"container_format\","},{"line_number":91,"context_line":"                     \"images_per_tenant\"],"},{"line_number":92,"context_line":"        \"additionalProperties\": False"},{"line_number":93,"context_line":"    }"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_1810154e","line":91,"range":{"start_line":90,"start_character":8,"end_line":91,"end_character":42},"updated":"2017-03-20 15:53:54.000000000","message":"It is backward incompatible, I mean old tasks will not pass validation with it and will not see any deprecation messages from setup method. We need to add hacky stuff like:\n\n   \"oneOf\": [{\"required\": [\"image_url\", \"image_type\", \"image_container\",\n                            \"images_per_tenant\"]},\n              {\"required\": [\"image_url\", \"disk_format\", \"image_container\",\n                            \"images_per_tenant\"]},\n              {\"required\": [\"image_url\", \"image_type\", \"container_format\",\n                            \"images_per_tenant\"]},\n              {\"required\": [\"image_url\", \"disk_format\", \"container_format\",\n                            \"images_per_tenant\"]}]","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        images_per_tenant \u003d self.config.get(\"images_per_tenant\")"},{"line_number":103,"context_line":"        image_name \u003d self.config.get(\"image_name\")"},{"line_number":104,"context_line":"        visibility \u003d self.config.get(\"visibility\", \"public\")"},{"line_number":105,"context_line":"        is_public \u003d self.config.get(\"is_public\")"},{"line_number":106,"context_line":"        min_disk \u003d self.config.get(\"min_disk\", 0)"},{"line_number":107,"context_line":"        min_ram \u003d self.config.get(\"min_ram\", 0)"},{"line_number":108,"context_line":"        image_args \u003d self.config.get(\"image_args\")"}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_d58728d5","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":48},"updated":"2017-03-20 15:53:54.000000000","message":"we should check for `is_public` from `image_args \u003d self.config.get(\"image_args\")`, since \"image_args\" previously accepted that field.","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if is_public:"},{"line_number":111,"context_line":"            LOG.warning(_(\"The \u0027is_public\u0027 argument is deprecated \""},{"line_number":112,"context_line":"                          \"since Rally 0.8.0; specify visibility \""},{"line_number":113,"context_line":"                          \"arguments instead\"))"},{"line_number":114,"context_line":"            if \"visibility\" not in self.config:"},{"line_number":115,"context_line":"                visibility \u003d \"public\" if is_public else \"private\""}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_35795cf7","line":112,"range":{"start_line":112,"start_character":41,"end_line":112,"end_character":42},"updated":"2017-03-20 15:53:54.000000000","message":"0.10.0","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Exit context: `Images`\"))"},{"line_number":164,"context_line":"    def cleanup(self):"},{"line_number":165,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":166,"context_line":"                self.context[\"users\"]):"},{"line_number":167,"context_line":"            clients \u003d osclients.Clients("},{"line_number":168,"context_line":"                user[\"credential\"],"},{"line_number":169,"context_line":"                api_info\u003dself.context[\"config\"].get(\"api_versions\"))"},{"line_number":170,"context_line":"            image_service \u003d image.Image(clients)"},{"line_number":171,"context_line":"            for image_id in self.context[\"tenants\"][tenant_id].get("},{"line_number":172,"context_line":"                    \"images\", []):"},{"line_number":173,"context_line":"                image_service.delete_image(image_id\u003dimage_id)"},{"line_number":174,"context_line":"                utils.wait_for_status("},{"line_number":175,"context_line":"                    image_service.get_image(image_id\u003dimage_id),"},{"line_number":176,"context_line":"                    [\"deleted\", \"pending_delete\"],"},{"line_number":177,"context_line":"                    check_deletion\u003dTrue,"},{"line_number":178,"context_line":"                    update_resource\u003dimage_service.get_image,"},{"line_number":179,"context_line":"                    timeout\u003dCONF.benchmark.glance_image_delete_timeout,"},{"line_number":180,"context_line":"                    check_interval\u003dCONF.benchmark."},{"line_number":181,"context_line":"                    glance_image_delete_poll_interval)"}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_f5dc24e6","line":181,"range":{"start_line":165,"start_character":8,"end_line":181,"end_character":54},"updated":"2017-03-20 15:53:54.000000000","message":"let\u0027s use our new cleanup mechanism","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c4daeb7931fca1fab7183282a2b9016546ca1edf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                \"additionalProperties\": True"},{"line_number":86,"context_line":"            }"},{"line_number":87,"context_line":"        },"},{"line_number":88,"context_line":"        \"required\": [{\"required\": [\"image_url\", \"disk_format\","},{"line_number":89,"context_line":"                                   \"container_format\", \"images_per_tenant\"]},"},{"line_number":90,"context_line":"                     {\"required\": [\"image_url\", \"image_type\","},{"line_number":91,"context_line":"                                   \"container_format\", \"images_per_tenant\"]},"}],"source_content_type":"text/x-python","patch_set":44,"id":"1a1ced50_39c0452a","line":88,"range":{"start_line":88,"start_character":9,"end_line":88,"end_character":17},"updated":"2017-03-21 14:16:15.000000000","message":"it should be \"oneOf\"","commit_id":"7d9e05afdf5f185e601fcbe9328ea60bb16a9892"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a3b3df1aea2e376d6c55a88ed9ff79209eb2d47","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        container_format \u003d self.config.get(\"container_format\")"},{"line_number":106,"context_line":"        images_per_tenant \u003d self.config.get(\"images_per_tenant\")"},{"line_number":107,"context_line":"        image_name \u003d self.config.get(\"image_name\")"},{"line_number":108,"context_line":"        visibility \u003d self.config.get(\"visibility\", \"public\")"},{"line_number":109,"context_line":"        min_disk \u003d self.config.get(\"min_disk\", 0)"},{"line_number":110,"context_line":"        min_ram \u003d self.config.get(\"min_ram\", 0)"},{"line_number":111,"context_line":"        image_args \u003d self.config.get(\"image_args\", {})"}],"source_content_type":"text/x-python","patch_set":46,"id":"1a1ced50_861b8872","line":108,"range":{"start_line":108,"start_character":52,"end_line":108,"end_character":58},"updated":"2017-03-21 20:03:06.000000000","message":"let\u0027s make it \"private\" by default.","commit_id":"d10f2a6d3a084285cfa67d4bf487d8291f229754"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"0e25271531ab1fccb0930a20cd6726511eb326d8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        container_format \u003d self.config.get(\"container_format\")"},{"line_number":106,"context_line":"        images_per_tenant \u003d self.config.get(\"images_per_tenant\")"},{"line_number":107,"context_line":"        image_name \u003d self.config.get(\"image_name\")"},{"line_number":108,"context_line":"        visibility \u003d self.config.get(\"visibility\", \"public\")"},{"line_number":109,"context_line":"        min_disk \u003d self.config.get(\"min_disk\", 0)"},{"line_number":110,"context_line":"        min_ram \u003d self.config.get(\"min_ram\", 0)"},{"line_number":111,"context_line":"        image_args \u003d self.config.get(\"image_args\", {})"}],"source_content_type":"text/x-python","patch_set":46,"id":"1a1ced50_8fec74f4","line":108,"range":{"start_line":108,"start_character":52,"end_line":108,"end_character":58},"in_reply_to":"1a1ced50_861b8872","updated":"2017-03-22 01:09:23.000000000","message":"Done","commit_id":"d10f2a6d3a084285cfa67d4bf487d8291f229754"}],"rally/plugins/openstack/scenarios/glance/images.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"@validation.required_services(consts.Service.GLANCE)"},{"line_number":44,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":45,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":46,"context_line":"                    name\u003d\"GlanceBasic.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d9b9e67a","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":39},"updated":"2017-02-14 14:20:07.000000000","message":"1) there is no need to rename scenario names\n\n2) all removals, renames should be done in the backward compatible way, we should support at least two cycles deprecated scenarios.\n\nPS: it relates to all scenarios in that module. let\u0027s leave old names","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":43,"context_line":"@validation.required_services(consts.Service.GLANCE)"},{"line_number":44,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":45,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":46,"context_line":"                    name\u003d\"GlanceBasic.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_593dc18d","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":39},"in_reply_to":"fa31d9ce_d9b9e67a","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    name\u003d\"GlanceBasic.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":50,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_b93992f4","line":49,"range":{"start_line":49,"start_character":65,"end_line":49,"end_character":73},"updated":"2017-02-14 14:20:07.000000000","message":"I prefer to replace kwargs by \"real\" expected arguments, but it can be done in separate patch.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    name\u003d\"GlanceBasic.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":50,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_5964e1b7","line":49,"range":{"start_line":49,"start_character":65,"end_line":49,"end_character":73},"in_reply_to":"fa31d9ce_b93992f4","updated":"2017-02-15 12:08:35.000000000","message":"Copy that. Let us finish this patch firstly.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":65,"context_line":"        :param kwargs: optional parameters to create image"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        image \u003d self.admin_glance.create_image("},{"line_number":68,"context_line":"            container_format\u003dcontainer_format,"},{"line_number":69,"context_line":"            image_location\u003dimage_location,"},{"line_number":70,"context_line":"            disk_format\u003ddisk_format,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_39576227","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":34},"updated":"2017-02-14 14:20:07.000000000","message":"why are you calling self.admin_glance? The regular user should be enough(it has enough permissions). We should avoid usage of admin user in all cases where we can do it.\n\nrelates to all changes.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                            ami, ari, aki, vhd, vmdk, raw, qcow2, vdi, and iso"},{"line_number":65,"context_line":"        :param kwargs: optional parameters to create image"},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        image \u003d self.admin_glance.create_image("},{"line_number":68,"context_line":"            container_format\u003dcontainer_format,"},{"line_number":69,"context_line":"            image_location\u003dimage_location,"},{"line_number":70,"context_line":"            disk_format\u003ddisk_format,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_995ad9f0","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":34},"in_reply_to":"fa31d9ce_39576227","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self._delete_image(image)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"@types.convert(flavor\u003d{\"type\": \"nova_flavor\"},"},{"line_number":109,"context_line":"               image_location\u003d{\"type\": \"path_or_url\"},"},{"line_number":110,"context_line":"               kwargs\u003d{\"type\": \"glance_image_args\"})"},{"line_number":111,"context_line":"@validation.flavor_exists(\"flavor\")"},{"line_number":112,"context_line":"@validation.required_services(consts.Service.GLANCE, consts.Service.NOVA)"},{"line_number":113,"context_line":"@validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_acb77438","side":"PARENT","line":110,"range":{"start_line":108,"start_character":45,"end_line":110,"end_character":51},"updated":"2017-02-23 22:39:13.000000000","message":"Why do you remove it? (relates to all changes in that file)","commit_id":"14ec480b16306ac4093fe9b565e190d035869481"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"738cbd00654a8f23e586148e13311b77b77305bd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self._delete_image(image)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"@types.convert(flavor\u003d{\"type\": \"nova_flavor\"},"},{"line_number":109,"context_line":"               image_location\u003d{\"type\": \"path_or_url\"},"},{"line_number":110,"context_line":"               kwargs\u003d{\"type\": \"glance_image_args\"})"},{"line_number":111,"context_line":"@validation.flavor_exists(\"flavor\")"},{"line_number":112,"context_line":"@validation.required_services(consts.Service.GLANCE, consts.Service.NOVA)"},{"line_number":113,"context_line":"@validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_802431c5","side":"PARENT","line":110,"range":{"start_line":108,"start_character":45,"end_line":110,"end_character":51},"in_reply_to":"da36d5c6_acb77438","updated":"2017-02-24 02:13:33.000000000","message":"Hm, i forget the reason why I need to remove it. And I would check it again.","commit_id":"14ec480b16306ac4093fe9b565e190d035869481"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":50,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_6cc65c9b","line":49,"range":{"start_line":49,"start_character":65,"end_line":49,"end_character":73},"updated":"2017-02-23 22:39:13.000000000","message":"it would be perfect to specify all actual allowed arguments instead of kwargs. \n\nPS: it can be done in a separate patch, but it would be a great improvement.\nPSS: relates to all scenarios in that module","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"738cbd00654a8f23e586148e13311b77b77305bd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":47,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":50,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_40d4f9bb","line":49,"range":{"start_line":49,"start_character":65,"end_line":49,"end_character":73},"in_reply_to":"da36d5c6_6cc65c9b","updated":"2017-02-24 02:13:33.000000000","message":"I have add a task in rally:)\nhttps://trello.com/c/mwXU7lsB/288-specifying-exact-params-in-run-of-scenarios","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"3cec1df5af39359c220dc3957222c5b3e638b39a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_24e30808","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":61},"updated":"2017-03-24 08:39:12.000000000","message":"Here nova_utils is likely unnecessary, and other some scenarios","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_8625ffad","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":61},"in_reply_to":"ffe62b97_24e30808","updated":"2017-03-26 16:59:28.000000000","message":"Done","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"095aa8025f827b07a55e3683609ff7a3e1227a59","unresolved":false,"context_lines":[{"line_number":45,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":46,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_decb01a3","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":61},"in_reply_to":"ffe62b97_24e30808","updated":"2017-03-24 12:45:42.000000000","message":"agree, let\u0027s remove all redundant parent classes in this module.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"3cec1df5af39359c220dc3957222c5b3e638b39a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_a466f850","line":50,"updated":"2017-03-24 08:39:12.000000000","message":"Do we need to restrict image_name ?","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_0631efec","line":50,"in_reply_to":"ffe62b97_7ee3d506","updated":"2017-03-26 16:59:28.000000000","message":"Done in this patch-\u003ehttps://review.openstack.org/#/c/450024/.\nI would district kwargs;)","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"095aa8025f827b07a55e3683609ff7a3e1227a59","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    name\u003d\"GlanceImages.create_and_list_image\")"},{"line_number":48,"context_line":"class CreateAndListImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":51,"context_line":"        \"\"\"Create an image and then list all images."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Measure the \"glance image-list\" command performance."}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_7ee3d506","line":50,"in_reply_to":"ffe62b97_a466f850","updated":"2017-03-24 12:45:42.000000000","message":"let\u0027s use https://github.com/openstack/rally/blob/master/rally/task/validation.py#L665 validator for that thing.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"095aa8025f827b07a55e3683609ff7a3e1227a59","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    name\u003d\"GlanceImages.create_and_delete_image\")"},{"line_number":103,"context_line":"class CreateAndDeleteImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":106,"context_line":"        \"\"\"Create and then delete an image."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param container_format: container format of image. Acceptable"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_fec00553","line":105,"range":{"start_line":105,"start_character":66,"end_line":105,"end_character":73},"updated":"2017-03-24 12:45:42.000000000","message":"same here","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    name\u003d\"GlanceImages.create_and_delete_image\")"},{"line_number":103,"context_line":"class CreateAndDeleteImage(GlanceBasic, nova_utils.NovaScenario):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def run(self, container_format, image_location, disk_format, **kwargs):"},{"line_number":106,"context_line":"        \"\"\"Create and then delete an image."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param container_format: container format of image. Acceptable"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_c650a70d","line":105,"range":{"start_line":105,"start_character":66,"end_line":105,"end_character":73},"in_reply_to":"ffe62b97_fec00553","updated":"2017-03-26 16:59:28.000000000","message":"Done","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"}],"rally/plugins/openstack/services/image/glance_v1.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param disk_format: Disk format"},{"line_number":129,"context_line":"        :param visibility: The created image\u0027s visible status"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":132,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":133,"context_line":"                                            visibility)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        is_public \u003d visibility \u003d\u003d \"public\""},{"line_number":136,"context_line":"        image_obj \u003d self._impl.create_image("}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d471aba9","line":133,"range":{"start_line":131,"start_character":8,"end_line":133,"end_character":55},"updated":"2017-02-14 14:20:07.000000000","message":"let\u0027s move it to separate method and reuse it in all methods where visibility parameter can be transmitted","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param disk_format: Disk format"},{"line_number":129,"context_line":"        :param visibility: The created image\u0027s visible status"},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":132,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":133,"context_line":"                                            visibility)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        is_public \u003d visibility \u003d\u003d \"public\""},{"line_number":136,"context_line":"        image_obj \u003d self._impl.create_image("}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_79dc4546","line":133,"range":{"start_line":131,"start_character":8,"end_line":133,"end_character":55},"in_reply_to":"fa31d9ce_d471aba9","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @atomic.action_timer(\"glance_v1.list_images\")"},{"line_number":94,"context_line":"    def list_images(self, status\u003d\"active\", is_public\u003dTrue):"},{"line_number":95,"context_line":"        \"\"\"List images."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_ec06cccc","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":57},"updated":"2017-02-23 22:39:13.000000000","message":"let it be None by default, so we will have all images.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":125,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":126,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":127,"context_line":"                     min_ram\u003d0):"},{"line_number":128,"context_line":"        \"\"\"Creates new image."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_4cb7d8f4","line":126,"range":{"start_line":126,"start_character":21,"end_line":126,"end_character":40},"updated":"2017-02-23 22:39:13.000000000","message":"invalid value in case of V1. Also, we should add a check that only valid values are transmitted.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            min_ram\u003dmin_ram)"},{"line_number":147,"context_line":"        return self._unify_image(image_obj)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003d\"shared\"):"},{"line_number":150,"context_line":"        \"\"\"List images."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_acef74e7","line":149,"range":{"start_line":149,"start_character":54,"end_line":149,"end_character":62},"updated":"2017-02-23 22:39:13.000000000","message":"same here.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        images \u003d self._impl.list_images(status\u003dstatus, is_public\u003dis_public)"},{"line_number":160,"context_line":"        return [self._unify_image(i) for i in images]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def set_visibility(self, image_id, visibility\u003d\"shared\"):"},{"line_number":163,"context_line":"        \"\"\"Update visibility."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        :param image_id: ID of image to update"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_8ccd5087","line":162,"range":{"start_line":162,"start_character":39,"end_line":162,"end_character":58},"updated":"2017-02-23 22:39:13.000000000","message":"and here","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cec729dd0758875e413961284b660c2f9ffea76a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                       glance_image_create_prepoll_delay)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            image_obj \u003d utils.wait_for_status("},{"line_number":70,"context_line":"                image_obj.id, [\"active\"],"},{"line_number":71,"context_line":"                update_resource\u003dself.get_image,"},{"line_number":72,"context_line":"                timeout\u003dCONF.benchmark.glance_image_create_timeout,"},{"line_number":73,"context_line":"                check_interval\u003dCONF.benchmark.glance_image_create_poll_interval"}],"source_content_type":"text/x-python","patch_set":51,"id":"ffe62b97_fb377a4c","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":28},"updated":"2017-03-28 10:33:26.000000000","message":"the same comment as it was for glance V2","commit_id":"f43f442a67107477e814900590897b858e2769a4"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ad3252418068624d2a85991ecae4e087a80f84c8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                       glance_image_create_prepoll_delay)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            image_obj \u003d utils.wait_for_status("},{"line_number":70,"context_line":"                image_obj.id, [\"active\"],"},{"line_number":71,"context_line":"                update_resource\u003dself.get_image,"},{"line_number":72,"context_line":"                timeout\u003dCONF.benchmark.glance_image_create_timeout,"},{"line_number":73,"context_line":"                check_interval\u003dCONF.benchmark.glance_image_create_poll_interval"}],"source_content_type":"text/x-python","patch_set":51,"id":"ffe62b97_0c7c2270","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":28},"in_reply_to":"ffe62b97_fb377a4c","updated":"2017-03-28 12:11:06.000000000","message":"sorry, forget fix it.","commit_id":"f43f442a67107477e814900590897b858e2769a4"}],"rally/plugins/openstack/services/image/glance_v2.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        rutils.interruptable_sleep(CONF.benchmark."},{"line_number":57,"context_line":"                                   glance_image_create_prepoll_delay)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start \u003d time.time()"},{"line_number":60,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":61,"context_line":"            image_obj.id, [\"queued\"],"},{"line_number":62,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":63,"context_line":"            timeout\u003dCONF.benchmark.glance_image_create_timeout,"},{"line_number":64,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":65,"context_line":"        timeout \u003d time.time() - start"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        image_data \u003d None"},{"line_number":68,"context_line":"        response \u003d None"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_54b5bb2e","line":65,"range":{"start_line":59,"start_character":8,"end_line":65,"end_character":37},"updated":"2017-02-14 14:20:07.000000000","message":"not sure why we need to calculate this timeout and not use timeout from the CONF.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        rutils.interruptable_sleep(CONF.benchmark."},{"line_number":57,"context_line":"                                   glance_image_create_prepoll_delay)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        start \u003d time.time()"},{"line_number":60,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":61,"context_line":"            image_obj.id, [\"queued\"],"},{"line_number":62,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":63,"context_line":"            timeout\u003dCONF.benchmark.glance_image_create_timeout,"},{"line_number":64,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":65,"context_line":"        timeout \u003d time.time() - start"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        image_data \u003d None"},{"line_number":68,"context_line":"        response \u003d None"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_d9e53109","line":65,"range":{"start_line":59,"start_character":8,"end_line":65,"end_character":37},"in_reply_to":"fa31d9ce_54b5bb2e","updated":"2017-02-15 12:08:35.000000000","message":"Maybe this timeout would be exact.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        :param disk_format: Disk format"},{"line_number":140,"context_line":"        :param visibility: The access permission for the created image."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":143,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":144,"context_line":"                                            visibility)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        image_obj \u003d self._impl.create_image("},{"line_number":147,"context_line":"            image_name\u003dimage_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_34e68744","line":144,"range":{"start_line":142,"start_character":0,"end_line":144,"end_character":55},"updated":"2017-02-14 14:20:07.000000000","message":"In case of V2, users should not be limited by values expected by V1","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        :param disk_format: Disk format"},{"line_number":140,"context_line":"        :param visibility: The access permission for the created image."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":143,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":144,"context_line":"                                            visibility)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        image_obj \u003d self._impl.create_image("},{"line_number":147,"context_line":"            image_name\u003dimage_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_59c06150","line":144,"range":{"start_line":142,"start_character":0,"end_line":144,"end_character":55},"in_reply_to":"fa31d9ce_34e68744","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        :param status: Filter in images for the specified status"},{"line_number":158,"context_line":"        :param visibility: Filter in images for the specified visibility"},{"line_number":159,"context_line":"        \"\"\""},{"line_number":160,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":161,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":162,"context_line":"                                            visibility)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        images \u003d self._impl.list_images(status\u003dstatus, visibility\u003dvisibility)"},{"line_number":165,"context_line":"        return [self._unify_image(i) for i in images]"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_94d7334a","line":162,"range":{"start_line":160,"start_character":7,"end_line":162,"end_character":55},"updated":"2017-02-14 14:20:07.000000000","message":"same here","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        :param status: Filter in images for the specified status"},{"line_number":158,"context_line":"        :param visibility: Filter in images for the specified visibility"},{"line_number":159,"context_line":"        \"\"\""},{"line_number":160,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":161,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":162,"context_line":"                                            visibility)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        images \u003d self._impl.list_images(status\u003dstatus, visibility\u003dvisibility)"},{"line_number":165,"context_line":"        return [self._unify_image(i) for i in images]"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_99b659f7","line":162,"range":{"start_line":160,"start_character":7,"end_line":162,"end_character":55},"in_reply_to":"fa31d9ce_94d7334a","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        :param image_id: ID of image to update"},{"line_number":171,"context_line":"        :param visibility: The visibility of specified image"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":174,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":175,"context_line":"                                            visibility)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self._impl.set_visibility(image_id\u003dimage_id, visibility\u003dvisibility)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_14c4238f","line":175,"range":{"start_line":173,"start_character":0,"end_line":175,"end_character":55},"updated":"2017-02-14 14:20:07.000000000","message":"and here","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        :param image_id: ID of image to update"},{"line_number":171,"context_line":"        :param visibility: The visibility of specified image"},{"line_number":172,"context_line":"        \"\"\""},{"line_number":173,"context_line":"        if visibility not in [\"public\", \"private\"]:"},{"line_number":174,"context_line":"            raise image.VisibilityException(\"Improper visibility value: %s\","},{"line_number":175,"context_line":"                                            visibility)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self._impl.set_visibility(image_id\u003dimage_id, visibility\u003dvisibility)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_f9c75561","line":175,"range":{"start_line":173,"start_character":0,"end_line":175,"end_character":55},"in_reply_to":"fa31d9ce_14c4238f","updated":"2017-02-15 12:08:35.000000000","message":"Done","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1c6f1de523a18af445369f8fb1760d250a52dca8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @atomic.action_timer(\"glance_v2.create_image\")"},{"line_number":36,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":37,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":38,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":39,"context_line":"                     min_ram\u003d0):"},{"line_number":40,"context_line":"        \"\"\"Creates new image."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_096fe92b","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":40},"updated":"2017-03-20 16:39:00.000000000","message":"The root cause of access-problem can be a default value of visibility. Not sure that the regular user can change shared image. let\u0027s make default value to None and see what happen","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2fadf0c061fa4205aa242d8429bc15f04f23fbf3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @atomic.action_timer(\"glance_v2.create_image\")"},{"line_number":36,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":37,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":38,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":39,"context_line":"                     min_ram\u003d0):"},{"line_number":40,"context_line":"        \"\"\"Creates new image."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_6be4ace0","line":38,"range":{"start_line":38,"start_character":31,"end_line":38,"end_character":40},"in_reply_to":"1a1ced50_096fe92b","updated":"2017-03-21 12:15:09.000000000","message":"I can try it.But None can not be transmitted.","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"095aa8025f827b07a55e3683609ff7a3e1227a59","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                response.close()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_3e7d4db1","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":24},"updated":"2017-03-24 12:45:42.000000000","message":"we need to transmit the whole image_obj there to have the proper exceptions. It relates to all calls of wait_for_status","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                response.close()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_6641db39","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":24},"in_reply_to":"ffe62b97_3e7d4db1","updated":"2017-03-26 16:59:28.000000000","message":"Done","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"44c48b1aa56ef76aca64d51cda2a431e127a48c0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                response.close()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_5c8d872f","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":24},"in_reply_to":"ffe62b97_3e7d4db1","updated":"2017-03-27 03:13:55.000000000","message":"oops, it is wrong. self.get_image just need a param of image\u0027s id. If we need transmit the whole image_obj, I need adjust get_image(image_id) to get_image(image_obj). But I think we need add another `wait_for_stauts` function would be better.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"3cec1df5af39359c220dc3957222c5b3e638b39a","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":92,"context_line":"        return image_obj"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_04ab641d","line":89,"updated":"2017-03-24 08:39:12.000000000","message":"not sure we need to save atomic actions of get_image.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":92,"context_line":"        return image_obj"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_cb3432fe","line":89,"in_reply_to":"ffe62b97_04ab641d","updated":"2017-03-26 16:59:28.000000000","message":"I agree `create image` operation don\u0027t save the atomic action of `get_image`, but other scenarios need it.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"095aa8025f827b07a55e3683609ff7a3e1227a59","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":92,"context_line":"        return image_obj"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_1ebe0965","line":89,"in_reply_to":"ffe62b97_04ab641d","updated":"2017-03-24 12:45:42.000000000","message":"I think we will be able to fix it without overhead after merging atomic action refactoring.","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d3ef21c2948e4ba81537e2033482c80852194ea5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        image_obj \u003d utils.wait_for_status("},{"line_number":88,"context_line":"            image_obj.id, [\"active\"],"},{"line_number":89,"context_line":"            update_resource\u003dself.get_image,"},{"line_number":90,"context_line":"            timeout\u003dtimeout,"},{"line_number":91,"context_line":"            check_interval\u003dCONF.benchmark.glance_image_create_poll_interval)"},{"line_number":92,"context_line":"        return image_obj"}],"source_content_type":"text/x-python","patch_set":49,"id":"ffe62b97_8b3e2ad8","line":89,"in_reply_to":"ffe62b97_1ebe0965","updated":"2017-03-26 16:59:28.000000000","message":"so it would be more concise;)","commit_id":"2f927ea170b26a5566753c63012d95f30ea2edf5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"539a2e4182fb3a965d4f4dcd37708ed0aafd3790","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return image_obj"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @atomic.action_timer(\"glance_v2.get_image\")"},{"line_number":95,"context_line":"    def get_image(self, image_id):"},{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_0ab67fda","line":95,"range":{"start_line":95,"start_character":24,"end_line":95,"end_character":32},"updated":"2017-03-27 11:10:34.000000000","message":"s/image_id/image","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"539a2e4182fb3a965d4f4dcd37708ed0aafd3790","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def get_image(self, image_id):"},{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_ca689722","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":58},"updated":"2017-03-27 11:10:34.000000000","message":":param image: ID or object with ID of image to obtain","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"075387d18278bd8a941eb50dae6b54808b2f7950","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def get_image(self, image_id):"},{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_f3ca2818","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":58},"in_reply_to":"ffe62b97_187a4bf0","updated":"2017-03-28 02:51:50.000000000","message":"Fine, I would fix it.","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b0521439c0fd6ee15ea158bdd0eda0b0c6bc1025","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def get_image(self, image_id):"},{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_187a4bf0","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":58},"in_reply_to":"ffe62b97_2c99581e","updated":"2017-03-27 16:04:36.000000000","message":"\u003e But we need transmit basic param excluding the param of instance.\n\nIt should not be a problem, because the way of obtaining \"id\" is unified across all classes.","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"beb4d8ad5faa9cd75d6fba1fba704912c554ccc4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def get_image(self, image_id):"},{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_2c99581e","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":58},"in_reply_to":"ffe62b97_ca689722","updated":"2017-03-27 13:59:49.000000000","message":"It could resolve our problem. But we need transmit basic param excluding the param of instance.","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"539a2e4182fb3a965d4f4dcd37708ed0aafd3790","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\"Get specified image."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"},{"line_number":102,"context_line":"        except glance_exc.HTTPNotFound:"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_6a63cb43","line":99,"range":{"start_line":99,"start_character":8,"end_line":99,"end_character":10},"updated":"2017-03-27 11:10:34.000000000","message":"redundant spaces","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"539a2e4182fb3a965d4f4dcd37708ed0aafd3790","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        :param image_id: ID of image which need to be got."},{"line_number":99,"context_line":"          \"\"\""},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            return self._clients.glance(\"2\").images.get(image_id)"},{"line_number":102,"context_line":"        except glance_exc.HTTPNotFound:"},{"line_number":103,"context_line":"            raise exceptions.GetResourceNotFound(resource\u003dimage)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @atomic.action_timer(\"glance_v2.list_images\")"},{"line_number":106,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003dNone):"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_0abc3f67","line":103,"range":{"start_line":100,"start_character":8,"end_line":103,"end_character":64},"updated":"2017-03-27 11:10:34.000000000","message":"image_id \u003d getattr(image, \"id\", image)\ntry:\n   ...","commit_id":"1c972c3b8603f89124e6b49c22526691538b579e"}],"rally/plugins/openstack/services/image/image.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"benchmark_group \u003d cfg.OptGroup(name\u003d\"benchmark\", title\u003d\"benchmark options\")"},{"line_number":33,"context_line":"CONF.register_opts(GLANCE_BENCHMARK_OPTS, group\u003dbenchmark_group)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"UnifiedImage \u003d collections.namedtuple(\"Image\", [\"id\", \"name\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VisibilityException(Exception):"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_a59a3c6c","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":62},"updated":"2017-02-14 14:20:07.000000000","message":"1) let\u0027s extend it with at least \"visibility\" field\n\n2) please, name it just Image","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"e3303eb26b2915decbf1ad29a73e578f2e4dce6e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"benchmark_group \u003d cfg.OptGroup(name\u003d\"benchmark\", title\u003d\"benchmark options\")"},{"line_number":33,"context_line":"CONF.register_opts(GLANCE_BENCHMARK_OPTS, group\u003dbenchmark_group)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"UnifiedImage \u003d collections.namedtuple(\"Image\", [\"id\", \"name\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VisibilityException(Exception):"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_810fb035","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":62},"in_reply_to":"fa31d9ce_9fa639ac","updated":"2017-02-15 16:26:00.000000000","message":"UnifiedImage can not ported to Image, because there is a class of Image:(","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":32,"context_line":"benchmark_group \u003d cfg.OptGroup(name\u003d\"benchmark\", title\u003d\"benchmark options\")"},{"line_number":33,"context_line":"CONF.register_opts(GLANCE_BENCHMARK_OPTS, group\u003dbenchmark_group)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"UnifiedImage \u003d collections.namedtuple(\"Image\", [\"id\", \"name\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VisibilityException(Exception):"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_9fa639ac","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":62},"in_reply_to":"fa31d9ce_a59a3c6c","updated":"2017-02-15 12:08:35.000000000","message":"ok","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"06ea2d29bfc4a1abf48a84b838b4797318ac5bf6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        return image"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @service.should_be_overridden"},{"line_number":75,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003d\"public\"):"},{"line_number":76,"context_line":"        \"\"\"List images."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_65d044f7","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":62},"updated":"2017-02-14 14:20:07.000000000","message":"Not sure that we need default value \"public\". Bu default it is better to list any image.","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"8c78ddd468d12da3482a61ab128244d346591185","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        return image"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @service.should_be_overridden"},{"line_number":75,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003d\"public\"):"},{"line_number":76,"context_line":"        \"\"\"List images."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa31d9ce_bfc85d56","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":62},"in_reply_to":"fa31d9ce_65d044f7","updated":"2017-02-15 12:08:35.000000000","message":"ok","commit_id":"169897eee46abdb2baa08d8089bfc0f6b4a7b56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return UnifiedImage(id\u003dimage.id, name\u003dimage.name,"},{"line_number":57,"context_line":"                                visibility\u003dimage.is_public)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def _check_visibility(visibility):"},{"line_number":61,"context_line":"        visibility_values \u003d [\"public\", \"private\", \"shared\", \"community\"]"},{"line_number":62,"context_line":"        if visibility not in visibility_values:"},{"line_number":63,"context_line":"            raise VisibilityException(\"Improper visibility value: %s\","},{"line_number":64,"context_line":"                                      visibility)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @service.should_be_overridden"},{"line_number":67,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_cc1588e5","line":64,"range":{"start_line":59,"start_character":3,"end_line":64,"end_character":49},"updated":"2017-02-23 22:39:13.000000000","message":"not sure that it should be a unified method, since v1 accepts only public and private","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2103ee7dc802a8dbc36fb99c4a7491250e909df6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return UnifiedImage(id\u003dimage.id, name\u003dimage.name,"},{"line_number":57,"context_line":"                                visibility\u003dimage.is_public)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def _check_visibility(visibility):"},{"line_number":61,"context_line":"        visibility_values \u003d [\"public\", \"private\", \"shared\", \"community\"]"},{"line_number":62,"context_line":"        if visibility not in visibility_values:"},{"line_number":63,"context_line":"            raise VisibilityException(\"Improper visibility value: %s\","},{"line_number":64,"context_line":"                                      visibility)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @service.should_be_overridden"},{"line_number":67,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_a3dbb620","line":64,"range":{"start_line":59,"start_character":3,"end_line":64,"end_character":49},"in_reply_to":"da36d5c6_cc1588e5","updated":"2017-02-27 16:00:35.000000000","message":"this function would check glance_v2:)","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @service.should_be_overridden"},{"line_number":67,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":68,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":69,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":70,"context_line":"                     min_ram\u003d0):"},{"line_number":71,"context_line":"        \"\"\"Creates new image."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_ac9db467","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":39},"updated":"2017-02-23 22:39:13.000000000","message":"maybe \"public\"?","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c1a36c13722ba598aa6648e06ee7284992f66ed6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @service.should_be_overridden"},{"line_number":67,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":68,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":69,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":70,"context_line":"                     min_ram\u003d0):"},{"line_number":71,"context_line":"        \"\"\"Creates new image."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_1fe4b739","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":39},"in_reply_to":"da36d5c6_2388a6c6","updated":"2017-03-01 01:23:45.000000000","message":"glance v2\u0027s default is \"shared\"","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2103ee7dc802a8dbc36fb99c4a7491250e909df6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @service.should_be_overridden"},{"line_number":67,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"},{"line_number":68,"context_line":"                     image_location\u003dNone, disk_format\u003dNone,"},{"line_number":69,"context_line":"                     visibility\u003d\"shared\", min_disk\u003d0,"},{"line_number":70,"context_line":"                     min_ram\u003d0):"},{"line_number":71,"context_line":"        \"\"\"Creates new image."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_2388a6c6","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":39},"in_reply_to":"da36d5c6_ac9db467","updated":"2017-02-27 16:00:35.000000000","message":"The default visibility of image is \u0027shared\u0027, so i think it is ok!","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ead6ec6f7aa564573843cad76af48b6065ac9e62","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return image"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @service.should_be_overridden"},{"line_number":92,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003d\"shared\"):"},{"line_number":93,"context_line":"        \"\"\"List images."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_cc9ae86d","line":92,"range":{"start_line":92,"start_character":54,"end_line":92,"end_character":62},"updated":"2017-02-23 22:39:13.000000000","message":"it should be None to list all images by default.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2103ee7dc802a8dbc36fb99c4a7491250e909df6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return image"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @service.should_be_overridden"},{"line_number":92,"context_line":"    def list_images(self, status\u003d\"active\", visibility\u003d\"shared\"):"},{"line_number":93,"context_line":"        \"\"\"List images."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param status: Filter in images for the specified status"}],"source_content_type":"text/x-python","patch_set":34,"id":"da36d5c6_63929ef8","line":92,"range":{"start_line":92,"start_character":54,"end_line":92,"end_character":62},"in_reply_to":"da36d5c6_cc9ae86d","updated":"2017-02-27 16:00:35.000000000","message":"OK, i will fix it.","commit_id":"8d40a5527cff0b60033aa522e4d24f761cc92a80"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"764b3ec9de0db9f7d0ee881f17f3dc464a54f3d9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return UnifiedImage(id\u003dimage.id, name\u003dimage.name,"},{"line_number":57,"context_line":"                                visibility\u003dimage.is_public)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def _check_v2_visibility(visibility):"},{"line_number":61,"context_line":"        visibility_values \u003d [\"public\", \"private\", \"shared\", \"community\"]"},{"line_number":62,"context_line":"        if visibility and visibility not in visibility_values:"},{"line_number":63,"context_line":"            raise VisibilityException(\"Improper visibility value: %s \""},{"line_number":64,"context_line":"                                      \"in glance_v2\" % visibility)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def _check_v1_visibility(visibility):"},{"line_number":68,"context_line":"        visibility_values \u003d [\"public\", \"private\"]"},{"line_number":69,"context_line":"        if visibility and visibility not in visibility_values:"},{"line_number":70,"context_line":"            raise VisibilityException(\"Improper visibility value: %s in \""},{"line_number":71,"context_line":"                                      \"glance_v1\" % visibility)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @service.should_be_overridden"},{"line_number":74,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3a1ff146_4d773f3a","line":71,"range":{"start_line":59,"start_character":4,"end_line":71,"end_character":63},"updated":"2017-03-16 08:54:56.000000000","message":"why not move these methods to corresponding classes?","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"0bed111f577e16fe1d3d376ae2262cb10cbeba5a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return UnifiedImage(id\u003dimage.id, name\u003dimage.name,"},{"line_number":57,"context_line":"                                visibility\u003dimage.is_public)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @staticmethod"},{"line_number":60,"context_line":"    def _check_v2_visibility(visibility):"},{"line_number":61,"context_line":"        visibility_values \u003d [\"public\", \"private\", \"shared\", \"community\"]"},{"line_number":62,"context_line":"        if visibility and visibility not in visibility_values:"},{"line_number":63,"context_line":"            raise VisibilityException(\"Improper visibility value: %s \""},{"line_number":64,"context_line":"                                      \"in glance_v2\" % visibility)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"},{"line_number":67,"context_line":"    def _check_v1_visibility(visibility):"},{"line_number":68,"context_line":"        visibility_values \u003d [\"public\", \"private\"]"},{"line_number":69,"context_line":"        if visibility and visibility not in visibility_values:"},{"line_number":70,"context_line":"            raise VisibilityException(\"Improper visibility value: %s in \""},{"line_number":71,"context_line":"                                      \"glance_v1\" % visibility)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @service.should_be_overridden"},{"line_number":74,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_982ff7a0","line":71,"range":{"start_line":59,"start_character":4,"end_line":71,"end_character":63},"in_reply_to":"3a1ff146_4d773f3a","updated":"2017-03-17 02:20:13.000000000","message":"Done","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2214cd615465d2d422ae00178dfaa728e2656352","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                visibility\u003dimage.visibility)"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return UnifiedImage(id\u003dimage.id, name\u003dimage.name,"},{"line_number":57,"context_line":"                                visibility\u003dimage.is_public)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @service.should_be_overridden"},{"line_number":60,"context_line":"    def create_image(self, image_name\u003dNone, container_format\u003dNone,"}],"source_content_type":"text/x-python","patch_set":42,"id":"1a1ced50_a36276ab","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":58},"updated":"2017-03-20 15:53:54.000000000","message":"visibility\u003d(\"public\" if image.is_public else \"private\")","commit_id":"a6f0dcfb73a4099184859e7e1e33eb75127154b8"}],"tests/unit/doc/test_task_samples.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"966c2533663e2d9f64790ed94bdfce5d29447e9c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                        yaml_config \u003d yaml.safe_load(api.Task.render_template"},{"line_number":129,"context_line":"                                                     (yaml_file.read()))"},{"line_number":130,"context_line":"                    self.assertEqual(json_config, yaml_config,"},{"line_number":131,"context_line":"                                     \"Sample task configs    are not equal:\""},{"line_number":132,"context_line":"                                     \"\\n%s\\n%s\" % (yaml_path, json_path))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_no_underscores_in_filename(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_a0713278","line":131,"range":{"start_line":131,"start_character":58,"end_line":131,"end_character":61},"updated":"2017-02-08 07:44:45.000000000","message":"Looks like an unintentional change.","commit_id":"7b1116f8666630d8e12f72dbcbffa9f8f3b91817"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"e530712e908e7445b755b0988fd0f1029b94ce65","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                        yaml_config \u003d yaml.safe_load(api.Task.render_template"},{"line_number":129,"context_line":"                                                     (yaml_file.read()))"},{"line_number":130,"context_line":"                    self.assertEqual(json_config, yaml_config,"},{"line_number":131,"context_line":"                                     \"Sample task configs    are not equal:\""},{"line_number":132,"context_line":"                                     \"\\n%s\\n%s\" % (yaml_path, json_path))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_no_underscores_in_filename(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_7adff268","line":131,"range":{"start_line":131,"start_character":58,"end_line":131,"end_character":61},"in_reply_to":"1a430d35_a0713278","updated":"2017-02-08 08:47:53.000000000","message":"Thanks","commit_id":"7b1116f8666630d8e12f72dbcbffa9f8f3b91817"}],"tests/unit/plugins/openstack/scenarios/glance/test_images.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"764b3ec9de0db9f7d0ee881f17f3dc464a54f3d9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_list_images(self):"},{"line_number":86,"context_line":"        image_service \u003d self.mock_image.return_value"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # call_args \u003d [fakes.FakeImage(id\u003d1, name\u003d\"image1\"),"},{"line_number":89,"context_line":"        #              fakes.FakeImage(id\u003d2, name\u003d\"image2\"),"},{"line_number":90,"context_line":"        #              fakes.FakeImage(id\u003d3, name\u003d\"image3\")]"},{"line_number":91,"context_line":"        # image_service.list_images.return_value \u003d call_args"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        images.ListImages(self.context).run()"},{"line_number":94,"context_line":"        image_service.list_images.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":41,"id":"3a1ff146_93b6b4da","line":91,"range":{"start_line":88,"start_character":8,"end_line":91,"end_character":60},"updated":"2017-03-16 08:54:56.000000000","message":"Please, remove it","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"0bed111f577e16fe1d3d376ae2262cb10cbeba5a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def test_list_images(self):"},{"line_number":86,"context_line":"        image_service \u003d self.mock_image.return_value"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # call_args \u003d [fakes.FakeImage(id\u003d1, name\u003d\"image1\"),"},{"line_number":89,"context_line":"        #              fakes.FakeImage(id\u003d2, name\u003d\"image2\"),"},{"line_number":90,"context_line":"        #              fakes.FakeImage(id\u003d3, name\u003d\"image3\")]"},{"line_number":91,"context_line":"        # image_service.list_images.return_value \u003d call_args"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        images.ListImages(self.context).run()"},{"line_number":94,"context_line":"        image_service.list_images.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_78223bbb","line":91,"range":{"start_line":88,"start_character":8,"end_line":91,"end_character":60},"in_reply_to":"3a1ff146_93b6b4da","updated":"2017-03-17 02:20:13.000000000","message":"Done","commit_id":"c56454d627eac7cd6a219694d95505d1f7036f1c"}]}
