)]}'
{"rally/plugins/openstack/scenarios/nova/keypairs.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d6a27ed5a4521d5f133c72dbc59bfe4106de5fbd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":119,"context_line":"        msg \u003d (\"Keypair isn\u0027t created\")"},{"line_number":120,"context_line":"        self.assertTrue(keypair, err_msg\u003dmsg)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self._get_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_1b0d8790","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":45},"updated":"2017-01-14 20:04:03.000000000","message":"assert shouldn\u0027t be in scenario","commit_id":"05b434227e81ae1b6eb2583e997df912c97969da"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"8a70e644abc3c7244df79fcf7e477a8966fc4787","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":119,"context_line":"        msg \u003d (\"Keypair isn\u0027t created\")"},{"line_number":120,"context_line":"        self.assertTrue(keypair, err_msg\u003dmsg)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self._get_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_1bce56b4","line":120,"range":{"start_line":119,"start_character":0,"end_line":120,"end_character":45},"in_reply_to":"7a3c09a3_1b0d8790","updated":"2017-01-16 05:13:31.000000000","message":"Done","commit_id":"05b434227e81ae1b6eb2583e997df912c97969da"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"51673349e6e009c9213989da94fdd691e173680b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        :param kwargs: Optional additional arguments for keypair creation"},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self._get_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_1fc36539","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":48},"updated":"2017-03-03 01:30:23.000000000","message":"@Roman, Why delete assertTrue in scenarios?. assertTrue() in scenarios would be better. ref:\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/flavors.py#L69","commit_id":"8b018d9f46a4a56ca389b029d6cfbbb4f293e773"}],"tests/unit/plugins/openstack/scenarios/nova/test_keypairs.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0f2e1d411d205681e3ba6791703bdd346d16ac8c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        scenario._create_keypair.assert_called_once_with(fakearg\u003d\"fakearg\")"},{"line_number":68,"context_line":"        scenario._get_keypair.assert_called_once_with(fake_keypair)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Negative case1: keypair isn\u0027t created"},{"line_number":71,"context_line":"        scenario._create_keypair.return_value \u003d None"},{"line_number":72,"context_line":"        self.assertRaises(exceptions.RallyAssertionError,"},{"line_number":73,"context_line":"                          scenario.run, fakearg\u003d\"fakearg\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9b4fb7bc","line":70,"updated":"2017-01-14 20:11:59.000000000","message":"I don\u0027t like approach of mixing positive and negative test cases. Because if we get fail of positive case we don\u0027t see results of negative case.\nYes, I saw that above the same code was accepted. So I don\u0027t insist on separation in that patch\u003d)","commit_id":"05b434227e81ae1b6eb2583e997df912c97969da"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"8a70e644abc3c7244df79fcf7e477a8966fc4787","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        scenario._create_keypair.assert_called_once_with(fakearg\u003d\"fakearg\")"},{"line_number":68,"context_line":"        scenario._get_keypair.assert_called_once_with(fake_keypair)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Negative case1: keypair isn\u0027t created"},{"line_number":71,"context_line":"        scenario._create_keypair.return_value \u003d None"},{"line_number":72,"context_line":"        self.assertRaises(exceptions.RallyAssertionError,"},{"line_number":73,"context_line":"                          scenario.run, fakearg\u003d\"fakearg\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_fbca6aa0","line":70,"in_reply_to":"7a3c09a3_9b4fb7bc","updated":"2017-01-16 05:13:31.000000000","message":"Done","commit_id":"05b434227e81ae1b6eb2583e997df912c97969da"}]}