)]}'
{"rally-jobs/nova.yaml":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"088c865baa28d2e52c84896e004dd1ffb1889c2c","unresolved":false,"context_lines":[{"line_number":539,"context_line":"          users_per_tenant: 2"},{"line_number":540,"context_line":"      sla:"},{"line_number":541,"context_line":"        failure_rate:"},{"line_number":542,"context_line":"          max: 2"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"  NovaServers.boot_server_from_volume_and_resize:"},{"line_number":545,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_862e6ff8","line":542,"range":{"start_line":542,"start_character":15,"end_line":542,"end_character":16},"updated":"2017-07-20 23:14:44.000000000","message":"Why not use 0?","commit_id":"ce6d0e1d1596fa985e90f6c48b7f475ffe1cfeb1"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"41db2c28a144ee890afa7620dcea0b09e4dc0d8a","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        new_volume_kwargs: {}"},{"line_number":532,"context_line":"      runner:"},{"line_number":533,"context_line":"        type: \"constant\""},{"line_number":534,"context_line":"        times: 4"},{"line_number":535,"context_line":"        concurrency: 2"},{"line_number":536,"context_line":"      context:"},{"line_number":537,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff346bd7_c818b682","line":534,"updated":"2017-07-25 00:30:34.000000000","message":"This adds 2 minutes in our gates on every patch. \nCan you please reduce here to 2 times it\u0027s enough to check it","commit_id":"95b1ba1139335e93f16d706a730b2d2b7101f2f0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"41db2c28a144ee890afa7620dcea0b09e4dc0d8a","unresolved":false,"context_lines":[{"line_number":539,"context_line":"          users_per_tenant: 2"},{"line_number":540,"context_line":"      sla:"},{"line_number":541,"context_line":"        failure_rate:"},{"line_number":542,"context_line":"          max: 2"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"  NovaServers.boot_server_from_volume_and_resize:"},{"line_number":545,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff346bd7_4a0cbb3a","line":542,"updated":"2017-07-25 00:30:34.000000000","message":"Why 2? it means 2% I would prefer 0","commit_id":"95b1ba1139335e93f16d706a730b2d2b7101f2f0"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"41db2c28a144ee890afa7620dcea0b09e4dc0d8a","unresolved":false,"context_lines":[{"line_number":534,"context_line":"@types.convert(image\u003d{\"type\": \"glance_image\"},"},{"line_number":535,"context_line":"               flavor\u003d{\"type\": \"nova_flavor\"})"},{"line_number":536,"context_line":"@validation.image_valid_on_flavor(\"flavor\", \"image\")"},{"line_number":537,"context_line":"@validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":538,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":539,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"nova\"]},"},{"line_number":540,"context_line":"                    name\u003d(\"NovaServers.boot_server\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_852bc292","line":537,"updated":"2017-07-25 00:30:34.000000000","message":"these are old style validators now you should use only \n\n  @validation.add(\"validator_name\", ...)\n\nas in other test cases.","commit_id":"95b1ba1139335e93f16d706a730b2d2b7101f2f0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"41db2c28a144ee890afa7620dcea0b09e4dc0d8a","unresolved":false,"context_lines":[{"line_number":537,"context_line":"@validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":538,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":539,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"nova\"]},"},{"line_number":540,"context_line":"                    name\u003d(\"NovaServers.boot_server\""},{"line_number":541,"context_line":"                          \"_attach_volume_and_update_attachment\"))"},{"line_number":542,"context_line":"class BootServerAttachVolumeAndUpdateAttachment(utils.NovaScenario,"},{"line_number":543,"context_line":"                                                cinder_utils.CinderScenario):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_2546567e","line":540,"updated":"2017-07-25 00:30:34.000000000","message":"Please don\u0027t split the name in 2 lines that makes it hard to find it using regular search of editor. \n\nrather just reindent things\n\n\n    @scenario.configure(\n       context\u003d{\"cleanup\": [\"cinder\", \"nova\"]},\n       name\u003d\"NovaServers.boot_server_attach_volume_and_update_attachment\")\n\n\nAs well we merged yesterday patch that refactors plugin namespaces (replace to platforms) and it is required now to specify platform\u003d\"openstack\" in configure method explicitly","commit_id":"95b1ba1139335e93f16d706a730b2d2b7101f2f0"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c4e9cf83d2437c13dbac29b0e38dde4e7ff9dbca","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    name\u003d\"NovaServers.boot_server_attach_volume_and_update_attachment\","},{"line_number":558,"context_line":"    platform\u003d\"openstack\")"},{"line_number":559,"context_line":"class BootServerAttachVolumeAndUpdateAttachment(utils.NovaScenario,"},{"line_number":560,"context_line":"                                                cinder_utils.CinderScenario):"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def run(self, image, flavor, volume_size, new_volume_size,"},{"line_number":563,"context_line":"            min_sleep\u003d0, max_sleep\u003d0, force_delete\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_df441dba","line":560,"range":{"start_line":560,"start_character":48,"end_line":560,"end_character":75},"updated":"2017-07-29 08:05:24.000000000","message":"Looks CinderScenario would be removed in version 0.10.0. https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/utils.py#L56-L60","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"57eb92a928586c1ec285088550ef2fd42c4392ce","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    name\u003d\"NovaServers.boot_server_attach_volume_and_update_attachment\","},{"line_number":558,"context_line":"    platform\u003d\"openstack\")"},{"line_number":559,"context_line":"class BootServerAttachVolumeAndUpdateAttachment(utils.NovaScenario,"},{"line_number":560,"context_line":"                                                cinder_utils.CinderScenario):"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def run(self, image, flavor, volume_size, new_volume_size,"},{"line_number":563,"context_line":"            min_sleep\u003d0, max_sleep\u003d0, force_delete\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_798120fb","line":560,"range":{"start_line":560,"start_character":48,"end_line":560,"end_character":75},"in_reply_to":"df3967d1_df441dba","updated":"2017-08-04 10:40:29.000000000","message":"Done","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3f6d2a0496de2692ed96c7543c6d3b3303b25a49","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        volume_kwargs \u003d volume_kwargs or {}"},{"line_number":590,"context_line":"        new_volume_kwargs \u003d new_volume_kwargs or {}"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        server \u003d self._boot_server(image, flavor, **boot_server_kwargs)"},{"line_number":593,"context_line":"        volume \u003d self.cinder.create_volume(volume_size, **volume_kwargs)"},{"line_number":594,"context_line":"        new_volume \u003d self.cinder.create_volume(new_volume_size,"},{"line_number":595,"context_line":"                                               **new_volume_kwargs)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        attachment \u003d self._attach_volume(server, volume)"},{"line_number":598,"context_line":"        self.sleep_between(min_sleep, max_sleep)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_eb483b5d","line":595,"range":{"start_line":592,"start_character":8,"end_line":595,"end_character":67},"updated":"2017-09-01 11:41:35.000000000","message":"we should restrict setting resource names here.","commit_id":"41cbdac5730e7792df68826dce7053c81c4c6464"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"35de5731d411d4b5e99ee44eaf1939ff390e70f5","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        volume_kwargs \u003d volume_kwargs or {}"},{"line_number":590,"context_line":"        new_volume_kwargs \u003d new_volume_kwargs or {}"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        server \u003d self._boot_server(image, flavor, **boot_server_kwargs)"},{"line_number":593,"context_line":"        volume \u003d self.cinder.create_volume(volume_size, **volume_kwargs)"},{"line_number":594,"context_line":"        new_volume \u003d self.cinder.create_volume(new_volume_size,"},{"line_number":595,"context_line":"                                               **new_volume_kwargs)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        attachment \u003d self._attach_volume(server, volume)"},{"line_number":598,"context_line":"        self.sleep_between(min_sleep, max_sleep)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f2577a7_005882f7","line":595,"range":{"start_line":592,"start_character":8,"end_line":595,"end_character":67},"in_reply_to":"7f287b81_eb483b5d","updated":"2017-09-15 03:10:29.000000000","message":"Done","commit_id":"41cbdac5730e7792df68826dce7053c81c4c6464"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"551f332aaba6371d3028e361a300078a7ca5501a","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                subdict\u003d\"new_volume_kwargs\")"},{"line_number":551,"context_line":"@validation.add(\"number\", param_name\u003d\"volume_size\", minval\u003d1,"},{"line_number":552,"context_line":"                integer_only\u003dTrue)"},{"line_number":553,"context_line":"@types.convert(image\u003d{\"type\": \"glance_image\"},"},{"line_number":554,"context_line":"               flavor\u003d{\"type\": \"nova_flavor\"})"},{"line_number":555,"context_line":"@validation.add(\"image_valid_on_flavor\", flavor_param\u003d\"flavor\","},{"line_number":556,"context_line":"                image_param\u003d\"image\", validate_disk\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_553d0f8c","line":553,"updated":"2017-10-09 20:29:41.000000000","message":"can you put types before all @validation.add ?","commit_id":"e40c87916399c2ffd50bde0db6fd3902416f480e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"551f332aaba6371d3028e361a300078a7ca5501a","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                                               consts.Service.CINDER])"},{"line_number":559,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":560,"context_line":"@scenario.configure("},{"line_number":561,"context_line":"    context\u003d{\"cleanup\": [\"cinder\", \"nova\"]},"},{"line_number":562,"context_line":"    name\u003d\"NovaServers.boot_server_attach_volume_and_update_attachment\","},{"line_number":563,"context_line":"    platform\u003d\"openstack\")"},{"line_number":564,"context_line":"class BootServerAttachVolumeAndUpdateAttachment(utils.NovaScenario,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_753c8b92","line":561,"updated":"2017-10-09 20:29:41.000000000","message":"context\u003d{\"clenaup@openstack\":  [\"cinder\", \"nova\"]}","commit_id":"e40c87916399c2ffd50bde0db6fd3902416f480e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"551f332aaba6371d3028e361a300078a7ca5501a","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        the scenario first create a VM and two volume, one is used to attach,"},{"line_number":574,"context_line":"        the other is used to update server\u0027s attachment. Finally detach the"},{"line_number":575,"context_line":"        volume and delete volume and VM."},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        Measure the \"nova volume-update\" command performance."},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_154b172b","line":575,"updated":"2017-10-09 20:29:41.000000000","message":"volume -\u003e volumes (there are 2 volumes and both are deleted)","commit_id":"e40c87916399c2ffd50bde0db6fd3902416f480e"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c4e9cf83d2437c13dbac29b0e38dde4e7ff9dbca","unresolved":false,"context_lines":[{"line_number":704,"context_line":"    def _update_attachment(self, server, attachment, new_volume):"},{"line_number":705,"context_line":"        \"\"\"Update the volume identified by the attachment ID."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_9f18d5d3","line":707,"range":{"start_line":707,"start_character":15,"end_line":707,"end_character":24},"updated":"2017-07-29 08:05:24.000000000","message":"pls update this arg.","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"57eb92a928586c1ec285088550ef2fd42c4392ce","unresolved":false,"context_lines":[{"line_number":704,"context_line":"    def _update_attachment(self, server, attachment, new_volume):"},{"line_number":705,"context_line":"        \"\"\"Update the volume identified by the attachment ID."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_59865c15","line":707,"range":{"start_line":707,"start_character":15,"end_line":707,"end_character":24},"in_reply_to":"df3967d1_9f18d5d3","updated":"2017-08-04 10:40:29.000000000","message":"Done","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c4e9cf83d2437c13dbac29b0e38dde4e7ff9dbca","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        \"\"\"Update the volume identified by the attachment ID."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"},{"line_number":711,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_7f0d318f","line":708,"range":{"start_line":708,"start_character":15,"end_line":708,"end_character":28},"updated":"2017-07-29 08:05:24.000000000","message":"dittio","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"57eb92a928586c1ec285088550ef2fd42c4392ce","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        \"\"\"Update the volume identified by the attachment ID."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"},{"line_number":711,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_397f1816","line":708,"range":{"start_line":708,"start_character":15,"end_line":708,"end_character":28},"in_reply_to":"df3967d1_7f0d318f","updated":"2017-08-04 10:40:29.000000000","message":"Done","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c4e9cf83d2437c13dbac29b0e38dde4e7ff9dbca","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"},{"line_number":711,"context_line":"        \"\"\""},{"line_number":712,"context_line":"        server_id \u003d server.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_3f27a915","line":709,"range":{"start_line":709,"start_character":15,"end_line":709,"end_character":28},"updated":"2017-07-29 08:05:24.000000000","message":"dittio","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"57eb92a928586c1ec285088550ef2fd42c4392ce","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        :param server_id: The ID of the server"},{"line_number":708,"context_line":"        :param attachment_id: The ID of the attachment"},{"line_number":709,"context_line":"        :param new_volume_id: The ID of the new volume to attach"},{"line_number":710,"context_line":"        :rtype: :class:`Volume`"},{"line_number":711,"context_line":"        \"\"\""},{"line_number":712,"context_line":"        server_id \u003d server.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"df3967d1_197c541d","line":709,"range":{"start_line":709,"start_character":15,"end_line":709,"end_character":28},"in_reply_to":"df3967d1_3f27a915","updated":"2017-08-04 10:40:29.000000000","message":"Done","commit_id":"6ea7fe0fe6d3360d0109fc4e0569dab3819fd209"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3f6d2a0496de2692ed96c7543c6d3b3303b25a49","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        attachment_id \u003d attachment.id"},{"line_number":714,"context_line":"        new_volume_id \u003d new_volume.id"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        new_attachment \u003d (self.admin_clients(\"nova\")"},{"line_number":717,"context_line":"                          .volumes.update_server_volume("},{"line_number":718,"context_line":"                              server_id, attachment_id,"},{"line_number":719,"context_line":"                              new_volume_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_4b73cfb2","line":716,"range":{"start_line":716,"start_character":25,"end_line":716,"end_character":52},"updated":"2017-09-01 11:41:35.000000000","message":"Does this action require admin client?","commit_id":"41cbdac5730e7792df68826dce7053c81c4c6464"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"35de5731d411d4b5e99ee44eaf1939ff390e70f5","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        attachment_id \u003d attachment.id"},{"line_number":714,"context_line":"        new_volume_id \u003d new_volume.id"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        new_attachment \u003d (self.admin_clients(\"nova\")"},{"line_number":717,"context_line":"                          .volumes.update_server_volume("},{"line_number":718,"context_line":"                              server_id, attachment_id,"},{"line_number":719,"context_line":"                              new_volume_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f2577a7_a0f76ed3","line":716,"range":{"start_line":716,"start_character":25,"end_line":716,"end_character":52},"in_reply_to":"7f287b81_4b73cfb2","updated":"2017-09-15 03:10:29.000000000","message":"it is my fault, it doesn\u0027t require admin client.","commit_id":"41cbdac5730e7792df68826dce7053c81c4c6464"}]}