)]}'
{"rally/api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6c64c016548db1dbefb0179c96a6cc2753caca1a","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"class _Verifier(object):"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    READY_TO_USE_STATES \u003d (consts.VerifierStatus.INSTALLED,)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    @classmethod"},{"line_number":396,"context_line":"    def list_plugins(cls, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_5252df67","line":393,"range":{"start_line":393,"start_character":3,"end_line":393,"end_character":60},"updated":"2017-01-18 16:46:46.000000000","message":"not sure that we need separate variable for storing one status:)","commit_id":"b662a82dac40193d691b7b37ef932438b1b90d61"}],"rally/plugins/openstack/verification/tempest/manager.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0133259c958e3c659db5ed66f9e2d9c1299cf4a2","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def is_configured(self):"},{"line_number":70,"context_line":"        \"\"\"Check whether Tempest is configured or not.\"\"\""},{"line_number":71,"context_line":"        return True if os.path.exists(self.configfile) else False"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":74,"context_line":"        \"\"\"Extend Tempest configuration with extra options.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_fe8c5f37","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":65},"updated":"2017-01-19 10:06:11.000000000","message":"simpler:\n\n  return os.path.exists(self.configfile)","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"c2de5a13727483ee4671740213c562318c6de99f","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def is_configured(self):"},{"line_number":70,"context_line":"        \"\"\"Check whether Tempest is configured or not.\"\"\""},{"line_number":71,"context_line":"        return True if os.path.exists(self.configfile) else False"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def extend_configuration(self, extra_options):"},{"line_number":74,"context_line":"        \"\"\"Extend Tempest configuration with extra options.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e4dcce1a","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":65},"in_reply_to":"5a3905b3_fe8c5f37","updated":"2017-01-19 10:33:38.000000000","message":"Done","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"}],"rally/verification/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6c64c016548db1dbefb0179c96a6cc2753caca1a","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            raise NotImplementedError("},{"line_number":239,"context_line":"                _LE(\"\u0027%s\u0027 verifiers don\u0027t support configuration at all.\") %"},{"line_number":240,"context_line":"                self.get_name())"},{"line_number":241,"context_line":"        LOG.info(_LI(\"Nothing to do. \u0027%s\u0027 verifiers don\u0027t support \""},{"line_number":242,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def is_configured(self):"},{"line_number":245,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_8545df43","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":57},"updated":"2017-01-18 16:46:46.000000000","message":"previously, method `config` was called in all cases while executing `rally verify start` with verifier in \"INSTALLED\" status. Now we have an ability to check real requirement to call \"configure\" method (if is_configured returned False) and we should raise NotImplementedError for all calls of configure method.","commit_id":"b662a82dac40193d691b7b37ef932438b1b90d61"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6c64c016548db1dbefb0179c96a6cc2753caca1a","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        LOG.info(_LI(\"Nothing to do. \u0027%s\u0027 verifiers don\u0027t support \""},{"line_number":242,"context_line":"                     \"configuration.\") % self.get_name())"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def is_configured(self):"},{"line_number":245,"context_line":"        return True"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def override_configuration(self, new_content):"},{"line_number":248,"context_line":"        \"\"\"Override verifier configuration.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b29783ea","line":245,"range":{"start_line":244,"start_character":4,"end_line":245,"end_character":19},"updated":"2017-01-18 16:46:46.000000000","message":"Please add a docsting. This class will be used as spec in docs.","commit_id":"b662a82dac40193d691b7b37ef932438b1b90d61"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2bafb62ccd80d3d01736407476851a32581a4491","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        source \u003d self.verifier.source or self._meta_get(\"default_repo\")"},{"line_number":145,"context_line":"        if not URL_RE.match(source) and not os.path.exists(source):"},{"line_number":146,"context_line":"            raise exceptions.RallyException("},{"line_number":147,"context_line":"                \"Source path \u0027%s\u0027 doesn\u0027t exist.\" % source)"},{"line_number":148,"context_line":"        if logging.is_debug():"},{"line_number":149,"context_line":"            LOG.debug(\"Cloning verifier repo from %s into %s.\", source,"},{"line_number":150,"context_line":"                      self.repo_dir)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a3905b3_b29d555b","line":147,"range":{"start_line":147,"start_character":34,"end_line":147,"end_character":47},"updated":"2017-01-20 16:03:26.000000000","message":"it is better to use `is not valid`","commit_id":"0c9cd2ca86907be6bf4c3b0ae50c083fe282479b"}],"tests/unit/plugins/openstack/verification/tempest/test_manager.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0133259c958e3c659db5ed66f9e2d9c1299cf4a2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            tempest.verifier.deployment)"},{"line_number":63,"context_line":"        cm.create.assert_called_once_with(tempest.configfile, extra_options)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\"%s.config.os.path.exists\" % PATH)"},{"line_number":66,"context_line":"    def test_is_configured(self, mock_exists):"},{"line_number":67,"context_line":"        tempest \u003d manager.TempestManager(mock.MagicMock(uuid\u003d\"uuuiiiddd\"))"},{"line_number":68,"context_line":"        self.assertTrue(tempest.is_configured())"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_6120d04a","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":49},"updated":"2017-01-19 10:06:11.000000000","message":"just \"os.path.exists\" should work too.","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a31565d467406f3ce4194d3b4240b0cfe5e04e57","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            tempest.verifier.deployment)"},{"line_number":63,"context_line":"        cm.create.assert_called_once_with(tempest.configfile, extra_options)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\"%s.config.os.path.exists\" % PATH)"},{"line_number":66,"context_line":"    def test_is_configured(self, mock_exists):"},{"line_number":67,"context_line":"        tempest \u003d manager.TempestManager(mock.MagicMock(uuid\u003d\"uuuiiiddd\"))"},{"line_number":68,"context_line":"        self.assertTrue(tempest.is_configured())"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_04947a35","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":49},"in_reply_to":"5a3905b3_6120d04a","updated":"2017-01-19 10:33:14.000000000","message":"Yes, it should work, but I would like to patch os.path.exists only in rally/plugins/openstack/verification/tempest/manager/config.py file, not globally.","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"}],"tests/unit/test_api.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0133259c958e3c659db5ed66f9e2d9c1299cf4a2","unresolved":false,"context_lines":[{"line_number":920,"context_line":"                self.assertIn(\"because verifier is in \u0027%s\u0027 status\" % status,"},{"line_number":921,"context_line":"                              \"%s\" % e)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    @mock.patch(\"rally.plugins.openstack.verification.tempest.manager.\""},{"line_number":924,"context_line":"                \"os.path.exists\")"},{"line_number":925,"context_line":"    @mock.patch(\"rally.api._Verifier.get\")"},{"line_number":926,"context_line":"    def test_configure_when_it_is_already_configured(self, mock___verifier_get,"},{"line_number":927,"context_line":"                                                     mock_exists):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e12be031","line":924,"range":{"start_line":923,"start_character":16,"end_line":924,"end_character":32},"updated":"2017-01-19 10:06:11.000000000","message":"ditto","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a31565d467406f3ce4194d3b4240b0cfe5e04e57","unresolved":false,"context_lines":[{"line_number":920,"context_line":"                self.assertIn(\"because verifier is in \u0027%s\u0027 status\" % status,"},{"line_number":921,"context_line":"                              \"%s\" % e)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    @mock.patch(\"rally.plugins.openstack.verification.tempest.manager.\""},{"line_number":924,"context_line":"                \"os.path.exists\")"},{"line_number":925,"context_line":"    @mock.patch(\"rally.api._Verifier.get\")"},{"line_number":926,"context_line":"    def test_configure_when_it_is_already_configured(self, mock___verifier_get,"},{"line_number":927,"context_line":"                                                     mock_exists):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_64a37e9f","line":924,"range":{"start_line":923,"start_character":16,"end_line":924,"end_character":32},"in_reply_to":"5a3905b3_e12be031","updated":"2017-01-19 10:33:14.000000000","message":"ditto","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"}],"tests/unit/verification/test_manager.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"0133259c958e3c659db5ed66f9e2d9c1299cf4a2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            mock_context_manager_validate.assert_called_once_with("},{"line_number":73,"context_line":"                mock__meta_get.return_value)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @mock.patch(\"rally.verification.manager.os.path.exists\","},{"line_number":76,"context_line":"                side_effect\u003d[False, True])"},{"line_number":77,"context_line":"    def test__clone(self, mock_exists):"},{"line_number":78,"context_line":"        verifier \u003d mock.Mock(source\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_c169848d","line":75,"range":{"start_line":75,"start_character":17,"end_line":75,"end_character":58},"updated":"2017-01-19 10:06:11.000000000","message":"ditto","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"a31565d467406f3ce4194d3b4240b0cfe5e04e57","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            mock_context_manager_validate.assert_called_once_with("},{"line_number":73,"context_line":"                mock__meta_get.return_value)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @mock.patch(\"rally.verification.manager.os.path.exists\","},{"line_number":76,"context_line":"                side_effect\u003d[False, True])"},{"line_number":77,"context_line":"    def test__clone(self, mock_exists):"},{"line_number":78,"context_line":"        verifier \u003d mock.Mock(source\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e4b5aed0","line":75,"range":{"start_line":75,"start_character":17,"end_line":75,"end_character":58},"in_reply_to":"5a3905b3_c169848d","updated":"2017-01-19 10:33:14.000000000","message":"ditto.","commit_id":"2f80680115557626db90aa93a0f00b989e4aa52b"}]}
