)]}'
{"rally/plugins/common/exporter/file_system.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7252a5dff441fb02b8884dff0b606d4a59366333","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.type \u003d\u003d \"json\":"},{"line_number":78,"context_line":"            if task_results:"},{"line_number":79,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dFalse, indent\u003d4,"},{"line_number":80,"context_line":"                                 separators\u003d(\",\", \":\"))"},{"line_number":81,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                msg \u003d (\"Task %s results would be available when it will \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_75671ce9","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":53},"updated":"2017-01-23 08:14:42.000000000","message":"s/\":\"/\": \"/","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"d860aa5b700239b793f027bf862f0d6ddade47a7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.type \u003d\u003d \"json\":"},{"line_number":78,"context_line":"            if task_results:"},{"line_number":79,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dFalse, indent\u003d4,"},{"line_number":80,"context_line":"                                 separators\u003d(\",\", \":\"))"},{"line_number":81,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                msg \u003d (\"Task %s results would be available when it will \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_30a842db","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":53},"in_reply_to":"5a3905b3_557940c7","updated":"2017-01-23 08:36:42.000000000","message":"makes sense, let me update in next push. thanks for your review!","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"8f2c8afdcd6b4e9e5bcbbbe1269d2356f8bea243","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.type \u003d\u003d \"json\":"},{"line_number":78,"context_line":"            if task_results:"},{"line_number":79,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dFalse, indent\u003d4,"},{"line_number":80,"context_line":"                                 separators\u003d(\",\", \":\"))"},{"line_number":81,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                msg \u003d (\"Task %s results would be available when it will \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_d5eff084","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":53},"in_reply_to":"5a3905b3_75671ce9","updated":"2017-01-23 08:28:17.000000000","message":"both \":\" and \": \" work for me:\n\n\u003e\u003e\u003e import json\n\n\u003e\u003e\u003e json.dumps(dict(a\u003d1,b\u003d2,c\u003d3), indent\u003d4)\n\u0027{\\n    \"a\": 1, \\n    \"c\": 3, \\n    \"b\": 2\\n}\u0027\n\n\u003e\u003e\u003e json.dumps(dict(a\u003d1,b\u003d2,c\u003d3), indent\u003d4, separators\u003d(\",\",\":\"))\n\u0027{\\n    \"a\":1,\\n    \"c\":3,\\n    \"b\":2\\n}\u0027\n\n\u003e\u003e\u003e json.dumps(dict(a\u003d1,b\u003d2,c\u003d3), indent\u003d4, separators\u003d(\",\",\": \"))\n\u0027{\\n    \"a\": 1,\\n    \"c\": 3,\\n    \"b\": 2\\n}\u0027\n\n\u003e\u003e\u003e sys.version\n\u00272.7.6 (default, Oct 26 2016, 20:30:19) \\n[GCC 4.8.4]\u0027","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"be6e22cb964f4a1d0a732d748bc96627e18b530c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if self.type \u003d\u003d \"json\":"},{"line_number":78,"context_line":"            if task_results:"},{"line_number":79,"context_line":"                res \u003d json.dumps(task_results, sort_keys\u003dFalse, indent\u003d4,"},{"line_number":80,"context_line":"                                 separators\u003d(\",\", \":\"))"},{"line_number":81,"context_line":"                LOG.debug(\"Got the task %s results.\" % uuid)"},{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                msg \u003d (\"Task %s results would be available when it will \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_557940c7","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":53},"in_reply_to":"5a3905b3_d5eff084","updated":"2017-01-23 08:31:34.000000000","message":"Yes, both work, but you are just removing the trailing space at the end of line, no need to change \": \" to \":\"","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"}],"rally/task/engine.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7252a5dff441fb02b8884dff0b606d4a59366333","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            self._validate_config_semantic(self.config)"},{"line_number":353,"context_line":"        except Exception as e:"},{"line_number":354,"context_line":"            exception_info \u003d json.dumps(traceback.format_exc(), indent\u003d2,"},{"line_number":355,"context_line":"                                        separators\u003d(\",\", \":\"))"},{"line_number":356,"context_line":"            self.task.set_failed(type(e).__name__,"},{"line_number":357,"context_line":"                                 str(e), exception_info)"},{"line_number":358,"context_line":"            LOG.debug(exception_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f5d94c58","line":355,"range":{"start_line":355,"start_character":40,"end_line":355,"end_character":62},"updated":"2017-01-23 08:14:42.000000000","message":"this doesn\u0027t write to file, right?, so not need to change here","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"46fd5aff4afe7b705fb2e37c60864db06fd2c0ee","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            self._validate_config_semantic(self.config)"},{"line_number":353,"context_line":"        except Exception as e:"},{"line_number":354,"context_line":"            exception_info \u003d json.dumps(traceback.format_exc(), indent\u003d2,"},{"line_number":355,"context_line":"                                        separators\u003d(\",\", \":\"))"},{"line_number":356,"context_line":"            self.task.set_failed(type(e).__name__,"},{"line_number":357,"context_line":"                                 str(e), exception_info)"},{"line_number":358,"context_line":"            LOG.debug(exception_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_552860e2","line":355,"range":{"start_line":355,"start_character":40,"end_line":355,"end_character":62},"in_reply_to":"5a3905b3_55d30004","updated":"2017-01-23 08:24:34.000000000","message":"Yes, didn\u0027t notice the LOG.debug below","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"},{"author":{"_account_id":24441,"name":"Cuong Nguyen","email":"cuongnv@vn.fujitsu.com","username":"cuongnv"},"change_message_id":"8b493cd3c8bed0013b333b48d44d5a964e25e0cb","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            self._validate_config_semantic(self.config)"},{"line_number":353,"context_line":"        except Exception as e:"},{"line_number":354,"context_line":"            exception_info \u003d json.dumps(traceback.format_exc(), indent\u003d2,"},{"line_number":355,"context_line":"                                        separators\u003d(\",\", \":\"))"},{"line_number":356,"context_line":"            self.task.set_failed(type(e).__name__,"},{"line_number":357,"context_line":"                                 str(e), exception_info)"},{"line_number":358,"context_line":"            LOG.debug(exception_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_55d30004","line":355,"range":{"start_line":355,"start_character":40,"end_line":355,"end_character":62},"in_reply_to":"5a3905b3_f5d94c58","updated":"2017-01-23 08:21:32.000000000","message":"doesn\u0027t it write that exception to log file?","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"}],"tests/unit/plugins/common/exporter/test_file_system.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7252a5dff441fb02b8884dff0b606d4a59366333","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            }"},{"line_number":70,"context_line":"        ]"},{"line_number":71,"context_line":"        mock_dumps.assert_called_once_with(expected_dict, sort_keys\u003dFalse,"},{"line_number":72,"context_line":"                                           indent\u003d4, separators\u003d(\",\", \":\"))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @mock.patch(\"rally.api.Task.get\")"},{"line_number":75,"context_line":"    def test_file_exporter_export_running_task(self, mock_task_get):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f5c06c52","line":72,"range":{"start_line":72,"start_character":70,"end_line":72,"end_character":73},"updated":"2017-01-23 08:14:42.000000000","message":"s/\":\"/\": \"/","commit_id":"8af739d434b825eccd8aacb1a511888fe05f59d6"}]}
