)]}'
{"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"089245465d6e2b76c419f9b2b7f6830629e92332","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        :return:"},{"line_number":500,"context_line":"        \"\"\""},{"line_number":501,"context_line":"        clients \u003d self.admin_clients(\"cinder\")"},{"line_number":502,"context_line":"        return clients.volume_type_access.add_project_access("},{"line_number":503,"context_line":"            volume_type, project)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    @atomic.action_timer(\"cinder.list_type_access\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_0c11015e","line":502,"updated":"2017-02-27 23:22:27.000000000","message":"you should add this resource to cleanup manager and to the https://github.com/openstack/rally/blob/master/tests/ci/osresources.py","commit_id":"669135b9d0ca3d982b0ab919dd0780f1c8273815"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"d43c04a723a4be39651a45318427602e8662cfdc","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        :return:"},{"line_number":500,"context_line":"        \"\"\""},{"line_number":501,"context_line":"        clients \u003d self.admin_clients(\"cinder\")"},{"line_number":502,"context_line":"        return clients.volume_type_access.add_project_access("},{"line_number":503,"context_line":"            volume_type, project)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    @atomic.action_timer(\"cinder.list_type_access\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_cdf51d84","line":502,"in_reply_to":"da36d5c6_0c11015e","updated":"2017-03-01 06:42:04.000000000","message":"Actually，there is no need to add this to cleanup manager, type access is related to certain volume type, when volume type is deleted, type access will disappears automatically。 Also type access is not a independent resource, does it need to be added to ci/osresources.py?","commit_id":"669135b9d0ca3d982b0ab919dd0780f1c8273815"}],"rally/plugins/openstack/scenarios/cinder/volume_types.py":[{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"d1e9d854f4c129f4c627b14d4389ef72c9a23a0b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        volume_type \u003d self._create_volume_type(**kwargs)"},{"line_number":101,"context_line":"        self._add_type_access(volume_type, self.context[\"tenant\"][\"id\"])"},{"line_number":102,"context_line":"        self._list_type_access(volume_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_74494e8e","line":102,"updated":"2017-02-17 08:02:08.000000000","message":"Let\u0027s add check what created type access is present in the list","commit_id":"fa45bd6e4a1832d8dcd1cb118623093ae9418709"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"4f2f6c61cfa8f905ce6885772c7a5b3108424a28","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        \"\"\""},{"line_number":100,"context_line":"        volume_type \u003d self._create_volume_type(**kwargs)"},{"line_number":101,"context_line":"        self._add_type_access(volume_type, self.context[\"tenant\"][\"id\"])"},{"line_number":102,"context_line":"        self._list_type_access(volume_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_01f3639f","line":102,"in_reply_to":"fa31d9ce_74494e8e","updated":"2017-02-21 08:08:29.000000000","message":"Hi, \nThe _add_type_access function\u0027s return value is \u003cResponse [202]\u003e, None, but _list_type_access function\u0027s return value is \u003cVolumeTypeAccess: c3d632b67be946e8a5ae7305ec7c4c51\u003e. How can I\ncheck created type access is present in the list ?","commit_id":"fa45bd6e4a1832d8dcd1cb118623093ae9418709"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"089245465d6e2b76c419f9b2b7f6830629e92332","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        :param kwargs: Optional parameters used during volume"},{"line_number":115,"context_line":"                       type creation."},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":"        volume_type \u003d self._create_volume_type(**kwargs)"},{"line_number":118,"context_line":"        self._add_type_access(volume_type, self.context[\"tenant\"][\"id\"])"},{"line_number":119,"context_line":"        self._list_type_access(volume_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_ecbf4d5e","line":117,"updated":"2017-02-27 23:22:27.000000000","message":"you should create it via volume type context https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cinder/volume_types.py . Because creation of the volume_type is not the object here due to the name of scenario. Thus its slowdown actual scenario and you should check whether volume type created or not.","commit_id":"669135b9d0ca3d982b0ab919dd0780f1c8273815"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"d43c04a723a4be39651a45318427602e8662cfdc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        :param kwargs: Optional parameters used during volume"},{"line_number":115,"context_line":"                       type creation."},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":"        volume_type \u003d self._create_volume_type(**kwargs)"},{"line_number":118,"context_line":"        self._add_type_access(volume_type, self.context[\"tenant\"][\"id\"])"},{"line_number":119,"context_line":"        self._list_type_access(volume_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_6d8351cd","line":117,"in_reply_to":"da36d5c6_ecbf4d5e","updated":"2017-03-01 06:42:04.000000000","message":"Hi Roman, I have tried to use volume type created by context.But the volume type used here is a none public volume type. Only private volume type can be added type access. So I changed my scenario name. Or is there any ways to create a \"--is-public false\" volume type in context?","commit_id":"669135b9d0ca3d982b0ab919dd0780f1c8273815"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"7cc33ac7e6cc17467de844bacc8df792bb762276","unresolved":false,"context_lines":[{"line_number":104,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":105,"context_line":"                    name\u003d\"CinderVolumeTypes.create_volume_type_\""},{"line_number":106,"context_line":"                         \"add_and_list_type_access\")"},{"line_number":107,"context_line":"class CreateVolumeTypeAddAndListTypeAccess(cinder_utils.CinderScenario):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def run(self, kwargs\u003dNone):"},{"line_number":110,"context_line":"        \"\"\"Add and list volume type access for the given project."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_bed1edfd","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":28},"updated":"2017-03-01 08:25:41.000000000","message":"AndAdd?","commit_id":"321a491af1d0bf412435dba65aa1d81cd98ece1a"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"33109954f1e36cb944bd4ab6d34b2c76cd88aaac","unresolved":false,"context_lines":[{"line_number":104,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":105,"context_line":"                    name\u003d\"CinderVolumeTypes.create_volume_type_\""},{"line_number":106,"context_line":"                         \"add_and_list_type_access\")"},{"line_number":107,"context_line":"class CreateVolumeTypeAddAndListTypeAccess(cinder_utils.CinderScenario):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def run(self, kwargs\u003dNone):"},{"line_number":110,"context_line":"        \"\"\"Add and list volume type access for the given project."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_6ba41657","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":28},"in_reply_to":"ba2be162_bed1edfd","updated":"2017-03-01 09:13:09.000000000","message":"Three functions have been called here:\n1:create volume type\n2:add type access\n3:list type access\nI think the right  grammar is 1,2and3 not 1and2,3","commit_id":"321a491af1d0bf412435dba65aa1d81cd98ece1a"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"093200bb2422a14e888b379a32518ac5066f880e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                                                 specs\u003dupdate_specs)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":367,"context_line":"@validation.required_api_versions(component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":368,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":369,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_5533cd14","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":41},"updated":"2017-05-23 02:23:01.000000000","message":"It looks redundant and the new validation ref: https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py#L25-L26","commit_id":"78aad7a6b2d25d60959f8725e0de276252bcc1be"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b2e286d17202a8d02909d52ccd4c66d2cc4593d3","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                 specs\u003dupdate_specs)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"@validation.required_api_versions(component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":372,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":373,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":374,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_f5e26fa0","line":371,"range":{"start_line":371,"start_character":0,"end_line":371,"end_character":69},"updated":"2017-05-25 22:11:24.000000000","message":"we merged new validator, so please use it.\n\nhttps://review.openstack.org/#/c/462592/","commit_id":"79c912bcacaab163de8cb9c08ec3ee33a6247a97"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"ce73b0627adcb7124ac87b2ae109d5dc0c59007b","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                                                 specs\u003dupdate_specs)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":373,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":374,"context_line":"@validators.RequiredAPIVersionsValidator(component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":375,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_3cdb2b7e","line":372,"updated":"2017-05-26 03:13:43.000000000","message":"and same here","commit_id":"b66b5888ba55736cfa2d1f6113836644a9a01c8b"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"7e8684699e6758d3d4f3d11a1bf1e1c145915f2a","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":373,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":374,"context_line":"@validators.RequiredAPIVersionsValidator(component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":375,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":376,"context_line":"                    name\u003d\"CinderVolumeTypes.create_volume_type_\""},{"line_number":377,"context_line":"                         \"add_and_list_type_access\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_71a2ec4d","line":374,"updated":"2017-05-26 02:59:03.000000000","message":"It should be like: @validators.add(\"required_api_versions\", component\u003dxxx, versions\u003dxxxx)","commit_id":"b66b5888ba55736cfa2d1f6113836644a9a01c8b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7db8dc3714ff591e6f5cb9e84a9e8a90aa42a65e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.plugins.openstack import scenario"},{"line_number":18,"context_line":"from rally.plugins.openstack.scenarios.cinder import utils as cinder_utils"},{"line_number":19,"context_line":"from rally.plugins.openstack.services.storage import cinder_v2"},{"line_number":20,"context_line":"from rally.plugins.openstack import validators"},{"line_number":21,"context_line":"from rally.task import validation"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_a77a8885","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":46},"updated":"2017-05-29 07:34:47.000000000","message":"it is redundant","commit_id":"10d4a2eb4f9d5d756f4c01533ce2473322808655"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7db8dc3714ff591e6f5cb9e84a9e8a90aa42a65e","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":373,"context_line":"@validators.add(\"required_api_versions\", component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":374,"context_line":"@validators.add(\"required_services\", services\u003dconsts.Service.CINDER)"},{"line_number":375,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":376,"context_line":"                    name\u003d\"CinderVolumeTypes.create_volume_type_\""}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_6774709a","line":373,"range":{"start_line":373,"start_character":1,"end_line":373,"end_character":11},"updated":"2017-05-29 07:34:47.000000000","message":"it should be validation","commit_id":"10d4a2eb4f9d5d756f4c01533ce2473322808655"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7db8dc3714ff591e6f5cb9e84a9e8a90aa42a65e","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":373,"context_line":"@validators.add(\"required_api_versions\", component\u003d\"cinder\", versions\u003d[\"2\"])"},{"line_number":374,"context_line":"@validators.add(\"required_services\", services\u003dconsts.Service.CINDER)"},{"line_number":375,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"},{"line_number":376,"context_line":"                    name\u003d\"CinderVolumeTypes.create_volume_type_\""},{"line_number":377,"context_line":"                         \"add_and_list_type_access\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"df140735_47696cbc","line":374,"range":{"start_line":374,"start_character":1,"end_line":374,"end_character":11},"updated":"2017-05-29 07:34:47.000000000","message":"same here","commit_id":"10d4a2eb4f9d5d756f4c01533ce2473322808655"}]}