)]}'
{"rally/task/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"854bffa59ebacd41b7a8a744630b32cef5c1a24a","unresolved":false,"context_lines":[{"line_number":537,"context_line":"    :param *context_names: list of strings and tuples with context names that"},{"line_number":538,"context_line":"        should be specified. Tuple represent \u0027at least one of the\u0027."},{"line_number":539,"context_line":"    \"\"\""},{"line_number":540,"context_line":"    missing_contexts \u003d set(context_names)"},{"line_number":541,"context_line":"    context_set \u003d set(config.get(\"context\", {}))"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    for ctx in context_names:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_b1bd0b6a","line":540,"range":{"start_line":540,"start_character":4,"end_line":540,"end_character":41},"updated":"2017-01-30 15:59:36.000000000","message":"not sure that using set in the new revision of that validator is the best option :)\n\nWhat about using empty list and extend it at L543-549 loop?","commit_id":"a7bd58f7cb1203932b36c2b97889b42006336476"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"854bffa59ebacd41b7a8a744630b32cef5c1a24a","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        for el in missing_contexts:"},{"line_number":557,"context_line":"            if isinstance(el, tuple):"},{"line_number":558,"context_line":"                msg_str +\u003d \" or \".join(el)"},{"line_number":559,"context_line":"                msg_str +\u003d \", \""},{"line_number":560,"context_line":"            else:"},{"line_number":561,"context_line":"                msg_str +\u003d \", {}\".format(el)"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_b1c8ab23","line":559,"range":{"start_line":558,"start_character":16,"end_line":559,"end_character":31},"updated":"2017-01-30 15:59:36.000000000","message":"let\u0027s wrap or or_cotnexts with quotas to split the group of contexts with other contexts","commit_id":"a7bd58f7cb1203932b36c2b97889b42006336476"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b55d1e02a2184c8af018a4cc1676dbe53c00636d","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        message \u003d _(\"The following contexts are required but missing from \""},{"line_number":554,"context_line":"                    \"the benchmark configuration file: %s\")"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        for el in missing_contexts:"},{"line_number":557,"context_line":"            if isinstance(el, tuple):"},{"line_number":558,"context_line":"                msg_str +\u003d \"\u0027{}\u0027,\".format(\" or \".join(el))"},{"line_number":559,"context_line":"            else:"},{"line_number":560,"context_line":"                msg_str +\u003d \", {}\".format(el)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        return ValidationResult(False, message % msg_str)"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d21e16ba","line":560,"range":{"start_line":556,"start_character":8,"end_line":560,"end_character":44},"updated":"2017-01-30 16:42:12.000000000","message":"string at L558 ends with a comma, string at L550 stars with a comma. It can lead to duplication of commas in case of `missing_contexts \u003d [(\"foo\", \"bar\"), \"xxx\"]`\n\nIt looks like we simplify this code, bug moving L558(without a comma) to L546, so we will be able to replace L556-560 by simple \n\n    \", \".join(missing_contexts)","commit_id":"5026869d2177399bca865b9cbb9e16798e2c0664"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b0d52141c57206a204c005a71b6f4e6aab45d56a","unresolved":false,"context_lines":[{"line_number":553,"context_line":"        message \u003d _(\"The following contexts are required but missing from \""},{"line_number":554,"context_line":"                    \"the benchmark configuration file: %s\")"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        for el in missing_contexts:"},{"line_number":557,"context_line":"            if isinstance(el, tuple):"},{"line_number":558,"context_line":"                msg_str +\u003d \"\u0027{}\u0027,\".format(\" or \".join(el))"},{"line_number":559,"context_line":"            else:"},{"line_number":560,"context_line":"                msg_str +\u003d \", {}\".format(el)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        return ValidationResult(False, message % msg_str)"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_92564e5a","line":560,"range":{"start_line":556,"start_character":8,"end_line":560,"end_character":44},"in_reply_to":"3a461143_d21e16ba","updated":"2017-01-30 16:43:01.000000000","message":"\u003e It looks like we simplify this code, bug moving\n\n* It looks like we can simplify this code by moving","commit_id":"5026869d2177399bca865b9cbb9e16798e2c0664"}]}