)]}'
{"rally/plugins/openstack/scenarios/cinder/volume_backups.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9767c2b938f35e7054940a318a2bd5d72c5e5198","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\"Scenarios for Cinder Volume Backup.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class CinderBasic(scenario.OpenStackScenario):"},{"line_number":25,"context_line":"    def __init__(self, context\u003dNone, admin_clients\u003dNone, clients\u003dNone):"},{"line_number":26,"context_line":"        super(CinderBasic, self).__init__(context, admin_clients, clients)"},{"line_number":27,"context_line":"        if hasattr(self, \"_admin_clients\"):"},{"line_number":28,"context_line":"            self.admin_cinder \u003d block.BlockStorage("},{"line_number":29,"context_line":"                self._admin_clients, name_generator\u003dself.generate_random_name,"},{"line_number":30,"context_line":"                atomic_inst\u003dself.atomic_actions())"},{"line_number":31,"context_line":"        if hasattr(self, \"_clients\"):"},{"line_number":32,"context_line":"            self.cinder \u003d block.BlockStorage("},{"line_number":33,"context_line":"                self._clients, name_generator\u003dself.generate_random_name,"},{"line_number":34,"context_line":"                atomic_inst\u003dself.atomic_actions())"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@validation.number(\"size\", minval\u003d1, integer_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ffe62b97_1c54d4c9","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":50},"updated":"2017-03-24 12:26:37.000000000","message":"there is no need to create several base classes. It is code duplication. Let\u0027s leave one class somewhere (in utils or in modules with scenarios for volumes)","commit_id":"557f9fe0bf666297b276f3118725425354049277"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"90d33d8d53cbe5bb3b7227fff945f5dc4e626422","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if image:"},{"line_number":82,"context_line":"            kwargs[\"imageRef\"] \u003d image"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.cinder.create_volume(size, **kwargs)"},{"line_number":85,"context_line":"        self.cinder.list_volumes(detailed)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_298665b9","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":49},"updated":"2017-03-20 16:45:58.000000000","message":"as it was discussed in our channel, we should restrict configuring name of the volume outside the python-code.\nIt can be done by two ways:\n\n1) replace all kwargs by real arguments (can be done in separate patch)\n\n2) by executing `kwargs.pop(\"name\")` and `kwargs.pop(\"display_name\")`\n\nIt relates to all scenarios","commit_id":"08b168790e12c249e93e8b4ca20aa2e6d2bbbc34"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"9c45110f2e87616da078e24a138534d517861871","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if image:"},{"line_number":82,"context_line":"            kwargs[\"imageRef\"] \u003d image"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.cinder.create_volume(size, **kwargs)"},{"line_number":85,"context_line":"        self.cinder.list_volumes(detailed)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_d24891b5","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":49},"in_reply_to":"1a1ced50_298665b9","updated":"2017-03-23 09:11:56.000000000","message":"I think we can use validation.restricted_parameters. :)","commit_id":"08b168790e12c249e93e8b4ca20aa2e6d2bbbc34"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"90d33d8d53cbe5bb3b7227fff945f5dc4e626422","unresolved":false,"context_lines":[{"line_number":92,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\"]},"},{"line_number":93,"context_line":"                    name\u003d\"CinderVolumes.create_and_get_volume\")"},{"line_number":94,"context_line":"class CreateAndGetVolume(CinderBasic,"},{"line_number":95,"context_line":"                         nova_utils.NovaScenario,"},{"line_number":96,"context_line":"                         glance_utils.GlanceScenario):"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def run(self, size, image\u003dNone, **kwargs):"},{"line_number":99,"context_line":"        \"\"\"Create a volume and get the volume."}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c945d170","line":96,"range":{"start_line":95,"start_character":25,"end_line":96,"end_character":52},"updated":"2017-03-20 16:45:58.000000000","message":"this scenario doesn\u0027t need all these utils. (same for most scenarios).\n\nCan be fixed in further patches, but it would be nice to fix it as soon as possible since discovery of glance service can make redundant call to glance api","commit_id":"08b168790e12c249e93e8b4ca20aa2e6d2bbbc34"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9767c2b938f35e7054940a318a2bd5d72c5e5198","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"        \"\"\""},{"line_number":192,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"},{"line_number":193,"context_line":"        update_volume_kwargs \u003d update_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ffe62b97_dc19cc88","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":70},"updated":"2017-03-24 12:26:37.000000000","message":"Let\u0027s add feature \"update_name\". if it is present in update_volume_kwargs, generate_random_name will be used for new name of volume.\n\nIt would be nice to document that feature here.","commit_id":"557f9fe0bf666297b276f3118725425354049277"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9767c2b938f35e7054940a318a2bd5d72c5e5198","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        if size is None:"},{"line_number":470,"context_line":"            size \u003d {\"min\": 1, \"max\": 5}"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        if isinstance(volume_type, bool) and volume_type:"},{"line_number":473,"context_line":"            LOG.warning(\"Selecting a random volume type is deprecated\""},{"line_number":474,"context_line":"                        \"as of Rally 0.7.0\")"},{"line_number":475,"context_line":"            volume_types \u003d [None]"},{"line_number":476,"context_line":"            volume_types_list \u003d self.cinder.list_types()"},{"line_number":477,"context_line":"            for s in volume_types_list:"},{"line_number":478,"context_line":"                volume_types.append(s.name)"},{"line_number":479,"context_line":"            volume_type \u003d random.choice(volume_types)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        volume \u003d self.cinder.create_volume(size, volume_type\u003dvolume_type)"},{"line_number":482,"context_line":"        snapshot \u003d self.cinder.create_snapshot(volume.id, force\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ffe62b97_7c8760d9","line":479,"range":{"start_line":472,"start_character":8,"end_line":479,"end_character":53},"updated":"2017-03-24 12:26:37.000000000","message":"two releases are enough for deprecation period. we can remove that code now","commit_id":"557f9fe0bf666297b276f3118725425354049277"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b32eed9655962f9d342073ef400018781c0eeb7b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"               update_volume_kwargs[\"update_name\"]\u003dTrue, if updating the"},{"line_number":192,"context_line":"               name of volume."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffe62b97_7c2a7d90","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":55},"updated":"2017-03-27 10:44:08.000000000","message":"I did not find an implementation of that feature:)","commit_id":"5d67aa7659469fc80f5a803ca471c4d5c2c43f73"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"759ebc3f065744ee0d336a1b4fab36b7a7bebe88","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"               update_volume_kwargs[\"update_name\"]\u003dTrue, if updating the"},{"line_number":192,"context_line":"               name of volume."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffe62b97_86b6dc3d","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":55},"in_reply_to":"ffe62b97_06552cfa","updated":"2017-03-28 06:49:28.000000000","message":"\u003e Maybe we should remove restricted display_name in validation.\n\nno, setting display_name should be restricted outside rally.","commit_id":"5d67aa7659469fc80f5a803ca471c4d5c2c43f73"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6372d6f56749e2602bf124b543981feeab4b47b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"               update_volume_kwargs[\"update_name\"]\u003dTrue, if updating the"},{"line_number":192,"context_line":"               name of volume."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffe62b97_f3cc73bd","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":55},"in_reply_to":"ffe62b97_1fb363ec","updated":"2017-03-27 12:51:26.000000000","message":"It should have a simple implementation, like:\n\n    if update_volume_kwargs.pop(\"update_name\", False):\n        update_volume_kwargs[\"name\"] \u003d self.generate_random_name()\n\n     self.cinder.update_volume(volume, **update_volume_kwargs)","commit_id":"5d67aa7659469fc80f5a803ca471c4d5c2c43f73"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"0f835f20b59d8ffeded785a6a1caa01962558d08","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"               update_volume_kwargs[\"update_name\"]\u003dTrue, if updating the"},{"line_number":192,"context_line":"               name of volume."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffe62b97_1fb363ec","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":55},"in_reply_to":"ffe62b97_7c2a7d90","updated":"2017-03-27 10:52:20.000000000","message":"forgot to remove this line. :( here is not done, i do not known how is good to do this now. Working on other bugs. :)","commit_id":"5d67aa7659469fc80f5a803ca471c4d5c2c43f73"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f71356a4d8d4b6c060d9ac79a155c95c41a27932","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        :param image: image to be used to create volume"},{"line_number":189,"context_line":"        :param create_volume_kwargs: dict, to be used to create volume"},{"line_number":190,"context_line":"        :param update_volume_kwargs: dict, to be used to update volume"},{"line_number":191,"context_line":"               update_volume_kwargs[\"update_name\"]\u003dTrue, if updating the"},{"line_number":192,"context_line":"               name of volume."},{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        create_volume_kwargs \u003d create_volume_kwargs or {}"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffe62b97_06552cfa","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":55},"in_reply_to":"ffe62b97_f3cc73bd","updated":"2017-03-28 06:46:45.000000000","message":"sure.\n\nWe have unified name and display_name, Maybe we should remove restricted display_name in validation.","commit_id":"5d67aa7659469fc80f5a803ca471c4d5c2c43f73"}]}
