)]}'
{"rally/aas/server.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e23b47fe93d86c992d47f2204842ced4f2cca328","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return wrapper"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FlaskServer(plugin.Plugin):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, api, app\u003dNone):"},{"line_number":46,"context_line":"        self.rapi \u003d api"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f4e5783_8af44bf2","line":43,"updated":"2017-10-17 22:33:08.000000000","message":"Thank you for redoing the patch, but I don\u0027t think that we should mix the Rally Plugins and Flask. \n\nBasically Flask is self contained framework that is already prepared to be used out of box. \n\nI would prefer to use pure Flask app.route() or blueprints (blueprints are more preferable in case of Rally because we have different groups of commands and they are already splited well)  \n\nSo code of API should look like this (without blueprint)\nhttps://github.com/godaddy/netmet/blob/master/netmet/server/main.py \nOr something like this\nhttps://github.com/seecloud/ceagle/blob/master/ceagle/app.py \n(where blueprint is https://github.com/seecloud/ceagle/blob/master/ceagle/api/v1/status.py)","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"91f682de0825291bbcb34b2ec98aa8474427fa17","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return wrapper"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FlaskServer(plugin.Plugin):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, api, app\u003dNone):"},{"line_number":46,"context_line":"        self.rapi \u003d api"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_383638e8","line":43,"in_reply_to":"3f4b6375_481db1bb","updated":"2017-10-23 16:35:54.000000000","message":"OK:)","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0b8d096edcbd7c838921f005b1ec363831ac43a3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return wrapper"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FlaskServer(plugin.Plugin):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, api, app\u003dNone):"},{"line_number":46,"context_line":"        self.rapi \u003d api"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_481db1bb","line":43,"in_reply_to":"3f4b6375_9cd6ab4f","updated":"2017-10-23 11:05:30.000000000","message":"I\u0027m ok about blueprints.","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"441befb50ba63fb583ca1c4d4e1cd756e4ec8350","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return wrapper"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FlaskServer(plugin.Plugin):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def __init__(self, api, app\u003dNone):"},{"line_number":46,"context_line":"        self.rapi \u003d api"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_9cd6ab4f","line":43,"in_reply_to":"5f4e5783_8af44bf2","updated":"2017-10-18 16:28:54.000000000","message":"Good demos:). Looks flask\u0027s blueprint would be better for us.\n@Andrey What\u0027s your idea?","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e23b47fe93d86c992d47f2204842ced4f2cca328","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def discover_all_routes(self):"},{"line_number":57,"context_line":"        sub_servers \u003d self.get_all()"},{"line_number":58,"context_line":"        for sub_server_cls in sub_servers:"},{"line_number":59,"context_line":"            import pdb;pdb.set_trace()"},{"line_number":60,"context_line":"            sub_server \u003d sub_server_cls(self.rapi, self.app)"},{"line_number":61,"context_line":"            methods \u003d [(name, getattr(sub_server, name))"},{"line_number":62,"context_line":"                       for name in dir(sub_server)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f4e5783_4a3e53b8","line":59,"updated":"2017-10-17 22:33:08.000000000","message":"probably this should not be in code?","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"441befb50ba63fb583ca1c4d4e1cd756e4ec8350","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def discover_all_routes(self):"},{"line_number":57,"context_line":"        sub_servers \u003d self.get_all()"},{"line_number":58,"context_line":"        for sub_server_cls in sub_servers:"},{"line_number":59,"context_line":"            import pdb;pdb.set_trace()"},{"line_number":60,"context_line":"            sub_server \u003d sub_server_cls(self.rapi, self.app)"},{"line_number":61,"context_line":"            methods \u003d [(name, getattr(sub_server, name))"},{"line_number":62,"context_line":"                       for name in dir(sub_server)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_16385ad1","line":59,"in_reply_to":"5f4e5783_4a3e53b8","updated":"2017-10-18 16:28:54.000000000","message":"Good catch. I would remove this line.","commit_id":"e949987f8ebd888aa4311e54393dbb70afa69745"}]}
