)]}'
{"rally/plugins/openstack/scenarios/cinder/volume_types.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"3b216ab81f25f98e4c4265a22656b077878a31d9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param kwargs: Optional parameters used during volume"},{"line_number":50,"context_line":"                       type creation."},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        self._create_volume_type(**kwargs)"},{"line_number":53,"context_line":"        self._list_types()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@validation.required_services(consts.Service.CINDER)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8a745968","line":53,"range":{"start_line":52,"start_character":8,"end_line":53,"end_character":26},"updated":"2017-02-14 18:07:27.000000000","message":"There should be a check that volume type is listed.\nLike in nova scenarios:\nhttps://github.com/openstack/rally/blob/a3ecfd74a0db628b2a7286883511ead9109e1c0b/rally/plugins/openstack/scenarios/nova/keypairs.py#L44-L45","commit_id":"2198ad173e9dfc2655223602bdea894e453d7079"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"69bf1dc4a706bdf4dd105443ce418f73b8d01588","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":44,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderScenario):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def run(self, **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :param kwargs: Optional parameters used during volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_544bcd58","line":46,"range":{"start_line":46,"start_character":18,"end_line":46,"end_character":26},"updated":"2017-02-24 15:57:58.000000000","message":"I think exact params would be better:)","commit_id":"03d9a3361542e51499189af651d870d5e675096c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ec5ea245d68daa3581de82d852af82c7d7d432c7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        volume_type \u003d self._create_volume_type(**kwargs)"},{"line_number":55,"context_line":"        msg \u003d (\"type isn\u0027t created\")"},{"line_number":56,"context_line":"        self.assertTrue(volume_type, err_msg\u003dmsg)"},{"line_number":57,"context_line":"        pool_list \u003d self._list_types()"},{"line_number":58,"context_line":"        msg \u003d (\"type not included into list of available types\""},{"line_number":59,"context_line":"               \"created type: {}\\n\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_6d9f9a50","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":49},"updated":"2017-03-08 14:10:30.000000000","message":"As andrey said, we don\u0027t need it;)","commit_id":"0e748a399d0f0c6f2b40701f243f8c85b5b49329"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"806bf958c7ff07fdeb347b5f1c711755416d05e9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self._create_volume_type(**kwargs)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._list_types()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@validation.required_services(consts.Service.CINDER)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_812a858e","line":56,"updated":"2017-03-10 09:46:57.000000000","message":"As Anton said, it is necessary that asserting the created type is in list.","commit_id":"515617e3d12e41da8a06ef2eae6cd3579af0ab89"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"e79539e07e3cb5d5b1c59817e8fa5440388617a3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        self._create_volume_type(**kwargs)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self._list_types()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@validation.required_services(consts.Service.CINDER)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_3be713ad","line":56,"in_reply_to":"9a30ddce_812a858e","updated":"2017-03-13 03:31:13.000000000","message":"Sorry, I don\u0027t think it is necessary. What is the meaning of doing this?","commit_id":"515617e3d12e41da8a06ef2eae6cd3579af0ab89"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"89d8b1815572306afd3a03c2c08d6c72d5bf5b46","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":65,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderBasic):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def run(self, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param kwargs: Optional parameters used during volume"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_3f4547b4","line":67,"updated":"2017-04-06 05:53:56.000000000","message":"Here i prefer to use explicit arguments. Actually, in future we expect to use explicit arguments instead of kwargs in all scenarios.If that, we can remove line #60.","commit_id":"23279b992da30ca4647468da194c6a860f346c32"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"39617e66d21e35fad2ccd283ee64b33720b1d938","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":65,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderBasic):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def run(self, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param kwargs: Optional parameters used during volume"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_6e609802","line":67,"in_reply_to":"bff0334d_3f4547b4","updated":"2017-04-07 01:36:40.000000000","message":"I will do it. thanks for your comment.","commit_id":"23279b992da30ca4647468da194c6a860f346c32"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"89d8b1815572306afd3a03c2c08d6c72d5bf5b46","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        self.admin_cinder.create_volume_type(**kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.admin_cinder.list_types()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@validation.restricted_parameters(\"name\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_bfa3974f","line":75,"updated":"2017-04-06 05:53:56.000000000","message":"Please fix this line as patch 1 comments. We should assert that the type created is included in types list.","commit_id":"23279b992da30ca4647468da194c6a860f346c32"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"7f5e6ace09b50cff566bcf9ab93e341cea1b727b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        self.admin_cinder.create_volume_type(**kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.admin_cinder.list_types()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@validation.restricted_parameters(\"name\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_092a268f","line":75,"in_reply_to":"bff0334d_0e7c6cb3","updated":"2017-04-07 02:15:37.000000000","message":"We need to confirm the volume type was created successfully and it is really existing while listing types.I want to this originated once ci broken. @Anton, right?","commit_id":"23279b992da30ca4647468da194c6a860f346c32"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"39617e66d21e35fad2ccd283ee64b33720b1d938","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        self.admin_cinder.create_volume_type(**kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self.admin_cinder.list_types()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@validation.restricted_parameters(\"name\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"bff0334d_0e7c6cb3","line":75,"in_reply_to":"bff0334d_bfa3974f","updated":"2017-04-07 01:36:40.000000000","message":"why we should assert? I think it is unnecessary.","commit_id":"23279b992da30ca4647468da194c6a860f346c32"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"87b171de782df2cf850e838bbd63872b2edc8d0b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":65,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderBasic):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def run(self, name\u003dNone, description\u003dNone, is_public\u003dTrue):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param name: Descriptive name of the volume type"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ff73747_0cc5df8e","line":67,"updated":"2017-04-22 05:01:27.000000000","message":"Lets remove name argument, the argument \"name\" is restricted. :)\nAnd remove line #60, it is unless if we specify argument explicitly.","commit_id":"026aa6afe0a8057a4d605723933bccf6b7b2e37b"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"9052da06c354f7d625c073256257dd9700db2e08","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                             is_public\u003dis_public)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self.admin_cinder.list_types()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":82,"context_line":"@validation.required_services(consts.Service.CINDER)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ff73747_3cafa895","line":79,"updated":"2017-04-23 04:03:18.000000000","message":"Adding `self.assertIn(volume_type, volume_type_list, err_msg\u003dmsg)` would be better;)","commit_id":"026aa6afe0a8057a4d605723933bccf6b7b2e37b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2f24734f58c130f6f6c3ebd164b06368a0a4fa7d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.admin_cinder.get_volume_type(volume_type)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":61,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":62,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":63,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_9cc64f9a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":41},"updated":"2017-04-26 16:09:50.000000000","message":"it is redundant","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"520913fffac99648cac359ae56785faa7b603172","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.admin_cinder.get_volume_type(volume_type)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":61,"context_line":"@validation.required_services(consts.Service.CINDER)"},{"line_number":62,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":63,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_21416f3a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":41},"in_reply_to":"5ff73747_9cc64f9a","updated":"2017-05-08 06:28:28.000000000","message":"Done","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2f24734f58c130f6f6c3ebd164b06368a0a4fa7d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":65,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderBasic):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def run(self, name\u003dNone, description\u003dNone, is_public\u003dTrue):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param name: Descriptive name of the volume type"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_bc5d8bea","line":67,"range":{"start_line":67,"start_character":18,"end_line":67,"end_character":30},"updated":"2017-04-26 16:09:50.000000000","message":"If name argument is restricted, why we should have it here? It is a new scenario, so we should not support a backward compatibility and allow deprecated parameter.","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"520913fffac99648cac359ae56785faa7b603172","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    name\u003d\"CinderVolumeTypes.create_and_list_volume_types\")"},{"line_number":65,"context_line":"class CreateAndListVolumeTypes(cinder_utils.CinderBasic):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def run(self, name\u003dNone, description\u003dNone, is_public\u003dTrue):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param name: Descriptive name of the volume type"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_013c33bd","line":67,"range":{"start_line":67,"start_character":18,"end_line":67,"end_character":30},"in_reply_to":"5ff73747_bc5d8bea","updated":"2017-05-08 06:28:28.000000000","message":"Done","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2f24734f58c130f6f6c3ebd164b06368a0a4fa7d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def run(self, name\u003dNone, description\u003dNone, is_public\u003dTrue):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param name: Descriptive name of the volume type"},{"line_number":71,"context_line":"        :param description: Description of the volume type"},{"line_number":72,"context_line":"        :param is_public: Volume type visibility"},{"line_number":73,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5ff73747_fc08b3d9","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":56},"updated":"2017-04-26 16:09:50.000000000","message":"do not forget to remove this.","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"520913fffac99648cac359ae56785faa7b603172","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def run(self, name\u003dNone, description\u003dNone, is_public\u003dTrue):"},{"line_number":68,"context_line":"        \"\"\"Create a volume Type, then list all types."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :param name: Descriptive name of the volume type"},{"line_number":71,"context_line":"        :param description: Description of the volume type"},{"line_number":72,"context_line":"        :param is_public: Volume type visibility"},{"line_number":73,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_e14a6753","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":56},"in_reply_to":"5ff73747_fc08b3d9","updated":"2017-05-08 06:28:28.000000000","message":"Done","commit_id":"5876c6eba52860cb2039f01b15dfb28c580c686b"}]}