)]}'
{"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"7ab801a184d388805bc744bc6607a0ff27fe1733","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        :param port_create_args: dict, POST /v2.0/ports request options"},{"line_number":288,"context_line":"        :param ports_per_network: int, number of ports for one network"},{"line_number":289,"context_line":"        \"\"\""},{"line_number":290,"context_line":"        network \u003d self._create_network(network_create_args)"},{"line_number":291,"context_line":"        for i in range(ports_per_network):"},{"line_number":292,"context_line":"            self._create_port(network, port_create_args or {})"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_09519e62","line":290,"range":{"start_line":290,"start_character":23,"end_line":290,"end_character":38},"updated":"2017-02-13 13:44:56.000000000","message":"I think _get_or_create_network() would be better. Maybe the context would create networks.:) https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network/networks.py#L73","commit_id":"364b874a8ba2c2b8464407dc4b04c6959e1efa32"},{"author":{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},"change_message_id":"570b2120c7e84ef42b9d3676f88ca3a905b75d95","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        :param port_create_args: dict, POST /v2.0/ports request options"},{"line_number":288,"context_line":"        :param ports_per_network: int, number of ports for one network"},{"line_number":289,"context_line":"        \"\"\""},{"line_number":290,"context_line":"        network \u003d self._create_network(network_create_args)"},{"line_number":291,"context_line":"        for i in range(ports_per_network):"},{"line_number":292,"context_line":"            self._create_port(network, port_create_args or {})"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_ea03e50e","line":290,"range":{"start_line":290,"start_character":23,"end_line":290,"end_character":38},"in_reply_to":"fa31d9ce_09519e62","updated":"2018-04-12 12:49:19.000000000","message":"Hi Hai Shi，_get_or_create_network() is not suitable in this palce.\n1. ports_per_network means number of ports for one network. If we use _get_or_create_network(), It will create ports for one network more than the number of ports_per_network.\n2. According to class CreateAndListSubnets, _create_network would be better","commit_id":"364b874a8ba2c2b8464407dc4b04c6959e1efa32"}]}
