)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"566b6b326244efc9c82269f24382ebfbae8c1816","unresolved":false,"context_lines":[{"line_number":260,"context_line":"  NeutronNetworks.create_and_show_routers:"},{"line_number":261,"context_line":"    -"},{"line_number":262,"context_line":"      args:"},{"line_number":263,"context_line":"        network_create_args: {}"},{"line_number":264,"context_line":"        subnet_create_args: {}"},{"line_number":265,"context_line":"        subnet_cidr_start: \"1.1.0.0/30\""},{"line_number":266,"context_line":"        subnets_per_network: 2"},{"line_number":267,"context_line":"        router_create_args: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ff73747_1cbd9fd7","line":264,"range":{"start_line":263,"start_character":8,"end_line":264,"end_character":30},"updated":"2017-04-26 16:12:18.000000000","message":"NIT: it is redundant","commit_id":"c1817bc77a1beb0e92531ed598e0d4c2c99a31a4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"566b6b326244efc9c82269f24382ebfbae8c1816","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        subnet_create_args: {}"},{"line_number":265,"context_line":"        subnet_cidr_start: \"1.1.0.0/30\""},{"line_number":266,"context_line":"        subnets_per_network: 2"},{"line_number":267,"context_line":"        router_create_args: {}"},{"line_number":268,"context_line":"      runner:"},{"line_number":269,"context_line":"        type: \"constant\""},{"line_number":270,"context_line":"        times: 4"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ff73747_bcb90bea","line":267,"range":{"start_line":267,"start_character":8,"end_line":267,"end_character":30},"updated":"2017-04-26 16:12:18.000000000","message":"the same","commit_id":"c1817bc77a1beb0e92531ed598e0d4c2c99a31a4"}],"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"a36da461e4c858f47d529685c5f09762a4184ca8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            network_create_args, subnet_create_args, subnet_cidr_start,"},{"line_number":235,"context_line":"            subnets_per_network, router_create_args)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        for router in routers:"},{"line_number":238,"context_line":"            self._show_router(router)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8de7c545","line":238,"range":{"start_line":237,"start_character":7,"end_line":238,"end_character":37},"updated":"2017-02-16 08:47:41.000000000","message":"Pls check the created router in routers.","commit_id":"7d02738be34a817b97298a33872d8b86b6db79a4"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"f70eedf16d61d30557196c2fb4f4861c9df6e4bd","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            network_create_args, subnet_create_args, subnet_cidr_start,"},{"line_number":235,"context_line":"            subnets_per_network, router_create_args)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        for router in routers:"},{"line_number":238,"context_line":"            self._show_router(router)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_458554ab","line":238,"range":{"start_line":237,"start_character":7,"end_line":238,"end_character":37},"in_reply_to":"da36d5c6_77914052","updated":"2017-02-21 16:42:43.000000000","message":"Showing routers is fine. But adding assert function which could check them would be better. If another cores agree with you, pls forget my review:)","commit_id":"7d02738be34a817b97298a33872d8b86b6db79a4"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"70852f3421198b306a051e9a7b9898227bc293b9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            network_create_args, subnet_create_args, subnet_cidr_start,"},{"line_number":235,"context_line":"            subnets_per_network, router_create_args)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        for router in routers:"},{"line_number":238,"context_line":"            self._show_router(router)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_77914052","line":238,"range":{"start_line":237,"start_character":7,"end_line":238,"end_character":37},"in_reply_to":"fa31d9ce_8de7c545","updated":"2017-02-21 09:26:43.000000000","message":"All the routers is created by this scenatio. This scenario created a couple of routers, then show them one by one.","commit_id":"7d02738be34a817b97298a33872d8b86b6db79a4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b80d889c78d7ab53b6b0866d5113645879df2206","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        and then show all routers."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        :param network_create_args: dict, POST /v2.0/networks request"},{"line_number":227,"context_line":"                                    options. Deprecated."},{"line_number":228,"context_line":"        :param subnet_create_args: dict, POST /v2.0/subnets request options"},{"line_number":229,"context_line":"        :param subnet_cidr_start: str, start value for subnets CIDR"},{"line_number":230,"context_line":"        :param subnets_per_network: int, number of subnets for each network"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_64074882","line":227,"range":{"start_line":227,"start_character":46,"end_line":227,"end_character":56},"updated":"2017-03-22 13:15:08.000000000","message":"new scenario should not have deprecated stuff","commit_id":"6c8880009f17dbf9af5c4f3affcaa606b2c3c43b"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"538cb6dc800accf7060e6afaf61b94e913fa3b3c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        and then show all routers."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        :param network_create_args: dict, POST /v2.0/networks request"},{"line_number":227,"context_line":"                                    options. Deprecated."},{"line_number":228,"context_line":"        :param subnet_create_args: dict, POST /v2.0/subnets request options"},{"line_number":229,"context_line":"        :param subnet_cidr_start: str, start value for subnets CIDR"},{"line_number":230,"context_line":"        :param subnets_per_network: int, number of subnets for each network"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_6514864c","line":227,"range":{"start_line":227,"start_character":46,"end_line":227,"end_character":56},"in_reply_to":"1a1ced50_64074882","updated":"2017-03-23 02:30:22.000000000","message":"Done","commit_id":"6c8880009f17dbf9af5c4f3affcaa606b2c3c43b"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"43f8955e0cead87fbf3e49b7169f169dd5ca1f68","unresolved":false,"context_lines":[{"line_number":216,"context_line":"class CreateAndShowRouters(utils.NeutronScenario):"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def run(self, network_create_args\u003dNone, subnet_create_args\u003dNone,"},{"line_number":219,"context_line":"            subnet_cidr_start\u003dNone, subnets_per_network\u003dNone,"},{"line_number":220,"context_line":"            router_create_args\u003dNone):"},{"line_number":221,"context_line":"        \"\"\"Create and show a given number of routers."},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_4c2c0047","line":219,"range":{"start_line":219,"start_character":35,"end_line":219,"end_character":61},"updated":"2017-03-24 00:40:24.000000000","message":"please specify the default value of subnets_per_network with 1.","commit_id":"a03260ae520cea3220aaac86e59a21a90a894bb7"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"a9feac7d4eecf0d8413e4f70d56a8a1bcc4816da","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self._list_routers()"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"},{"line_number":245,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":246,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":247,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_b0380f3d","line":244,"updated":"2017-04-26 16:35:58.000000000","message":"Using @validation.restricted_parameters to restrict the name argument in xx_create_args would be better.","commit_id":"c1817bc77a1beb0e92531ed598e0d4c2c99a31a4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"03e06945fc01073a4d10ce86250e7280f136d75b","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"},{"line_number":245,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":246,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":247,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":248,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":249,"context_line":"                    name\u003d\"NeutronNetworks.create_and_show_routers\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_ec404538","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":41},"updated":"2017-05-05 07:53:39.000000000","message":"1) It checks that \"name\" parameter is missed at a root level of arguments. If you want to validate netwrok_create_args, subnet_create_args or router_create_args, you should use \"subdict\" argument of validator to specify the location\n\n2) As for neutron resources, we override name argument automatically[0][1][2], so this validation is not required.\n\n[0] - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/utils.py#L72\n[1] - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/utils.py#L146\n[2] - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/utils.py#L369","commit_id":"2755305b9794f2fcba2a58d5368031aa73387f2b"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"e75e8970b4fe2f3af2723924fae70338cbefe65b","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"},{"line_number":245,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":246,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":247,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":248,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":249,"context_line":"                    name\u003d\"NeutronNetworks.create_and_show_routers\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_864f3991","line":246,"range":{"start_line":246,"start_character":0,"end_line":246,"end_character":41},"in_reply_to":"3f044301_ec404538","updated":"2017-05-08 05:29:13.000000000","message":"Got it","commit_id":"2755305b9794f2fcba2a58d5368031aa73387f2b"}]}