)]}'
{"rally/plugins/openstack/scenarios/nova/server_groups.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b59d20707e1bdd77cd167e3dc2e55b3125bc99cc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":73,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":74,"context_line":"        msg \u003d (\"Server Group isn\u0027t created\")"},{"line_number":75,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self._delete_server_group(server_group.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_521965d6","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":50},"updated":"2017-03-21 11:00:57.000000000","message":"We don\u0027t need this line.","commit_id":"422c538010d976f88ad588401750b917aff8823c"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"047d51ae9ff597eb1df57fd1e103f831a4be2de2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":73,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":74,"context_line":"        msg \u003d (\"Server Group isn\u0027t created\")"},{"line_number":75,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self._delete_server_group(server_group.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_9523c7a6","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":50},"in_reply_to":"1a1ced50_521965d6","updated":"2017-03-21 11:10:20.000000000","message":"This is actually better than:\n    \n    \u0027NoneType\u0027 object has no attribute \u0027id\u0027","commit_id":"422c538010d976f88ad588401750b917aff8823c"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"67e778fdcbf43b41868ac66400bb288c80e00bda","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":73,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":74,"context_line":"        msg \u003d (\"Server Group isn\u0027t created\")"},{"line_number":75,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self._delete_server_group(server_group.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_2367144e","line":75,"range":{"start_line":75,"start_character":7,"end_line":75,"end_character":50},"in_reply_to":"1a1ced50_9523c7a6","updated":"2017-03-22 07:32:29.000000000","message":"En, I will just leave it unchanged.","commit_id":"422c538010d976f88ad588401750b917aff8823c"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"47995d193ec0ba33d43a6d465159b9c4099a524c","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":69,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":70,"context_line":"        msg \u003d (\"Server Group isn\u0027t created\")"},{"line_number":71,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_d5e2712e","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":22},"updated":"2017-03-22 08:47:42.000000000","message":"In the case of kwargs\u003d\u003dNone, this would throw an error.\nAlso, there is the same issue in line 41 that needs to be fixed too.","commit_id":"83e623a6b17ef978b1c4d1dbdb8f13ee5e7ee0d1"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"6a3f0b0518f93278beb6c159bb46b01eee636aa3","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":69,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":70,"context_line":"        msg \u003d (\"Server Group isn\u0027t created\")"},{"line_number":71,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_e514f6e9","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":22},"in_reply_to":"1a1ced50_d5e2712e","updated":"2017-03-23 02:04:40.000000000","message":"How about add a line \"kwargs \u003d kwargs or {}\" before this line?\nI have also changed line41 and new merged create_and_get_server_group","commit_id":"83e623a6b17ef978b1c4d1dbdb8f13ee5e7ee0d1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"febffb1a43974517f0a65772b1fdb5bfc5dd62bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            projects(Admin only)"},{"line_number":39,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":42,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":43,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":44,"context_line":"        msg \u003d (\"Server Groups isn\u0027t created\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_d6d24b00","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":29},"updated":"2017-03-28 12:09:33.000000000","message":"good catch, thanks","commit_id":"d8956526114a158c8c67031a37bc2d40e49c70b0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"febffb1a43974517f0a65772b1fdb5bfc5dd62bb","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"},{"line_number":70,"context_line":"        server_group \u003d self._create_server_group(**kwargs)"},{"line_number":71,"context_line":"        msg \u003d (\"Server Groups isn\u0027t created\")"},{"line_number":72,"context_line":"        self.assertTrue(server_group, err_msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_76d5bfe4","line":69,"updated":"2017-03-28 12:09:33.000000000","message":"please, do the same here.","commit_id":"d8956526114a158c8c67031a37bc2d40e49c70b0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"febffb1a43974517f0a65772b1fdb5bfc5dd62bb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        Measure the \"nova server-group-create\" and \"nova server-group-delete\""},{"line_number":88,"context_line":"        command performance."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":93,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_0edc17e2","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":51},"updated":"2017-03-28 12:09:33.000000000","message":"\"name\" is restricted param, so there is only one allowed parameter - policy. Let\u0027s use only policy argument here, we do not need kwargs. (for all other scenarios, let\u0027s deprecate kwargs and add policy param)\n\nPS: it relates to all scenarios in the current module. Please fix them too.","commit_id":"d8956526114a158c8c67031a37bc2d40e49c70b0"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"09bd773f13b4cde05f78eca4656bb96c5012974d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        Measure the \"nova server-group-create\" and \"nova server-group-delete\""},{"line_number":88,"context_line":"        command performance."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param kwargs: Server group name and policy"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        kwargs \u003d kwargs or {}"},{"line_number":93,"context_line":"        kwargs[\"name\"] \u003d self.generate_random_name()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_5b684af3","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":51},"in_reply_to":"ffe62b97_0edc17e2","updated":"2017-03-30 03:34:49.000000000","message":"I have moved param name to utils.py, this will make code simple.\nAnd I haved fix all scenarios about server group, please review again.","commit_id":"d8956526114a158c8c67031a37bc2d40e49c70b0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"94d397c67c2e6b328311bd17912a4a873f2f071f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":30,"context_line":"class CreateAndListServerGroups(utils.NovaScenario):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def run(self, policies, all_projects\u003dFalse):"},{"line_number":33,"context_line":"        \"\"\"Create a server group, then list all server groups."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        Measure the \"nova server-group-create\" and \"nova server-group-list\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_f55d8315","line":32,"range":{"start_line":32,"start_character":18,"end_line":32,"end_character":46},"updated":"2017-08-21 11:48:54.000000000","message":"I really like this, but can we make this in a backward compatible way? I mean deprecate an old argument.","commit_id":"27857001c707d957d430399d06d2d4c3af9dd6f1"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"ca37fe9b7742c04061b7338690e09d22f901a479","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        :returns: Nova server group"},{"line_number":467,"context_line":"        \"\"\""},{"line_number":468,"context_line":"        group_name \u003d self.generate_random_name()"},{"line_number":469,"context_line":"        group_policy \u003d policies"},{"line_number":470,"context_line":"        kwargs \u003d {\"name\": group_name,"},{"line_number":471,"context_line":"                  \"policies\": group_policy}"},{"line_number":472,"context_line":"        return self.clients(\"nova\").server_groups.create(**kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_6913f25d","line":469,"updated":"2017-04-07 01:48:48.000000000","message":"this line is redundant.","commit_id":"e86e5b97e09d3f3f19c514e673c350f8e4eefba8"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"ca37fe9b7742c04061b7338690e09d22f901a479","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            return self.clients(\"nova\").server_groups.list(all_projects)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    @atomic.action_timer(\"nova.delete_server_group\")"},{"line_number":499,"context_line":"    def _delete_server_group(self, id):"},{"line_number":500,"context_line":"        \"\"\"Delete a specific server group."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        :param id: The ID of the :class:`ServerGroup` to delete"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_c979de93","line":499,"range":{"start_line":499,"start_character":35,"end_line":499,"end_character":37},"updated":"2017-04-07 01:48:48.000000000","message":"It will be better if this argument can be specified with group object or id.","commit_id":"e86e5b97e09d3f3f19c514e673c350f8e4eefba8"}],"samples/tasks/scenarios/nova/create-and-delete-server-group.json":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"265b47cbe1bb29a9895532c1d984cd3692b12b62","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"kwargs\": {"},{"line_number":6,"context_line":"                        \"policies\": ["},{"line_number":7,"context_line":"                            \"affinity\""},{"line_number":8,"context_line":"                        ]"},{"line_number":9,"context_line":"                    }"},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":1,"id":"1a1ced50_141367b9","line":9,"range":{"start_line":6,"start_character":17,"end_line":9,"end_character":21},"updated":"2017-03-21 06:39:17.000000000","message":"Please fix indentation","commit_id":"422c538010d976f88ad588401750b917aff8823c"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"67e778fdcbf43b41868ac66400bb288c80e00bda","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"kwargs\": {"},{"line_number":6,"context_line":"                        \"policies\": ["},{"line_number":7,"context_line":"                            \"affinity\""},{"line_number":8,"context_line":"                        ]"},{"line_number":9,"context_line":"                    }"},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":1,"id":"1a1ced50_836fe829","line":9,"range":{"start_line":6,"start_character":17,"end_line":9,"end_character":21},"in_reply_to":"1a1ced50_141367b9","updated":"2017-03-22 07:32:29.000000000","message":"Done","commit_id":"422c538010d976f88ad588401750b917aff8823c"}]}