)]}'
{"rally/plugins/openstack/scenarios/nova/server_groups.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c599e7eeaa803a3460b0e45cfc70fe23bfbeaf69","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    name\u003d\"NovaServerGroups.create_and_get_server_group\")"},{"line_number":62,"context_line":"class CreateAndGetServerGroup(utils.NovaScenario):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def run(self, kwargs\u003dNone):"},{"line_number":65,"context_line":"        \"\"\"Create a server group, then get its detailed information."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        Measure the \"nova server-group-create\" and \"nova server-group-get\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_941b8580","line":64,"range":{"start_line":64,"start_character":18,"end_line":64,"end_character":24},"updated":"2017-02-24 16:14:14.000000000","message":"Using exact params would be better. kwargs would reduce potential problem. So we should improve this param like this one. https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/designate/basic.py#L140","commit_id":"8f653f5268fc439d5b711a77d90cb4a4223a3569"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"77a8f82fd0b29e6b965874430ccb9007aa9d00f4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    name\u003d\"NovaServerGroups.create_and_get_server_group\")"},{"line_number":62,"context_line":"class CreateAndGetServerGroup(utils.NovaScenario):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def run(self, kwargs\u003dNone):"},{"line_number":65,"context_line":"        \"\"\"Create a server group, then get its detailed information."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        Measure the \"nova server-group-create\" and \"nova server-group-get\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2bbf7ed1","line":64,"range":{"start_line":64,"start_character":18,"end_line":64,"end_character":24},"in_reply_to":"da36d5c6_941b8580","updated":"2017-03-01 09:03:09.000000000","message":"？ what should i do if kwargs has a lot of params? You mean kwargs or sth like this should be canceled?","commit_id":"8f653f5268fc439d5b711a77d90cb4a4223a3569"}],"tests/unit/plugins/openstack/scenarios/nova/test_server_groups.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3b0ef6e9c51981055e56ba5b749820149989a5db","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        scenario._create_server_group.assert_called_with(**create_args)"},{"line_number":62,"context_line":"        scenario._list_server_groups.assert_called_with(all_projects)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_create_and_get_server_group(self):"},{"line_number":65,"context_line":"        scenario \u003d server_groups.CreateAndGetServerGroup(self.context)"},{"line_number":66,"context_line":"        gen_name \u003d mock.MagicMock()"},{"line_number":67,"context_line":"        scenario.generate_random_name \u003d gen_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_3db49580","line":64,"updated":"2017-02-23 21:52:40.000000000","message":"Please split it at at 2 tests: positive and negative. Also ddt module pretty useful would be here","commit_id":"8f653f5268fc439d5b711a77d90cb4a4223a3569"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"77a8f82fd0b29e6b965874430ccb9007aa9d00f4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        scenario._create_server_group.assert_called_with(**create_args)"},{"line_number":62,"context_line":"        scenario._list_server_groups.assert_called_with(all_projects)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_create_and_get_server_group(self):"},{"line_number":65,"context_line":"        scenario \u003d server_groups.CreateAndGetServerGroup(self.context)"},{"line_number":66,"context_line":"        gen_name \u003d mock.MagicMock()"},{"line_number":67,"context_line":"        scenario.generate_random_name \u003d gen_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_cb5502c7","line":64,"in_reply_to":"da36d5c6_3db49580","updated":"2017-03-01 09:03:09.000000000","message":"Done","commit_id":"8f653f5268fc439d5b711a77d90cb4a4223a3569"}]}