)]}'
{"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1af5a8adc98eefa232af00cd2bffb9fef832da7","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        Measure the \"neutron floating-ip-create\" and \"neutron floating-ip-show\""},{"line_number":379,"context_line":"        commands performance"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        :param floating_network: str external network for floating Ip creation"},{"line_number":382,"context_line":"        :param floating_ip_args: dict,POST /floatingips request options"},{"line_number":383,"context_line":"        \"\"\""},{"line_number":384,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_7228ca33","line":381,"updated":"2017-02-25 21:42:11.000000000","message":"str, ...","commit_id":"3ea8d07a38b47ee0f274dcbb504f1d64118abf7a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1af5a8adc98eefa232af00cd2bffb9fef832da7","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        commands performance"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        :param floating_network: str external network for floating Ip creation"},{"line_number":382,"context_line":"        :param floating_ip_args: dict,POST /floatingips request options"},{"line_number":383,"context_line":"        \"\"\""},{"line_number":384,"context_line":"        floating_ip_args \u003d floating_ip_args or {}"},{"line_number":385,"context_line":"        floatingip \u003d self._create_floatingip(floating_network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_92237e55","line":382,"updated":"2017-02-25 21:42:11.000000000","message":"dict, POST","commit_id":"3ea8d07a38b47ee0f274dcbb504f1d64118abf7a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4c31dd74d696e5beec71d183ab9a6c4cf5576090","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                    name\u003d\"NeutronNetworks.create_and_show_floatingip\")"},{"line_number":524,"context_line":"class CreateAndShowFloatingIp(utils.NeutronScenario):"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def run(self, floating_network\u003dNone, floating_ip_args\u003dNone):"},{"line_number":527,"context_line":"        \"\"\"Create and show floating Ip."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        Measure the \"neutron floating-ip-create\" and \"neutron floating-ip-show\""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_d1ef7fae","line":526,"range":{"start_line":526,"start_character":34,"end_line":526,"end_character":39},"updated":"2017-05-29 05:04:58.000000000","message":"as far as I understand floating_network parameter is required, not optional, so default argument is redundant.","commit_id":"fa70b10194847f71667c402a5b8e002d3fe8be5d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4c31dd74d696e5beec71d183ab9a6c4cf5576090","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                    name\u003d\"NeutronNetworks.create_and_show_floatingip\")"},{"line_number":524,"context_line":"class CreateAndShowFloatingIp(utils.NeutronScenario):"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def run(self, floating_network\u003dNone, floating_ip_args\u003dNone):"},{"line_number":527,"context_line":"        \"\"\"Create and show floating Ip."},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        Measure the \"neutron floating-ip-create\" and \"neutron floating-ip-show\""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_51392f3f","line":526,"range":{"start_line":526,"start_character":41,"end_line":526,"end_character":62},"updated":"2017-05-29 05:04:58.000000000","message":"can you specify explicitly all available arguments?","commit_id":"fa70b10194847f71667c402a5b8e002d3fe8be5d"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"3dfa7813c23f6e5f976ad58738a608cd4172ee5d","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        :param port_id: ID of the port to be associated with the floating IP."},{"line_number":522,"context_line":"        :param subnet_id: Subnet ID on which you want to create the floating IP"},{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":"        self._create_floatingip("},{"line_number":525,"context_line":"            floating_network,"},{"line_number":526,"context_line":"            description\u003ddescription,"},{"line_number":527,"context_line":"            fixed_ip_address\u003dfixed_ip_address,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_d9def86b","line":524,"range":{"start_line":524,"start_character":21,"end_line":524,"end_character":31},"updated":"2017-06-02 11:15:05.000000000","message":"please separate these two words by using \u0027_\u0027","commit_id":"a8c9d3372beff0d3a1ce18828ed48ede9f58243a"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"2219e81cdd654e5dfbd71c367f38c94d5aa62f92","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        :param port_id: ID of the port to be associated with the floating IP."},{"line_number":522,"context_line":"        :param subnet_id: Subnet ID on which you want to create the floating IP"},{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":"        self._create_floatingip("},{"line_number":525,"context_line":"            floating_network,"},{"line_number":526,"context_line":"            description\u003ddescription,"},{"line_number":527,"context_line":"            fixed_ip_address\u003dfixed_ip_address,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_ef2cfcac","line":524,"range":{"start_line":524,"start_character":21,"end_line":524,"end_character":31},"in_reply_to":"df140735_9def1ee8","updated":"2017-06-06 07:22:01.000000000","message":"thank you for your comment, i think we should use floatingip instead of floating_ip, we should be same with client. i will fix it everywhere.","commit_id":"a8c9d3372beff0d3a1ce18828ed48ede9f58243a"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"02653b25e7a6134378c926e29fe9a468f6b99a02","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        :param port_id: ID of the port to be associated with the floating IP."},{"line_number":522,"context_line":"        :param subnet_id: Subnet ID on which you want to create the floating IP"},{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":"        self._create_floatingip("},{"line_number":525,"context_line":"            floating_network,"},{"line_number":526,"context_line":"            description\u003ddescription,"},{"line_number":527,"context_line":"            fixed_ip_address\u003dfixed_ip_address,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_9def1ee8","line":524,"range":{"start_line":524,"start_character":21,"end_line":524,"end_character":31},"in_reply_to":"df140735_a092bc55","updated":"2017-06-05 07:37:49.000000000","message":"pls look at https://review.openstack.org/#/c/437829/6/rally/plugins/openstack/scenarios/neutron/utils.py#546 and L560\nAlso pls look at line 531 with name of action timer. According to this, I suppose that \u0027_create_floatingip\u0027 is some kind of misprint. I don\u0027t ask you to fix it everywhere, but usage of \u0027_\u0027 to separate different words looks more accuracy","commit_id":"a8c9d3372beff0d3a1ce18828ed48ede9f58243a"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"c3d99262bfa988f725a8dcc8d2a11ca82882d8b8","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        :param port_id: ID of the port to be associated with the floating IP."},{"line_number":522,"context_line":"        :param subnet_id: Subnet ID on which you want to create the floating IP"},{"line_number":523,"context_line":"        \"\"\""},{"line_number":524,"context_line":"        self._create_floatingip("},{"line_number":525,"context_line":"            floating_network,"},{"line_number":526,"context_line":"            description\u003ddescription,"},{"line_number":527,"context_line":"            fixed_ip_address\u003dfixed_ip_address,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_a092bc55","line":524,"range":{"start_line":524,"start_character":21,"end_line":524,"end_character":31},"in_reply_to":"df140735_d9def86b","updated":"2017-06-05 03:27:58.000000000","message":"please look https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L905\nand L911, L915, L919, L923","commit_id":"a8c9d3372beff0d3a1ce18828ed48ede9f58243a"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"3dfa7813c23f6e5f976ad58738a608cd4172ee5d","unresolved":false,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        self.assertTrue(floatingip, \"floatingip isn\u0027t created\")"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        floatingip_info \u003d self._show_floatingip(floatingip[\"floatingip\"][\"id\"])"},{"line_number":569,"context_line":"        self.assertEqual(floatingip[\"floatingip\"][\"id\"],"},{"line_number":570,"context_line":"                         floatingip_info[\"floatingip\"][\"id\"])"},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_79680c86","line":568,"range":{"start_line":568,"start_character":38,"end_line":568,"end_character":48},"updated":"2017-06-02 11:15:05.000000000","message":"Please separate these two words by using \u0027_\u0027","commit_id":"a8c9d3372beff0d3a1ce18828ed48ede9f58243a"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2b99b86c2f1b25b13b88fd5bfe00e31e0f735c44","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    def _show_floatingip(self, floatingip, **kwargs):"},{"line_number":552,"context_line":"        \"\"\"Fetches information of a certain floatingip."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        :param floatingip: dict, floating IP object"},{"line_number":555,"context_line":"        :param kwargs: Optional additional arguments for ip show"},{"line_number":556,"context_line":"        :returns: detailed information of floatingip"},{"line_number":557,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_d18143fd","line":554,"range":{"start_line":554,"start_character":8,"end_line":554,"end_character":51},"updated":"2017-05-22 15:08:09.000000000","message":"It looks we could only transmitted the id of floating ip object here.\n\n[1]https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L913","commit_id":"fa70b10194847f71667c402a5b8e002d3fe8be5d"}],"tests/unit/plugins/openstack/scenarios/neutron/test_network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1af5a8adc98eefa232af00cd2bffb9fef832da7","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        scenario._show_floatingip \u003d mock.Mock()"},{"line_number":431,"context_line":"        scenario._show_floatingip.return_value \u003d fip_info"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        # Positive case"},{"line_number":434,"context_line":"        scenario._create_floatingip.return_value \u003d fip"},{"line_number":435,"context_line":"        scenario.run(floating_network\u003dfloating_network,"},{"line_number":436,"context_line":"                     floating_ip_args\u003dfloating_ip_args)"},{"line_number":437,"context_line":"        scenario._create_floatingip.assert_called_once_with("},{"line_number":438,"context_line":"            floating_network, **floating_ip_args)"},{"line_number":439,"context_line":"        scenario._show_floatingip.assert_called_once_with("},{"line_number":440,"context_line":"            fip[\"floatingip\"][\"id\"])"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        # Negative case1: floatingip isn\u0027t created"},{"line_number":443,"context_line":"        scenario._create_floatingip.return_value \u003d None"},{"line_number":444,"context_line":"        self.assertRaises(rally_exceptions.RallyAssertionError,"},{"line_number":445,"context_line":"                          scenario.run,"},{"line_number":446,"context_line":"                          floating_network\u003dfloating_network,"},{"line_number":447,"context_line":"                          floating_ip_args\u003dfloating_ip_args)"},{"line_number":448,"context_line":"        scenario._create_floatingip.assert_called_with("},{"line_number":449,"context_line":"            floating_network, **floating_ip_args)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    @ddt.data("},{"line_number":452,"context_line":"        {\"floating_network\": \"ext-net\"},"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_f2fd9ab1","line":449,"range":{"start_line":433,"start_character":7,"end_line":449,"end_character":49},"updated":"2017-02-25 21:42:11.000000000","message":"please split it into two tests. Positive and negative","commit_id":"3ea8d07a38b47ee0f274dcbb504f1d64118abf7a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1af5a8adc98eefa232af00cd2bffb9fef832da7","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        scenario._create_floatingip \u003d mock.Mock(return_value\u003dfip)"},{"line_number":464,"context_line":"        scenario._show_floatingip \u003d mock.Mock(return_value\u003dfip_info)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        # Negative case2: floatingip show error information"},{"line_number":467,"context_line":"        self.assertRaises(rally_exceptions.RallyAssertionError,"},{"line_number":468,"context_line":"                          scenario.run,"},{"line_number":469,"context_line":"                          floating_network\u003dfloating_network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_122f8e3f","line":466,"updated":"2017-02-25 21:42:11.000000000","message":"same one as in 449","commit_id":"3ea8d07a38b47ee0f274dcbb504f1d64118abf7a"}]}