)]}'
{"tests/unit/cli/commands/test_plugin.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"4692a0a7862b56d97e7ef96f5d3fa04cde0befca","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                            \"get_all\") as mock_plugin_get_all:"},{"line_number":122,"context_line":"                mock_plugin_get_all.return_value \u003d [self.Plugin2, self.Plugin3]"},{"line_number":123,"context_line":"                plugin_cmd.PluginCommands().show(None, \"p\", \"p2_ns\")"},{"line_number":124,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":125,"context_line":"                self.assertEqual(\"Multiple plugins found:\\n\", out.getvalue())"},{"line_number":126,"context_line":"                mock_plugin_get_all.assert_called_once_with(platform\u003d\"p2_ns\")"},{"line_number":127,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff346bd7_aa4d6773","line":124,"updated":"2017-07-25 00:31:43.000000000","message":"You have to fix all merge conflicts in code","commit_id":"2ff173e2d4978a3e7e14476ea1f25449aa400aea"}],"tests/unit/cli/test_envutils.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                return_value\u003dTrue)"},{"line_number":103,"context_line":"    def test_clear_env(self, mock_update_env_file, mock_path_exists):"},{"line_number":104,"context_line":"        envutils.clear_env()"},{"line_number":105,"context_line":"        self.assertEqual(os.environ, {})"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @mock.patch.dict(os.environ, {\"OS_AUTH_URL\": \"fake_auth_url\","},{"line_number":108,"context_line":"                                  \"OS_USERNAME\": \"fake_username\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_7ad78825","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":40},"updated":"2017-07-28 21:47:41.000000000","message":"think you missed here","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/common/db/test_api.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        deploy_two \u003d db.deployment_create({})"},{"line_number":611,"context_line":"        update_deploy_two \u003d db.deployment_update("},{"line_number":612,"context_line":"            deploy_two[\"uuid\"], {\"config\": {\"opt2\": \"val2\"}})"},{"line_number":613,"context_line":"        self.assertEqual(update_deploy_two[\"uuid\"], deploy_two[\"uuid\"])"},{"line_number":614,"context_line":"        self.assertEqual(update_deploy_two[\"config\"], {\"opt2\": \"val2\"})"},{"line_number":615,"context_line":"        get_deploy_one_again \u003d db.deployment_get(deploy_one[\"uuid\"])"},{"line_number":616,"context_line":"        self.assertEqual(get_deploy_one_again[\"uuid\"], deploy_one[\"uuid\"])"},{"line_number":617,"context_line":"        self.assertEqual(get_deploy_one_again[\"config\"], {\"opt1\": \"val1\"})"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e384910e","line":614,"range":{"start_line":613,"start_character":0,"end_line":614,"end_character":71},"updated":"2017-07-25 23:53:25.000000000","message":"I think you forgot to change here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        self.assertEqual(update_deploy_two[\"uuid\"], deploy_two[\"uuid\"])"},{"line_number":614,"context_line":"        self.assertEqual(update_deploy_two[\"config\"], {\"opt2\": \"val2\"})"},{"line_number":615,"context_line":"        get_deploy_one_again \u003d db.deployment_get(deploy_one[\"uuid\"])"},{"line_number":616,"context_line":"        self.assertEqual(get_deploy_one_again[\"uuid\"], deploy_one[\"uuid\"])"},{"line_number":617,"context_line":"        self.assertEqual(get_deploy_one_again[\"config\"], {\"opt1\": \"val1\"})"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_deployment_get(self):"},{"line_number":620,"context_line":"        deploy_one \u003d db.deployment_create({\"config\": {\"opt1\": \"val1\"}})"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_83794530","line":617,"range":{"start_line":616,"start_character":0,"end_line":617,"end_character":74},"updated":"2017-07-25 23:53:25.000000000","message":"and here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self.assertTrue(resource[\"id\"])"},{"line_number":702,"context_line":"        self.assertEqual(1, len(resources))"},{"line_number":703,"context_line":"        self.assertTrue(resource[\"id\"], resources[0][\"id\"])"},{"line_number":704,"context_line":"        self.assertEqual(resource[\"deployment_uuid\"], deployment[\"uuid\"])"},{"line_number":705,"context_line":"        self.assertEqual(\"fakeprovider\", resource[\"provider_name\"])"},{"line_number":706,"context_line":"        self.assertEqual(\"faketype\", resource[\"type\"])"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_da76743f","line":704,"range":{"start_line":704,"start_character":25,"end_line":704,"end_character":72},"updated":"2017-07-28 21:47:41.000000000","message":"this should be reversed","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/common/db/test_migrations.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                  \"name\": self._08e1515a576c_deployment_uuid,"},{"line_number":420,"context_line":"                  \"config\": six.b(\"{}\"),"},{"line_number":421,"context_line":"                  \"enum_deployments_status\":"},{"line_number":422,"context_line":"                  consts.DeployStatus.DEPLOY_FINISHED,"},{"line_number":423,"context_line":"                  \"credentials\": six.b(json.dumps([])),"},{"line_number":424,"context_line":"                  \"users\": six.b(json.dumps([]))"},{"line_number":425,"context_line":"                  }])"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_43c11d2e","line":422,"range":{"start_line":422,"start_character":18,"end_line":422,"end_character":54},"updated":"2017-07-25 23:53:25.000000000","message":"I think this is under indented","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":547,"context_line":"            self.assertEqual(1, len(tasks_found))"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"            task_found \u003d tasks_found[0]"},{"line_number":550,"context_line":"            self.assertEqual(task_found.uuid, self._e654a0648db0_task_uuid)"},{"line_number":551,"context_line":"            self.assertEqual(task_found.deployment_uuid,"},{"line_number":552,"context_line":"                             self._e654a0648db0_deployment_uuid)"},{"line_number":553,"context_line":"            self.assertEqual(task_found.status, consts.TaskStatus.FINISHED)"},{"line_number":554,"context_line":"            # NOTE(ikhudoshyn): if for all workloads success \u003d\u003d True"},{"line_number":555,"context_line":"            self.assertFalse(task_found.pass_sla)"},{"line_number":556,"context_line":"            # NOTE(ikhudoshyn): sum of all full_durations of all workloads"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_43d6bdf3","line":553,"range":{"start_line":550,"start_character":0,"end_line":553,"end_character":75},"updated":"2017-07-25 23:53:25.000000000","message":"I think here the order should be changed too","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            # NOTE(ikhudoshyn): we have no info on validation duration in old"},{"line_number":559,"context_line":"            # schema"},{"line_number":560,"context_line":"            self.assertEqual(0, task_found.validation_duration)"},{"line_number":561,"context_line":"            self.assertEqual(json.loads(task_found.validation_result), {})"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"            # Check subtask"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e300116a","line":561,"range":{"start_line":561,"start_character":0,"end_line":561,"end_character":74},"updated":"2017-07-25 23:53:25.000000000","message":"and here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            self.assertEqual(1, len(subtasks_found))"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"            subtask_found \u003d subtasks_found[0]"},{"line_number":574,"context_line":"            self.assertEqual(subtask_found.task_uuid,"},{"line_number":575,"context_line":"                             self._e654a0648db0_task_uuid)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"            # NOTE(ikhudoshyn): if for all workloads success \u003d\u003d True"},{"line_number":578,"context_line":"            self.assertFalse(subtask_found.pass_sla)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_c303cd72","line":575,"range":{"start_line":574,"start_character":0,"end_line":575,"end_character":58},"updated":"2017-07-25 23:53:25.000000000","message":"and here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"            self.assertEqual(1, len(tags_found))"},{"line_number":592,"context_line":"            self.assertEqual(\"test_tag\", tags_found[0].tag)"},{"line_number":593,"context_line":"            self.assertEqual(tags_found[0].type, consts.TagType.TASK)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"            # Check workload"},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_63f42187","line":593,"range":{"start_line":593,"start_character":0,"end_line":593,"end_character":69},"updated":"2017-07-25 23:53:25.000000000","message":"I think here as well","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":"            workload_found \u003d workloads_found[0]"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"            self.assertEqual(workload_found.task_uuid,"},{"line_number":608,"context_line":"                             self._e654a0648db0_task_uuid)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"            self.assertEqual(workload_found.subtask_uuid,"},{"line_number":611,"context_line":"                             self._e654a0648db0_subtask_uuid)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"            self.assertEqual(\"test_scenario\", workload_found.name)"},{"line_number":614,"context_line":"            self.assertEqual(0, workload_found.position)"},{"line_number":615,"context_line":"            self.assertEqual(\"theRunner\", workload_found.runner_type)"},{"line_number":616,"context_line":"            self.assertEqual(workload_found.runner,"},{"line_number":617,"context_line":"                             json.dumps({\"type\": \"theRunner\"}))"},{"line_number":618,"context_line":"            self.assertEqual(workload_found.sla,"},{"line_number":619,"context_line":"                             json.dumps({\"s\": \"S\"}))"},{"line_number":620,"context_line":"            self.assertEqual(workload_found.args,"},{"line_number":621,"context_line":"                             json.dumps({\"a\": \"A\"}))"},{"line_number":622,"context_line":"            self.assertEqual(workload_found.context,"},{"line_number":623,"context_line":"                             json.dumps({\"c\": \"C\"}))"},{"line_number":624,"context_line":"            self.assertEqual(workload_found.sla_results,"},{"line_number":625,"context_line":"                             json.dumps({"},{"line_number":626,"context_line":"                                 \"sla\": ["},{"line_number":627,"context_line":"                                     {\"success\": True},"},{"line_number":628,"context_line":"                                     {\"success\": False}"},{"line_number":629,"context_line":"                                 ]"},{"line_number":630,"context_line":"                             }))"},{"line_number":631,"context_line":"            self.assertEqual(workload_found.context_execution,"},{"line_number":632,"context_line":"                             json.dumps({}))"},{"line_number":633,"context_line":"            self.assertEqual(42, workload_found.load_duration)"},{"line_number":634,"context_line":"            self.assertEqual(142, workload_found.full_duration)"},{"line_number":635,"context_line":"            self.assertEqual(1, workload_found.min_duration)"},{"line_number":636,"context_line":"            self.assertEqual(8, workload_found.max_duration)"},{"line_number":637,"context_line":"            self.assertEqual(3, workload_found.total_iteration_count)"},{"line_number":638,"context_line":"            self.assertEqual(1, workload_found.failed_iteration_count)"},{"line_number":639,"context_line":"            self.assertFalse(workload_found.pass_sla)"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"            self._e654a0648db0_workload_uuid \u003d workload_found.uuid"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"            # Check workloadData"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"            workloaddata_found \u003d conn.execute("},{"line_number":646,"context_line":"                workloaddata_table.select()."},{"line_number":647,"context_line":"                where(workloaddata_table.c.task_uuid \u003d\u003d"},{"line_number":648,"context_line":"                      self._e654a0648db0_task_uuid)"},{"line_number":649,"context_line":"            ).fetchall()"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"            self.assertEqual(1, len(workloaddata_found))"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"            wloaddata_found \u003d workloaddata_found[0]"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"            self.assertEqual(wloaddata_found.task_uuid,"},{"line_number":656,"context_line":"                             self._e654a0648db0_task_uuid)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"            self.assertEqual(wloaddata_found.workload_uuid,"},{"line_number":659,"context_line":"                             self._e654a0648db0_workload_uuid)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"            self.assertEqual(0, wloaddata_found.chunk_order)"},{"line_number":662,"context_line":"            self.assertEqual(0, wloaddata_found.chunk_size)"},{"line_number":663,"context_line":"            self.assertEqual(0, wloaddata_found.compressed_chunk_size)"},{"line_number":664,"context_line":"            self.assertEqual(3, wloaddata_found.iteration_count)"},{"line_number":665,"context_line":"            self.assertEqual(1, wloaddata_found.failed_iteration_count)"},{"line_number":666,"context_line":"            self.assertEqual("},{"line_number":667,"context_line":"                wloaddata_found.chunk_data,"},{"line_number":668,"context_line":"                json.dumps("},{"line_number":669,"context_line":"                    {"},{"line_number":670,"context_line":"                        \"raw\": ["},{"line_number":671,"context_line":"                            {\"error\": \"e\", \"duration\": 3},"},{"line_number":672,"context_line":"                            {\"duration\": 1},"},{"line_number":673,"context_line":"                            {\"duration\": 8},"},{"line_number":674,"context_line":"                        ]"},{"line_number":675,"context_line":"                    }"},{"line_number":676,"context_line":"                )"},{"line_number":677,"context_line":"            )"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"            # Delete all stuff created at _pre_upgrade step"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"            conn.execute("},{"line_number":682,"context_line":"                tag_table.delete()."},{"line_number":683,"context_line":"                where(tag_table.c.uuid \u003d\u003d self._e654a0648db0_task_uuid)"},{"line_number":684,"context_line":"            )"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"            conn.execute("},{"line_number":687,"context_line":"                workloaddata_table.delete()."},{"line_number":688,"context_line":"                where(workloaddata_table.c.task_uuid \u003d\u003d"},{"line_number":689,"context_line":"                      self._e654a0648db0_task_uuid)"},{"line_number":690,"context_line":"            )"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"            conn.execute("},{"line_number":693,"context_line":"                workload_table.delete()."},{"line_number":694,"context_line":"                where(workload_table.c.task_uuid \u003d\u003d"},{"line_number":695,"context_line":"                      self._e654a0648db0_task_uuid)"},{"line_number":696,"context_line":"            )"},{"line_number":697,"context_line":"            conn.execute("},{"line_number":698,"context_line":"                subtask_table.delete()."},{"line_number":699,"context_line":"                where(subtask_table.c.task_uuid \u003d\u003d"},{"line_number":700,"context_line":"                      self._e654a0648db0_task_uuid)"},{"line_number":701,"context_line":"            )"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"            conn.execute("},{"line_number":704,"context_line":"                task_table.delete()."},{"line_number":705,"context_line":"                where(task_table.c.uuid \u003d\u003d self._e654a0648db0_task_uuid)"},{"line_number":706,"context_line":"            )"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            conn.execute("},{"line_number":709,"context_line":"                deployment_table.delete()."},{"line_number":710,"context_line":"                where(deployment_table.c.uuid \u003d\u003d"},{"line_number":711,"context_line":"                      self._e654a0648db0_deployment_uuid)"},{"line_number":712,"context_line":"            )"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _pre_upgrade_6ad4f426f005(self, engine):"},{"line_number":715,"context_line":"        deployment_table \u003d db_utils.get_table(engine, \"deployments\")"},{"line_number":716,"context_line":"        task_table \u003d db_utils.get_table(engine, \"tasks\")"},{"line_number":717,"context_line":"        task_result_table \u003d db_utils.get_table(engine, \"task_results\")"},{"line_number":718,"context_line":"        with engine.connect() as conn:"},{"line_number":719,"context_line":"            # create deployment"},{"line_number":720,"context_line":"            conf \u003d {"},{"line_number":721,"context_line":"                \"admin\": {\"username\": \"admin\","},{"line_number":722,"context_line":"                          \"password\": \"passwd\","},{"line_number":723,"context_line":"                          \"project_name\": \"admin\"},"},{"line_number":724,"context_line":"                \"auth_url\": \"http://example.com:5000/v3\","},{"line_number":725,"context_line":"                \"region_name\": \"RegionOne\","},{"line_number":726,"context_line":"                \"type\": \"ExistingCloud\""},{"line_number":727,"context_line":"            }"},{"line_number":728,"context_line":"            deployment_status \u003d consts.DeployStatus.DEPLOY_FINISHED"},{"line_number":729,"context_line":"            conn.execute("},{"line_number":730,"context_line":"                deployment_table.insert(),"},{"line_number":731,"context_line":"                [{"},{"line_number":732,"context_line":"                    \"uuid\": \"my_deployment\","},{"line_number":733,"context_line":"                    \"name\": \"my_deployment\","},{"line_number":734,"context_line":"                    \"config\": json.dumps(conf),"},{"line_number":735,"context_line":"                    \"enum_deployments_status\": deployment_status,"},{"line_number":736,"context_line":"                    \"credentials\": six.b(json.dumps([])),"},{"line_number":737,"context_line":"                    \"users\": six.b(json.dumps([]))"},{"line_number":738,"context_line":"                }])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"            # create task"},{"line_number":741,"context_line":"            conn.execute("},{"line_number":742,"context_line":"                task_table.insert(),"},{"line_number":743,"context_line":"                [{"},{"line_number":744,"context_line":"                    \"uuid\": \"my_task\","},{"line_number":745,"context_line":"                    \"deployment_uuid\": \"my_deployment\","},{"line_number":746,"context_line":"                    \"status\": consts.TaskStatus.INIT,"},{"line_number":747,"context_line":"                }])"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"            # create task result with empty data"},{"line_number":750,"context_line":"            conn.execute("},{"line_number":751,"context_line":"                task_result_table.insert(),"},{"line_number":752,"context_line":"                [{"},{"line_number":753,"context_line":"                    \"task_uuid\": \"my_task\","},{"line_number":754,"context_line":"                    \"key\": json.dumps({}),"},{"line_number":755,"context_line":"                    \"data\": json.dumps({}),"},{"line_number":756,"context_line":"                }]"},{"line_number":757,"context_line":"            )"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"    def _check_6ad4f426f005(self, engine, data):"},{"line_number":760,"context_line":"        self.assertEqual(\"6ad4f426f005\","},{"line_number":761,"context_line":"                         api.get_backend().schema_revision(engine\u003dengine))"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        deployment_table \u003d db_utils.get_table(engine, \"deployments\")"},{"line_number":764,"context_line":"        task_table \u003d db_utils.get_table(engine, \"tasks\")"},{"line_number":765,"context_line":"        task_result_table \u003d db_utils.get_table(engine, \"task_results\")"},{"line_number":766,"context_line":"        with engine.connect() as conn:"},{"line_number":767,"context_line":"            task_results \u003d conn.execute(task_result_table.select()).fetchall()"},{"line_number":768,"context_line":"            self.assertEqual(1, len(task_results))"},{"line_number":769,"context_line":"            task_result \u003d task_results[0]"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"            # check that \"hooks\" field added"},{"line_number":772,"context_line":"            self.assertEqual({\"hooks\": []}, json.loads(task_result.data))"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"            # Remove task result"},{"line_number":775,"context_line":"            conn.execute("},{"line_number":776,"context_line":"                task_result_table.delete().where("},{"line_number":777,"context_line":"                    task_result_table.c.id \u003d\u003d task_result.id)"},{"line_number":778,"context_line":"            )"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"            # Remove task"},{"line_number":781,"context_line":"            conn.execute("},{"line_number":782,"context_line":"                task_table.delete().where(task_table.c.uuid \u003d\u003d \"my_task\"))"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"            # Remove deployment"},{"line_number":785,"context_line":"            conn.execute("},{"line_number":786,"context_line":"                deployment_table.delete().where("},{"line_number":787,"context_line":"                    deployment_table.c.uuid \u003d\u003d \"my_deployment\")"},{"line_number":788,"context_line":"            )"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def _pre_upgrade_32fada9b2fde(self, engine):"},{"line_number":791,"context_line":"            self._32fada9b2fde_deployments \u003d {"},{"line_number":792,"context_line":"                # right config which should not be changed after migration"},{"line_number":793,"context_line":"                \"should-not-be-changed-1\": {"},{"line_number":794,"context_line":"                    \"admin\": {\"username\": \"admin\","},{"line_number":795,"context_line":"                              \"password\": \"passwd\","},{"line_number":796,"context_line":"                              \"project_name\": \"admin\"},"},{"line_number":797,"context_line":"                    \"auth_url\": \"http://example.com:5000/v3\","},{"line_number":798,"context_line":"                    \"region_name\": \"RegionOne\","},{"line_number":799,"context_line":"                    \"type\": \"ExistingCloud\"},"},{"line_number":800,"context_line":"                # right config which should not be changed after migration"},{"line_number":801,"context_line":"                \"should-not-be-changed-2\": {"},{"line_number":802,"context_line":"                    \"admin\": {\"username\": \"admin\","},{"line_number":803,"context_line":"                              \"password\": \"passwd\","},{"line_number":804,"context_line":"                              \"tenant_name\": \"admin\"},"},{"line_number":805,"context_line":"                    \"users\": [{\"username\": \"admin\","},{"line_number":806,"context_line":"                               \"password\": \"passwd\","},{"line_number":807,"context_line":"                              \"tenant_name\": \"admin\"}],"},{"line_number":808,"context_line":"                    \"auth_url\": \"http://example.com:5000/v2.0\","},{"line_number":809,"context_line":"                    \"region_name\": \"RegionOne\","},{"line_number":810,"context_line":"                    \"type\": \"ExistingCloud\"},"},{"line_number":811,"context_line":"                # not ExistingCloud config which should not be changed"},{"line_number":812,"context_line":"                \"should-not-be-changed-3\": {"},{"line_number":813,"context_line":"                    \"url\": \"example.com\","},{"line_number":814,"context_line":"                    \"type\": \"Something\"},"},{"line_number":815,"context_line":"                # with `admin_domain_name` field"},{"line_number":816,"context_line":"                \"with_admin_domain_name\": {"},{"line_number":817,"context_line":"                    \"admin\": {\"username\": \"admin\","},{"line_number":818,"context_line":"                              \"password\": \"passwd\","},{"line_number":819,"context_line":"                              \"project_name\": \"admin\","},{"line_number":820,"context_line":"                              \"admin_domain_name\": \"admin\"},"},{"line_number":821,"context_line":"                    \"auth_url\": \"http://example.com:5000/v3\","},{"line_number":822,"context_line":"                    \"region_name\": \"RegionOne\","},{"line_number":823,"context_line":"                    \"type\": \"ExistingCloud\"},"},{"line_number":824,"context_line":"            }"},{"line_number":825,"context_line":"            deployment_table \u003d db_utils.get_table(engine, \"deployments\")"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"            deployment_status \u003d consts.DeployStatus.DEPLOY_FINISHED"},{"line_number":828,"context_line":"            with engine.connect() as conn:"},{"line_number":829,"context_line":"                for deployment in self._32fada9b2fde_deployments:"},{"line_number":830,"context_line":"                    conf \u003d json.dumps("},{"line_number":831,"context_line":"                        self._32fada9b2fde_deployments[deployment])"},{"line_number":832,"context_line":"                    conn.execute("},{"line_number":833,"context_line":"                        deployment_table.insert(),"},{"line_number":834,"context_line":"                        [{\"uuid\": deployment, \"name\": deployment,"},{"line_number":835,"context_line":"                          \"config\": conf,"},{"line_number":836,"context_line":"                          \"enum_deployments_status\": deployment_status,"},{"line_number":837,"context_line":"                          \"credentials\": six.b(json.dumps([])),"},{"line_number":838,"context_line":"                          \"users\": six.b(json.dumps([]))"},{"line_number":839,"context_line":"                          }])"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def _check_32fada9b2fde(self, engine, data):"},{"line_number":842,"context_line":"        self.assertEqual(\"32fada9b2fde\","},{"line_number":843,"context_line":"                         api.get_backend().schema_revision(engine\u003dengine))"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"        original_deployments \u003d self._32fada9b2fde_deployments"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        deployment_table \u003d db_utils.get_table(engine, \"deployments\")"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        with engine.connect() as conn:"},{"line_number":850,"context_line":"            deployments_found \u003d conn.execute("},{"line_number":851,"context_line":"                deployment_table.select()).fetchall()"},{"line_number":852,"context_line":"            for deployment in deployments_found:"},{"line_number":853,"context_line":"                # check deployment"},{"line_number":854,"context_line":"                self.assertIn(deployment.uuid, original_deployments)"},{"line_number":855,"context_line":"                self.assertIn(deployment.name, original_deployments)"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"                config \u003d json.loads(deployment.config)"},{"line_number":858,"context_line":"                if config !\u003d original_deployments[deployment.uuid]:"},{"line_number":859,"context_line":"                    if deployment.uuid.startswith(\"should-not-be-changed\"):"},{"line_number":860,"context_line":"                        self.fail(\"Config of deployment \u0027%s\u0027 is changes, but \""},{"line_number":861,"context_line":"                                  \"should not.\" % deployment.uuid)"},{"line_number":862,"context_line":"                    if \"admin_domain_name\" in deployment.config:"},{"line_number":863,"context_line":"                        self.fail(\"Config of deployment \u0027%s\u0027 should not \""},{"line_number":864,"context_line":"                                  \"contain `admin_domain_name` field.\" %"},{"line_number":865,"context_line":"                                  deployment.uuid)"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"                    endpoint_type \u003d (original_deployments["},{"line_number":868,"context_line":"                                     deployment.uuid].get(\"endpoint_type\"))"},{"line_number":869,"context_line":"                    if endpoint_type in (None, \"public\"):"},{"line_number":870,"context_line":"                        self.assertNotIn(\"endpoint_type\", config)"},{"line_number":871,"context_line":"                    else:"},{"line_number":872,"context_line":"                        self.assertIn(\"endpoint_type\", config)"},{"line_number":873,"context_line":"                        self.assertEqual(endpoint_type,"},{"line_number":874,"context_line":"                                         config[\"endpoint_type\"])"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"                    existing.ExistingCloud({\"config\": config}).validate()"},{"line_number":877,"context_line":"                else:"},{"line_number":878,"context_line":"                    if not deployment.uuid.startswith(\"should-not-be-changed\"):"},{"line_number":879,"context_line":"                        self.fail(\"Config of deployment \u0027%s\u0027 is not changes, \""},{"line_number":880,"context_line":"                                  \"but should.\" % deployment.uuid)"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"                # this deployment created at _pre_upgrade step is not needed"},{"line_number":883,"context_line":"                # anymore and we can remove it"},{"line_number":884,"context_line":"                conn.execute("},{"line_number":885,"context_line":"                    deployment_table.delete().where("},{"line_number":886,"context_line":"                        deployment_table.c.uuid \u003d\u003d deployment.uuid)"},{"line_number":887,"context_line":"                )"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def _pre_upgrade_484cd9413e66(self, engine):"},{"line_number":890,"context_line":"            self._484cd9413e66_deployment_uuid \u003d \"484cd9413e66-deploy\""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"            self._484cd9413e66_verifications \u003d ["},{"line_number":893,"context_line":"                {\"total\": {\"time\": 1.0,"},{"line_number":894,"context_line":"                           \"failures\": 2,"},{"line_number":895,"context_line":"                           \"skipped\": 3,"},{"line_number":896,"context_line":"                           \"success\": 4,"},{"line_number":897,"context_line":"                           \"errors\": 0,"},{"line_number":898,"context_line":"                           \"tests\": 2"},{"line_number":899,"context_line":"                           },"},{"line_number":900,"context_line":"                 \"test_cases\": {\"test1\": {\"status\": \"OK\"},"},{"line_number":901,"context_line":"                                \"test2\": {\"status\": \"FAIL\","},{"line_number":902,"context_line":"                                          \"failure\": {\"log\": \"trace\"}}},"},{"line_number":903,"context_line":"                 \"set_name\": \"full\"},"},{"line_number":904,"context_line":"                {\"total\": {\"time\": 2.0,"},{"line_number":905,"context_line":"                           \"failures\": 3,"},{"line_number":906,"context_line":"                           \"skipped\": 4,"},{"line_number":907,"context_line":"                           \"success\": 5,"},{"line_number":908,"context_line":"                           \"unexpected_success\": 6,"},{"line_number":909,"context_line":"                           \"expected_failures\": 7,"},{"line_number":910,"context_line":"                           \"tests\": 2"},{"line_number":911,"context_line":"                           },"},{"line_number":912,"context_line":"                 \"test_cases\": {\"test1\": {\"status\": \"success\"},"},{"line_number":913,"context_line":"                                \"test2\": {\"status\": \"failed\", \"\""},{"line_number":914,"context_line":"                                          \"traceback\": \"trace\"}},"},{"line_number":915,"context_line":"                 \"set_name\": \"smoke\"}"},{"line_number":916,"context_line":"            ]"},{"line_number":917,"context_line":"            deployment_table \u003d db_utils.get_table(engine, \"deployments\")"},{"line_number":918,"context_line":"            verifications_table \u003d db_utils.get_table(engine, \"verifications\")"},{"line_number":919,"context_line":"            vresults_table \u003d db_utils.get_table(engine,"},{"line_number":920,"context_line":"                                                \"verification_results\")"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"            deployment_status \u003d consts.DeployStatus.DEPLOY_FINISHED"},{"line_number":923,"context_line":"            vstatus \u003d consts.TaskStatus.FINISHED"},{"line_number":924,"context_line":"            with engine.connect() as conn:"},{"line_number":925,"context_line":"                conn.execute("},{"line_number":926,"context_line":"                    deployment_table.insert(),"},{"line_number":927,"context_line":"                    [{\"uuid\": self._484cd9413e66_deployment_uuid,"},{"line_number":928,"context_line":"                      \"name\": self._484cd9413e66_deployment_uuid,"},{"line_number":929,"context_line":"                      \"config\": six.b(json.dumps([])),"},{"line_number":930,"context_line":"                      \"enum_deployments_status\": deployment_status,"},{"line_number":931,"context_line":"                      \"credentials\": six.b(json.dumps([])),"},{"line_number":932,"context_line":"                      \"users\": six.b(json.dumps([]))"},{"line_number":933,"context_line":"                      }])"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"                for i in range(len(self._484cd9413e66_verifications)):"},{"line_number":936,"context_line":"                    verification \u003d self._484cd9413e66_verifications[i]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_037d55e6","line":933,"range":{"start_line":607,"start_character":0,"end_line":933,"end_character":25},"updated":"2017-07-25 23:53:25.000000000","message":"I think all the self._exxx_uuid and json.dumps should be expected value","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def assertColumnCount(self, engine, table, columns):"},{"line_number":232,"context_line":"        t \u003d db_utils.get_table(engine, table)"},{"line_number":233,"context_line":"        self.assertEqual(len(t.columns), len(columns))"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def assertColumnNotExists(self, engine, table, column):"},{"line_number":236,"context_line":"        t \u003d db_utils.get_table(engine, table)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_5ab164e1","line":233,"range":{"start_line":233,"start_character":8,"end_line":233,"end_character":54},"updated":"2017-07-28 21:47:41.000000000","message":"this should be changed too","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"                        verifications_table.insert(),"},{"line_number":1078,"context_line":"                        [{\"uuid\": \"verification-uuid-%s\" % i,"},{"line_number":1079,"context_line":"                          \"deployment_uuid\":"},{"line_number":1080,"context_line":"                          self._37fdbb373e8d_deployment_uuid,"},{"line_number":1081,"context_line":"                          \"verifier_uuid\": self._37fdbb373e8d_verifier_uuid,"},{"line_number":1082,"context_line":"                          \"status\": consts.VerificationStatus.FINISHED,"},{"line_number":1083,"context_line":"                          \"tests\": json.dumps(tests)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_4bb199e1","line":1080,"updated":"2017-07-28 20:55:17.000000000","message":"this is not related change and not sure that this is better .. but ok","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/common/objects/test_deploy.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        deploy \u003d objects.Deployment(deployment\u003dself.deployment)"},{"line_number":270,"context_line":"        resources \u003d deploy.get_resources(provider_name\u003d\"provider\", type\u003d\"some\")"},{"line_number":271,"context_line":"        self.assertEqual(1, len(resources))"},{"line_number":272,"context_line":"        self.assertEqual(resources[0][\"id\"], self.resource[\"id\"])"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @mock.patch(\"rally.common.objects.deploy.dt.datetime\")"},{"line_number":275,"context_line":"    @mock.patch(\"rally.common.objects.deploy.db.deployment_update\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_c35f4d70","line":272,"range":{"start_line":272,"start_character":0,"end_line":272,"end_character":65},"updated":"2017-07-25 23:53:25.000000000","message":"I think self.resource[\"id\"] is expected value here because you are testing to get resources....and check if the first resources[0] that you get match the self.resource[\"id\"]","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/common/plugin/test_meta.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        meta_ref \u003d Meta._meta"},{"line_number":58,"context_line":"        Meta._meta_clear()"},{"line_number":59,"context_line":"        self.assertRaises(AttributeError, getattr, Meta, \"_meta\")"},{"line_number":60,"context_line":"        self.assertEqual(meta_ref, {})"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_meta_set_and_get(self):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_8bdc2119","line":60,"updated":"2017-07-28 20:55:17.000000000","message":"so it was right before, we are expecting {} to be eqault to value of meta_ref","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        Meta._meta_init()"},{"line_number":143,"context_line":"        SubMeta._meta_init()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.assertEqual(Meta._meta_get(\"foo\"), [])"},{"line_number":146,"context_line":"        self.assertEqual(SubMeta._meta_get(\"foo\"), [])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        SubMeta._meta_get(\"foo\").append(\"bar\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_2bebf5b0","line":145,"updated":"2017-07-28 20:55:17.000000000","message":"same here and below it was right before","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/common/plugin/test_plugin.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        class B(SecondBase):"},{"line_number":80,"context_line":"            pass"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self.assertEqual(A, OneBase.get(name))"},{"line_number":83,"context_line":"        self.assertEqual(B, SecondBase.get(name))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_get_multiple_chooses(self):"},{"line_number":86,"context_line":"        name \u003d \"test_get_multiple_chooses\""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_3ad580ba","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":49},"updated":"2017-07-28 21:47:41.000000000","message":"I think these two should be changed too..?","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/common/test_utils.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                print(msg, file\u003dsys.stderr)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.assertEqual(messages, err.getvalue().rstrip(\"\\n\").split(\"\\n\"))"},{"line_number":93,"context_line":"        self.assertEqual(stderr, sys.stderr)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class TimerTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_23c85920","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":44},"updated":"2017-07-25 23:53:25.000000000","message":"I think here should be changed as well","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        d \u003d utils.LockedDict()"},{"line_number":508,"context_line":"        self.assertIsInstance(d, dict)"},{"line_number":509,"context_line":"        self.assertEqual(d, {})"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        d \u003d utils.LockedDict(foo\u003d\"bar\", spam\u003d{\"a\": [\"b\", {\"c\": \"d\"}]})"},{"line_number":512,"context_line":"        self.assertEqual({\"foo\": \"bar\", \"spam\": {\"a\": (\"b\", {\"c\": \"d\"})}}, d)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_83d6e5c2","line":509,"range":{"start_line":509,"start_character":8,"end_line":509,"end_character":31},"updated":"2017-07-25 23:53:25.000000000","message":"and here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":527,"context_line":"            d[\"spam\"] \u003d 42"},{"line_number":528,"context_line":"            self.assertEqual({\"foo\": \"bar\", \"spam\": 42}, d)"},{"line_number":529,"context_line":"            d.clear()"},{"line_number":530,"context_line":"            self.assertEqual(d, {})"},{"line_number":531,"context_line":"            d.setdefault(\"foo\", 42)"},{"line_number":532,"context_line":"            d.update({\"bar\": 24})"},{"line_number":533,"context_line":"            self.assertEqual({\"foo\": 42, \"bar\": 24}, d)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_c3ed0d8c","line":530,"range":{"start_line":530,"start_character":11,"end_line":530,"end_character":35},"updated":"2017-07-25 23:53:25.000000000","message":"and here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/plugins/common/runners/test_constant.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        results \u003d runner.ScenarioRunner.validate("},{"line_number":51,"context_line":"            \"constant\", None, None, config)"},{"line_number":52,"context_line":"        if valid:"},{"line_number":53,"context_line":"            self.assertEqual(results, [])"},{"line_number":54,"context_line":"        else:"},{"line_number":55,"context_line":"            self.assertGreater(len(results), 0)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_83ff0533","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":41},"updated":"2017-07-25 23:53:25.000000000","message":"why did you change here?","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/plugins/common/runners/test_rps.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def test_validate(self, config, valid\u003dTrue):"},{"line_number":143,"context_line":"        results \u003d runner.ScenarioRunner.validate(\"rps\", None, None, config)"},{"line_number":144,"context_line":"        if valid:"},{"line_number":145,"context_line":"            self.assertEqual(results, [])"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            self.assertGreater(len(results), 0)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_1a5f5c42","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":41},"updated":"2017-07-28 21:47:41.000000000","message":"think you missed here","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/plugins/openstack/context/keystone/test_users.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            for (user, tenant_id, orig_user) in zip(ctx.context[\"users\"],"},{"line_number":490,"context_line":"                                                    tenants_ids, user_list):"},{"line_number":491,"context_line":"                self.assertEqual(user[\"id\"], orig_user.id)"},{"line_number":492,"context_line":"                self.assertEqual(user[\"tenant_id\"], tenant_id)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    @mock.patch(\"%s.identity\" % CTX)"},{"line_number":495,"context_line":"    def test_users_contains_correct_endpoint_type(self, mock_identity):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_bd460a4f","line":492,"range":{"start_line":491,"start_character":0,"end_line":492,"end_character":62},"updated":"2017-07-28 21:47:41.000000000","message":"I think the order here should be reversed, because you are checking if the id in user context matches the ctx.context[\"users\"]","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/plugins/openstack/context/network/test_network.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"45023663d2b90ce3e96b194c78594422c71aef50","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def test__init__default(self, mock_wrap, mock_clients):"},{"line_number":43,"context_line":"        context \u003d network_context.Network(self.get_context())"},{"line_number":44,"context_line":"        self.assertEqual(1, context.config[\"networks_per_tenant\"])"},{"line_number":45,"context_line":"        self.assertEqual(context.config[\"start_cidr\"],"},{"line_number":46,"context_line":"                         network_context.Network.DEFAULT_CONFIG[\"start_cidr\"])"},{"line_number":47,"context_line":"        self.assertIsNone(context.config[\"dns_nameservers\"])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @mock.patch(\"rally.osclients.Clients\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_7d88a270","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":78},"updated":"2017-07-28 21:47:41.000000000","message":"I think it should be reversed order here because you are comparing the context config to default config","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/plugins/openstack/services/storage/test_cinder_common.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        all_deleted \u003d []"},{"line_number":175,"context_line":"        for call in calls:"},{"line_number":176,"context_line":"            call_volume, del_keys \u003d call[0]"},{"line_number":177,"context_line":"            self.assertEqual(call_volume, volume)"},{"line_number":178,"context_line":"            self.assertEqual(4, len(del_keys))"},{"line_number":179,"context_line":"            for key in del_keys:"},{"line_number":180,"context_line":"                self.assertIn(key, keys)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_e346d17c","line":177,"range":{"start_line":177,"start_character":12,"end_line":177,"end_character":49},"updated":"2017-07-25 23:53:25.000000000","message":"think here should be changed as well","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/plugins/openstack/wrappers/test_network.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual(5, service._generate_cidr())"},{"line_number":54,"context_line":"        self.assertEqual(6, service._generate_cidr())"},{"line_number":55,"context_line":"        self.assertEqual(7, service._generate_cidr())"},{"line_number":56,"context_line":"        self.assertEqual(mock_generate_cidr.mock_calls,"},{"line_number":57,"context_line":"                         [mock.call(start_cidr\u003d3)] * 5)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_external_networks(self):"},{"line_number":60,"context_line":"        wrap \u003d self.get_wrapper()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_832025b2","line":57,"range":{"start_line":56,"start_character":8,"end_line":57,"end_character":55},"updated":"2017-07-25 23:53:25.000000000","message":"I think here should be changed as well","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/task/test_atomic.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        inst \u003d TestAtomicTimer()"},{"line_number":126,"context_line":"        self.assertEqual(5, inst.some_func(2, 3, atomic_action\u003dFalse))"},{"line_number":127,"context_line":"        self.assertEqual(inst.atomic_actions(), [])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        inst \u003d TestAtomicTimer()"},{"line_number":130,"context_line":"        self.assertEqual(5, inst.other_func(2, 3))"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_eb84cdb3","line":127,"updated":"2017-07-28 20:55:17.000000000","message":"actually it was right","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        inst \u003d TestAtomicTimer()"},{"line_number":130,"context_line":"        self.assertEqual(5, inst.other_func(2, 3))"},{"line_number":131,"context_line":"        self.assertEqual(inst.atomic_actions(), [])"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        inst \u003d TestAtomicTimer()"},{"line_number":134,"context_line":"        self.assertEqual(5, inst.other_func(2, 3, foo\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_ab8ec5cd","line":131,"updated":"2017-07-28 20:55:17.000000000","message":"and here as well","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/task/test_runner.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.assertIsNone(result)"},{"line_number":151,"context_line":"        self.assertEqual(runner_obj.run_duration,"},{"line_number":152,"context_line":"                         mock_timer_duration.return_value)"},{"line_number":153,"context_line":"        self.assertEqual(list(runner_obj.result_queue), [])"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        runner_obj._run_scenario.assert_called_once_with("},{"line_number":156,"context_line":"            scenario_class, \"run\", context_obj, {\"foo\": 11, \"bar\": \"spam\"})"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_6bc21dec","line":153,"updated":"2017-07-28 20:55:17.000000000","message":"it was right before","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        result \u003d {\"timestamp\": 42}"},{"line_number":336,"context_line":"        runner_._result_has_valid_schema \u003d mock.Mock(return_value\u003dTrue)"},{"line_number":337,"context_line":"        self.assertIsNone(runner_._send_result(result))"},{"line_number":338,"context_line":"        self.assertEqual(runner_.result_batch, [])"},{"line_number":339,"context_line":"        self.assertEqual(collections.deque([[result]]), runner_.result_queue)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    @mock.patch(\"rally.task.runner.LOG\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_0bb15190","line":338,"updated":"2017-07-28 20:55:17.000000000","message":"it was right before","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        self.assertIsNone(runner_._send_result(result))"},{"line_number":347,"context_line":"        runner_._result_has_valid_schema.assert_called_once_with(result)"},{"line_number":348,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":349,"context_line":"        self.assertEqual(runner_.result_batch, [])"},{"line_number":350,"context_line":"        self.assertEqual(collections.deque([]), runner_.result_queue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_ebaded31","line":349,"updated":"2017-07-28 20:55:17.000000000","message":"it was right before","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}],"tests/unit/test_hacking.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        for bad in bad_imports:"},{"line_number":107,"context_line":"            checkres \u003d checks.check_import_of_logging("},{"line_number":108,"context_line":"                bad, bad, \"./rally/common/logging.py\")"},{"line_number":109,"context_line":"            self.assertEqual(list(checkres), [])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        for good in good_imports:"},{"line_number":112,"context_line":"            checkres \u003d checks.check_import_of_logging(good, good, \"fakefile\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_6308a12b","line":109,"range":{"start_line":109,"start_character":11,"end_line":109,"end_character":48},"updated":"2017-07-25 23:53:25.000000000","message":"why did you change here?","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        for good in good_imports:"},{"line_number":112,"context_line":"            checkres \u003d checks.check_import_of_logging(good, good, \"fakefile\")"},{"line_number":113,"context_line":"            self.assertEqual(list(checkres), [])"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_no_translate_debug_logs(self):"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_26006701","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":48},"updated":"2017-07-25 23:53:25.000000000","message":"and here?","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        checkres \u003d checks.check_using_unicode(line, line, \"fakefile\")"},{"line_number":351,"context_line":"        self.assertIsNotNone(next(checkres))"},{"line_number":352,"context_line":"        self.assertEqual(list(checkres), [])"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def test_check_raises(self):"},{"line_number":355,"context_line":"        checkres \u003d checks.check_raises("}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_26298789","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":44},"updated":"2017-07-25 23:53:25.000000000","message":"? +1","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def test_check_old_type_class(self, line):"},{"line_number":388,"context_line":"        checkres \u003d checks.check_old_type_class(line, line, \"fakefile\")"},{"line_number":389,"context_line":"        self.assertIsNotNone(next(checkres))"},{"line_number":390,"context_line":"        self.assertEqual(list(checkres), [])"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def test_check_datetime_alias(self):"},{"line_number":393,"context_line":"        lines \u003d [\"import datetime as date\","}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_062c4397","line":390,"range":{"start_line":390,"start_character":8,"end_line":390,"end_character":44},"updated":"2017-07-25 23:53:25.000000000","message":"? +1","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/test_osclients.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               clients.cache))"},{"line_number":143,"context_line":"        fake_client.create_client \u003d mock.MagicMock()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.assertEqual(clients.cache, {})"},{"line_number":146,"context_line":"        fake_client()"},{"line_number":147,"context_line":"        self.assertEqual("},{"line_number":148,"context_line":"            {client_name: fake_client.create_client.return_value},"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_c6251bad","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":43},"updated":"2017-07-25 23:53:25.000000000","message":"why did you change here?","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":"             \"%s(\u00272\u0027,)\" % client_name: fake_client.create_client.return_value},"},{"line_number":157,"context_line":"            clients.cache)"},{"line_number":158,"context_line":"        clients.clear()"},{"line_number":159,"context_line":"        self.assertEqual(clients.cache, {})"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_a63c57c8","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":43},"updated":"2017-07-25 23:53:25.000000000","message":"+1 ?","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    def test_keystone(self):"},{"line_number":356,"context_line":"        self.assertNotIn(\"keystone\", self.clients.cache)"},{"line_number":357,"context_line":"        client \u003d self.clients.keystone()"},{"line_number":358,"context_line":"        self.assertEqual(client, self.fake_keystone)"},{"line_number":359,"context_line":"        credential \u003d {\"timeout\": cfg.CONF.openstack_client_http_timeout,"},{"line_number":360,"context_line":"                      \"insecure\": False, \"cacert\": None}"},{"line_number":361,"context_line":"        kwargs \u003d self.credential.to_dict()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_66366fe9","line":358,"range":{"start_line":358,"start_character":8,"end_line":358,"end_character":52},"updated":"2017-07-25 23:53:25.000000000","message":"think you want to change here","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"},{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"9f6c24ef3c9823fe5a5cd690b9c6d815af6600ea","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        kwargs \u003d self.credential.to_dict()"},{"line_number":362,"context_line":"        kwargs.update(credential)"},{"line_number":363,"context_line":"        self.mock_create_keystone_client.assert_called_once_with()"},{"line_number":364,"context_line":"        self.assertEqual(self.clients.cache[\"keystone\"], self.fake_keystone)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_keystone_versions(self):"},{"line_number":367,"context_line":"        self.clients.keystone.validate_version(2)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ff346bd7_267747a3","line":364,"range":{"start_line":364,"start_character":8,"end_line":364,"end_character":76},"updated":"2017-07-25 23:53:25.000000000","message":"I think previous order was correct","commit_id":"2f32105d10163b80fbe156b7e35fabeaab8cc5ea"}],"tests/unit/test_test_ddt.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2423ce825762454acb85c566cfc473a3e7db874","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        tree \u003d ast.parse(code).body[0]"},{"line_number":42,"context_line":"        visitor \u003d test_ddt.DDTDecoratorChecker()"},{"line_number":43,"context_line":"        visitor.visit(tree)"},{"line_number":44,"context_line":"        self.assertEqual(visitor.errors,"},{"line_number":45,"context_line":"                         {\"Test\": {\"lineno\": 3,"},{"line_number":46,"context_line":"                          \"message\": \"Class Test has functions that use DDT, \""},{"line_number":47,"context_line":"                                     \"but is not decorated with `ddt.ddt`\"}})"}],"source_content_type":"text/x-python","patch_set":15,"id":"df3967d1_6b67bd27","line":44,"updated":"2017-07-28 20:55:17.000000000","message":"arguments should be reversed","commit_id":"0d6bda1d6b26d3ff93adb0528f622864f6973367"}]}
