)]}'
{"rally/plugins/openstack/cleanup/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b43b870dbb033038e429796c966a449c3ba8fcb7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                % msg_kw)"},{"line_number":102,"context_line":"            if logging.is_debug():"},{"line_number":103,"context_line":"                LOG.exception(e)"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            started \u003d time.time()"},{"line_number":106,"context_line":"            failures_count \u003d 0"},{"line_number":107,"context_line":"            while time.time() - started \u003c resource._timeout:"},{"line_number":108,"context_line":"                try:"},{"line_number":109,"context_line":"                    if resource.is_deleted():"},{"line_number":110,"context_line":"                        return"},{"line_number":111,"context_line":"                except Exception as e:"},{"line_number":112,"context_line":"                    LOG.warning("},{"line_number":113,"context_line":"                        _(\"Seems like %s.%s.is_deleted(self) method is broken \""},{"line_number":114,"context_line":"                          \"It shouldn\u0027t raise any exceptions.\")"},{"line_number":115,"context_line":"                        % (resource.__module__, type(resource).__name__))"},{"line_number":116,"context_line":"                    LOG.exception(e)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    # NOTE(boris-42): Avoid LOG spamming in case of bad"},{"line_number":119,"context_line":"                    #                 is_deleted() method"},{"line_number":120,"context_line":"                    failures_count +\u003d 1"},{"line_number":121,"context_line":"                    if failures_count \u003e resource._max_attempts:"},{"line_number":122,"context_line":"                        break"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                finally:"},{"line_number":125,"context_line":"                    rutils.interruptable_sleep(resource._interval)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            LOG.warning(_(\"Resource deletion failed, timeout occurred for \""},{"line_number":128,"context_line":"                          \"%(service)s.%(resource)s: %(uuid)s.\")"},{"line_number":129,"context_line":"                        % msg_kw)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _publisher(self, queue):"},{"line_number":132,"context_line":"        \"\"\"Publisher for deletion jobs."}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_c49a1863","side":"PARENT","line":129,"range":{"start_line":104,"start_character":7,"end_line":129,"end_character":33},"updated":"2017-03-20 16:56:50.000000000","message":"These lines were designed to check that after sending a request for resource removal, the resource is actually removed. It is not designed for not-exist resources which are the target of your patch.","commit_id":"b6bc5bc3a211c82c67fbbe72ebacb220d5e1e3f7"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"faf5dafc3eca83217e5b1e2e380dd5ba29cb15e2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                % msg_kw)"},{"line_number":102,"context_line":"            if logging.is_debug():"},{"line_number":103,"context_line":"                LOG.exception(e)"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            started \u003d time.time()"},{"line_number":106,"context_line":"            failures_count \u003d 0"},{"line_number":107,"context_line":"            while time.time() - started \u003c resource._timeout:"},{"line_number":108,"context_line":"                try:"},{"line_number":109,"context_line":"                    if resource.is_deleted():"},{"line_number":110,"context_line":"                        return"},{"line_number":111,"context_line":"                except Exception as e:"},{"line_number":112,"context_line":"                    LOG.warning("},{"line_number":113,"context_line":"                        _(\"Seems like %s.%s.is_deleted(self) method is broken \""},{"line_number":114,"context_line":"                          \"It shouldn\u0027t raise any exceptions.\")"},{"line_number":115,"context_line":"                        % (resource.__module__, type(resource).__name__))"},{"line_number":116,"context_line":"                    LOG.exception(e)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    # NOTE(boris-42): Avoid LOG spamming in case of bad"},{"line_number":119,"context_line":"                    #                 is_deleted() method"},{"line_number":120,"context_line":"                    failures_count +\u003d 1"},{"line_number":121,"context_line":"                    if failures_count \u003e resource._max_attempts:"},{"line_number":122,"context_line":"                        break"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"                finally:"},{"line_number":125,"context_line":"                    rutils.interruptable_sleep(resource._interval)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            LOG.warning(_(\"Resource deletion failed, timeout occurred for \""},{"line_number":128,"context_line":"                          \"%(service)s.%(resource)s: %(uuid)s.\")"},{"line_number":129,"context_line":"                        % msg_kw)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _publisher(self, queue):"},{"line_number":132,"context_line":"        \"\"\"Publisher for deletion jobs."}],"source_content_type":"text/x-python","patch_set":8,"id":"1a1ced50_2a19e488","side":"PARENT","line":129,"range":{"start_line":104,"start_character":7,"end_line":129,"end_character":33},"in_reply_to":"1a1ced50_c49a1863","updated":"2017-03-21 01:44:22.000000000","message":"#L109 looks return True all the time because of SynchronizedDeletion which we have talked. If I don\u0027t delete those codes, I would get a error of timeout and exceed the connectionpool, because #L109 would send requests to server frequently. So it just a experiment, try to pass the gate. \nAnd the failure of gate in here-\u003e\nLog:http://logs.openstack.org/94/446394/6/check/gate-rally-dsvm-neutron-existing-users-rally/a34e8e5/console.html","commit_id":"b6bc5bc3a211c82c67fbbe72ebacb220d5e1e3f7"}]}
