)]}'
{"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"3c5cba49f54ae7285ff8ef04753dc3c5aa16f2ee","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def name(self):"},{"line_number":320,"context_line":"        return self.raw_resource.get(\"name\", \"\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete(self):"},{"line_number":323,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_a58c3836","line":320,"range":{"start_line":320,"start_character":45,"end_line":320,"end_character":47},"updated":"2017-03-16 15:04:02.000000000","message":"Shouldn\u0027t we set NoName as default here?","commit_id":"d004a63eab1a7975eca2dad4686249e6b01573aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3c01866d7d6e74f4c9c506fbd570848f67984c81","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def name(self):"},{"line_number":320,"context_line":"        return self.raw_resource.get(\"name\", \"\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete(self):"},{"line_number":323,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_d7148745","line":320,"range":{"start_line":320,"start_character":45,"end_line":320,"end_character":47},"in_reply_to":"3a1ff146_a58c3836","updated":"2017-03-16 15:15:35.000000000","message":"no, we should return `self.raw_resource[\"name\"]` :) fixed","commit_id":"d004a63eab1a7975eca2dad4686249e6b01573aa"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"cea482825a8e1398d8731af7c7357cc192a1ada9","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def name(self):"},{"line_number":320,"context_line":"        return self.raw_resource[\"name\"]"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete(self):"},{"line_number":323,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_691a8170","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":40},"updated":"2017-03-16 16:37:13.000000000","message":"I prefer to like the previous code. If you could cover all subclasses\u0027 name() with no name property, it is fine to me.","commit_id":"ae65185219e3d8faf8625f6762f09a89648b2eb9"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"d2d5498e587cf47f2b196499ddec72173b97fead","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def name(self):"},{"line_number":320,"context_line":"        return self.raw_resource[\"name\"]"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete(self):"},{"line_number":323,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_cd1d2111","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":40},"in_reply_to":"1a1ced50_12d83b53","updated":"2017-03-17 12:24:19.000000000","message":"Thanks, I understand your purpose now.","commit_id":"ae65185219e3d8faf8625f6762f09a89648b2eb9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d7360039d1a4449b3cedb069d3bc126d0c1dfcf5","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def name(self):"},{"line_number":320,"context_line":"        return self.raw_resource[\"name\"]"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def delete(self):"},{"line_number":323,"context_line":"        delete_method \u003d getattr(self._manager(), \"delete_%s\" % self._resource)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_12d83b53","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":40},"in_reply_to":"1a1ced50_691a8170","updated":"2017-03-17 09:36:00.000000000","message":"please, read the note from https://review.openstack.org/#/c/446463/4/rally/plugins/openstack/cleanup/base.py .\nWe should not use `.get(\"name\", \"\")`, since it can help to miss the case when \"name\" field should be, but for some reason it is absent.","commit_id":"ae65185219e3d8faf8625f6762f09a89648b2eb9"}]}
