)]}'
{"rally/cli/commands/deployment.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"25c04302db0625a33bb464a16e8fa8146790ea60","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        def is_field_there(lst, field):"},{"line_number":233,"context_line":"            return True if [item for item in lst if field in item] else False"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def print_error(user_type, error):"},{"line_number":236,"context_line":"            print(\"Error while checking %s credentials:\" % user_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_2242483f","line":233,"range":{"start_line":233,"start_character":19,"end_line":233,"end_character":27},"updated":"2017-04-05 09:27:13.000000000","message":"bool(...)","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"22af456cfa2e5d8a561ddd86344b6ac6fbf19208","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        def is_field_there(lst, field):"},{"line_number":233,"context_line":"            return True if [item for item in lst if field in item] else False"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def print_error(user_type, error):"},{"line_number":236,"context_line":"            print(\"Error while checking %s credentials:\" % user_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_2cb35a0c","line":233,"range":{"start_line":233,"start_character":19,"end_line":233,"end_character":27},"in_reply_to":"dfeb2761_2242483f","updated":"2017-04-05 12:22:08.000000000","message":"hm...","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c14551e160b966f995f6f8a4abdb0cd9ebeebe93","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            return True if [item for item in lst if field in item] else False"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def print_error(user_type, error):"},{"line_number":236,"context_line":"            print(\"Error while checking %s credentials:\" % user_type)"},{"line_number":237,"context_line":"            if logging.is_debug():"},{"line_number":238,"context_line":"                print(error[\"trace\"])"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_10656d1e","line":236,"range":{"start_line":236,"start_character":19,"end_line":236,"end_character":55},"updated":"2017-04-04 16:26:01.000000000","message":"small question. Don\u0027t we need _(\"xxxx\")?","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"22af456cfa2e5d8a561ddd86344b6ac6fbf19208","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            return True if [item for item in lst if field in item] else False"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def print_error(user_type, error):"},{"line_number":236,"context_line":"            print(\"Error while checking %s credentials:\" % user_type)"},{"line_number":237,"context_line":"            if logging.is_debug():"},{"line_number":238,"context_line":"                print(error[\"trace\"])"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_2ca8fa89","line":236,"range":{"start_line":236,"start_character":19,"end_line":236,"end_character":55},"in_reply_to":"dfeb2761_10656d1e","updated":"2017-04-05 12:22:08.000000000","message":"Done","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2d11ea0428208477c09a1fcc633af3624db6e633","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            return True if [item for item in lst if field in item] else False"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def print_error(user_type, error):"},{"line_number":236,"context_line":"            print(\"Error while checking %s credentials:\" % user_type)"},{"line_number":237,"context_line":"            if logging.is_debug():"},{"line_number":238,"context_line":"                print(error[\"trace\"])"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_aefbfe76","line":236,"range":{"start_line":236,"start_character":19,"end_line":236,"end_character":55},"in_reply_to":"dfeb2761_10656d1e","updated":"2017-04-04 16:34:14.000000000","message":"yes :P","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c14551e160b966f995f6f8a4abdb0cd9ebeebe93","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                print(\"\\t%s: %s\" % (error[\"etype\"], error[\"msg\"]))"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        exit_code \u003d 0"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        info \u003d api.deployment.check(deployment)"},{"line_number":245,"context_line":"        for platform in info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_73ce0383","line":242,"range":{"start_line":242,"start_character":7,"end_line":242,"end_character":21},"updated":"2017-04-04 16:26:01.000000000","message":"small comment and you can ignore them now;): ruling all exit codes in consts would be better and exception adds the property of error_code would be better.","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"2661aa4d93276f87183c88bc4c072e4da09f6136","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                print(\"\\t%s: %s\" % (error[\"etype\"], error[\"msg\"]))"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        exit_code \u003d 0"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        info \u003d api.deployment.check(deployment)"},{"line_number":245,"context_line":"        for platform in info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_9c1f46b6","line":242,"range":{"start_line":242,"start_character":7,"end_line":242,"end_character":21},"in_reply_to":"dfeb2761_4e4352b0","updated":"2017-04-05 02:22:44.000000000","message":"Copy that.","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2d11ea0428208477c09a1fcc633af3624db6e633","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                print(\"\\t%s: %s\" % (error[\"etype\"], error[\"msg\"]))"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        exit_code \u003d 0"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        info \u003d api.deployment.check(deployment)"},{"line_number":245,"context_line":"        for platform in info:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_4e4352b0","line":242,"range":{"start_line":242,"start_character":7,"end_line":242,"end_character":21},"in_reply_to":"dfeb2761_73ce0383","updated":"2017-04-04 16:34:14.000000000","message":"in general - yes. We need to add specification somewhere about rally possible error codes. Now, it is just `0 - everything is ok` and `1 - something crashed`","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"}],"rally/plugins/openstack/credential.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"25c04302db0625a33bb464a16e8fa8146790ea60","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            if self.permission \u003d\u003d consts.EndpointPermission.ADMIN:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"                self.clients().verified_keystone()"},{"line_number":88,"context_line":"            else:"},{"line_number":89,"context_line":"                self.clients().keystone()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_222928e5","line":86,"updated":"2017-04-05 09:27:13.000000000","message":"redundant new line?","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"22af456cfa2e5d8a561ddd86344b6ac6fbf19208","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            if self.permission \u003d\u003d consts.EndpointPermission.ADMIN:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"                self.clients().verified_keystone()"},{"line_number":88,"context_line":"            else:"},{"line_number":89,"context_line":"                self.clients().keystone()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_8c15c6e7","line":86,"in_reply_to":"dfeb2761_222928e5","updated":"2017-04-05 12:22:08.000000000","message":"Done","commit_id":"74d10d84fd61c9ed87416f8c90cc7b9f779188aa"}]}