)]}'
{"rally/task/engine.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"01af39b32bb6e54d66736c38ce55f79e620a29ab","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                for hook_conf in workload.hooks:"},{"line_number":305,"context_line":"                    results.extend(hook.Hook.validate("},{"line_number":306,"context_line":"                        name\u003dhook_conf[\"name\"],"},{"line_number":307,"context_line":"                        credentials\u003dNone,"},{"line_number":308,"context_line":"                        config\u003dNone,"},{"line_number":309,"context_line":"                        plugin_cfg\u003dhook_conf[\"args\"]))"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"                    trigger_conf \u003d hook_conf[\"trigger\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f01c7b6b","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":36},"updated":"2017-04-03 12:56:08.000000000","message":"I prefer to remove it and add default_value(credentials\u003dNone, config\u003dNone) in https://github.com/openstack/rally/blob/master/rally/common/validation.py#L155-L156.","commit_id":"53a2df4413df6b964d3911a00e288200085a1380"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"17d25c7d82ad0e8b79098fcaef2e8460cb08362c","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                for hook_conf in workload.hooks:"},{"line_number":305,"context_line":"                    results.extend(hook.Hook.validate("},{"line_number":306,"context_line":"                        name\u003dhook_conf[\"name\"],"},{"line_number":307,"context_line":"                        credentials\u003dNone,"},{"line_number":308,"context_line":"                        config\u003dNone,"},{"line_number":309,"context_line":"                        plugin_cfg\u003dhook_conf[\"args\"]))"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"                    trigger_conf \u003d hook_conf[\"trigger\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_44bb6571","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":36},"in_reply_to":"dfeb2761_f01c7b6b","updated":"2017-04-03 14:34:49.000000000","message":"Yes, but these arguments are not always optional(see line 329).\nSo, I think it is better to keep them specified explicitly.","commit_id":"53a2df4413df6b964d3911a00e288200085a1380"}],"rally/task/hook.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bc762d2b374d532423214e9698f06d258b0a1ddb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return results"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"@validation.add_default(\"jsonschema\")"},{"line_number":112,"context_line":"@plugin.base()"},{"line_number":113,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":114,"context_line":"class Hook(plugin.Plugin, validation.ValidatablePluginMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_9ba2cc4a","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":37},"updated":"2017-04-04 10:48:33.000000000","message":"Potentially, it can lead to AttributeError in jsonschema validator while accessing `CONFIG_SCHEMA` property. Let\u0027s add default CONFIG_SCHEMA to base class. It can be just:\n\n   CONFIG_SCHEMA \u003d {\n       \"type\": \"object\", \n       \"additionalProperties\": False, \n       \"properties\": {\"type\": {\"type\": \"string\"}}, \n       \"required\": [\"type\"]}\n\nIt relates to other base classes too","commit_id":"53a2df4413df6b964d3911a00e288200085a1380"}]}